[11u] RFR: 8213400: Support choosing group name in keytool keypair generation

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Sep 2 13:08:57 UTC 2020


Hi Matthias,

You are right, I should have removed that include. Fixed.

Thanks,
  Goetz.

From: Baesken, Matthias <matthias.baesken at sap.com>
Sent: Wednesday, September 2, 2020 1:21 PM
To: jdk-updates-dev at openjdk.java.net
Cc: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
Subject: re: [11u] RFR: 8213400: Support choosing group name in keytool keypair generation

Hi Götz ,



>I would like to downport this for parity with 11.0.10-oracle.

>I had to resolve the code, especially CertAndKeyGen.

>There already is a downport of the CSR which I will reuse.

>Please review:

>http://cr.openjdk.java.net/~goetz/wr20/8213400-keytool_keypair-jdk11/01/

>

>Orig change:

>https://bugs.openjdk.java.net/browse/JDK-8213400

>http://hg.openjdk.java.net/jdk/jdk/rev/ddcbc20e8c6a

Why do you need this import ?

http://cr.openjdk.java.net/~goetz/wr20/8213400-keytool_keypair-jdk11/01/src/java.base/share/classes/sun/security/tools/keytool/Main.java.frames.html

38 import java.security.NoSuchProviderException;

It seems  to  be removed in the jdk/jdk  change .
Otherwise looks good .
If you really need this import keep it,  otherwise remove ,  no new webrev needed .

Best regards, Matthias




More information about the jdk-updates-dev mailing list