[11u] Test failing since downport of 8234011: (zipfs) Memory leak in ZipFileSystem.releaseDeflater() was downported

[Lindenmaier, Goetz]

Yes, I think we should bring it to 11.0.9.
It's just a test fix ... so it won't break anything.

Best regards,
  Goetz.

-----Original Message-----
From: Volker Simonis <volker.simonis at gmail.com> 
Sent: Freitag, 4. September 2020 15:42
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
Cc: jdk-updates-dev at openjdk.java.net
Subject: Re: [11u] Test failing since downport of 8234011: (zipfs) Memory leak in ZipFileSystem.releaseDeflater() was downported

The fix is trivial and out for review now:

https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2020-September/003769.html

Do you want me to bring this to 11.0.9 with a "jdk11u-critical-request"?

Best regards,
Volker

On Fri, Sep 4, 2020 at 10:33 AM Lindenmaier, Goetz
<goetz.lindenmaier at sap.com> wrote:
>
> Hi Volker
>
> That sounds good, thanks for investigating!
>
> Best regards,
>   Goetz
>
> -----Original Message-----
> From: Volker Simonis <volker.simonis at gmail.com>
> Sent: Freitag, 4. September 2020 10:10
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> Cc: jdk-updates-dev at openjdk.java.net
> Subject: Re: [11u] Test failing since downport of 8234011: (zipfs) Memory leak in ZipFileSystem.releaseDeflater() was downported
>
> Hi Goetz,
>
> yes, this is a test problem caused by the way we construct the URI
> from a Path. This part of the test had to be changed for the downport
> because the original patch used a version of
> FileSystems.newFileSystem(..) which directly takes a Path argument and
> is not available in jdk11.
>
> I think the fix would be similar to
> https://bugs.openjdk.java.net/browse/JDK-8186227. I'll take a look.
>
> Thanks for finding this,
> Volker
>
> On Wed, Sep 2, 2020 at 9:23 AM Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com> wrote:
> >
> > Hi,
> >
> > We see test jdk/nio/zipfs/ReleaseDeflater.java failing on Windows 64-bit since
> > "8234011: (zipfs) Memory leak in ZipFileSystem.releaseDeflater()" was downported.
> >
> > java.lang.IllegalArgumentException: Illegal character in opaque part at index 11: jar:file:C:\\jvmtests\\output_ ....  \\jdk\\nio\\zipfs\\ReleaseDeflater\\ReleaseDeflaterTest.zip
> >         at java.base/java.net.URI.create(URI.java:883)
> >         at ReleaseDeflater.main(ReleaseDeflater.java:51)
> >         at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> >         at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> >
> > https://bugs.openjdk.java.net/browse/JDK-8234011
> > https://hg.openjdk.java.net/jdk-updates/jdk11u-dev/rev/cb299db4a569
> >
> > I would assume this is a problem with the test, looking at the change.
> > Does someone have an idea how to fix this?
> >
> > Best regards,
> >   Goetz.