[11u] RFR: JDK-8252258: JDK-8242154 changes the default vendor

[Langer, Christoph]

Hi Andrew,

thanks for spotting this and creating the fix.

While I think, N/A is the better default for OpenJDK, compared to Oracle Corporation, I have to admit that that's not something that should be changed during a release lifecycle. So, LGTM. And, I agree, this should go into 11.0.9.

Cheers
Christoph

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
> Behalf Of Andrew Hughes
> Sent: Donnerstag, 3. September 2020 05:20
> To: jdk-updates-dev at openjdk.java.net
> Subject: [11u] RFR: JDK-8252258: JDK-8242154 changes the default vendor
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8252258
> Webrev:
> https://cr.openjdk.java.net/~andrew/openjdk11/8252258/webrev.01/
> 
> This is an 11u only fix.
> 
> JDK-4947890 was partially backported during the 11.0.8 cycle,
> causing a regression in the default vendor name.
> 
> In the partial backport, under the bug JDK-8242154 [0],
> the default defines for VENDOR, VENDOR_URL and VENDOR_URL_BUG
> are removed from System.c. However, only the default values
> for VENDOR_URL and VENDOR_URL_BUG are transferred to
> make/autoconf/version-numbers.
> 
> The result is that the default vendor changes from
> "Oracle Corporation" in 11.0.7 to "N/A" in 11.0.8:
> 
> With a local build of 11.0.7-ga:
> 
> $ ~/builder/11u/images/jdk/bin/java -version
> openjdk version "11.0.7-internal" 2020-04-14
> OpenJDK Runtime Environment (fastdebug build 11.0.7-internal+0-
> adhoc.ahughes.jdk11)
> OpenJDK 64-Bit Server VM (fastdebug build 11.0.7-internal+0-
> adhoc.ahughes.jdk11, mixed mode)
> 
> $ ~/builder/11u/images/jdk/bin/java -XshowSettings:properties -version
> 2>&1 | grep java.vendor
> java.vendor = Oracle Corporation
> java.vendor.url = http://java.oracle.com/
> java.vendor.url.bug = http://bugreport.java.com/bugreport/
> 
> With the system install of 11.0.8-ga:
> 
> $ /usr/lib/jvm/java-11-openjdk/bin/java -version
> openjdk version "11.0.8" 2020-07-14 LTS
> OpenJDK Runtime Environment 18.9 (build 11.0.8+10-LTS)
> OpenJDK 64-Bit Server VM 18.9 (build 11.0.8+10-LTS, mixed mode, sharing)
> 
> $ /usr/lib/jvm/java-11-openjdk/bin/java -XshowSettings:properties -version
> 2>&1 | grep java.vendor
> java.vendor = N/A
> java.vendor.url = https://openjdk.java.net/
> java.vendor.url.bug = https://bugreport.java.com/bugreport/
> java.vendor.version = 18.9
> 
> I don't believe we should be changing these defaults in a maintenance
> release.  The webrev linked above changes COMPANY_NAME to "Oracle
> Corporation" to resume the previous behaviour and I intend to flag
> this as jdk11-critical-request once reviewed, as it's a regression.
> 
> [0] https://bugs.openjdk.java.net/browse/JDK-8242154
> --
> Andrew :)
> 
> Senior Free Java Software Engineer
> OpenJDK Package Owner
> Red Hat, Inc. (http://www.redhat.com)
> 
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222