[11u] RFR(S): 8241234: Unify monitor enter/exit runtime entries.
Mario Torre
neugens at redhat.com
Tue Sep 8 12:27:41 UTC 2020
On Tue, Sep 8, 2020 at 2:02 PM Lindenmaier, Goetz
<goetz.lindenmaier at sap.com> wrote:
> In the case of this change, it required a close look at the coding,
> which is why I had asked Martin to address it. Martin is an
> expert in this area. The objections came just after he had completed
> his work. I's really not helpful if a change is turned down just after
> all the work is done. This could be avoided by above approach.
> Great it is approved.
The way I see it is that although the maintainer can say no at any
time, since they are not reviewing the patch their "no" usually
happens later in the game anyway, so some amount of work has been
done, I think the backporter (and reviewer) should be responsible to
apply the first line of filtering.
But this brings up an interesting point, we rarely discuss patches,
your proposal seems to be a step in the right direction since it
forces maintainer's attention earlier, but I think there's an element
of planification still missing, also, we don't want to overload the
mantainer's time, this needs to be a share effort from the ground up.
Regarding the backporting in general, I do think we're backporting too
much, I think we had a slowdown in 8u which is good, but 11u is still
getting a lot of attention, we should slow the pace there too, imho.
Cheers,
Mario
--
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898
More information about the jdk-updates-dev
mailing list