[11u] RFR(M): 8248190: PPC: Enable Power10 system and use new byte-reverse instructions

[Doerr, Martin]

Hi Jose,

looks good. Thanks for backporting.

Best regards,
Martin


> -----Original Message-----
> From: joserz at linux.ibm.com <joserz at linux.ibm.com>
> Sent: Freitag, 11. September 2020 03:21
> To: Doerr, Martin <martin.doerr at sap.com>
> Cc: hotspot-compiler-dev at openjdk.java.net; jdk-updates-
> dev at openjdk.java.net; HORIE at jp.ibm.com
> Subject: Re: [11u] RFR(M): 8248190: PPC: Enable Power10 system and use
> new byte-reverse instructions
> 
> Hello Martin,
> 
> Here is my new webrev.
> https://cr.openjdk.java.net/~mhorie/8248190/jdk11u/webrev.00/
> (Thanks again, Michi)
> 
> 8<----------------------------------------------------------------------
> Some evidences in a Power10 emulator:
> $ openjdk/jdk11u-dev/build/jdk/bin/java -Xcomp -XX:CompileThreshold=1 -
> XX:-TieredCompilation -XX:+UnlockDiagnosticVMOptions -
> XX:+PrintOptoAssembly -XX:-UseSIGTRAP -XX:+UseByteReverseInstructions
> ReverseBytes | grep 'BRD\|BRH\|BRW\|EXTSH'
> ...
> 054     BRW  R17, R18
> 070     BRD  R14, R14
> 080     BRH   R14, R15
>         EXTSH R14, R14
> 0a0     BRH  R17, R15
> 
> $ openjdk/jdk11u-dev/build/jdk/bin/java -XX:+Verbose -
> XX:PowerArchitecturePPC64=10 -version
> dscr value was 0x10
> Version: ppc64 fsqrt isel lxarxeh cmpb popcntb popcntw fcfids vand lqarx aes
> vpmsumb mfdscr vsx ldbrx stdbrx sha darn brw
> L1_data_cache_line_size=128
> 
> ContendedPaddingWidth 128
> 
> openjdk version "11.0.10-internal" 2021-01-19
> OpenJDK Runtime Environment (slowdebug build 11.0.10-internal+0-
> adhoc.ziviani.jdk11u-dev)
> OpenJDK 64-Bit Server VM (slowdebug build 11.0.10-internal+0-
> adhoc.ziviani.jdk11u-dev, mixed mode)
> 8<----------------------------------------------------------------------
> 
> Thank you very much!
> 
> Jose
> 
> On Thu, Sep 10, 2020 at 09:54:04AM +0000, Doerr, Martin wrote:
> > Hi Jose,
> >
> > if manual adaptation/integration is needed we also need to review the
> backport webrev (except trivial differences like in copyright headers).
> >
> > Best regards,
> > Martin
> >
> >
> > > -----Original Message-----
> > > From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
> > > Behalf Of joserz at linux.ibm.com
> > > Sent: Mittwoch, 9. September 2020 18:38
> > > To: hotspot-compiler-dev at openjdk.java.net; jdk-updates-
> > > dev at openjdk.java.net
> > > Subject: [11u] RFR(M): 8248190: PPC: Enable Power10 system and use
> new
> > > byte-reverse instructions
> > >
> > > Hello team!
> > >
> > > I'd like to backport the following patchset to 11u. It doesn't apply
> perfectly
> > > due to some positional changes and a copyright update.
> > > Please, let me know if you prefer another webrev addressing this
> backport.
> > >
> > > Webrev: https://cr.openjdk.java.net/~mhorie/8248190/webrev.02/
> > > Bug: https://bugs.openjdk.java.net/browse/JDK-8248190
> > >
> > > Thank you very much,
> > >
> > > Jose R Ziviani