[11u] RFR 8250928: JFR: Improve hash algorithm for stack traces
Jaroslav Bachorík
jaroslav.bachorik at datadoghq.com
Mon Sep 14 13:33:09 UTC 2020
Gentle ping?
On Thu, Sep 3, 2020 at 7:00 PM Jaroslav Bachorík
<jaroslav.bachorik at datadoghq.com> wrote:
>
> Hearing no objections, here is a new webrev:
> http://cr.openjdk.java.net/~jbachorik/8250928/11u/01/webrev
>
> -JB-
>
> On Thu, Sep 3, 2020 at 3:04 PM Jaroslav Bachorík
> <jaroslav.bachorik at datadoghq.com> wrote:
> >
> > I have opened and fixed
> > https://bugs.openjdk.java.net/browse/JDK-8252754 to do the hash code
> > calculation consistently.
> >
> > I would prefer including both parts in one backport if possible. Any thoughts?
> >
> > Thanks,
> >
> > -JB-
> >
> > On Tue, Sep 1, 2020 at 12:57 PM Jaroslav Bachorík
> > <jaroslav.bachorik at datadoghq.com> wrote:
> > >
> > > On Tue, Sep 1, 2020 at 12:48 PM Aleksey Shipilev <shade at redhat.com> wrote:
> > > >
> > > > On 9/1/20 12:45 PM, Jaroslav Bachorík wrote:
> > > > > Perhaps, the mainline should be fixed to use the 'improved'
> > > > > calculation in both places first?
> > > >
> > > > Yes, that would be my guess. The backport to both 8u and 11u does not look safe until that
> > > > peculiarity is resolved, either by additional patch, or justification why it is fine.
> > >
> > > Yes. I totally agree. Thanks for catching this early!
> > >
> > > -JB-
> > >
> > > >
> > > > --
> > > > Thanks,
> > > > -Aleksey
> > > >
More information about the jdk-updates-dev
mailing list