[11u] RFR: JDK-8222286: Fix for JDK-8213419 is broken on s390
Andrew Haley
aph at redhat.com
Wed Sep 16 08:27:21 UTC 2020
On 16/09/2020 04:05, Andrew Hughes wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8222286
> Webrev: https://cr.openjdk.java.net/~andrew/openjdk11/8222286/webrev.01/
>
> On s390 (the 31-bit architecture), calls to log2_intptr with a size_t
> argument are ambiguous, because there is log2_intptr(uintptr_t x) and
> log2_intptr(intptr_t x). This is not a problem on other architectures
> where size_t is the same as uintptr_t. See existing bugs for
> more details of the s390 situation [0] [1] [2].
>
> The issue can be resolved by explicitly casting to uintptr_t.
>
> It is not applicable to >= 12u, as JDK-8213436 removed the problematic
> function in which this occurs.
>
> Ok for 11u?
Sure, but please add a comment. "S/390: Cast to (uintptr_t): see JDK-8222286"
would do. Thanks.
--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
More information about the jdk-updates-dev
mailing list