[11u] RFR: JDK-8222286: Fix for JDK-8213419 is broken on s390

[Langer, Christoph]

Hi,

looks good to me.

Best regards
Christoph

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
> Behalf Of Andrew Hughes
> Sent: Freitag, 18. September 2020 17:52
> To: Andrew Haley <aph at redhat.com>
> Cc: jdk-updates-dev at openjdk.java.net
> Subject: Re: [11u] RFR: JDK-8222286: Fix for JDK-8213419 is broken on s390
> 
> On 17:01 Wed 16 Sep     , Andrew Hughes wrote:
> > On 09:27 Wed 16 Sep     , Andrew Haley wrote:
> > > On 16/09/2020 04:05, Andrew Hughes wrote:
> > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8222286
> > > > Webrev:
> https://cr.openjdk.java.net/~andrew/openjdk11/8222286/webrev.01/
> > > >
> > > > On s390 (the 31-bit architecture), calls to log2_intptr with a size_t
> > > > argument are ambiguous, because there is log2_intptr(uintptr_t x) and
> > > > log2_intptr(intptr_t x). This is not a problem on other architectures
> > > > where size_t is the same as uintptr_t. See existing bugs for
> > > > more details of the s390 situation [0] [1] [2].
> > > >
> > > > The issue can be resolved by explicitly casting to uintptr_t.
> > > >
> > > > It is not applicable to >= 12u, as JDK-8213436 removed the problematic
> > > > function in which this occurs.
> > > >
> > > > Ok for 11u?
> > >
> > > Sure, but please add a comment. "S/390: Cast to (uintptr_t): see JDK-
> 8222286"
> > > would do. Thanks.
> > >
> > > --
> > > Andrew Haley  (he/him)
> > > Java Platform Lead Engineer
> > > Red Hat UK Ltd. <https://www.redhat.com>
> > > https://keybase.io/andrewhaley
> > > EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
> > >
> >
> > Sure, good idea.
> >
> > Added in
> https://cr.openjdk.java.net/~andrew/openjdk11/8222286/webrev.02/
> >
> > Thanks,
> > --
> > Andrew :)
> >
> > Senior Free Java Software Engineer
> > OpenJDK Package Owner
> > Red Hat, Inc. (http://www.redhat.com)
> >
> > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> > Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
> 
> Is this good to go?
> 
> Thanks,
> --
> Andrew :)
> 
> Senior Free Java Software Engineer
> OpenJDK Package Owner
> Red Hat, Inc. (http://www.redhat.com)
> 
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222