[11u] RFR: 8224555: vmTestbase/nsk/jvmti/scenarios/contention/TC02/tc02t001/TestDescription.java failed

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Tue Sep 22 15:38:47 UTC 2020


Hi Martin, 

Thanks for reviewing. 

I fixed the whitespace.

Best regards,
  Goetz.

> -----Original Message-----
> From: Doerr, Martin <martin.doerr at sap.com>
> Sent: Tuesday, September 22, 2020 3:15 PM
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: RE: [11u] RFR: 8224555:
> vmTestbase/nsk/jvmti/scenarios/contention/TC02/tc02t001/TestDescription
> .java failed
> 
> Hi Götz,
> 
> you have additional leading whitespaces in tc02t001.c:
>   static jint lines[] = { 48, 53, 58 };
> 
> Looks good otherwise. Don't need to see another webrev.
> 
> Best regards,
> Martin
> 
> 
> > -----Original Message-----
> > From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
> > Behalf Of Lindenmaier, Goetz
> > Sent: Dienstag, 22. September 2020 08:56
> > To: jdk-updates-dev at openjdk.java.net
> > Subject: [11u] RFR: 8224555:
> >
> vmTestbase/nsk/jvmti/scenarios/contention/TC02/tc02t001/TestDescription
> > .java failed
> >
> > Hi,
> >
> > I am downporting this for parity with 11.0.10-oracle.
> >
> > I had to resolve because one file is C and not C++.
> > Also, in tc02t001.java, the deleted sleep() times differ.
> >
> > (The patch looks complicated but is not. The change switches
> > position of class tc02t001Thread and class tc02t001,
> > and webrev computed a different diff than to be seen in
> > the repo.)
> >
> > http://cr.openjdk.java.net/~goetz/wr20/8224555-nsk_jvmti_test-jdk11/01/
> >
> > Please review.
> >
> > https://bugs.openjdk.java.net/browse/JDK-8224555
> > http://hg.openjdk.java.net/jdk/jdk13/rev/e17c9a93b505
> >
> > Best regards,
> >   Goetz.


More information about the jdk-updates-dev mailing list