[11u] RFR 8244847: Linux/PPC: runtime/CompressedOops/CompressedClassPointers: smallHeapTest fails

Reingruber, Richard richard.reingruber at sap.com
Tue Apr 13 08:59:04 UTC 2021


> The corresponding #endif should have its comment updated to "// AARCH64 || PPC64". Otherwise lgtm.

Done.

http://cr.openjdk.java.net/~rrich/webrevs/8244847_11u_Linux_PPC__runtime_CompressedOops_CompressedClassPointers__smallHeapTest_fails/webrev.1/

Thanks for the review!
Richard.

-----Original Message-----
From: Hohensee, Paul <hohensee at amazon.com> 
Sent: Dienstag, 13. April 2021 00:00
To: Reingruber, Richard <richard.reingruber at sap.com>; jdk-updates-dev at openjdk.java.net
Subject: Re: [11u] RFR 8244847: Linux/PPC: runtime/CompressedOops/CompressedClassPointers: smallHeapTest fails

The corresponding #endif should have its comment updated to "// AARCH64 || PPC64". Otherwise lgtm.

Thanks,
Paul

-----Original Message-----
From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> on behalf of "Reingruber, Richard" <richard.reingruber at sap.com>
Date: Monday, April 12, 2021 at 2:45 AM
To: "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
Subject: [11u] RFR 8244847: Linux/PPC: runtime/CompressedOops/CompressedClassPointers: smallHeapTest fails

Hi,

Please help review this XXS backport of JDK-8244847 to 11u.

Original bug (JDK16):
  https://bugs.openjdk.java.net/browse/JDK-8244847
  https://git.openjdk.java.net/jdk/commit/4a267f1b

11u webrev:
  http://cr.openjdk.java.net/~rrich/webrevs/8244847_11u_Linux_PPC__runtime_CompressedOops_CompressedClassPointers__smallHeapTest_fails/webrev.0/

Adaptations:

  In both codelines, JDK16 and JDK11u, the fix reuses code for AARCH64 to search for a
  free address block below 32g that can be used for a zerobased compressed class
  space also on PPC64.

  In JDK16 the method Metaspace::reserve_address_space_for_compressed_classes() holds that code.
  In JDK11u it is the method Metaspace::allocate_metaspace_compressed_klass_ptrs().

  The test (CompressedClassPointers.java) is not changed because it's not disabled in 11u.

Testing:

CI testing @SAP: JCK and JTREG, also in Xcomp mode, SPECjvm2008, SPECjbb2015, Renaissance Suite,
SAP specific tests with fastdebug and release builds on all platforms

Thanks, Richard.



More information about the jdk-updates-dev mailing list