[11u] RFR: 8240487: Cleanup whitespace in .cc, .hh, .m, and .mm files

Hohensee, Paul hohensee at amazon.com
Thu Apr 15 21:44:27 UTC 2021


Lgtm. Just realized that the fact that the first webrev was empty was enough to prove that the changes are whitespace-only. And that the changeset has all the whitespace changes. :)

From: Vladimir Kempik <vkempik at azul.com>
Date: Thursday, April 15, 2021 at 1:52 PM
To: "Hohensee, Paul" <hohensee at amazon.com>
Cc: jdk-updates-dev <jdk-updates-dev at openjdk.java.net>
Subject: RE: [11u] RFR: 8240487: Cleanup whitespace in .cc, .hh, .m, and .mm files

Hello
thanks for notice, updated webrev - http://cr.openjdk.java.net/~vkempik/8240487/webrev.02/

still the webrev isn’t the best tool for whitespace patches, to see white spaces need to select that area, and I can’t tell that webrev displays them correctly all the time.

Regards, Vladimir

15 апр. 2021 г., в 23:38, Hohensee, Paul <hohensee at amazon.com<mailto:hohensee at amazon.com>> написал(а):

The webrev is empty (i.e., reports the changed files, but not the changes). Use "webrev -b".

Thanks,
Paul

-----Original Message-----
From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net<mailto:jdk-updates-dev-retn at openjdk.java.net>> on behalf of Vladimir Kempik <vkempik at azul.com<mailto:vkempik at azul.com>>
Date: Thursday, April 15, 2021 at 1:27 AM
To: jdk-updates-dev <jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>>
Subject: RE: [11u] RFR: 8240487: Cleanup whitespace in .cc, .hh, .m, and .mm files

Correcting the title


15 апр. 2021 г., в 10:40, Vladimir Kempik <vkempik at azul.com<mailto:vkempik at azul.com>> написал(а):

Hello
please review this backport of JDK-8240487 to jdk11u
I’m working on a series of patches for JNF dependency removal for macos and this backport will allow it to apply a lot more cleanly.
Very safe, white-space only changes.
Applies almost cleanly, I only removed second part of patch for src/jdk.hotspot.agent/macosx/native/libsaproc/MacosxDebuggerLocal.m
as it wasn’t needed.

The bug - https://bugs.openjdk.java.net/browse/JDK-8240487 <https://bugs.openjdk.java.net/browse/JDK-8240487>
The original commit - https://hg.openjdk.java.net/jdk/jdk/rev/f532ef5561c3 <https://hg.openjdk.java.net/jdk/jdk/rev/f532ef5561c3>
The webrev - http://cr.openjdk.java.net/~vkempik/8240487/webrev.01/ <http://cr.openjdk.java.net/~vkempik/8240487/webrev.01/>

Regards, Vladimir




More information about the jdk-updates-dev mailing list