[11u] RFR 8265677: CMS: CardTableBarrierSet::write_ref_array_work() lacks storestore barrier

[Hohensee, Paul]

Putting an unconditional storestore barrier in dirty_MemRegion might be a better fix since it will catch everything, not just arrays. But, that's not in tip, so lgtm.

Thanks,
Paul

-----Original Message-----
From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> on behalf of "Reingruber, Richard" <richard.reingruber at sap.com>
Date: Wednesday, April 21, 2021 at 7:32 AM
To: "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
Subject: RE: [11u] RFR 8265677: CMS: CardTableBarrierSet::write_ref_array_work() lacks storestore barrier

// Resend after removing incorrect link

Hi,

please review this XXS fix for 11u which adds a storestore barrier to
`CardTableBarrierSet::write_ref_array_work(MemRegion mr)`. The barrier is only
executed if CMS is selected. Please refer to the bug report for more details.

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8265677

11u webrev:
  http://cr.openjdk.java.net/~rrich/webrevs/8265677_11u_CMS__CardTableBarrierSet__write_ref_array_work___lacks_storestore_barrier/webrev.0/

Testing:

make run-test-tier1 JTREG="VM_OPTIONS=-XX:+UseConcMarkSweepGC"

CI testing @SAP: JCK and JTREG, also in Xcomp mode, SPECjvm2008, SPECjbb2015, Renaissance Suite,
SAP specific tests with fastdebug and release builds on all platforms

Thanks, Richard.