[11u] RFR (XS) 8265537: x86 version string truncated after JDK-8249672 11u backport

Aleksey Shipilev shade at redhat.com
Thu Apr 22 10:06:58 UTC 2021


On 4/20/21 7:23 PM, Aleksey Shipilev wrote:
> 11u-specific regression:
>     https://bugs.openjdk.java.net/browse/JDK-8265537
> 
> See the details in the bug.
> 
> 11u patch:
> 
> diff -r 9846af5a0949 src/hotspot/cpu/x86/vm_version_x86.cpp
> --- a/src/hotspot/cpu/x86/vm_version_x86.cpp    Mon Apr 19 12:47:46 2021 +0200
> +++ b/src/hotspot/cpu/x86/vm_version_x86.cpp    Tue Apr 20 19:23:24 2021 +0200
> @@ -743,11 +743,11 @@
>        if (is_knights_family()) {
>          _features &= ~CPU_VZEROUPPER;
>        }
>      }
> 
> -  char buf[256];
> +  char buf[512];
>      jio_snprintf(buf, sizeof(buf),
>                   "(%u cores per cpu, %u threads per core) family %d model %d stepping %d microcode 0x%x"
>                   "%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s",
>                   cores_per_cpu(), threads_per_core(),
>                   cpu_family(), _model, _stepping, os::cpu_microcode_revision(),
> 
> Testing: compiler/intrinsics/sha tests (now pass); tier1

Goetz, (since you were the author of that 11u backport,) you are fine with this patch, right?

-- 
Thanks,
-Aleksey



More information about the jdk-updates-dev mailing list