[11u] RFR: Missing intrinsics for Math.ceil, floor, rint

Hohensee, Paul hohensee at amazon.com
Thu Apr 29 17:53:28 UTC 2021


Lgtm, but note that the JBS issue says it needs 8231713 (which is trivial) as a follow-up.

Thanks,
Paul

-----Original Message-----
From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> on behalf of "Astigeevich, Evgeny" <eastig at amazon.co.uk>
Date: Wednesday, April 28, 2021 at 2:59 PM
To: "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
Subject: [11u] RFR 8226721: Missing intrinsics for Math.ceil, floor, rint

Hi,

Please review the backport of JDK-8226721to 11u.

Bug: https://bugs.openjdk.java.net/browse/JDK-8226721
Original patch: https://hg.openjdk.java.net/jdk/jdk/rev/6fc57e391539

The original patch does not apply cleanly to 11u. The update to the patch is to reposition the changes to five files:

src/hotspot/cpu/x86/x86.ad
src/hotspot/share/opto/library_call.cpp
src/hotspot/share/opto/superword.cpp
src/hotspot/share/opto/vectornode.cpp
src/hotspot/share/opto/vectornode.hpp

The content of the patch is not changed.

11u webrev: http://cr.openjdk.java.net/~eastigeevich/8226721/webrev.00/

Tested: Amazon Linux 2 x86_64, tier1, tier2, test/hotspot/jtreg/compiler/c2/cr6340864/TestDoubleVect.java
Note: There is a failing test: sun/security/pkcs11/Secmod/AddTrustedCert.java. It fails without the patch as well. Details: https://bugs.openjdk.java.net/browse/JDK-8232153

Thanks,
Evgeny Astigeevich




Amazon Development Centre (London) Ltd. Registered in England and Wales with registration number 04543232 with its registered office at 1 Principal Place, Worship Street, London EC2A 2FA, United Kingdom.





More information about the jdk-updates-dev mailing list