From clanger at openjdk.java.net Mon Aug 2 07:55:02 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 2 Aug 2021 07:55:02 GMT Subject: [jdk11u-dev] RFR: 8241768: git needs .gitattributes Message-ID: <1GwO6nxHyYAQKrXGGRMkscZ8P4IEL_sZuWvJUw40GdU=.91609069-4be0-45de-96e0-3e2f39e9b591@github.com> Hi all, this pull request contains a backport of JDK-8241768 from the openjdk/jdk repository. The commit being backported was authored by Magnus Ihse Bursie on 3 Sep 2020 and was reviewed by Erik Joelsson, Jorn Vernee and Erik Helin. We need it as a prerequisite to enable GitHub actions in 11u. Thanks! ------------- Commit messages: - Backport 49a9d49dbdb1d17aa4e6b808de6249be543961ea Changes: https://git.openjdk.java.net/jdk11u-dev/pull/176/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=176&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8241768 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/176.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/176/head:pull/176 PR: https://git.openjdk.java.net/jdk11u-dev/pull/176 From clanger at openjdk.java.net Mon Aug 2 09:21:54 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 2 Aug 2021 09:21:54 GMT Subject: [jdk11u-dev] Integrated: 8241768: git needs .gitattributes In-Reply-To: <1GwO6nxHyYAQKrXGGRMkscZ8P4IEL_sZuWvJUw40GdU=.91609069-4be0-45de-96e0-3e2f39e9b591@github.com> References: <1GwO6nxHyYAQKrXGGRMkscZ8P4IEL_sZuWvJUw40GdU=.91609069-4be0-45de-96e0-3e2f39e9b591@github.com> Message-ID: On Mon, 2 Aug 2021 07:48:07 GMT, Christoph Langer wrote: > Hi all, > > this pull request contains a backport of JDK-8241768 from the openjdk/jdk repository. > > The commit being backported was authored by Magnus Ihse Bursie on 3 Sep 2020 and was reviewed by Erik Joelsson, Jorn Vernee and Erik Helin. > > We need it as a prerequisite to enable GitHub actions in 11u. > > Thanks! This pull request has now been integrated. Changeset: 37bc75b3 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/37bc75b3df79518363b0886394c613a908d7dbdf Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8241768: git needs .gitattributes Backport-of: 49a9d49dbdb1d17aa4e6b808de6249be543961ea ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/176 From sgehwolf at openjdk.java.net Mon Aug 2 10:11:50 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 2 Aug 2021 10:11:50 GMT Subject: [jdk11u-dev] Integrated: 8269668: [aarch64] java.library.path not including /usr/lib64 In-Reply-To: References: Message-ID: On Wed, 14 Jul 2021 16:35:01 GMT, Severin Gehwolf wrote: > Here is a conservative backport of JDK-8269668. The JDK 17 patch was not uses as this would mean a change in behaviour for existing JDK 11u users. Instead, a more conservative patch has been chosen to only add 64-bit paths later in the lookup-chain. I believe this is the best we can do in terms of compatibility with also fixing the bug. Thoughts? > > Testing: Builds on aarch64 and inspecting `java -XshowSettings:properties -version` output. Manual test with a reproducer I had. tier1 on Linux x86_64. > > Thoughts? This pull request has now been integrated. Changeset: 05c76978 Author: Severin Gehwolf URL: https://git.openjdk.java.net/jdk11u-dev/commit/05c76978a6954897500c3dc8ac6aeca0f23e57cd Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod 8269668: [aarch64] java.library.path not including /usr/lib64 Reviewed-by: andrew Backport-of: e14801cdd9b108aa4ca47d0bc1dc67fca575764c ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/133 From aph at openjdk.java.net Mon Aug 2 12:06:48 2021 From: aph at openjdk.java.net (Andrew Haley) Date: Mon, 2 Aug 2021 12:06:48 GMT Subject: [jdk11u-dev] RFR: 8269668: [aarch64] java.library.path not including /usr/lib64 In-Reply-To: References: Message-ID: On Wed, 14 Jul 2021 16:35:01 GMT, Severin Gehwolf wrote: > Here is a conservative backport of JDK-8269668. The JDK 17 patch was not uses as this would mean a change in behaviour for existing JDK 11u users. Instead, a more conservative patch has been chosen to only add 64-bit paths later in the lookup-chain. I believe this is the best we can do in terms of compatibility with also fixing the bug. Thoughts? > > Testing: Builds on aarch64 and inspecting `java -XshowSettings:properties -version` output. Manual test with a reproducer I had. tier1 on Linux x86_64. > > Thoughts? Sorry I missed this. Your solution looks about the best that can be done in the circumstances, so I'm happy. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/133 From zgu at openjdk.java.net Mon Aug 2 18:03:46 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Mon, 2 Aug 2021 18:03:46 GMT Subject: [jdk11u-dev] RFR: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type Message-ID: A clean backport for parity with Oracle 11.0.13 ------------- Commit messages: - Backport 3d090e7ee561252027c06021b337c69a39f724e1 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/178/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=178&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8267625 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/178.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/178/head:pull/178 PR: https://git.openjdk.java.net/jdk11u-dev/pull/178 From zgu at openjdk.java.net Mon Aug 2 19:39:04 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Mon, 2 Aug 2021 19:39:04 GMT Subject: [jdk11u-dev] RFR: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info. Message-ID: Not a clean backport due to context different, but easy to resolve manually. Test: - [x] New test failed w/o patch and passed with patch. ------------- Commit messages: - Backport 4ed548b3eeffe8dfa601d4d0eeed2bfe359af965 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/179/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=179&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268261 Stats: 75 lines in 2 files changed: 74 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/179.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/179/head:pull/179 PR: https://git.openjdk.java.net/jdk11u-dev/pull/179 From kvn at openjdk.java.net Mon Aug 2 19:49:29 2021 From: kvn at openjdk.java.net (Vladimir Kozlov) Date: Mon, 2 Aug 2021 19:49:29 GMT Subject: [jdk11u-dev] RFR: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info. In-Reply-To: References: Message-ID: On Mon, 2 Aug 2021 19:32:21 GMT, Zhengyu Gu wrote: > Not a clean backport due to context different, but easy to resolve manually. > > Test: > - [x] New test failed w/o patch and passed with patch. Backport looks good. ------------- Marked as reviewed by kvn (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/179 From phh at openjdk.java.net Mon Aug 2 19:54:03 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Mon, 2 Aug 2021 19:54:03 GMT Subject: [jdk11u-dev] RFR: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info. In-Reply-To: References: Message-ID: On Mon, 2 Aug 2021 19:32:21 GMT, Zhengyu Gu wrote: > Not a clean backport due to context different, but easy to resolve manually. > > Test: > - [x] New test failed w/o patch and passed with patch. Other than the extra blank line at the end of TestIdomAfterLoopUnswitching.java, lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/179 From phh at openjdk.java.net Mon Aug 2 20:02:41 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Mon, 2 Aug 2021 20:02:41 GMT Subject: [jdk11u-dev] RFR: 8266761: AssertionError in sun.net.httpserver.ServerImpl.responseCompleted In-Reply-To: References: Message-ID: On Wed, 28 Jul 2021 13:13:44 GMT, Martin Doerr wrote: > Backport of JDK-8266761. Applies cleanly except the following hunk: > > --- src/jdk.httpserver/share/classes/sun/net/httpserver/ExchangeImpl.java > +++ src/jdk.httpserver/share/classes/sun/net/httpserver/ExchangeImpl.java > @@ -270,7 +269,6 @@ public void sendResponseHeaders (int rCode, long contentLen) > Optional.ofNullable(rspHdrs.get("Connection")) > .map(List::stream).orElse(Stream.empty()); > if (conheader.anyMatch("close"::equalsIgnoreCase)) { > - Logger logger = server.getLogger(); > logger.log (Level.DEBUG, "Connection: close requested by handler"); > close = true; > } > > That code belongs to the enhancement JDK-8218554 which is not in 11u. Lgtm, except please put a comment about JDK-8218554 in ExchangeImpl.java at the point where JDK-8218554 applies. If JDK-8218554 is backported in the future, it's unlikely the engineer doing the backport will notice that this patch was done. No need for another review. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/169 From zgu at openjdk.java.net Mon Aug 2 20:03:34 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Mon, 2 Aug 2021 20:03:34 GMT Subject: [jdk11u-dev] RFR: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info. In-Reply-To: References: Message-ID: On Mon, 2 Aug 2021 19:50:07 GMT, Paul Hohensee wrote: > Other than the extra blank line at the end of TestIdomAfterLoopUnswitching.java, lgtm. This file is a clean backport, I would rather no touch it. Thanks. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/179 From zgu at openjdk.java.net Mon Aug 2 20:03:34 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Mon, 2 Aug 2021 20:03:34 GMT Subject: [jdk11u-dev] RFR: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info. In-Reply-To: References: Message-ID: On Mon, 2 Aug 2021 19:46:24 GMT, Vladimir Kozlov wrote: >> Not a clean backport due to context different, but easy to resolve manually. >> >> Test: >> - [x] New test failed w/o patch and passed with patch. > > Backport looks good. Thanks, @vnkozlov @phohensee ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/179 From kvn at openjdk.java.net Mon Aug 2 21:08:57 2021 From: kvn at openjdk.java.net (Vladimir Kozlov) Date: Mon, 2 Aug 2021 21:08:57 GMT Subject: [jdk17u] Integrated: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info. In-Reply-To: References: Message-ID: On Fri, 23 Jul 2021 22:13:55 GMT, Vladimir Kozlov wrote: > Backport of 8268261. Applied cleanly. > Reviewed-by: iveresov, vlivanov > Tested for jdk17u: tier1 This pull request has now been integrated. Changeset: de808a5e Author: Vladimir Kozlov URL: https://git.openjdk.java.net/jdk17u/commit/de808a5e92d6fde98b0e147299550cde7fd0fa3c Stats: 75 lines in 2 files changed: 74 ins; 0 del; 1 mod 8268261: C2: assert(n != __null) failed: Bad immediate dominator info. Backport-of: 4ed548b3eeffe8dfa601d4d0eeed2bfe359af965 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/6 From clanger at openjdk.java.net Mon Aug 2 21:26:13 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 2 Aug 2021 21:26:13 GMT Subject: [jdk17u] RFR: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type Message-ID: Hi all, this pull request contains a backport of JDK-8267625 from the openjdk/jdk repository. The commit being backported was authored by Nick Gasson on 7 Jul 2021 and was reviewed by Andrew Haley and Dean Long. Thanks! ------------- Commit messages: - Backport 3d090e7ee561252027c06021b337c69a39f724e1 Changes: https://git.openjdk.java.net/jdk17u/pull/8/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=8&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8267625 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u/pull/8.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/8/head:pull/8 PR: https://git.openjdk.java.net/jdk17u/pull/8 From github.com+3094961+buddyliao at openjdk.java.net Tue Aug 3 02:59:00 2021 From: github.com+3094961+buddyliao at openjdk.java.net (BuddyLiao) Date: Tue, 3 Aug 2021 02:59:00 GMT Subject: [jdk11u-dev] RFR: 8234510: Remove file seeking requirement for writing a heap dump [v2] In-Reply-To: References: Message-ID: > Backport of the heap dump enhancement: Remove file seeking requirement for writing a heap dump > > Patch did not apply cleanly, I had to resolve/modify > src/hotspot/share/services/heapDumper.cpp > > I have built it on linux x86_64 and run test-tier1 BuddyLiao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge master - 8234510: Remove file seeking requirement for writing a heap dump ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/134/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=134&range=01 Stats: 417 lines in 1 file changed: 161 ins; 185 del; 71 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/134.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/134/head:pull/134 PR: https://git.openjdk.java.net/jdk11u-dev/pull/134 From clanger at openjdk.java.net Tue Aug 3 05:17:49 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 3 Aug 2021 05:17:49 GMT Subject: [jdk11u-dev] RFR: 8220445: Support for side by side MSVC Toolset versions Message-ID: This is a backport of JDK-8220445 Support for side by side MSVC Toolset versions. It is needed to support the GitHub Actions workflow for Windows because it is using the hereby introduced configure option --with-msvc-toolset-version. The backport did not apply cleanly because JDK-8215445: Enable building for Windows in WSL is missing. I adapted the change to make it fit. I moved the line ` $ECHO "$WINPATH_BASH -c 'echo VCToolsRedistDir="'"$VCToolsRedistDir " >> set-vs-env.sh' \ >> $EXTRACT_VC_ENV_BAT_FILE` to the fitting place and dropped the hunk ` $ECHO 'echo VCToolsRedistDir="%VCToolsRedistDir% " >> set-vs-env.sh' \ >> $EXTRACT_VC_ENV_BAT_FILE` ------------- Commit messages: - 8220445: Support for side by side MSVC Toolset versions Changes: https://git.openjdk.java.net/jdk11u-dev/pull/180/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=180&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8220445 Stats: 24 lines in 1 file changed: 22 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/180.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/180/head:pull/180 PR: https://git.openjdk.java.net/jdk11u-dev/pull/180 From clanger at openjdk.java.net Tue Aug 3 05:30:24 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 3 Aug 2021 05:30:24 GMT Subject: [jdk11u-dev] RFR: 8221988: add possibility to build with Visual Studio 2019 Message-ID: This is another backport that is needed for GitHub Actions. The Runners will use a VS 2019 installation as base and use VS2017 as a minor version that is installed into the VS 2019 installation. Patch applies cleanly after JDK-8220445 backport, except for copyright in toolchain_windows.m4. ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/180 Commit messages: - 8221988: add possibility to build with Visual Studio 2019 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/181/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=181&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8221988 Stats: 229 lines in 4 files changed: 223 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/181.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/181/head:pull/181 PR: https://git.openjdk.java.net/jdk11u-dev/pull/181 From stuefe at openjdk.java.net Tue Aug 3 05:37:39 2021 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Tue, 3 Aug 2021 05:37:39 GMT Subject: [jdk11u-dev] RFR: 8220445: Support for side by side MSVC Toolset versions In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 05:07:21 GMT, Christoph Langer wrote: > This is a backport of JDK-8220445 Support for side by side MSVC Toolset versions. It is needed to support the GitHub Actions workflow for Windows because it is using the hereby introduced configure option --with-msvc-toolset-version. > > The backport did not apply cleanly because JDK-8215445: Enable building for Windows in WSL is missing. I adapted the change to make it fit. > > I moved the line > ` $ECHO "$WINPATH_BASH -c 'echo VCToolsRedistDir="'"$VCToolsRedistDir " >> set-vs-env.sh' \ > >> $EXTRACT_VC_ENV_BAT_FILE` > to the fitting place and dropped the hunk > ` $ECHO 'echo VCToolsRedistDir="%VCToolsRedistDir% " >> set-vs-env.sh' \ > >> $EXTRACT_VC_ENV_BAT_FILE` Not an expert, but looks okay to me. You did test it, right? ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/180 From clanger at openjdk.java.net Tue Aug 3 05:57:31 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 3 Aug 2021 05:57:31 GMT Subject: [jdk11u-dev] RFR: 8220445: Support for side by side MSVC Toolset versions In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 05:34:24 GMT, Thomas Stuefe wrote: > Not an expert, but looks okay to me. You did test it, right? Thanks for the Review, Thomas. I tested it in my GitHub actions experiments and it looks promising. Will run it through SAP's testing tonight. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/180 From rrich at openjdk.java.net Tue Aug 3 07:01:10 2021 From: rrich at openjdk.java.net (Richard Reingruber) Date: Tue, 3 Aug 2021 07:01:10 GMT Subject: [jdk17u] Integrated: 8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events In-Reply-To: References: Message-ID: On Mon, 19 Jul 2021 13:17:42 GMT, Richard Reingruber wrote: > Hi all, > this pull request contains a backport of commit 72530ef6 from the openjdk/jdk repository. > The commit being backported was authored by Richard Reingruber on 7 Jul 2021 and was reviewed by Vladimir Kozlov, Roland Westrelin and Nils Eliasson. > Thanks! This pull request has now been integrated. Changeset: a575f5c0 Author: Richard Reingruber URL: https://git.openjdk.java.net/jdk17u/commit/a575f5c0900a048e39fcc61988e8963451f6d6e9 Stats: 14 lines in 1 file changed: 7 ins; 7 del; 0 mod 8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events Backport-of: 72530ef666ce2ace899cf34faefe715539d1ee25 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/5 From snazarki at openjdk.java.net Tue Aug 3 08:53:54 2021 From: snazarki at openjdk.java.net (Sergey Nazarkin) Date: Tue, 3 Aug 2021 08:53:54 GMT Subject: [jdk13u-dev] RFR: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type Message-ID: A clean backport for parity with JDK11/17 ------------- Commit messages: - Backport 3d090e7ee561252027c06021b337c69a39f724e1 Changes: https://git.openjdk.java.net/jdk13u-dev/pull/248/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=248&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8267625 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/248.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/248/head:pull/248 PR: https://git.openjdk.java.net/jdk13u-dev/pull/248 From snazarki at openjdk.java.net Tue Aug 3 08:54:00 2021 From: snazarki at openjdk.java.net (Sergey Nazarkin) Date: Tue, 3 Aug 2021 08:54:00 GMT Subject: [jdk15u-dev] RFR: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type Message-ID: A clean backport for parity with JDK11/17 ------------- Commit messages: - Backport 3d090e7ee561252027c06021b337c69a39f724e1 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/88/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=88&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8267625 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/88.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/88/head:pull/88 PR: https://git.openjdk.java.net/jdk15u-dev/pull/88 From aph at openjdk.java.net Tue Aug 3 09:20:44 2021 From: aph at openjdk.java.net (Andrew Haley) Date: Tue, 3 Aug 2021 09:20:44 GMT Subject: [jdk13u-dev] RFR: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 08:44:59 GMT, Sergey Nazarkin wrote: > A clean backport for parity with JDK11/17 Marked as reviewed by aph (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/248 From mdoerr at openjdk.java.net Tue Aug 3 09:47:29 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 3 Aug 2021 09:47:29 GMT Subject: [jdk11u-dev] RFR: 8221988: add possibility to build with Visual Studio 2019 In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 05:23:44 GMT, Christoph Langer wrote: > This is another backport that is needed for GitHub Actions. The Runners will use a VS 2019 installation as base and use VS2017 as a minor version that is installed into the VS 2019 installation. > Patch applies cleanly after JDK-8220445 backport, except for copyright in toolchain_windows.m4. LGTM ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/181 From aph at openjdk.java.net Tue Aug 3 09:55:30 2021 From: aph at openjdk.java.net (Andrew Haley) Date: Tue, 3 Aug 2021 09:55:30 GMT Subject: [jdk15u-dev] RFR: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 08:44:44 GMT, Sergey Nazarkin wrote: > A clean backport for parity with JDK11/17 Marked as reviewed by aph (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/88 From jdowland at redhat.com Tue Aug 3 10:54:45 2021 From: jdowland at redhat.com (Jonathan Dowland) Date: Tue, 3 Aug 2021 11:54:45 +0100 Subject: [jdk11u-dev] maintainer suggestion: jdk11u-fix-no label JDK-8267100 and JDK-8196415 Message-ID: <20210803105445.ffel5pqdieau2v7b@coil> Hello, "JDK-8196415: Disable SHA-1 Signed JARs" shows up on backport parity scans but it was reverted in "JDK-8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs" (itself in the backport lists) I'd like to request a maintainer set the label jdk11u-fix-no on both bugs so they disappear from parity scan reports. Alternatively if a maintainer can give me permission to do it on their behalf I will. Thank you, -- ???? Jonathan Dowland Senior Software Engineer, OpenJDK, Red Hat From snazarki at openjdk.java.net Tue Aug 3 11:27:46 2021 From: snazarki at openjdk.java.net (Sergey Nazarkin) Date: Tue, 3 Aug 2021 11:27:46 GMT Subject: [jdk13u-dev] Integrated: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type In-Reply-To: References: Message-ID: <1kvEDpe4o4ATtjBZeNB6giY3eYNNaamw95cKwtiuWig=.123b41b0-ddf1-4f06-8e29-f0931b46c85f@github.com> On Tue, 3 Aug 2021 08:44:59 GMT, Sergey Nazarkin wrote: > A clean backport for parity with JDK11/17 This pull request has now been integrated. Changeset: 7a64454a Author: Sergey Nazarkin Committer: Dmitry Cherepanov URL: https://git.openjdk.java.net/jdk13u-dev/commit/7a64454afb11bfaeee01e2e274b07e0668396b8c Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type Reviewed-by: aph Backport-of: 3d090e7ee561252027c06021b337c69a39f724e1 ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/248 From snazarki at openjdk.java.net Tue Aug 3 11:35:49 2021 From: snazarki at openjdk.java.net (Sergey Nazarkin) Date: Tue, 3 Aug 2021 11:35:49 GMT Subject: [jdk15u-dev] Integrated: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 08:44:44 GMT, Sergey Nazarkin wrote: > A clean backport for parity with JDK11/17 This pull request has now been integrated. Changeset: 25760d13 Author: Sergey Nazarkin Committer: Dmitry Cherepanov URL: https://git.openjdk.java.net/jdk15u-dev/commit/25760d13cead3d3ae0380d0722a68a3bff18cc44 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type Reviewed-by: aph Backport-of: 3d090e7ee561252027c06021b337c69a39f724e1 ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/88 From mdoerr at openjdk.java.net Tue Aug 3 12:45:00 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 3 Aug 2021 12:45:00 GMT Subject: [jdk11u-dev] RFR: 8266761: AssertionError in sun.net.httpserver.ServerImpl.responseCompleted [v2] In-Reply-To: References: Message-ID: > Backport of JDK-8266761. Applies cleanly except the following hunk: > > --- src/jdk.httpserver/share/classes/sun/net/httpserver/ExchangeImpl.java > +++ src/jdk.httpserver/share/classes/sun/net/httpserver/ExchangeImpl.java > @@ -270,7 +269,6 @@ public void sendResponseHeaders (int rCode, long contentLen) > Optional.ofNullable(rspHdrs.get("Connection")) > .map(List::stream).orElse(Stream.empty()); > if (conheader.anyMatch("close"::equalsIgnoreCase)) { > - Logger logger = server.getLogger(); > logger.log (Level.DEBUG, "Connection: close requested by handler"); > close = true; > } > > That code belongs to the enhancement JDK-8218554 which is not in 11u. Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: Add comment. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/169/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/169/files/b8183c5f..c76e3666 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=169&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=169&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/169.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/169/head:pull/169 PR: https://git.openjdk.java.net/jdk11u-dev/pull/169 From mdoerr at openjdk.java.net Tue Aug 3 12:45:04 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 3 Aug 2021 12:45:04 GMT Subject: [jdk11u-dev] RFR: 8266761: AssertionError in sun.net.httpserver.ServerImpl.responseCompleted In-Reply-To: References: Message-ID: On Wed, 28 Jul 2021 13:13:44 GMT, Martin Doerr wrote: > Backport of JDK-8266761. Applies cleanly except the following hunk: > > --- src/jdk.httpserver/share/classes/sun/net/httpserver/ExchangeImpl.java > +++ src/jdk.httpserver/share/classes/sun/net/httpserver/ExchangeImpl.java > @@ -270,7 +269,6 @@ public void sendResponseHeaders (int rCode, long contentLen) > Optional.ofNullable(rspHdrs.get("Connection")) > .map(List::stream).orElse(Stream.empty()); > if (conheader.anyMatch("close"::equalsIgnoreCase)) { > - Logger logger = server.getLogger(); > logger.log (Level.DEBUG, "Connection: close requested by handler"); > close = true; > } > > That code belongs to the enhancement JDK-8218554 which is not in 11u. Thanks for the review! Comment added. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/169 From zgu at openjdk.java.net Tue Aug 3 13:26:41 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 3 Aug 2021 13:26:41 GMT Subject: [jdk11u-dev] Integrated: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info. In-Reply-To: References: Message-ID: On Mon, 2 Aug 2021 19:32:21 GMT, Zhengyu Gu wrote: > Not a clean backport due to context different, but easy to resolve manually. > > Test: > - [x] New test failed w/o patch and passed with patch. This pull request has now been integrated. Changeset: 4da3fb81 Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk11u-dev/commit/4da3fb8158242b6d7720a299311e652fcf56b854 Stats: 75 lines in 2 files changed: 74 ins; 0 del; 1 mod 8268261: C2: assert(n != __null) failed: Bad immediate dominator info. Reviewed-by: kvn, phh Backport-of: 4ed548b3eeffe8dfa601d4d0eeed2bfe359af965 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/179 From zgu at openjdk.java.net Tue Aug 3 13:27:32 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 3 Aug 2021 13:27:32 GMT Subject: [jdk11u-dev] Integrated: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type In-Reply-To: References: Message-ID: On Mon, 2 Aug 2021 17:55:16 GMT, Zhengyu Gu wrote: > A clean backport for parity with Oracle 11.0.13 This pull request has now been integrated. Changeset: 815d3e1c Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk11u-dev/commit/815d3e1c6cd8272f962eaec80758cafa97c1dda5 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type Backport-of: 3d090e7ee561252027c06021b337c69a39f724e1 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/178 From sgehwolf at redhat.com Tue Aug 3 14:11:01 2021 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Tue, 03 Aug 2021 16:11:01 +0200 Subject: [jdk11u-dev] maintainer suggestion: jdk11u-fix-no label JDK-8267100 and JDK-8196415 In-Reply-To: <20210803105445.ffel5pqdieau2v7b@coil> References: <20210803105445.ffel5pqdieau2v7b@coil> Message-ID: <641668b9e48d96b306c980cfc6a2aa4d4d71db89.camel@redhat.com> Hi Jon, On Tue, 2021-08-03 at 11:54 +0100, Jonathan Dowland wrote: > Hello, > > "JDK-8196415: Disable SHA-1 Signed JARs" shows up on backport parity > scans but it was reverted in "JDK-8267100: [BACKOUT] JDK-8196415 > Disable SHA-1 Signed JARs" (itself in the backport lists) > > I'd like to request a maintainer set the label jdk11u-fix-no on both > bugs so they disappear from parity scan reports. Alternatively if a > maintainer can give me permission to do it on their behalf I will. Sure, done. I've also added a comment to both bugs. JDK-8269039 is the one to track. Thanks, Severin From clanger at openjdk.java.net Tue Aug 3 14:21:03 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 3 Aug 2021 14:21:03 GMT Subject: [jdk11u-dev] RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c Message-ID: This is a clean backport of JDK-8254270, another prerequisite to enable GitHub actions in 11u. ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/181 Commit messages: - 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c Changes: https://git.openjdk.java.net/jdk11u-dev/pull/182/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=182&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8254270 Stats: 7 lines in 1 file changed: 3 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/182.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/182/head:pull/182 PR: https://git.openjdk.java.net/jdk11u-dev/pull/182 From sgehwolf at openjdk.java.net Tue Aug 3 16:09:48 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 3 Aug 2021 16:09:48 GMT Subject: [jdk11u-dev] RFR: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers Message-ID: Please review this backport of JDK-8269851 to OpenJDK 11u. That code stream is affected by the same bug and should get fixed in the same way as it got fixed with [JDK-8265836](https://bugs.openjdk.java.net/browse/JDK-8265836) for system CPU load, but for process CPU load. The patch only differs minimally from the JDK 18 patch, but doesn't apply clean due to the following reason. This version uses `getSystemCpuLoad()` and `getSystemCpuLoad0()` instead of `getCpuLoad()` and `getCpuLoad0()`. Testing: Manually using the reproducer code from the bug and tier1 on Linux x86_64. Thoughts? ------------- Commit messages: - Backport 25f00d787cf56f6cdca6949115d04e7d8e675554 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/183/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=183&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269851 Stats: 214 lines in 1 file changed: 137 ins; 74 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/183.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/183/head:pull/183 PR: https://git.openjdk.java.net/jdk11u-dev/pull/183 From github.com+42899633+eastig at openjdk.java.net Tue Aug 3 17:06:30 2021 From: github.com+42899633+eastig at openjdk.java.net (Evgeny Astigeevich) Date: Tue, 3 Aug 2021 17:06:30 GMT Subject: [jdk11u-dev] RFR: 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully In-Reply-To: References: Message-ID: On Thu, 29 Jul 2021 12:22:06 GMT, Sergey Nazarkin wrote: > Hi! > I'd like to backport this changes to fix crash happens on memory mapped file operations. The patch applies almost cleanly except stubGenerator_arm.cpp due to miss of JEP 340 (One AArch64 Port, Not Two), and some copyright year conflicts. > Need to note that a series of follow up is required to fix some platforms build. Particularly arm32/aarch64 is not buildable without 8226871. I'll create necessary PR soon. > Tested with tier1/tier2 and new InternalErrorTest. LGTM Confirm changes to files except stubGenerator_arm.cpp are identical to the original patch. Changes to stubGenerator_arm.cpp look good to me. > Particularly arm32/aarch64 is not buildable without 8226871. I'll create necessary PR soon. BTW, 8226871 looks trivial. Maybe it is worth to push it first. ------------- Marked as reviewed by eastig at github.com (no known OpenJDK username). PR: https://git.openjdk.java.net/jdk11u-dev/pull/173 From phh at openjdk.java.net Tue Aug 3 17:34:32 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 3 Aug 2021 17:34:32 GMT Subject: [jdk11u-dev] RFR: 8246387: switch to jtreg 5.1 In-Reply-To: References: Message-ID: On Tue, 6 Jul 2021 17:19:29 GMT, Aleksey Shipilev wrote: > This is a compound backport that brings the entire 11u to 5.1 b1. There are many dependencies thorough the repository history, so I opted to squash them together. It seems the 11.0.13-oracle backport exists only for this issue, which indicates Oracle maintainers did the same. > > The current list of included patches is: > > > 8246387: switch to jtreg 5.1 > 8238943: switch to jtreg 5.0 > 8235866: bump jtreg requiredVersion to 4.2b16 > 8219552: bump jtreg requiredVersion to b14 in test/jdk/sanity/client/ > 8219417: bump jtreg requiredVersion to b14 > 8236111: narrow allowSmartActionArgs disabling > > > Tested on Linux x86_64 fastdebug with jtreg5.1-b1 and the following test suites: > - tier1 > - tier2 > - tier3 > - vmTestbase_nsk_jvmti > - vmTestbase_vm_metaspace > - vmTestbase_vm_defmeth > - vmTestbase_vm_mlvm > - vmTestbase_vm_compiler > - vmTestbase_nsk_jvmti > - vmTestbase_vm_metaspace > - sanity/client CDSTestUtils.java needs a copyright update to 2020. All the TEST.properties files have an extra newline at their ends. ------------- Changes requested by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/103 From phh at openjdk.java.net Tue Aug 3 17:39:32 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 3 Aug 2021 17:39:32 GMT Subject: [jdk11u-dev] RFR: 8230808: Remove Access::equals() In-Reply-To: References: Message-ID: <0TGIxTWcXv-YhnbHuKJCEs47BCPka7-f_GyZW6WAkN8=.dbe067aa-09ff-4a2e-9fa8-e4c4f1bea628@github.com> On Tue, 6 Jul 2021 07:18:06 GMT, Aleksey Shipilev wrote: > This is the first patch in the series to cleanup/revert the GC BarrierSets to most current state. See the dependent ("this issue blocks" links) issues to see what is next. > > The `equals` APIs were added for Shenandoah GC, in the incarnation that exposed both from- and to-copies to the runtime system (see JDK-8199781). Since then, Shenandoah greatly simplified this by switching to a strong to-space invariant, which obviates the need for this API. Therefore, it was removed in JDK 14. This patch reverts JDK 11 parts to that shape as well, which should simplify 11u maintenance. > > Additional testing: > - [x] Linux x86_64 {release, fastdebug, slowdebug} builds > - [x] Linux x86_64 `tier1`, `tier2` with Shenandoah, Parallel Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/100 From phh at openjdk.java.net Tue Aug 3 17:48:33 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 3 Aug 2021 17:48:33 GMT Subject: [jdk11u-dev] RFR: 8168304: Make all of DependencyContext_test available in product mode In-Reply-To: References: Message-ID: <4Jri2CL_317hbLf18k4eToiWujrzlGf2A6r-l8FBgDg=.b4486501-ddf9-419f-ad71-49f444d9a142@github.com> On Fri, 2 Jul 2021 11:10:02 GMT, Aleksey Shipilev wrote: > Unclean backport, because there is `find_stale_entries` too. > > Additional testing: > - [x] Affected test on Linux x86_64 fastdebug > - [x] Affected test on Linux x86_64 release Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/96 From phh at openjdk.java.net Tue Aug 3 17:51:32 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 3 Aug 2021 17:51:32 GMT Subject: [jdk11u-dev] RFR: 8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes In-Reply-To: References: Message-ID: On Wed, 30 Jun 2021 19:59:17 GMT, Jiangli Zhou wrote: > Please review the backport of JDK-8230674. Backport was created with the /backport commit command. Original patch applies cleanly. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/89 From mdoerr at openjdk.java.net Tue Aug 3 18:32:48 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 3 Aug 2021 18:32:48 GMT Subject: [jdk11u-dev] RFR: 8211055: Provide print to a file (PDF) feature even when printer was not connected Message-ID: <6ammajvEC-zOlNl6pi2pllKlHKW-HKJ4OQ3AcQBqiPY=.2579afd2-89db-443b-9023-038a9c07f8f0@github.com> Backport of JDK-8211055. Doesn't apply cleanly because JNF removal is already backported to 11u. ------------- Commit messages: - Fix typo. - Backport 9b0d241a16b2f2abb821c7a74408b826db75ec4a Changes: https://git.openjdk.java.net/jdk11u-dev/pull/177/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=177&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8211055 Stats: 233 lines in 3 files changed: 231 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/177.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/177/head:pull/177 PR: https://git.openjdk.java.net/jdk11u-dev/pull/177 From jdowland at redhat.com Tue Aug 3 18:36:42 2021 From: jdowland at redhat.com (Jonathan Dowland) Date: Tue, 3 Aug 2021 19:36:42 +0100 Subject: [jdk11u-dev] maintainer suggestion: jdk11u-fix-no label JDK-8267100 and JDK-8196415 In-Reply-To: <641668b9e48d96b306c980cfc6a2aa4d4d71db89.camel@redhat.com> References: <20210803105445.ffel5pqdieau2v7b@coil> <641668b9e48d96b306c980cfc6a2aa4d4d71db89.camel@redhat.com> Message-ID: <20210803183642.mmxw3aaurpke4dyf@coil> On Tue, Aug 03, 2021 at 04:11:01PM +0200, Severin Gehwolf wrote: > Sure, done. I've also added a comment to both bugs. JDK-8269039 is the > one to track. Thanks! -- ???? Jonathan Dowland Senior Software Engineer, OpenJDK, Red Hat From mdoerr at openjdk.java.net Tue Aug 3 19:12:42 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 3 Aug 2021 19:12:42 GMT Subject: [jdk11u-dev] RFR: 8263432: javac may report an invalid package/class clash on case insensitive filesystems Message-ID: Backport of JDK-8263432. Fix applies cleanly except Copyright year update. The test required manual integration and adaptation of imports. ------------- Commit messages: - Backport 0a4c33826d0422af7c4cfa5f479fe0b6b0f83d23 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/184/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=184&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263432 Stats: 107 lines in 2 files changed: 102 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/184.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/184/head:pull/184 PR: https://git.openjdk.java.net/jdk11u-dev/pull/184 From clanger at openjdk.java.net Tue Aug 3 21:43:29 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 3 Aug 2021 21:43:29 GMT Subject: [jdk11u-dev] RFR: 8211055: Provide print to a file (PDF) feature even when printer was not connected In-Reply-To: <6ammajvEC-zOlNl6pi2pllKlHKW-HKJ4OQ3AcQBqiPY=.2579afd2-89db-443b-9023-038a9c07f8f0@github.com> References: <6ammajvEC-zOlNl6pi2pllKlHKW-HKJ4OQ3AcQBqiPY=.2579afd2-89db-443b-9023-038a9c07f8f0@github.com> Message-ID: On Mon, 2 Aug 2021 14:37:43 GMT, Martin Doerr wrote: > Backport of JDK-8211055. Doesn't apply cleanly because JNF removal is already backported to 11u. LGTM - did you run/verify the testcase? It is a manual test which is not covered in our nightlies. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/177 From clanger at openjdk.java.net Tue Aug 3 21:46:29 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 3 Aug 2021 21:46:29 GMT Subject: [jdk11u-dev] RFR: 8226319: Add forgotten test/jdk/java/net/httpclient/BodySubscribersTest.java In-Reply-To: <0mMQG-X_NkqpuwLOcYxXiSzqB_bbbdqtwoq4YUKgs5E=.c00b3dd0-9a1a-46e7-8aaf-bac7fa4ea680@github.com> References: <0mMQG-X_NkqpuwLOcYxXiSzqB_bbbdqtwoq4YUKgs5E=.c00b3dd0-9a1a-46e7-8aaf-bac7fa4ea680@github.com> Message-ID: On Thu, 29 Jul 2021 17:30:21 GMT, Zhengyu Gu wrote: > I would like to backport this patch to 11u. This patch contains missing test from JDK-8225583, which is a Oracle parity backport. > > The backport is clean. And the test passes with JDK-8225583. @zhengyu123 Can you update the PR to only contain the commit of JDK-8226319? Force push should be ok in this case. Then the PR should probably get marked as clean... ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/175 From clanger at openjdk.java.net Tue Aug 3 21:52:33 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 3 Aug 2021 21:52:33 GMT Subject: [jdk11u-dev] RFR: 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully In-Reply-To: References: Message-ID: On Thu, 29 Jul 2021 12:22:06 GMT, Sergey Nazarkin wrote: > Hi! > I'd like to backport this changes to fix crash happens on memory mapped file operations. The patch applies almost cleanly except stubGenerator_arm.cpp due to miss of JEP 340 (One AArch64 Port, Not Two), and some copyright year conflicts. > Need to note that a series of follow up is required to fix some platforms build. Particularly arm32/aarch64 is not buildable without 8226871. I'll create necessary PR soon. > Tested with tier1/tier2 and new InternalErrorTest. Hi, @snazarkin, since JDK-8191278 has a few follow-up fixes, could you please use the recently enabled feature of dependent pull requests and add all those. We can then test them together. To do that, create the backport of e.g. JDK-8226871 on top of this branch and then open a PR to branch pr/173 of this repository. Please let me know if you have further questions. Thanks! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/173 From christoph.langer at sap.com Tue Aug 3 22:01:28 2021 From: christoph.langer at sap.com (Langer, Christoph) Date: Tue, 3 Aug 2021 22:01:28 +0000 Subject: [jdk11u-dev] maintainer suggestion: jdk11u-fix-no label JDK-8267100 and JDK-8196415 In-Reply-To: <20210803183642.mmxw3aaurpke4dyf@coil> References: <20210803105445.ffel5pqdieau2v7b@coil> <641668b9e48d96b306c980cfc6a2aa4d4d71db89.camel@redhat.com> <20210803183642.mmxw3aaurpke4dyf@coil> Message-ID: Hi Jon, Severin, I changed the label to openjdk-na which is what we usually use to mark bugs as not applicable for OpenJDK backports. (E.g. the filter https://bugs.openjdk.java.net/issues/?filter=40588). Please let me know if that's an issue for you. Thanks & Best regards Christoph > -----Original Message----- > From: jdk-updates-dev On > Behalf Of Jonathan Dowland > Sent: Dienstag, 3. August 2021 20:37 > To: sgehwolf > Cc: jdk-updates-dev at openjdk.java.net > Subject: Re: [jdk11u-dev] maintainer suggestion: jdk11u-fix-no label JDK- > 8267100 and JDK-8196415 > > On Tue, Aug 03, 2021 at 04:11:01PM +0200, Severin Gehwolf wrote: > > Sure, done. I've also added a comment to both bugs. JDK-8269039 is the > > one to track. > > Thanks! > > -- > ???? Jonathan Dowland > Senior Software Engineer, OpenJDK, Red Hat From clanger at openjdk.java.net Tue Aug 3 22:22:33 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 3 Aug 2021 22:22:33 GMT Subject: [jdk11u-dev] RFR: 8257497: Update keytool to create AKID from the SKID of the issuing certificate as specified by RFC 5280 In-Reply-To: References: Message-ID: On Tue, 27 Jul 2021 17:14:24 GMT, Martin Doerr wrote: > Backport of JDK-8257497. The actual fix applies cleanly. Copyright year update doesn't. The test CheckCertAKID.java uses KnownOIDs which is not part of the JDK in 11u. We're using a copy in the test library instead. Skipped changes in ExtOptionCamelCase.java which belongs to JDK-8231950 which is not in 11u. Looks good. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/167 From clanger at openjdk.java.net Tue Aug 3 22:25:28 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 3 Aug 2021 22:25:28 GMT Subject: [jdk11u-dev] RFR: 8263432: javac may report an invalid package/class clash on case insensitive filesystems In-Reply-To: References: Message-ID: <5Fn9R_o_kX7qKw0wBPwrjmqEglJs7dvw0a6ytyaxOGY=.b19cb9b3-3ce2-482b-8853-fe28d31dc199@github.com> On Tue, 3 Aug 2021 19:04:55 GMT, Martin Doerr wrote: > Backport of JDK-8263432. Fix applies cleanly except Copyright year update. The test required manual integration and adaptation of imports. Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/184 From clanger at openjdk.java.net Tue Aug 3 22:31:28 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 3 Aug 2021 22:31:28 GMT Subject: [jdk11u-dev] RFR: 8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes In-Reply-To: References: Message-ID: On Wed, 30 Jun 2021 19:59:17 GMT, Jiangli Zhou wrote: > Please review the backport of JDK-8230674. Backport was created with the /backport commit command. Original patch applies cleanly. @jianglizhou, will you integrate this one any time soon? ?? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/89 From clanger at openjdk.java.net Tue Aug 3 22:39:30 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 3 Aug 2021 22:39:30 GMT Subject: [jdk11u-dev] RFR: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 16:04:31 GMT, Severin Gehwolf wrote: > Please review this backport of JDK-8269851 to OpenJDK 11u. That code stream is affected by the same bug and should get fixed in the same way as it got fixed with [JDK-8265836](https://bugs.openjdk.java.net/browse/JDK-8265836) for system CPU load, but for process CPU load. > > The patch only differs minimally from the JDK 18 patch, but doesn't apply clean due to the following reason. This version uses `getSystemCpuLoad()` and `getSystemCpuLoad0()` instead of `getCpuLoad()` and `getCpuLoad0()`. > > Testing: Manually using the reproducer code from the bug and tier1 on Linux x86_64. > > Thoughts? LGTM. As JDK17 is LTS, it should be backported there, too. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/183 From clanger at openjdk.java.net Tue Aug 3 22:44:36 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 3 Aug 2021 22:44:36 GMT Subject: [jdk11u-dev] RFR: 8234510: Remove file seeking requirement for writing a heap dump [v2] In-Reply-To: References: Message-ID: <26EkImayFUkM1HOApKjLZMlwgyyKkWkBS12pdrrsP0E=.1dfe6b89-359e-4343-b338-71db96fe025c@github.com> On Tue, 3 Aug 2021 02:59:00 GMT, BuddyLiao wrote: >> Backport of the heap dump enhancement: Remove file seeking requirement for writing a heap dump >> >> Patch did not apply cleanly, I had to resolve/modify >> src/hotspot/share/services/heapDumper.cpp >> >> I have built it on linux x86_64 and run test-tier1 > > BuddyLiao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Merge master > - 8234510: Remove file seeking requirement for writing a heap dump @buddyliao, thanks for rebasing. I'll run this through our nightlies and if all goes well I'll approve it then. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/134 From clanger at openjdk.java.net Tue Aug 3 22:53:41 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 3 Aug 2021 22:53:41 GMT Subject: [jdk11u-dev] RFR: 8257913: Add more known library locations to simplify Linux cross-compilation Message-ID: This backport of JDK-8257913 is another prereq for GitHub Actions in 11u. I had to make it fit a little bit. The changes to .github/workflows/submit.yml were dropped obviously as the submit.yml that I'll propose will not need the removed parts then. ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/182 Commit messages: - 8257913: Add more known library locations to simplify Linux cross-compilation Changes: https://git.openjdk.java.net/jdk11u-dev/pull/185/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=185&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8257913 Stats: 51 lines in 3 files changed: 51 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/185.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/185/head:pull/185 PR: https://git.openjdk.java.net/jdk11u-dev/pull/185 From jiangli at openjdk.java.net Tue Aug 3 23:14:31 2021 From: jiangli at openjdk.java.net (Jiangli Zhou) Date: Tue, 3 Aug 2021 23:14:31 GMT Subject: [jdk11u-dev] RFR: 8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 22:29:04 GMT, Christoph Langer wrote: >> Please review the backport of JDK-8230674. Backport was created with the /backport commit command. Original patch applies cleanly. > > @jianglizhou, will you integrate this one any time soon? ?? @RealCLanger, integrated ?? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/89 From jiangli at openjdk.java.net Tue Aug 3 23:14:32 2021 From: jiangli at openjdk.java.net (Jiangli Zhou) Date: Tue, 3 Aug 2021 23:14:32 GMT Subject: [jdk11u-dev] Integrated: 8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes In-Reply-To: References: Message-ID: On Wed, 30 Jun 2021 19:59:17 GMT, Jiangli Zhou wrote: > Please review the backport of JDK-8230674. Backport was created with the /backport commit command. Original patch applies cleanly. This pull request has now been integrated. Changeset: aebdee34 Author: Jiangli Zhou URL: https://git.openjdk.java.net/jdk11u-dev/commit/aebdee343c9fa3a50a73ae6606c49d6bca8c3fc5 Stats: 35 lines in 1 file changed: 29 ins; 5 del; 1 mod 8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes Reviewed-by: phh Backport-of: e90970b67bb3cd1980ac873b0c9465e53f494e37 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/89 From clanger at openjdk.java.net Wed Aug 4 05:48:37 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 05:48:37 GMT Subject: [jdk11u-dev] RFR: 8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 22:29:04 GMT, Christoph Langer wrote: >> Please review the backport of JDK-8230674. Backport was created with the /backport commit command. Original patch applies cleanly. > > @jianglizhou, will you integrate this one any time soon? ?? > @RealCLanger, integrated ?? Cool, thanks ?? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/89 From clanger at openjdk.java.net Wed Aug 4 07:52:38 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 07:52:38 GMT Subject: [jdk11u-dev] RFR: 8209380: ARM: cleanup maybe-uninitialized and reorder compiler warnings Message-ID: <-cABFq2nXdrwlRAXSv7OfkpBkUNrBKbp_0hlLztH390=.cff946d8-f293-4127-8db3-979cfcef2e33@github.com> Please review the backport of JDK-8209380. It is another prereq to get the upcoming GitHub Actions workflow green. The patch applies cleanly and follow up JDK-8209193 is already in 11u. If it weren't integrated, the GHA crossbuild of hotspot for arm would fail. ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/185 Commit messages: - 8209380: ARM: cleanup maybe-uninitialized and reorder compiler warnings Changes: https://git.openjdk.java.net/jdk11u-dev/pull/186/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=186&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8209380 Stats: 9 lines in 4 files changed: 5 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/186.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/186/head:pull/186 PR: https://git.openjdk.java.net/jdk11u-dev/pull/186 From shade at openjdk.java.net Wed Aug 4 08:06:04 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 4 Aug 2021 08:06:04 GMT Subject: [jdk11u-dev] RFR: 8246387: switch to jtreg 5.1 [v2] In-Reply-To: References: Message-ID: <-MXDjlKUIvGUePd02JhbdFa0sshoyzwSNvrEmojkuzU=.84ea7eec-0387-4614-a108-f68043c0c208@github.com> > This is a compound backport that brings the entire 11u to 5.1 b1. There are many dependencies thorough the repository history, so I opted to squash them together. It seems the 11.0.13-oracle backport exists only for this issue, which indicates Oracle maintainers did the same. > > The current list of included patches is: > > > 8246387: switch to jtreg 5.1 > 8238943: switch to jtreg 5.0 > 8235866: bump jtreg requiredVersion to 4.2b16 > 8219552: bump jtreg requiredVersion to b14 in test/jdk/sanity/client/ > 8219417: bump jtreg requiredVersion to b14 > 8236111: narrow allowSmartActionArgs disabling > > > Tested on Linux x86_64 fastdebug with jtreg5.1-b1 and the following test suites: > - tier1 > - tier2 > - tier3 > - vmTestbase_nsk_jvmti > - vmTestbase_vm_metaspace > - vmTestbase_vm_defmeth > - vmTestbase_vm_mlvm > - vmTestbase_vm_compiler > - vmTestbase_nsk_jvmti > - vmTestbase_vm_metaspace > - sanity/client Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Update CDSTestUtils copyright - Merge branch 'master' into JDK-8246387 - Backport e47b2bc8c338a0b137106074952cded1067fc50a ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/103/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/103/files/d154cf99..14cde8be Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=103&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=103&range=00-01 Stats: 14990 lines in 364 files changed: 7587 ins; 5163 del; 2240 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/103.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/103/head:pull/103 PR: https://git.openjdk.java.net/jdk11u-dev/pull/103 From shade at openjdk.java.net Wed Aug 4 08:06:07 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 4 Aug 2021 08:06:07 GMT Subject: [jdk11u-dev] RFR: 8246387: switch to jtreg 5.1 [v2] In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 17:31:40 GMT, Paul Hohensee wrote: > CDSTestUtils.java needs a copyright update to 2020. Right, fixed. > All the TEST.properties files have an extra newline at their ends. I don't follow. TEST.properties are from https://hg.openjdk.java.net/jdk/jdk/rev/1922c31f1dcc verbatim: two lines each. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/103 From mdoerr at openjdk.java.net Wed Aug 4 09:09:42 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 4 Aug 2021 09:09:42 GMT Subject: [jdk11u-dev] Integrated: 8257497: Update keytool to create AKID from the SKID of the issuing certificate as specified by RFC 5280 In-Reply-To: References: Message-ID: On Tue, 27 Jul 2021 17:14:24 GMT, Martin Doerr wrote: > Backport of JDK-8257497. The actual fix applies cleanly. Copyright year update doesn't. The test CheckCertAKID.java uses KnownOIDs which is not part of the JDK in 11u. We're using a copy in the test library instead. Skipped changes in ExtOptionCamelCase.java which belongs to JDK-8231950 which is not in 11u. This pull request has now been integrated. Changeset: 0c783b06 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/0c783b06c0008698c6174aee44cf6ca82e6f508c Stats: 149 lines in 2 files changed: 138 ins; 7 del; 4 mod 8257497: Update keytool to create AKID from the SKID of the issuing certificate as specified by RFC 5280 Reviewed-by: clanger Backport-of: 05301f5fd2b5f2357024a3d7bb788270861220a8 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/167 From mdoerr at openjdk.java.net Wed Aug 4 09:10:36 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 4 Aug 2021 09:10:36 GMT Subject: [jdk11u-dev] Integrated: 8266761: AssertionError in sun.net.httpserver.ServerImpl.responseCompleted In-Reply-To: References: Message-ID: On Wed, 28 Jul 2021 13:13:44 GMT, Martin Doerr wrote: > Backport of JDK-8266761. Applies cleanly except the following hunk: > > --- src/jdk.httpserver/share/classes/sun/net/httpserver/ExchangeImpl.java > +++ src/jdk.httpserver/share/classes/sun/net/httpserver/ExchangeImpl.java > @@ -270,7 +269,6 @@ public void sendResponseHeaders (int rCode, long contentLen) > Optional.ofNullable(rspHdrs.get("Connection")) > .map(List::stream).orElse(Stream.empty()); > if (conheader.anyMatch("close"::equalsIgnoreCase)) { > - Logger logger = server.getLogger(); > logger.log (Level.DEBUG, "Connection: close requested by handler"); > close = true; > } > > That code belongs to the enhancement JDK-8218554 which is not in 11u. This pull request has now been integrated. Changeset: cf2cf257 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/cf2cf25799ddc70b5f213434750ec08fd4f44c2b Stats: 245 lines in 3 files changed: 242 ins; 3 del; 0 mod 8266761: AssertionError in sun.net.httpserver.ServerImpl.responseCompleted Reviewed-by: phh Backport-of: 2d2cd78bde7bb9101614a1ba2285d1e37d5d3249 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/169 From mdoerr at openjdk.java.net Wed Aug 4 09:09:40 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 4 Aug 2021 09:09:40 GMT Subject: [jdk11u-dev] RFR: 8257497: Update keytool to create AKID from the SKID of the issuing certificate as specified by RFC 5280 In-Reply-To: References: Message-ID: On Tue, 27 Jul 2021 17:14:24 GMT, Martin Doerr wrote: > Backport of JDK-8257497. The actual fix applies cleanly. Copyright year update doesn't. The test CheckCertAKID.java uses KnownOIDs which is not part of the JDK in 11u. We're using a copy in the test library instead. Skipped changes in ExtOptionCamelCase.java which belongs to JDK-8231950 which is not in 11u. Thanks for the review! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/167 From clanger at openjdk.java.net Wed Aug 4 09:16:50 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 09:16:50 GMT Subject: [jdk11u-dev] RFR: 8249095: tools/javac/launcher/SourceLauncherTest.java fails on Windows Message-ID: This is a clean backport of JDK-8249095, required to enable green runs of a GitHub Actions workflow. ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/186 Commit messages: - 8249095: tools/javac/launcher/SourceLauncherTest.java fails on Windows Changes: https://git.openjdk.java.net/jdk11u-dev/pull/187/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=187&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8249095 Stats: 29 lines in 2 files changed: 21 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/187.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/187/head:pull/187 PR: https://git.openjdk.java.net/jdk11u-dev/pull/187 From sgehwolf at openjdk.java.net Wed Aug 4 09:11:35 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Wed, 4 Aug 2021 09:11:35 GMT Subject: [jdk11u-dev] RFR: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 16:04:31 GMT, Severin Gehwolf wrote: > Please review this backport of JDK-8269851 to OpenJDK 11u. That code stream is affected by the same bug and should get fixed in the same way as it got fixed with [JDK-8265836](https://bugs.openjdk.java.net/browse/JDK-8265836) for system CPU load, but for process CPU load. > > The patch only differs minimally from the JDK 18 patch, but doesn't apply clean due to the following reason. This version uses `getSystemCpuLoad()` and `getSystemCpuLoad0()` instead of `getCpuLoad()` and `getCpuLoad0()`. > > Testing: Manually using the reproducer code from the bug and tier1 on Linux x86_64. > > Thoughts? Thanks for the review. Yes, I'll try to get it into JDK 17 too. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/183 From shade at openjdk.java.net Wed Aug 4 09:22:31 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 4 Aug 2021 09:22:31 GMT Subject: [jdk11u-dev] RFR: 8230808: Remove Access::equals() In-Reply-To: References: Message-ID: On Tue, 6 Jul 2021 07:18:06 GMT, Aleksey Shipilev wrote: > This is the first patch in the series to cleanup/revert the GC BarrierSets to most current state. See the dependent ("this issue blocks" links) issues to see what is next. > > The `equals` APIs were added for Shenandoah GC, in the incarnation that exposed both from- and to-copies to the runtime system (see JDK-8199781). Since then, Shenandoah greatly simplified this by switching to a strong to-space invariant, which obviates the need for this API. Therefore, it was removed in JDK 14. This patch reverts JDK 11 parts to that shape as well, which should simplify 11u maintenance. > > Additional testing: > - [x] Linux x86_64 {release, fastdebug, slowdebug} builds > - [x] Linux x86_64 `tier1`, `tier2` with Shenandoah, Parallel Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/100 From shade at openjdk.java.net Wed Aug 4 09:22:31 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 4 Aug 2021 09:22:31 GMT Subject: [jdk11u-dev] Integrated: 8230808: Remove Access::equals() In-Reply-To: References: Message-ID: On Tue, 6 Jul 2021 07:18:06 GMT, Aleksey Shipilev wrote: > This is the first patch in the series to cleanup/revert the GC BarrierSets to most current state. See the dependent ("this issue blocks" links) issues to see what is next. > > The `equals` APIs were added for Shenandoah GC, in the incarnation that exposed both from- and to-copies to the runtime system (see JDK-8199781). Since then, Shenandoah greatly simplified this by switching to a strong to-space invariant, which obviates the need for this API. Therefore, it was removed in JDK 14. This patch reverts JDK 11 parts to that shape as well, which should simplify 11u maintenance. > > Additional testing: > - [x] Linux x86_64 {release, fastdebug, slowdebug} builds > - [x] Linux x86_64 `tier1`, `tier2` with Shenandoah, Parallel This pull request has now been integrated. Changeset: 77513521 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/775135214df14dc52e0d4d339b15cd23033423af Stats: 104 lines in 6 files changed: 0 ins; 102 del; 2 mod 8230808: Remove Access::equals() Reviewed-by: phh Backport-of: cb50d3b4f3c3cb85a5312fdf20a3229b88302f53 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/100 From shade at openjdk.java.net Wed Aug 4 09:22:36 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 4 Aug 2021 09:22:36 GMT Subject: [jdk11u-dev] RFR: 8168304: Make all of DependencyContext_test available in product mode In-Reply-To: References: Message-ID: On Fri, 2 Jul 2021 11:10:02 GMT, Aleksey Shipilev wrote: > Unclean backport, because there is `find_stale_entries` too. > > Additional testing: > - [x] Affected test on Linux x86_64 fastdebug > - [x] Affected test on Linux x86_64 release Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/96 From shade at openjdk.java.net Wed Aug 4 09:22:37 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 4 Aug 2021 09:22:37 GMT Subject: [jdk11u-dev] Integrated: 8168304: Make all of DependencyContext_test available in product mode In-Reply-To: References: Message-ID: On Fri, 2 Jul 2021 11:10:02 GMT, Aleksey Shipilev wrote: > Unclean backport, because there is `find_stale_entries` too. > > Additional testing: > - [x] Affected test on Linux x86_64 fastdebug > - [x] Affected test on Linux x86_64 release This pull request has now been integrated. Changeset: 35fcac65 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/35fcac65dc317d97f5c14427ea493e619f47d3ce Stats: 15 lines in 3 files changed: 2 ins; 5 del; 8 mod 8168304: Make all of DependencyContext_test available in product mode Enable the utility inspection function `DependencyContext::is_dependent_method` and therefore the test in the product mode. Reviewed-by: phh Backport-of: 66c8794c8141632d730a87643e898c6d4951daee ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/96 From clanger at openjdk.java.net Wed Aug 4 09:25:47 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 09:25:47 GMT Subject: [jdk11u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions Message-ID: This is the backport of the GitHub Actions workflow to JDK11 Updates ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/187 Commit messages: - GitHub Actions for JDK11 Updates Changes: https://git.openjdk.java.net/jdk11u-dev/pull/189/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=189&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253424 Stats: 1546 lines in 2 files changed: 1546 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/189.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/189/head:pull/189 PR: https://git.openjdk.java.net/jdk11u-dev/pull/189 From shade at openjdk.java.net Wed Aug 4 09:48:30 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 4 Aug 2021 09:48:30 GMT Subject: [jdk11u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 09:19:38 GMT, Christoph Langer wrote: > This is the backport of the GitHub Actions workflow to JDK11 Updates Thank you for doing this! So we would also need to do followup additions (as separate backports), right? 8254282: Add Linux x86_32 builds to submit workflow 8254175: Build no-pch configuration in debug mode for submit checks 8254173: Add Zero, Minimal hotspot targets to submit workflow 8256414: add optimized build to submit workflow ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/189 From clanger at openjdk.java.net Wed Aug 4 09:53:32 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 09:53:32 GMT Subject: [jdk11u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 09:45:05 GMT, Aleksey Shipilev wrote: > Thank you for doing this! So we would also need to do followup additions (as separate backports), right? > > 8254282: Add Linux x86_32 builds to submit workflow > 8254175: Build no-pch configuration in debug mode for submit checks > 8254173: Add Zero, Minimal hotspot targets to submit workflow > 8256414: add optimized build to submit workflow Yes, the state of the workflow is very close to what we have in head openjdk/jdk. I'll update the description with some details and mark the important JBS items that I find as backported. Stay tuned... ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/189 From shade at openjdk.java.net Wed Aug 4 09:53:32 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 4 Aug 2021 09:53:32 GMT Subject: [jdk11u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions In-Reply-To: References: Message-ID: <8HabdxZ9AgFgdgTqYXWC1aeVHz3c4b1k28mvzJTyNQo=.b22c319c-9a0a-4fb0-9246-c8c562884c6c@github.com> On Wed, 4 Aug 2021 09:19:38 GMT, Christoph Langer wrote: > This is the backport of the GitHub Actions workflow to JDK11 Updates Also, from the looks of it, "8256127: Add cross-compiled foreign architectures builds to submit workflow" is also included here. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/189 From sgehwolf at openjdk.java.net Wed Aug 4 09:59:45 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Wed, 4 Aug 2021 09:59:45 GMT Subject: [jdk17u] RFR: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers Message-ID: Hi all, This issue is present in JDK 17u as well and should get fixed (like the similar [JDK-8265836](https://bugs.openjdk.java.net/browse/JDK-8265836) which made it into JDK 17 GA.) Patch applies clean. The commit being backported was authored by bobpengxie on 28 Jul 2021 and was reviewed by Severin Gehwolf. Thanks! ------------- Commit messages: - Backport 25f00d787cf56f6cdca6949115d04e7d8e675554 Changes: https://git.openjdk.java.net/jdk17u/pull/9/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=9&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269851 Stats: 218 lines in 1 file changed: 137 ins; 78 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u/pull/9.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/9/head:pull/9 PR: https://git.openjdk.java.net/jdk17u/pull/9 From aph at openjdk.java.net Wed Aug 4 10:54:46 2021 From: aph at openjdk.java.net (Andrew Haley) Date: Wed, 4 Aug 2021 10:54:46 GMT Subject: [jdk17u] RFR: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type In-Reply-To: References: Message-ID: On Mon, 2 Aug 2021 21:17:25 GMT, Christoph Langer wrote: > Hi all, > > this pull request contains a backport of JDK-8267625 from the openjdk/jdk repository. > > The commit being backported was authored by Nick Gasson on 7 Jul 2021 and was reviewed by Andrew Haley and Dean Long. > > Thanks! Marked as reviewed by aph (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk17u/pull/8 From phh at openjdk.java.net Wed Aug 4 11:27:33 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 4 Aug 2021 11:27:33 GMT Subject: [jdk11u-dev] RFR: 8246387: switch to jtreg 5.1 [v2] In-Reply-To: <-MXDjlKUIvGUePd02JhbdFa0sshoyzwSNvrEmojkuzU=.84ea7eec-0387-4614-a108-f68043c0c208@github.com> References: <-MXDjlKUIvGUePd02JhbdFa0sshoyzwSNvrEmojkuzU=.84ea7eec-0387-4614-a108-f68043c0c208@github.com> Message-ID: On Wed, 4 Aug 2021 08:06:04 GMT, Aleksey Shipilev wrote: >> This is a compound backport that brings the entire 11u to 5.1 b1. There are many dependencies thorough the repository history, so I opted to squash them together. It seems the 11.0.13-oracle backport exists only for this issue, which indicates Oracle maintainers did the same. >> >> The current list of included patches is: >> >> >> 8246387: switch to jtreg 5.1 >> 8238943: switch to jtreg 5.0 >> 8235866: bump jtreg requiredVersion to 4.2b16 >> 8219552: bump jtreg requiredVersion to b14 in test/jdk/sanity/client/ >> 8219417: bump jtreg requiredVersion to b14 >> 8236111: narrow allowSmartActionArgs disabling >> >> >> Tested on Linux x86_64 fastdebug with jtreg5.1-b1 and the following test suites: >> - tier1 >> - tier2 >> - tier3 >> - vmTestbase_nsk_jvmti >> - vmTestbase_vm_metaspace >> - vmTestbase_vm_defmeth >> - vmTestbase_vm_mlvm >> - vmTestbase_vm_compiler >> - vmTestbase_nsk_jvmti >> - vmTestbase_vm_metaspace >> - sanity/client > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Update CDSTestUtils copyright > - Merge branch 'master' into JDK-8246387 > - Backport e47b2bc8c338a0b137106074952cded1067fc50a The extra lines seem to be a webrev artifact. They're not in the diff, so lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/103 From clanger at openjdk.java.net Wed Aug 4 12:27:40 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 12:27:40 GMT Subject: [jdk11u-dev] RFR: 8238930: problem list compiler/c2/Test8004741.java Message-ID: Please review the backport of this test exclusion (JDK-8238930). I see the test compiler/c2/Test8004741.java regularly failing in the GitHub Actions pipeline and the actual issue JDK-8235801 doesn't seem to be fixed yet. ------------- Commit messages: - 8238930: problem list compiler/c2/Test8004741.java Changes: https://git.openjdk.java.net/jdk11u-dev/pull/190/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=190&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8238930 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/190.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/190/head:pull/190 PR: https://git.openjdk.java.net/jdk11u-dev/pull/190 From jdowland at redhat.com Wed Aug 4 12:43:09 2021 From: jdowland at redhat.com (Jonathan Dowland) Date: Wed, 4 Aug 2021 13:43:09 +0100 Subject: [jdk11u-dev] maintainer suggestion: jdk11u-fix-no label JDK-8267100 and JDK-8196415 In-Reply-To: References: <20210803105445.ffel5pqdieau2v7b@coil> <641668b9e48d96b306c980cfc6a2aa4d4d71db89.camel@redhat.com> <20210803183642.mmxw3aaurpke4dyf@coil> Message-ID: <20210804124309.z6hyvrt6qvabpvfz@coil> Hi Christoph, On Tue, Aug 03, 2021 at 10:01:28PM +0000, Langer, Christoph wrote: > I changed the label to openjdk-na which is what we usually use to mark > bugs as not applicable for OpenJDK backports. (E.g. the filter > https://bugs.openjdk.java.net/issues/?filter=40588). Please let me > know if that's an issue for you. Fine by me! That will have the desired effect on the parity reports too. Thanks, -- ???? Jonathan Dowland Senior Software Engineer, OpenJDK, Red Hat From snazarki at openjdk.java.net Wed Aug 4 12:56:41 2021 From: snazarki at openjdk.java.net (Sergey Nazarkin) Date: Wed, 4 Aug 2021 12:56:41 GMT Subject: [jdk11u-dev] RFR: 8226871: invalid use of incomplete type class MacroAssembler when building minimal after JDK-8191278 Message-ID: This is follow up for 8191278 that fixes build of arm/aarch64 platforms. ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/173 Commit messages: - Backport 7a1bd6184971f72a8e8dc41a3a9baceb0ab7c52d Changes: https://git.openjdk.java.net/jdk11u-dev/pull/191/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=191&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8226871 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/191.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/191/head:pull/191 PR: https://git.openjdk.java.net/jdk11u-dev/pull/191 From snazarki at openjdk.java.net Wed Aug 4 13:02:46 2021 From: snazarki at openjdk.java.net (Sergey Nazarkin) Date: Wed, 4 Aug 2021 13:02:46 GMT Subject: [jdk11u-dev] RFR: 8226878: zero crashes after JDK-8191278 Message-ID: This is follow up for 8191278 that fixes crash of zero builds. Applies cleanly. ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/173 Commit messages: - Backport 302b8d06ce595b6071d728f6ab10dde561dcd54b Changes: https://git.openjdk.java.net/jdk11u-dev/pull/192/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=192&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8226878 Stats: 5 lines in 1 file changed: 3 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/192.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/192/head:pull/192 PR: https://git.openjdk.java.net/jdk11u-dev/pull/192 From snazarki at openjdk.java.net Wed Aug 4 13:21:32 2021 From: snazarki at openjdk.java.net (Sergey Nazarkin) Date: Wed, 4 Aug 2021 13:21:32 GMT Subject: [jdk11u-dev] RFR: 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 21:49:08 GMT, Christoph Langer wrote: > To do that, create the backport of e.g. JDK-8226871 on top of this branch and then open a PR to branch pr/173 of this repository. Thanks for information. I've added PRs with changes made independently from code introduced by this PR. Hovewer it is not clear how to add fix for this PR covered by 8229254. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/173 From snazarki at openjdk.java.net Wed Aug 4 13:24:28 2021 From: snazarki at openjdk.java.net (Sergey Nazarkin) Date: Wed, 4 Aug 2021 13:24:28 GMT Subject: [jdk11u-dev] RFR: 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 17:03:14 GMT, Evgeny Astigeevich wrote: > > Particularly arm32/aarch64 is not buildable without 8226871. I'll create necessary PR soon. > > BTW, 8226871 looks trivial. Maybe it is worth to push it first. Thanks. Added depended pull request. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/173 From snazarki at openjdk.java.net Wed Aug 4 13:29:35 2021 From: snazarki at openjdk.java.net (Sergey Nazarkin) Date: Wed, 4 Aug 2021 13:29:35 GMT Subject: [jdk11u-dev] RFR: 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 17:01:50 GMT, Evgeny Astigeevich wrote: > LGTM > > Confirm changes to files except stubGenerator_arm.cpp are identical to the original patch. Changes to stubGenerator_arm.cpp look good to me. Thanks for review. The review would be simpler if diff viewer can omit while space changes. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/173 From github.com+42899633+eastig at openjdk.java.net Wed Aug 4 13:55:32 2021 From: github.com+42899633+eastig at openjdk.java.net (Evgeny Astigeevich) Date: Wed, 4 Aug 2021 13:55:32 GMT Subject: [jdk11u-dev] RFR: 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 13:26:26 GMT, Sergey Nazarkin wrote: > Thanks for review. The review would be simpler if diff viewer can omit while space changes. It can. In 'File changed' tab you can click the gear and select 'Hide whitespace changes'. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/173 From clanger at openjdk.java.net Wed Aug 4 14:29:30 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 14:29:30 GMT Subject: [jdk11u-dev] RFR: 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 13:18:49 GMT, Sergey Nazarkin wrote: > > To do that, create the backport of e.g. JDK-8226871 on top of this branch and then open a PR to branch pr/173 of this repository. > > Thanks for information. I've added PRs with changes made independently from code introduced by this PR. Hovewer it is not clear how to add fix for this PR covered by 8229254. You should be able to do 8229254 as dependend PR to this PR. Just cherry pick the change on a branch based on snazarkin:8226878-backport (or pr/173) and then open the PR against pr/173. That should be exactly what dependend PRs are designed for. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/173 From shade at openjdk.java.net Wed Aug 4 15:08:30 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 4 Aug 2021 15:08:30 GMT Subject: [jdk11u-dev] RFR: 8257913: Add more known library locations to simplify Linux cross-compilation In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 22:48:27 GMT, Christoph Langer wrote: > This backport of JDK-8257913 is another prereq for GitHub Actions in 11u. I had to make it fit a little bit. The changes to .github/workflows/submit.yml were dropped obviously as the submit.yml that I'll propose will not need the removed parts then. This looks good, thanks. ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/185 From github.com+42899633+eastig at openjdk.java.net Wed Aug 4 15:15:44 2021 From: github.com+42899633+eastig at openjdk.java.net (Evgeny Astigeevich) Date: Wed, 4 Aug 2021 15:15:44 GMT Subject: [jdk11u-dev] RFR: 8268427: Improve AlgorithmConstraints:checkAlgorithm performance Message-ID: <-rDfm2V6c-1KxqjiriQKYIp2uhOwuGTYD0hir2SfHy4=.9643a93e-cdc3-49f2-b170-003765127773@github.com> A backport of JDK-8233228 to 11u increased the list of disabled algorithms. For TLS the size of the list increased from 9 to 56. `sun.security.util.AbstractAlgorithmConstraints.checkAlgorithm()` uses linear search to check if an algorithm has been disabled. Its execution time significantly increased in the most common case: a checked algorithm is not disabled. This backport improves `AbstractAlgorithmConstraints.checkAlgorithm()` performance. Tier1 and tier2 tests pass with the patch. The patch contains a microbenchmark. Baseline results before patch: Benchmark (algorithm) Mode Cnt Score Error Units AlgorithmConstraintsPermits.permits SSLv3 avgt 25 17.296 ? 0.282 ns/op AlgorithmConstraintsPermits.permits DES avgt 25 288.010 ? 2.502 ns/op AlgorithmConstraintsPermits.permits NULL avgt 25 459.496 ? 6.160 ns/op AlgorithmConstraintsPermits.permits TLS1.3 avgt 25 1361.700 ? 12.871 ns/op Benchmark results after patch: Benchmark (algorithm) Mode Cnt Score Error Units AlgorithmConstraintsPermits.permits SSLv3 avgt 25 119.320 ? 2.572 ns/op AlgorithmConstraintsPermits.permits DES avgt 25 82.259 ? 0.668 ns/op AlgorithmConstraintsPermits.permits NULL avgt 25 57.302 ? 3.611 ns/op AlgorithmConstraintsPermits.permits TLS1.3 avgt 25 465.914 ? 2.553 ns/op Before the patch the list of the disabled algorithms has `SSLv3` first, `DES` second, `NULL` 9th and `TLS1.3` not on the list. As `SSLv3` is the first, accesses to it are the fastest. As we get far from the head, the access time increases. `NULL` had been the last before JDK-8233228. In a case of TLS1.3 the whole list has to be checked. The patch replaces the list with an ordered set. Despite the increased time for `SSLv3` all other times, especially for permitted algorithms such as `TLS1.3`, significantly decreased. ------------- Commit messages: - Backport 3b83bc1bc331d268987f56ea4f23124a7f6ee38b Changes: https://git.openjdk.java.net/jdk11u-dev/pull/193/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=193&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268427 Stats: 112 lines in 4 files changed: 72 ins; 17 del; 23 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/193.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/193/head:pull/193 PR: https://git.openjdk.java.net/jdk11u-dev/pull/193 From zgu at openjdk.java.net Wed Aug 4 15:35:47 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 4 Aug 2021 15:35:47 GMT Subject: [jdk11u-dev] RFR: 8270893: IndexOutOfBoundsException while reading large TIFF file Message-ID: A clean backport and new test passed. ------------- Commit messages: - Backport efcdcc7fb792c77aef1da69b1fcc652b401115f7 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/194/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=194&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270893 Stats: 83 lines in 2 files changed: 76 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/194.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/194/head:pull/194 PR: https://git.openjdk.java.net/jdk11u-dev/pull/194 From mdoerr at openjdk.java.net Wed Aug 4 16:29:31 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 4 Aug 2021 16:29:31 GMT Subject: [jdk11u-dev] RFR: 8211055: Provide print to a file (PDF) feature even when printer was not connected In-Reply-To: <6ammajvEC-zOlNl6pi2pllKlHKW-HKJ4OQ3AcQBqiPY=.2579afd2-89db-443b-9023-038a9c07f8f0@github.com> References: <6ammajvEC-zOlNl6pi2pllKlHKW-HKJ4OQ3AcQBqiPY=.2579afd2-89db-443b-9023-038a9c07f8f0@github.com> Message-ID: On Mon, 2 Aug 2021 14:37:43 GMT, Martin Doerr wrote: > Backport of JDK-8211055. Doesn't apply cleanly because JNF removal is already backported to 11u. Thanks for the review! The manual test has passed. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/177 From mdoerr at openjdk.java.net Wed Aug 4 16:29:33 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 4 Aug 2021 16:29:33 GMT Subject: [jdk11u-dev] Integrated: 8211055: Provide print to a file (PDF) feature even when printer was not connected In-Reply-To: <6ammajvEC-zOlNl6pi2pllKlHKW-HKJ4OQ3AcQBqiPY=.2579afd2-89db-443b-9023-038a9c07f8f0@github.com> References: <6ammajvEC-zOlNl6pi2pllKlHKW-HKJ4OQ3AcQBqiPY=.2579afd2-89db-443b-9023-038a9c07f8f0@github.com> Message-ID: On Mon, 2 Aug 2021 14:37:43 GMT, Martin Doerr wrote: > Backport of JDK-8211055. Doesn't apply cleanly because JNF removal is already backported to 11u. This pull request has now been integrated. Changeset: d900e312 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/d900e312f52f4fcc90086da5d8c00f7c85b59013 Stats: 233 lines in 3 files changed: 231 ins; 1 del; 1 mod 8211055: Provide print to a file (PDF) feature even when printer was not connected Reviewed-by: clanger Backport-of: 9b0d241a16b2f2abb821c7a74408b826db75ec4a ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/177 From snazarki at openjdk.java.net Wed Aug 4 16:48:41 2021 From: snazarki at openjdk.java.net (Sergey Nazarkin) Date: Wed, 4 Aug 2021 16:48:41 GMT Subject: [jdk11u-dev] RFR: 8229254: solaris_x64 build fails after JDK-8191278 Message-ID: <-t09u8l1iopZZIc08gfP4abNtfFQ6lx3yER_SbzcmyI=.3237dfd9-f089-4a07-941d-2b5d8a17c99c@github.com> This is follow up for 8191278 that fixes solaris_x64 build. Applies cleanly ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/173 Commit messages: - Baclport 9e633ae0657897636a4ade580a7a2e9844252389 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/196/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=196&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8229254 Stats: 5 lines in 2 files changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/196.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/196/head:pull/196 PR: https://git.openjdk.java.net/jdk11u-dev/pull/196 From snazarki at openjdk.java.net Wed Aug 4 16:51:30 2021 From: snazarki at openjdk.java.net (Sergey Nazarkin) Date: Wed, 4 Aug 2021 16:51:30 GMT Subject: [jdk11u-dev] RFR: 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully In-Reply-To: References: Message-ID: On Thu, 29 Jul 2021 12:22:06 GMT, Sergey Nazarkin wrote: > Hi! > I'd like to backport this changes to fix crash happens on memory mapped file operations. The patch applies almost cleanly except stubGenerator_arm.cpp due to miss of JEP 340 (One AArch64 Port, Not Two), and some copyright year conflicts. > Need to note that a series of follow up is required to fix some platforms build. Particularly arm32/aarch64 is not buildable without 8226871. I'll create necessary PR soon. > Tested with tier1/tier2 and new InternalErrorTest. I've complete all 3 follow-ups to cover issue introduced by this PR ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/173 From sgehwolf at openjdk.java.net Wed Aug 4 17:11:29 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Wed, 4 Aug 2021 17:11:29 GMT Subject: [jdk11u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 09:19:38 GMT, Christoph Langer wrote: > This is the backport of the GitHub Actions workflow to JDK11 Updates > > It is close to the current state of the workflow in head openjdk/jdk, except for the following modifications: > > - No Windows Aarch64 > - No MacOs Aarch64 > - Used jtreg5.1-b01 vs. jtreg-6+1 (which means a slight modification for the steps that build it). This can/should probably be updated later > - Use Adopt OpenJDK 11.0.11 as boot JDK (I don't know whether Adoptium 11.0.12 is ready. I guess this can be changed later on as well) > - Computation of JDK_VERSION used in bundle names: It is different because 11u is an update release (e.g. we have to account for 11.0.13 vs. only 11) > - Added a step "Fix jtreg permissions" because configure on Linux/Mac would bail out otherwise. I don't know why this is not needed in head. Maybe configure was improved? > - Use gcc 9 vs. gcc 10 on Linux. I chose to take what we use in SAP's nightly tests for the moment. We could probably spend some effort later to update the code to be able to compile on gcc 10. > - No gtest support > - Make target for test runs is "run-test-prebuilt" vs. "test-prebuilt". There was some refactoring between 11 and 18. > - MacOS bundle names contain 'osx' (vs 'macos' in head) > > To make the pipeline work and results look greenish, I proposed 6 other backports to be done before merging this: #180, #181, #182, #185, #186 and #187. > > There are probably a few more testfixes needed to further reduce testing noise. My preference would be to use Temurin binaries. make/conf/test-dependencies line 34: > 32: > 33: LINUX_X64_BOOT_JDK_FILENAME=openjdk-11_linux-x64_bin.tar.gz > 34: LINUX_X64_BOOT_JDK_URL=https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.11%2B9/OpenJDK11U-jdk_x64_linux_hotspot_11.0.11_9.tar.gz Could we use Eclipse Temurin binaries now, please? Latest is: https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_linux_hotspot_11.0.12_7.tar.gz See: https://github.com/adoptium/temurin11-binaries/releases/tag/jdk-11.0.12%2B7 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/189 From zgu at openjdk.java.net Wed Aug 4 17:52:36 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 4 Aug 2021 17:52:36 GMT Subject: [jdk11u-dev] Integrated: 8270893: IndexOutOfBoundsException while reading large TIFF file In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 15:28:33 GMT, Zhengyu Gu wrote: > A clean backport and new test passed. This pull request has now been integrated. Changeset: d05effd4 Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk11u-dev/commit/d05effd4083e0eabec3194af367804fbbd24cc27 Stats: 83 lines in 2 files changed: 76 ins; 0 del; 7 mod 8270893: IndexOutOfBoundsException while reading large TIFF file Backport-of: efcdcc7fb792c77aef1da69b1fcc652b401115f7 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/194 From mdoerr at openjdk.java.net Wed Aug 4 18:21:41 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 4 Aug 2021 18:21:41 GMT Subject: [jdk11u-dev] RFR: 8212040: Compilation error due to wrong usage of NSPrintJobDispositionValue in mac10.12 Message-ID: Backport of JDK-8212040. Manual integration was needed due to JNF removal in the succeeding code. ------------- Commit messages: - Backport a7c90c54007eb73c602431b76060cde36dda3b34 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/195/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=195&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8212040 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/195.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/195/head:pull/195 PR: https://git.openjdk.java.net/jdk11u-dev/pull/195 From clanger at openjdk.java.net Wed Aug 4 18:30:37 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 18:30:37 GMT Subject: [jdk11u-dev] Integrated: 8220445: Support for side by side MSVC Toolset versions In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 05:07:21 GMT, Christoph Langer wrote: > This is a backport of JDK-8220445 Support for side by side MSVC Toolset versions. It is needed to support the GitHub Actions workflow for Windows because it is using the hereby introduced configure option --with-msvc-toolset-version. > > The backport did not apply cleanly because JDK-8215445: Enable building for Windows in WSL is missing. I adapted the change to make it fit. > > I moved the line > ` $ECHO "$WINPATH_BASH -c 'echo VCToolsRedistDir="'"$VCToolsRedistDir " >> set-vs-env.sh' \ > >> $EXTRACT_VC_ENV_BAT_FILE` > to the fitting place and dropped the hunk > ` $ECHO 'echo VCToolsRedistDir="%VCToolsRedistDir% " >> set-vs-env.sh' \ > >> $EXTRACT_VC_ENV_BAT_FILE` This pull request has now been integrated. Changeset: 87e300be Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/87e300be2660ba102a7002a8da7aa4fea0af3cc7 Stats: 24 lines in 1 file changed: 22 ins; 0 del; 2 mod 8220445: Support for side by side MSVC Toolset versions Reviewed-by: stuefe Backport-of: 9833d2a1cd5ff386ee233de9c89e23b204458320 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/180 From clanger at openjdk.java.net Wed Aug 4 18:36:06 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 18:36:06 GMT Subject: [jdk11u-dev] RFR: 8221988: add possibility to build with Visual Studio 2019 [v2] In-Reply-To: References: Message-ID: > This is another backport that is needed for GitHub Actions. The Runners will use a VS 2019 installation as base and use VS2017 as a minor version that is installed into the VS 2019 installation. > Patch applies cleanly after JDK-8220445 backport, except for copyright in toolchain_windows.m4. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/181/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/181/files/5210d9c0..5210d9c0 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=181&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=181&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/181.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/181/head:pull/181 PR: https://git.openjdk.java.net/jdk11u-dev/pull/181 From "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net Wed Aug 4 18:36:08 2021 From: "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net (openjdk-notifier [bot]) Date: Wed, 4 Aug 2021 18:36:08 GMT Subject: [jdk11u-dev] RFR: 8221988: add possibility to build with Visual Studio 2019 In-Reply-To: References: Message-ID: <6T_W7u15YxqdpcB1wP3Onrmg74V0fPrk4qZlEz-BZ8g=.d70ed3ad-f175-4b9a-bd55-3abb98cb9c00@github.com> On Tue, 3 Aug 2021 05:23:44 GMT, Christoph Langer wrote: > This is another backport that is needed for GitHub Actions. The Runners will use a VS 2019 installation as base and use VS2017 as a minor version that is installed into the VS 2019 installation. > Patch applies cleanly after JDK-8220445 backport, except for copyright in toolchain_windows.m4. The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8220445 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/181 From clanger at openjdk.java.net Wed Aug 4 20:48:53 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 20:48:53 GMT Subject: [jdk11u-dev] RFR: 8221988: add possibility to build with Visual Studio 2019 [v3] In-Reply-To: References: Message-ID: > This is another backport that is needed for GitHub Actions. The Runners will use a VS 2019 installation as base and use VS2017 as a minor version that is installed into the VS 2019 installation. > Patch applies cleanly after JDK-8220445 backport, except for copyright in toolchain_windows.m4. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into 8221988 - 8221988: add possibility to build with Visual Studio 2019 Reviewed-by: erikj, ysuenaga - 8220445: Support for side by side MSVC Toolset versions Co-authored-by: Ali Ince Reviewed-by: tbell ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/181/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/181/files/5210d9c0..d01c179d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=181&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=181&range=01-02 Stats: 940 lines in 23 files changed: 792 ins; 123 del; 25 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/181.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/181/head:pull/181 PR: https://git.openjdk.java.net/jdk11u-dev/pull/181 From clanger at openjdk.java.net Wed Aug 4 20:52:37 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 20:52:37 GMT Subject: [jdk17u] Integrated: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type In-Reply-To: References: Message-ID: On Mon, 2 Aug 2021 21:17:25 GMT, Christoph Langer wrote: > Hi all, > > this pull request contains a backport of JDK-8267625 from the openjdk/jdk repository. > > The commit being backported was authored by Nick Gasson on 7 Jul 2021 and was reviewed by Andrew Haley and Dean Long. > > Thanks! This pull request has now been integrated. Changeset: 9175a8d2 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk17u/commit/9175a8d217878e1d23506d3955e3623697f7e2e6 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type Reviewed-by: aph Backport-of: 3d090e7ee561252027c06021b337c69a39f724e1 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/8 From clanger at openjdk.java.net Wed Aug 4 21:28:33 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 21:28:33 GMT Subject: [jdk11u-dev] Integrated: 8221988: add possibility to build with Visual Studio 2019 In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 05:23:44 GMT, Christoph Langer wrote: > This is another backport that is needed for GitHub Actions. The Runners will use a VS 2019 installation as base and use VS2017 as a minor version that is installed into the VS 2019 installation. > Patch applies cleanly after JDK-8220445 backport, except for copyright in toolchain_windows.m4. This pull request has now been integrated. Changeset: f2240cc5 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/f2240cc5b1f6e82c3d36551f36cd22916c1772bd Stats: 229 lines in 4 files changed: 223 ins; 0 del; 6 mod 8221988: add possibility to build with Visual Studio 2019 Reviewed-by: mdoerr Backport-of: 2a00db0b2eb2f491c7b0b8500b855d8d933114cf ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/181 From clanger at openjdk.java.net Wed Aug 4 21:32:59 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 21:32:59 GMT Subject: [jdk11u-dev] RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v2] In-Reply-To: References: Message-ID: > This is a clean backport of JDK-8254270, another prerequisite to enable GitHub actions in 11u. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/182/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/182/files/155c5cc1..155c5cc1 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=182&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=182&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/182.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/182/head:pull/182 PR: https://git.openjdk.java.net/jdk11u-dev/pull/182 From "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net Wed Aug 4 21:33:00 2021 From: "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net (openjdk-notifier [bot]) Date: Wed, 4 Aug 2021 21:33:00 GMT Subject: [jdk11u-dev] RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 14:13:11 GMT, Christoph Langer wrote: > This is a clean backport of JDK-8254270, another prerequisite to enable GitHub actions in 11u. The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8221988 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/182 From clanger at openjdk.java.net Wed Aug 4 21:38:56 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 21:38:56 GMT Subject: [jdk11u-dev] RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v3] In-Reply-To: References: Message-ID: > This is a clean backport of JDK-8254270, another prerequisite to enable GitHub actions in 11u. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into 8254270 - 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c Reviewed-by: redestad, cjplummer, dholmes, stuefe - 8221988: add possibility to build with Visual Studio 2019 Reviewed-by: erikj, ysuenaga - 8220445: Support for side by side MSVC Toolset versions Co-authored-by: Ali Ince Reviewed-by: tbell ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/182/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/182/files/155c5cc1..08145fcb Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=182&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=182&range=01-02 Stats: 940 lines in 23 files changed: 792 ins; 123 del; 25 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/182.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/182/head:pull/182 PR: https://git.openjdk.java.net/jdk11u-dev/pull/182 From clanger at openjdk.java.net Wed Aug 4 21:51:15 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 21:51:15 GMT Subject: [jdk11u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v2] In-Reply-To: References: Message-ID: > This is the backport of the GitHub Actions workflow to JDK11 Updates > > It is close to the current state of the workflow in head openjdk/jdk, except for the following modifications: > > - No Windows Aarch64 > - No MacOs Aarch64 > - Used jtreg5.1-b01 vs. jtreg-6+1 (which means a slight modification for the steps that build it). This can/should probably be updated later > - Use Adopt OpenJDK 11.0.11 as boot JDK (I don't know whether Adoptium 11.0.12 is ready. I guess this can be changed later on as well) > - Computation of JDK_VERSION used in bundle names: It is different because 11u is an update release (e.g. we have to account for 11.0.13 vs. only 11) > - Added a step "Fix jtreg permissions" because configure on Linux/Mac would bail out otherwise. I don't know why this is not needed in head. Maybe configure was improved? > - Use gcc 9 vs. gcc 10 on Linux. I chose to take what we use in SAP's nightly tests for the moment. We could probably spend some effort later to update the code to be able to compile on gcc 10. > - No gtest support > - Make target for test runs is "run-test-prebuilt" vs. "test-prebuilt". There was some refactoring between 11 and 18. > - MacOS bundle names contain 'osx' (vs 'macos' in head) > > To make the pipeline work and results look greenish, I proposed 6 other backports to be done before merging this: #180, #181, #182, #185, #186 and #187. > > There are probably a few more testfixes needed to further reduce testing noise. Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: Use Temurin JDK 11.0.12 for Bootstrap ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/189/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/189/files/adc83614..73229c2d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=189&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=189&range=00-01 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/189.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/189/head:pull/189 PR: https://git.openjdk.java.net/jdk11u-dev/pull/189 From clanger at openjdk.java.net Wed Aug 4 21:51:18 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 21:51:18 GMT Subject: [jdk11u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v2] In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 17:06:49 GMT, Severin Gehwolf wrote: >> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: >> >> Use Temurin JDK 11.0.12 for Bootstrap > > make/conf/test-dependencies line 34: > >> 32: >> 33: LINUX_X64_BOOT_JDK_FILENAME=openjdk-11_linux-x64_bin.tar.gz >> 34: LINUX_X64_BOOT_JDK_URL=https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.11%2B9/OpenJDK11U-jdk_x64_linux_hotspot_11.0.11_9.tar.gz > > Could we use Eclipse Temurin binaries now, please? Latest is: > https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_linux_hotspot_11.0.12_7.tar.gz > > See: > https://github.com/adoptium/temurin11-binaries/releases/tag/jdk-11.0.12%2B7 OK, I updated this. Let's see how it goes: https://github.com/RealCLanger/jdk11u-dev/actions/runs/1099309576 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/189 From clanger at openjdk.java.net Wed Aug 4 22:16:40 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 22:16:40 GMT Subject: [jdk11u-dev] RFR: 8246387: switch to jtreg 5.1 [v2] In-Reply-To: <-MXDjlKUIvGUePd02JhbdFa0sshoyzwSNvrEmojkuzU=.84ea7eec-0387-4614-a108-f68043c0c208@github.com> References: <-MXDjlKUIvGUePd02JhbdFa0sshoyzwSNvrEmojkuzU=.84ea7eec-0387-4614-a108-f68043c0c208@github.com> Message-ID: <3PFJBO2HWM_Ib9qT_9LjwBqHRcNPkRtopfhSXAb52q0=.78635843-df83-491b-a942-2e029d8c6474@github.com> On Wed, 4 Aug 2021 08:06:04 GMT, Aleksey Shipilev wrote: >> This is a compound backport that brings the entire 11u to 5.1 b1. There are many dependencies thorough the repository history, so I opted to squash them together. It seems the 11.0.13-oracle backport exists only for this issue, which indicates Oracle maintainers did the same. >> >> The current list of included patches is: >> >> >> 8246387: switch to jtreg 5.1 >> 8238943: switch to jtreg 5.0 >> 8235866: bump jtreg requiredVersion to 4.2b16 >> 8219552: bump jtreg requiredVersion to b14 in test/jdk/sanity/client/ >> 8219417: bump jtreg requiredVersion to b14 >> 8236111: narrow allowSmartActionArgs disabling >> >> >> Tested on Linux x86_64 fastdebug with jtreg5.1-b1 and the following test suites: >> - tier1 >> - tier2 >> - tier3 >> - vmTestbase_nsk_jvmti >> - vmTestbase_vm_metaspace >> - vmTestbase_vm_defmeth >> - vmTestbase_vm_mlvm >> - vmTestbase_vm_compiler >> - vmTestbase_nsk_jvmti >> - vmTestbase_vm_metaspace >> - sanity/client > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Update CDSTestUtils copyright > - Merge branch 'master' into JDK-8246387 > - Backport e47b2bc8c338a0b137106074952cded1067fc50a Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/103 From clanger at openjdk.java.net Wed Aug 4 22:19:29 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 4 Aug 2021 22:19:29 GMT Subject: [jdk11u-dev] RFR: 8246387: switch to jtreg 5.1 [v2] In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 08:02:22 GMT, Aleksey Shipilev wrote: >> CDSTestUtils.java needs a copyright update to 2020. >> All the TEST.properties files have an extra newline at their ends. > >> CDSTestUtils.java needs a copyright update to 2020. > > Right, fixed. > >> All the TEST.properties files have an extra newline at their ends. > > I don't follow. TEST.properties are from https://hg.openjdk.java.net/jdk/jdk/rev/1922c31f1dcc verbatim: two lines each. @shipilev, I eyeballed the bugs you mentioned and then tried to mark them as solved in this PR. Obviously I'm not allowed to... can you do it? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/103 From stuefe at openjdk.java.net Thu Aug 5 04:08:30 2021 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Thu, 5 Aug 2021 04:08:30 GMT Subject: [jdk11u-dev] RFR: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c [v3] In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 21:38:56 GMT, Christoph Langer wrote: >> This is a clean backport of JDK-8254270, another prerequisite to enable GitHub actions in 11u. > > Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into 8254270 > - 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c > > Reviewed-by: redestad, cjplummer, dholmes, stuefe > - 8221988: add possibility to build with Visual Studio 2019 > > Reviewed-by: erikj, ysuenaga > - 8220445: Support for side by side MSVC Toolset versions > > Co-authored-by: Ali Ince > Reviewed-by: tbell LGTM ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/182 From shade at openjdk.java.net Thu Aug 5 06:40:30 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 5 Aug 2021 06:40:30 GMT Subject: [jdk11u-dev] RFR: 8246387: switch to jtreg 5.1 [v2] In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 08:02:22 GMT, Aleksey Shipilev wrote: >> CDSTestUtils.java needs a copyright update to 2020. >> All the TEST.properties files have an extra newline at their ends. > >> CDSTestUtils.java needs a copyright update to 2020. > > Right, fixed. > >> All the TEST.properties files have an extra newline at their ends. > > I don't follow. TEST.properties are from https://hg.openjdk.java.net/jdk/jdk/rev/1922c31f1dcc verbatim: two lines each. > @shipilev, I eyeballed the bugs you mentioned and then tried to mark them as solved in this PR. Obviously I'm not allowed to... can you do it? Done. This would create the backport bugs for all of these, right? I thought we are going with a squashed commit to match only this `11.0.13-oracle`. But either way, this would be good to report as proper history too. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/103 From clanger at openjdk.java.net Thu Aug 5 06:47:33 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 06:47:33 GMT Subject: [jdk11u-dev] RFR: 8246387: switch to jtreg 5.1 [v2] In-Reply-To: References: Message-ID: <0vkWMhuHRTKRhYiDEpacF6-QgsVyH6q4AOFGmJpYNCM=.193614cb-6b41-4fe8-a569-96e98128a38a@github.com> On Thu, 5 Aug 2021 06:38:20 GMT, Aleksey Shipilev wrote: > > @shipilev, I eyeballed the bugs you mentioned and then tried to mark them as solved in this PR. Obviously I'm not allowed to... can you do it? > > Done. This would create the backport bugs for all of these, right? I thought we are going with a squashed commit to match only this `11.0.13-oracle`. But either way, this would be good to report as proper history too. Yes, this creates backport bugs for all of them. Although it's a squashed commit, which is good here, I think it's helpful to keep the history. One could argue that e.g. https://bugs.openjdk.java.net/browse/JDK-8219417 isn't necessary since nothing of this change remains after the squash (maybe there are others with the same effect). Do you want me to run this through SAP's nightlies once? But if you're confident you can integrate it right away. I leave it to you... ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/103 From shade at openjdk.java.net Thu Aug 5 06:55:31 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 5 Aug 2021 06:55:31 GMT Subject: [jdk11u-dev] RFR: 8246387: switch to jtreg 5.1 [v2] In-Reply-To: <0vkWMhuHRTKRhYiDEpacF6-QgsVyH6q4AOFGmJpYNCM=.193614cb-6b41-4fe8-a569-96e98128a38a@github.com> References: <0vkWMhuHRTKRhYiDEpacF6-QgsVyH6q4AOFGmJpYNCM=.193614cb-6b41-4fe8-a569-96e98128a38a@github.com> Message-ID: <8rBn8Wj26q_kczz1P86tddlKLGFLdUxa_ylVCMMk5xw=.352288df-328e-4aa6-b7d7-de6d0eb509a4@github.com> On Thu, 5 Aug 2021 06:44:42 GMT, Christoph Langer wrote: > Do you want me to run this through SAP's nightlies once? But if you're confident you can integrate it right away. I leave it to you... I am in no rush to integrate, and have limited capacity to handle follow-up issues, so the more pre-integration testing, the merrier. Thanks! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/103 From shade at openjdk.java.net Thu Aug 5 07:35:36 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 5 Aug 2021 07:35:36 GMT Subject: [jdk11u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v2] In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 21:51:15 GMT, Christoph Langer wrote: >> This is the backport of the GitHub Actions workflow to JDK11 Updates >> >> It is close to the current state of the workflow in head openjdk/jdk, except for the following modifications: >> >> - No Windows Aarch64 >> - No MacOs Aarch64 >> - Used jtreg5.1-b01 vs. jtreg-6+1 (which means a slight modification for the steps that build it). This can/should probably be updated later >> - Use Adopt OpenJDK 11.0.11 as boot JDK (I don't know whether Adoptium 11.0.12 is ready. I guess this can be changed later on as well) >> - Computation of JDK_VERSION used in bundle names: It is different because 11u is an update release (e.g. we have to account for 11.0.13 vs. only 11) >> - Added a step "Fix jtreg permissions" because configure on Linux/Mac would bail out otherwise. I don't know why this is not needed in head. Maybe configure was improved? >> - Use gcc 9 vs. gcc 10 on Linux. I chose to take what we use in SAP's nightly tests for the moment. We could probably spend some effort later to update the code to be able to compile on gcc 10. >> - No gtest support >> - Make target for test runs is "run-test-prebuilt" vs. "test-prebuilt". There was some refactoring between 11 and 18. >> - MacOS bundle names contain 'osx' (vs 'macos' in head) >> >> To make the pipeline work and results look greenish, I proposed 6 other backports to be done before merging this: #180, #181, #182, #185, #186 and #187. >> >> There are probably a few more testfixes needed to further reduce testing noise. > > Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: > > Use Temurin JDK 11.0.12 for Bootstrap This looks fine to me. I think these fixes are included too, but not linked to this PR: 8255305: Add Linux x86_32 tier1 to submit workflow 8255352: Archive important test outputs in submit workflow ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/189 From clanger at openjdk.java.net Thu Aug 5 08:06:33 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 08:06:33 GMT Subject: [jdk11u-dev] RFR: 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 16:48:57 GMT, Sergey Nazarkin wrote: > I've complete all 3 follow-ups to cover issue introduced by this PR Thanks, @snazarkin. I'll run the PRs through SAP's regression testing and reach out to the fellow maintainers for some alignment on whether this backport is appropriate for 11u at this time. Judging by the lines of code that are changed by this - and most of these are at the very heart of hotspot - we have to be very careful with this one. Thanks for your understanding. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/173 From clanger at openjdk.java.net Thu Aug 5 08:15:34 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 08:15:34 GMT Subject: [jdk11u-dev] RFR: 8234510: Remove file seeking requirement for writing a heap dump [v2] In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 02:59:00 GMT, BuddyLiao wrote: >> Backport of the heap dump enhancement: Remove file seeking requirement for writing a heap dump >> >> Patch did not apply cleanly, I had to resolve/modify >> src/hotspot/share/services/heapDumper.cpp >> >> I have built it on linux x86_64 and run test-tier1 > > BuddyLiao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Merge master > - 8234510: Remove file seeking requirement for writing a heap dump No regressions spotted in the nightlies. Good to go from my end. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/134 From clanger at openjdk.java.net Thu Aug 5 08:19:30 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 08:19:30 GMT Subject: [jdk11u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v2] In-Reply-To: References: Message-ID: On Thu, 5 Aug 2021 07:31:00 GMT, Aleksey Shipilev wrote: > This looks fine to me. I think these fixes are included too, but not linked to this PR: > > 8255305: Add Linux x86_32 tier1 to submit workflow > 8255352: Archive important test outputs in submit workflow Thanks, I added those as well. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/189 From aph at redhat.com Thu Aug 5 08:46:32 2021 From: aph at redhat.com (Andrew Haley) Date: Thu, 5 Aug 2021 09:46:32 +0100 Subject: [jdk11u-dev] RFR: 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully In-Reply-To: References: Message-ID: On 7/29/21 1:28 PM, Sergey Nazarkin wrote: > I'd like to backport this changes to fix crash happens on memory mapped file operations. The patch applies almost cleanly except stubGenerator_arm.cpp due to miss of JEP 340 (One AArch64 Port, Not Two), and some copyright year conflicts. > Need to note that a series of follow up is required to fix some platforms build. Particularly arm32/aarch64 is not buildable without 8226871. I'll create necessary PR soon. > Tested with tier1/tier2 and new InternalErrorTest. Wow. This is a very invasive patch for a P3 enhancement (that mysteriously got upgraded to a P2 for backports.) We'd need to see evidence of significant hardship to users in order to justify approval. As far as I know, this only has any effect if someone modifies a file in some way while a mapping is open. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From mdoerr at openjdk.java.net Thu Aug 5 08:58:28 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 5 Aug 2021 08:58:28 GMT Subject: [jdk11u-dev] RFR: 8263432: javac may report an invalid package/class clash on case insensitive filesystems In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 19:04:55 GMT, Martin Doerr wrote: > Backport of JDK-8263432. Fix applies cleanly except Copyright year update. The test required manual integration and adaptation of imports. Thanks for the review! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/184 From mdoerr at openjdk.java.net Thu Aug 5 08:58:29 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 5 Aug 2021 08:58:29 GMT Subject: [jdk11u-dev] Integrated: 8263432: javac may report an invalid package/class clash on case insensitive filesystems In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 19:04:55 GMT, Martin Doerr wrote: > Backport of JDK-8263432. Fix applies cleanly except Copyright year update. The test required manual integration and adaptation of imports. This pull request has now been integrated. Changeset: b878e3f8 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/b878e3f8d15f4c8f9a48cf89989349ad8b741d79 Stats: 107 lines in 2 files changed: 102 ins; 0 del; 5 mod 8263432: javac may report an invalid package/class clash on case insensitive filesystems Reviewed-by: clanger Backport-of: 0a4c33826d0422af7c4cfa5f479fe0b6b0f83d23 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/184 From sgehwolf at openjdk.java.net Thu Aug 5 09:14:35 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Thu, 5 Aug 2021 09:14:35 GMT Subject: [jdk11u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v2] In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 21:51:15 GMT, Christoph Langer wrote: >> This is the backport of the GitHub Actions workflow to JDK11 Updates >> >> It is close to the current state of the workflow in head openjdk/jdk, except for the following modifications: >> >> - No Windows Aarch64 >> - No MacOs Aarch64 >> - Used jtreg5.1-b01 vs. jtreg-6+1 (which means a slight modification for the steps that build it). This can/should probably be updated later >> - Use Adopt OpenJDK 11.0.11 as boot JDK (I don't know whether Adoptium 11.0.12 is ready. I guess this can be changed later on as well) >> - Computation of JDK_VERSION used in bundle names: It is different because 11u is an update release (e.g. we have to account for 11.0.13 vs. only 11) >> - Added a step "Fix jtreg permissions" because configure on Linux/Mac would bail out otherwise. I don't know why this is not needed in head. Maybe configure was improved? >> - Use gcc 9 vs. gcc 10 on Linux. I chose to take what we use in SAP's nightly tests for the moment. We could probably spend some effort later to update the code to be able to compile on gcc 10. >> - No gtest support >> - Make target for test runs is "run-test-prebuilt" vs. "test-prebuilt". There was some refactoring between 11 and 18. >> - MacOS bundle names contain 'osx' (vs 'macos' in head) >> >> To make the pipeline work and results look greenish, I proposed 6 other backports to be done before merging this: #180, #181, #182, #185, #186 and #187. >> >> There are probably a few more testfixes needed to further reduce testing noise. > > Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: > > Use Temurin JDK 11.0.12 for Bootstrap I cannot comment on the workflow part (know too little about them), but the test-deps look good. Thumbs up! ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/189 From github.com+3094961+buddyliao at openjdk.java.net Thu Aug 5 10:03:54 2021 From: github.com+3094961+buddyliao at openjdk.java.net (BuddyLiao) Date: Thu, 5 Aug 2021 10:03:54 GMT Subject: [jdk11u-dev] RFR: 8234510: Remove file seeking requirement for writing a heap dump [v3] In-Reply-To: References: Message-ID: <6qKslh1zolgk5Df-FieWuhatSyjWXzxCFGbDkFno0Zs=.21ad520b-5738-4c51-a46b-894a04191fa9@github.com> > Backport of the heap dump enhancement: Remove file seeking requirement for writing a heap dump > > Patch did not apply cleanly, I had to resolve/modify > src/hotspot/share/services/heapDumper.cpp > > I have built it on linux x86_64 and run test-tier1 BuddyLiao has updated the pull request incrementally with one additional commit since the last revision: Update full name ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/134/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/134/files/6098c619..650e623b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=134&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=134&range=01-02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/134.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/134/head:pull/134 PR: https://git.openjdk.java.net/jdk11u-dev/pull/134 From abakhtin at openjdk.java.net Thu Aug 5 10:04:47 2021 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Thu, 5 Aug 2021 10:04:47 GMT Subject: [jdk13u-dev] RFR: 8241888: Mirror jdk.security.allowNonCaAnchor system property with a security one Message-ID: The original patch applies almost clean: trivial fix in java.security because of jdk.jndi.object.factoriesFilter property already backported into 13u Tests in jdk/sun/security/validator passed. ------------- Commit messages: - Backport 1c651455a75ff21770bb3b112a440396fce402a5 Changes: https://git.openjdk.java.net/jdk13u-dev/pull/249/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=249&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8241888 Stats: 21 lines in 2 files changed: 14 ins; 1 del; 6 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/249.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/249/head:pull/249 PR: https://git.openjdk.java.net/jdk13u-dev/pull/249 From mdoerr at openjdk.java.net Thu Aug 5 10:46:32 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 5 Aug 2021 10:46:32 GMT Subject: [jdk11u-dev] Integrated: 8212040: Compilation error due to wrong usage of NSPrintJobDispositionValue in mac10.12 In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 16:33:13 GMT, Martin Doerr wrote: > Backport of JDK-8212040. Manual integration was needed due to JNF removal in the succeeding code. This pull request has now been integrated. Changeset: 1223b583 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/1223b5830f4a3e58243af79b888575c12a004462 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8212040: Compilation error due to wrong usage of NSPrintJobDispositionValue in mac10.12 Backport-of: a7c90c54007eb73c602431b76060cde36dda3b34 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/195 From abakhtin at openjdk.java.net Thu Aug 5 11:00:50 2021 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Thu, 5 Aug 2021 11:00:50 GMT Subject: [jdk15u-dev] RFR: 8254631: Better support ALPN byte wire values in SunJSSE Message-ID: <8LMo2gaCIycAlsW3ytf-ZeGicQwMnG-QOx-i6oS57Qg=.28b3d29c-7fec-4879-bd00-e3594a785fda@github.com> Applies cleanly, but the javadoc parts are removed as documented in CSR JDK-8271938 sun/security/ssl/ALPN test passed ------------- Commit messages: - Backport fe5cccc1ec76a5c29b1f55af311823f84483395b Changes: https://git.openjdk.java.net/jdk15u-dev/pull/89/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=89&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8254631 Stats: 345 lines in 3 files changed: 336 ins; 1 del; 8 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/89.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/89/head:pull/89 PR: https://git.openjdk.java.net/jdk15u-dev/pull/89 From clanger at openjdk.java.net Thu Aug 5 11:18:33 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 11:18:33 GMT Subject: [jdk11u-dev] RFR: 8234510: Remove file seeking requirement for writing a heap dump [v3] In-Reply-To: <6qKslh1zolgk5Df-FieWuhatSyjWXzxCFGbDkFno0Zs=.21ad520b-5738-4c51-a46b-894a04191fa9@github.com> References: <6qKslh1zolgk5Df-FieWuhatSyjWXzxCFGbDkFno0Zs=.21ad520b-5738-4c51-a46b-894a04191fa9@github.com> Message-ID: On Thu, 5 Aug 2021 10:03:54 GMT, BuddyLiao wrote: >> Backport of the heap dump enhancement: Remove file seeking requirement for writing a heap dump >> >> Patch did not apply cleanly, I had to resolve/modify >> src/hotspot/share/services/heapDumper.cpp >> >> I have built it on linux x86_64 and run test-tier1 > > BuddyLiao has updated the pull request incrementally with one additional commit since the last revision: > > Update full name > /integrate @buddyliao, you need to Request maintainer approval via jdk11u-fix-request label and Fix request comment in the JBS item [JDK-8234510](https://bugs.openjdk.java.net/browse/JDK-8234510), that part of the protocol hasn't changed with the migration to GitHub. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/134 From clanger at openjdk.java.net Thu Aug 5 11:24:28 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 11:24:28 GMT Subject: [jdk11u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v2] In-Reply-To: References: Message-ID: <8tVyZilDe2EwgJNW-NU3rYxxb7qg_ZWLF9SSk28f3cs=.4f46c623-8e4f-4997-aebf-26954a86eff7@github.com> On Thu, 5 Aug 2021 09:11:12 GMT, Severin Gehwolf wrote: > I cannot comment on the workflow part (know too little about them), but the test-deps look good. Thumbs up! Thank you. I've flagged the bug for approval now. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/189 From mdoerr at openjdk.java.net Thu Aug 5 13:23:47 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 5 Aug 2021 13:23:47 GMT Subject: [jdk11u-dev] RFR: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead Message-ID: Backport of JDK-7179006. CPrinterJob.m parts don't apply cleanly because JNF removal is already backported. Tests have passed on M1 with Rosetta (x86_64 build). ------------- Commit messages: - Backport ea7c47c1bb51d079aff44b88f94b3fe5c76fbce5 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/197/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=197&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-7179006 Stats: 237 lines in 4 files changed: 169 ins; 49 del; 19 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/197.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/197/head:pull/197 PR: https://git.openjdk.java.net/jdk11u-dev/pull/197 From mdoerr at openjdk.java.net Thu Aug 5 14:08:40 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 5 Aug 2021 14:08:40 GMT Subject: [jdk11u-dev] RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible Message-ID: Backport of JDK-8251377. Doesn't apply cleanly because Mac OS version check from JDK-8230869 is not in 11u. I just included the introduction of `isCatalinaOrAbove` and `isBigSurOrAbove` from the latter. Rest applies cleanly. ------------- Commit messages: - Backport 3f67afd3a8c642f33ca58a9881dff4c81f83e821 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/198/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=198&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8251377 Stats: 20 lines in 5 files changed: 18 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/198.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/198/head:pull/198 PR: https://git.openjdk.java.net/jdk11u-dev/pull/198 From sgehwolf at openjdk.java.net Thu Aug 5 14:55:32 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Thu, 5 Aug 2021 14:55:32 GMT Subject: [jdk11u-dev] Integrated: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 16:04:31 GMT, Severin Gehwolf wrote: > Please review this backport of JDK-8269851 to OpenJDK 11u. That code stream is affected by the same bug and should get fixed in the same way as it got fixed with [JDK-8265836](https://bugs.openjdk.java.net/browse/JDK-8265836) for system CPU load, but for process CPU load. > > The patch only differs minimally from the JDK 18 patch, but doesn't apply clean due to the following reason. This version uses `getSystemCpuLoad()` and `getSystemCpuLoad0()` instead of `getCpuLoad()` and `getCpuLoad0()`. > > Testing: Manually using the reproducer code from the bug and tier1 on Linux x86_64. > > Thoughts? This pull request has now been integrated. Changeset: 52a32a76 Author: Severin Gehwolf URL: https://git.openjdk.java.net/jdk11u-dev/commit/52a32a764f2bbe7bdf962e518ec1ae6f250e072c Stats: 214 lines in 1 file changed: 137 ins; 74 del; 3 mod 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers Reviewed-by: clanger Backport-of: 25f00d787cf56f6cdca6949115d04e7d8e675554 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/183 From sgehwolf at openjdk.java.net Thu Aug 5 14:57:46 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Thu, 5 Aug 2021 14:57:46 GMT Subject: [jdk17u] Integrated: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 09:53:07 GMT, Severin Gehwolf wrote: > Hi all, > > This issue is present in JDK 17u as well and should get fixed (like the similar [JDK-8265836](https://bugs.openjdk.java.net/browse/JDK-8265836) which made it into JDK 17 GA.) Patch applies clean. > > The commit being backported was authored by bobpengxie on 28 Jul 2021 and was reviewed by Severin Gehwolf. > > Thanks! This pull request has now been integrated. Changeset: 02ea80a6 Author: Severin Gehwolf URL: https://git.openjdk.java.net/jdk17u/commit/02ea80a6f051db4002f9af29cf18707688b5247c Stats: 218 lines in 1 file changed: 137 ins; 78 del; 3 mod 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers Backport-of: 25f00d787cf56f6cdca6949115d04e7d8e675554 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/9 From clanger at openjdk.java.net Thu Aug 5 16:16:33 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 16:16:33 GMT Subject: [jdk11u-dev] Integrated: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 14:13:11 GMT, Christoph Langer wrote: > This is a clean backport of JDK-8254270, another prerequisite to enable GitHub actions in 11u. This pull request has now been integrated. Changeset: 1c77fa87 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/1c77fa87ec3ae033ff815bb71afd21d80141e93a Stats: 7 lines in 1 file changed: 3 ins; 0 del; 4 mod 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c Reviewed-by: stuefe Backport-of: 0b7fba75c139bc263cc77c1d29f31703dd88b6f4 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/182 From clanger at openjdk.java.net Thu Aug 5 16:20:30 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 16:20:30 GMT Subject: [jdk11u-dev] Integrated: 8238930: problem list compiler/c2/Test8004741.java In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 12:20:38 GMT, Christoph Langer wrote: > Please review the backport of this test exclusion (JDK-8238930). I see the test compiler/c2/Test8004741.java regularly failing in the GitHub Actions pipeline and the actual issue JDK-8235801 doesn't seem to be fixed yet. This pull request has now been integrated. Changeset: 5464d62f Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/5464d62f60eac8c6078ac76105cd790f0fb8467e Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8238930: problem list compiler/c2/Test8004741.java Backport-of: 93241e5db71cf6db00db4cc513f127fe5b1885e0 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/190 From clanger at openjdk.java.net Thu Aug 5 16:21:55 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 16:21:55 GMT Subject: [jdk11u-dev] RFR: 8257913: Add more known library locations to simplify Linux cross-compilation [v2] In-Reply-To: References: Message-ID: <87MSxgRqlupvhh9lJDE01WE7rUS2siL6f5EMAAn7H8Y=.13ebd547-3c84-40cc-a996-a498231b495e@github.com> > This backport of JDK-8257913 is another prereq for GitHub Actions in 11u. I had to make it fit a little bit. The changes to .github/workflows/submit.yml were dropped obviously as the submit.yml that I'll propose will not need the removed parts then. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/185/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/185/files/6afee834..6afee834 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=185&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=185&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/185.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/185/head:pull/185 PR: https://git.openjdk.java.net/jdk11u-dev/pull/185 From "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net Thu Aug 5 16:21:56 2021 From: "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net (openjdk-notifier [bot]) Date: Thu, 5 Aug 2021 16:21:56 GMT Subject: [jdk11u-dev] RFR: 8257913: Add more known library locations to simplify Linux cross-compilation In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 22:48:27 GMT, Christoph Langer wrote: > This backport of JDK-8257913 is another prereq for GitHub Actions in 11u. I had to make it fit a little bit. The changes to .github/workflows/submit.yml were dropped obviously as the submit.yml that I'll propose will not need the removed parts then. The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8254270 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/185 From clanger at openjdk.java.net Thu Aug 5 16:29:55 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 16:29:55 GMT Subject: [jdk11u-dev] Integrated: 8257913: Add more known library locations to simplify Linux cross-compilation In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 22:48:27 GMT, Christoph Langer wrote: > This backport of JDK-8257913 is another prereq for GitHub Actions in 11u. I had to make it fit a little bit. The changes to .github/workflows/submit.yml were dropped obviously as the submit.yml that I'll propose will not need the removed parts then. This pull request has now been integrated. Changeset: 9d521b11 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/9d521b118f8ceb062f7b5d49f4cbf119d907c409 Stats: 51 lines in 3 files changed: 51 ins; 0 del; 0 mod 8257913: Add more known library locations to simplify Linux cross-compilation Reviewed-by: shade Backport-of: 61cff4da90706e27de27ee9ee09e5b277be6bcad ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/185 From clanger at openjdk.java.net Thu Aug 5 16:29:55 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 16:29:55 GMT Subject: [jdk11u-dev] RFR: 8257913: Add more known library locations to simplify Linux cross-compilation [v3] In-Reply-To: References: Message-ID: > This backport of JDK-8257913 is another prereq for GitHub Actions in 11u. I had to make it fit a little bit. The changes to .github/workflows/submit.yml were dropped obviously as the submit.yml that I'll propose will not need the removed parts then. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'master' into 8257913 - 8257913: Add more known library locations to simplify Linux cross-compilation Reviewed-by: erikj - 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c Reviewed-by: redestad, cjplummer, dholmes, stuefe - 8221988: add possibility to build with Visual Studio 2019 Reviewed-by: erikj, ysuenaga - 8220445: Support for side by side MSVC Toolset versions Co-authored-by: Ali Ince Reviewed-by: tbell ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/185/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/185/files/6afee834..d7eb6232 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=185&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=185&range=01-02 Stats: 1262 lines in 27 files changed: 1032 ins; 197 del; 33 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/185.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/185/head:pull/185 PR: https://git.openjdk.java.net/jdk11u-dev/pull/185 From clanger at openjdk.java.net Thu Aug 5 16:32:56 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 16:32:56 GMT Subject: [jdk11u-dev] RFR: 8209380: ARM: cleanup maybe-uninitialized and reorder compiler warnings [v2] In-Reply-To: <-cABFq2nXdrwlRAXSv7OfkpBkUNrBKbp_0hlLztH390=.cff946d8-f293-4127-8db3-979cfcef2e33@github.com> References: <-cABFq2nXdrwlRAXSv7OfkpBkUNrBKbp_0hlLztH390=.cff946d8-f293-4127-8db3-979cfcef2e33@github.com> Message-ID: <8QQZsq-Q-nfFvGRX1Q6ISF2HmfhpGIWs5XzU422p4dU=.9454971d-c807-4d67-bd6c-2958751944f2@github.com> > Please review the backport of JDK-8209380. It is another prereq to get the upcoming GitHub Actions workflow green. The patch applies cleanly and follow up JDK-8209193 is already in 11u. > If it weren't integrated, the GHA crossbuild of hotspot for arm would fail. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge branch 'master' into 8209380 - 8209380: ARM: cleanup maybe-uninitialized and reorder compiler warnings Reviewed-by: dholmes, drwhite, tschatzl - 8257913: Add more known library locations to simplify Linux cross-compilation Reviewed-by: erikj - 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c Reviewed-by: redestad, cjplummer, dholmes, stuefe - 8221988: add possibility to build with Visual Studio 2019 Reviewed-by: erikj, ysuenaga - 8220445: Support for side by side MSVC Toolset versions Co-authored-by: Ali Ince Reviewed-by: tbell ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/186/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/186/files/a62c240e..46d2c8b3 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=186&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=186&range=00-01 Stats: 1262 lines in 27 files changed: 1032 ins; 197 del; 33 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/186.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/186/head:pull/186 PR: https://git.openjdk.java.net/jdk11u-dev/pull/186 From "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net Thu Aug 5 16:32:57 2021 From: "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net (openjdk-notifier [bot]) Date: Thu, 5 Aug 2021 16:32:57 GMT Subject: [jdk11u-dev] RFR: 8209380: ARM: cleanup maybe-uninitialized and reorder compiler warnings In-Reply-To: <-cABFq2nXdrwlRAXSv7OfkpBkUNrBKbp_0hlLztH390=.cff946d8-f293-4127-8db3-979cfcef2e33@github.com> References: <-cABFq2nXdrwlRAXSv7OfkpBkUNrBKbp_0hlLztH390=.cff946d8-f293-4127-8db3-979cfcef2e33@github.com> Message-ID: <_N8GTUkyG5WZeDiivCKJQH9ln6Gv1VRgNTgaO4rzFHM=.b7a90d5a-3828-4f2e-8de2-81c1dc1f3c9e@github.com> On Wed, 4 Aug 2021 07:45:22 GMT, Christoph Langer wrote: > Please review the backport of JDK-8209380. It is another prereq to get the upcoming GitHub Actions workflow green. The patch applies cleanly and follow up JDK-8209193 is already in 11u. > If it weren't integrated, the GHA crossbuild of hotspot for arm would fail. The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8257913 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/186 From clanger at openjdk.java.net Thu Aug 5 16:32:57 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 16:32:57 GMT Subject: [jdk11u-dev] Integrated: 8209380: ARM: cleanup maybe-uninitialized and reorder compiler warnings In-Reply-To: <-cABFq2nXdrwlRAXSv7OfkpBkUNrBKbp_0hlLztH390=.cff946d8-f293-4127-8db3-979cfcef2e33@github.com> References: <-cABFq2nXdrwlRAXSv7OfkpBkUNrBKbp_0hlLztH390=.cff946d8-f293-4127-8db3-979cfcef2e33@github.com> Message-ID: On Wed, 4 Aug 2021 07:45:22 GMT, Christoph Langer wrote: > Please review the backport of JDK-8209380. It is another prereq to get the upcoming GitHub Actions workflow green. The patch applies cleanly and follow up JDK-8209193 is already in 11u. > If it weren't integrated, the GHA crossbuild of hotspot for arm would fail. This pull request has now been integrated. Changeset: 90d30cca Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/90d30cca978ef953540b9e9a766f9a942b0ce860 Stats: 9 lines in 4 files changed: 5 ins; 0 del; 4 mod 8209380: ARM: cleanup maybe-uninitialized and reorder compiler warnings Backport-of: 1712e272cde40f0848ecad1532e2528ab517ca6f ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/186 From clanger at openjdk.java.net Thu Aug 5 16:45:54 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 16:45:54 GMT Subject: [jdk11u-dev] RFR: 8249095: tools/javac/launcher/SourceLauncherTest.java fails on Windows [v2] In-Reply-To: References: Message-ID: > This is a clean backport of JDK-8249095, required to enable green runs of a GitHub Actions workflow. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Merge branch 'master' into 8249095 - 8249095: tools/javac/launcher/SourceLauncherTest.java fails on Windows Reviewed-by: jjg - 8209380: ARM: cleanup maybe-uninitialized and reorder compiler warnings Reviewed-by: dholmes, drwhite, tschatzl - 8257913: Add more known library locations to simplify Linux cross-compilation Reviewed-by: erikj - 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c Reviewed-by: redestad, cjplummer, dholmes, stuefe - 8221988: add possibility to build with Visual Studio 2019 Reviewed-by: erikj, ysuenaga - 8220445: Support for side by side MSVC Toolset versions Co-authored-by: Ali Ince Reviewed-by: tbell ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/187/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/187/files/6aa29f89..6c8a2c88 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=187&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=187&range=00-01 Stats: 1262 lines in 27 files changed: 1032 ins; 197 del; 33 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/187.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/187/head:pull/187 PR: https://git.openjdk.java.net/jdk11u-dev/pull/187 From "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net Thu Aug 5 16:45:54 2021 From: "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net (openjdk-notifier [bot]) Date: Thu, 5 Aug 2021 16:45:54 GMT Subject: [jdk11u-dev] RFR: 8249095: tools/javac/launcher/SourceLauncherTest.java fails on Windows In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 09:10:55 GMT, Christoph Langer wrote: > This is a clean backport of JDK-8249095, required to enable green runs of a GitHub Actions workflow. The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8209380 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/187 From clanger at openjdk.java.net Thu Aug 5 16:45:54 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 16:45:54 GMT Subject: [jdk11u-dev] Integrated: 8249095: tools/javac/launcher/SourceLauncherTest.java fails on Windows In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 09:10:55 GMT, Christoph Langer wrote: > This is a clean backport of JDK-8249095, required to enable green runs of a GitHub Actions workflow. This pull request has now been integrated. Changeset: d780f938 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/d780f938e233252a9c1af8a9804f337b232b59a6 Stats: 29 lines in 2 files changed: 21 ins; 0 del; 8 mod 8249095: tools/javac/launcher/SourceLauncherTest.java fails on Windows Backport-of: cd4faff0ec935c768662a30232005c3313598231 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/187 From clanger at openjdk.java.net Thu Aug 5 16:51:04 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 16:51:04 GMT Subject: [jdk11u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v3] In-Reply-To: References: Message-ID: > This is the backport of the GitHub Actions workflow to JDK11 Updates > > It is close to the current state of the workflow in head openjdk/jdk, except for the following modifications: > > - No Windows Aarch64 > - No MacOs Aarch64 > - Used jtreg5.1-b01 vs. jtreg-6+1 (which means a slight modification for the steps that build it). This can/should probably be updated later > - Use Adopt OpenJDK 11.0.11 as boot JDK (I don't know whether Adoptium 11.0.12 is ready. I guess this can be changed later on as well) > - Computation of JDK_VERSION used in bundle names: It is different because 11u is an update release (e.g. we have to account for 11.0.13 vs. only 11) > - Added a step "Fix jtreg permissions" because configure on Linux/Mac would bail out otherwise. I don't know why this is not needed in head. Maybe configure was improved? > - Use gcc 9 vs. gcc 10 on Linux. I chose to take what we use in SAP's nightly tests for the moment. We could probably spend some effort later to update the code to be able to compile on gcc 10. > - No gtest support > - Make target for test runs is "run-test-prebuilt" vs. "test-prebuilt". There was some refactoring between 11 and 18. > - MacOS bundle names contain 'osx' (vs 'macos' in head) > > To make the pipeline work and results look greenish, I proposed 6 other backports to be done before merging this: #180, #181, #182, #185, #186 and #187. > > There are probably a few more testfixes needed to further reduce testing noise. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision: - Merge branch 'master' into gha - Use Temurin JDK 11.0.12 for Bootstrap - GitHub Actions for JDK11 Updates - 8249095: tools/javac/launcher/SourceLauncherTest.java fails on Windows Reviewed-by: jjg - 8209380: ARM: cleanup maybe-uninitialized and reorder compiler warnings Reviewed-by: dholmes, drwhite, tschatzl - 8257913: Add more known library locations to simplify Linux cross-compilation Reviewed-by: erikj - 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c Reviewed-by: redestad, cjplummer, dholmes, stuefe - 8221988: add possibility to build with Visual Studio 2019 Reviewed-by: erikj, ysuenaga - 8220445: Support for side by side MSVC Toolset versions Co-authored-by: Ali Ince Reviewed-by: tbell ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/189/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/189/files/73229c2d..440e04a5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=189&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=189&range=01-02 Stats: 1262 lines in 27 files changed: 1032 ins; 197 del; 33 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/189.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/189/head:pull/189 PR: https://git.openjdk.java.net/jdk11u-dev/pull/189 From "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net Thu Aug 5 16:51:07 2021 From: "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net (openjdk-notifier [bot]) Date: Thu, 5 Aug 2021 16:51:07 GMT Subject: [jdk11u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v2] In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 21:51:15 GMT, Christoph Langer wrote: >> This is the backport of the GitHub Actions workflow to JDK11 Updates >> >> It is close to the current state of the workflow in head openjdk/jdk, except for the following modifications: >> >> - No Windows Aarch64 >> - No MacOs Aarch64 >> - Used jtreg5.1-b01 vs. jtreg-6+1 (which means a slight modification for the steps that build it). This can/should probably be updated later >> - Use Adopt OpenJDK 11.0.11 as boot JDK (I don't know whether Adoptium 11.0.12 is ready. I guess this can be changed later on as well) >> - Computation of JDK_VERSION used in bundle names: It is different because 11u is an update release (e.g. we have to account for 11.0.13 vs. only 11) >> - Added a step "Fix jtreg permissions" because configure on Linux/Mac would bail out otherwise. I don't know why this is not needed in head. Maybe configure was improved? >> - Use gcc 9 vs. gcc 10 on Linux. I chose to take what we use in SAP's nightly tests for the moment. We could probably spend some effort later to update the code to be able to compile on gcc 10. >> - No gtest support >> - Make target for test runs is "run-test-prebuilt" vs. "test-prebuilt". There was some refactoring between 11 and 18. >> - MacOS bundle names contain 'osx' (vs 'macos' in head) >> >> To make the pipeline work and results look greenish, I proposed 6 other backports to be done before merging this: #180, #181, #182, #185, #186 and #187. >> >> There are probably a few more testfixes needed to further reduce testing noise. > > Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: > > Use Temurin JDK 11.0.12 for Bootstrap The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8249095 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/189 From clanger at openjdk.java.net Thu Aug 5 16:51:11 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 16:51:11 GMT Subject: [jdk11u-dev] Integrated: 8253424: Add support for running pre-submit testing using GitHub Actions In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 09:19:38 GMT, Christoph Langer wrote: > This is the backport of the GitHub Actions workflow to JDK11 Updates > > It is close to the current state of the workflow in head openjdk/jdk, except for the following modifications: > > - No Windows Aarch64 > - No MacOs Aarch64 > - Used jtreg5.1-b01 vs. jtreg-6+1 (which means a slight modification for the steps that build it). This can/should probably be updated later > - Use Adopt OpenJDK 11.0.11 as boot JDK (I don't know whether Adoptium 11.0.12 is ready. I guess this can be changed later on as well) > - Computation of JDK_VERSION used in bundle names: It is different because 11u is an update release (e.g. we have to account for 11.0.13 vs. only 11) > - Added a step "Fix jtreg permissions" because configure on Linux/Mac would bail out otherwise. I don't know why this is not needed in head. Maybe configure was improved? > - Use gcc 9 vs. gcc 10 on Linux. I chose to take what we use in SAP's nightly tests for the moment. We could probably spend some effort later to update the code to be able to compile on gcc 10. > - No gtest support > - Make target for test runs is "run-test-prebuilt" vs. "test-prebuilt". There was some refactoring between 11 and 18. > - MacOS bundle names contain 'osx' (vs 'macos' in head) > > To make the pipeline work and results look greenish, I proposed 6 other backports to be done before merging this: #180, #181, #182, #185, #186 and #187. > > There are probably a few more testfixes needed to further reduce testing noise. This pull request has now been integrated. Changeset: 1faefed2 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/1faefed218051c324bdb5c7c10369050d6c9dd44 Stats: 1546 lines in 2 files changed: 1546 ins; 0 del; 0 mod 8253424: Add support for running pre-submit testing using GitHub Actions 8253865: Pre-submit testing using GitHub Actions does not detect failures reliably 8254054: Pre-submit testing using GitHub Actions should not use the deprecated set-env command 8254173: Add Zero, Minimal hotspot targets to submit workflow 8254175: Build no-pch configuration in debug mode for submit checks 8254282: Add Linux x86_32 builds to submit workflow 8255373: Submit workflow artifact name is always "test-results_.zip" 8255895: Submit workflow artifacts miss hs_errs/replays due to ZIP include mismatch 8256127: Add cross-compiled foreign architectures builds to submit workflow 8256277: Github Action build on macOS should define OS and Xcode versions 8256354: Github Action build on Windows should define OS and MSVC versions 8256414: add optimized build to submit workflow 8256393: Github Actions build on Linux should define OS and GCC versions 8256747: GitHub Actions: decouple the hotspot build-only jobs from Linux x64 testing 8257056: Submit workflow should apt-get update to avoid package installation errors 8259679: GitHub actions should use MSVC 14.28 8259924: GitHub actions fail on Linux x86_32 with "Could not configure libc6:i386" 8260460: GitHub actions still fail on Linux x86_32 with "Could not configure libc6:i386" 8263667: Avoid running GitHub actions on branches named pr/* 8255305: Add Linux x86_32 tier1 to submit workflow 8255352: Archive important test outputs in submit workflow Reviewed-by: sgehwolf, shade ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/189 From github.com+42899633+eastig at openjdk.java.net Thu Aug 5 18:51:07 2021 From: github.com+42899633+eastig at openjdk.java.net (Evgeny Astigeevich) Date: Thu, 5 Aug 2021 18:51:07 GMT Subject: [jdk17u] RFR: 8268427: Improve AlgorithmConstraints:checkAlgorithm performance Message-ID: <571bdQIPbWwpszI3EaL0etOgzS5bFwJGM4Zdt3a_owY=.df1db002-6556-4e45-a524-dec7d8334125@github.com> `sun.security.util.AbstractAlgorithmConstraints.checkAlgorithm()` uses linear search to check if an algorithm has been disabled. Its execution time is high in the most common case: a checked algorithm is not disabled. This backport replaces the list with an ordered set. This improves AbstractAlgorithmConstraints.checkAlgorithm() performance, especially for permitted algorithms. The patch applies cleanly. Tier1 and tier2 tests pass with the patch. ------------- Commit messages: - Backport 3b83bc1bc331d268987f56ea4f23124a7f6ee38b Changes: https://git.openjdk.java.net/jdk17u/pull/10/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=10&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268427 Stats: 112 lines in 4 files changed: 72 ins; 17 del; 23 mod Patch: https://git.openjdk.java.net/jdk17u/pull/10.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/10/head:pull/10 PR: https://git.openjdk.java.net/jdk17u/pull/10 From snazarkin at azul.com Thu Aug 5 19:15:17 2021 From: snazarkin at azul.com (Sergey Nazarkin) Date: Thu, 5 Aug 2021 19:15:17 +0000 Subject: [jdk11u-dev] RFR: 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully In-Reply-To: References: Message-ID: The patch looks scary but in general it just adds a guard at the beginning of unsafe copy block. So a bunch of code just shifted right without single line modification. We got a few reports from the users about JVM crash when they modify file being mapped. It was definitely application issue but Unsafe contains protection for primitive types so it might be worth to have the same for copy operation. > On Aug 5, 2021, at 11:46, Andrew Haley wrote: > > On 7/29/21 1:28 PM, Sergey Nazarkin wrote: > >> I'd like to backport this changes to fix crash happens on memory mapped file operations. The patch applies almost cleanly except stubGenerator_arm.cpp due to miss of JEP 340 (One AArch64 Port, Not Two), and some copyright year conflicts. >> Need to note that a series of follow up is required to fix some platforms build. Particularly arm32/aarch64 is not buildable without 8226871. I'll create necessary PR soon. >> Tested with tier1/tier2 and new InternalErrorTest. > > Wow. This is a very invasive patch for a P3 enhancement (that mysteriously > got upgraded to a P2 for backports.) We'd need to see evidence of significant > hardship to users in order to justify approval. > > As far as I know, this only has any effect if someone modifies a file in > some way while a mapping is open. > > -- > Andrew Haley (he/him) > Java Platform Lead Engineer > Red Hat UK Ltd. > https://keybase.io/andrewhaley > EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 > From mdoerr at openjdk.java.net Thu Aug 5 19:25:59 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 5 Aug 2021 19:25:59 GMT Subject: [jdk11u-dev] RFR: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead [v2] In-Reply-To: References: Message-ID: <0pL9dgODx11k8wIqPM8qpHT9QiSfPO6qIEUQUq05g7w=.962523ac-da95-4052-b667-e185a9e48a58@github.com> > Backport of JDK-7179006. CPrinterJob.m parts don't apply cleanly because JNF removal is already backported. Tests have passed on M1 with Rosetta (x86_64 build). Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: Add JNFNSToJavaString replacement and CHECK_EXCEPTION. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/197/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/197/files/423d95fe..5609c8ea Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=197&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=197&range=00-01 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/197.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/197/head:pull/197 PR: https://git.openjdk.java.net/jdk11u-dev/pull/197 From mdoerr at openjdk.java.net Thu Aug 5 19:32:03 2021 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 5 Aug 2021 19:32:03 GMT Subject: [jdk11u-dev] RFR: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead [v3] In-Reply-To: References: Message-ID: > Backport of JDK-7179006. CPrinterJob.m parts don't apply cleanly because JNF removal is already backported. Tests have passed on M1 with Rosetta (x86_64 build). Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: Add JNFJavaToNSString replacement and CHECK_EXCEPTION. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/197/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/197/files/5609c8ea..d7f822f4 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=197&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=197&range=01-02 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/197.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/197/head:pull/197 PR: https://git.openjdk.java.net/jdk11u-dev/pull/197 From zgu at openjdk.java.net Thu Aug 5 19:55:44 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Thu, 5 Aug 2021 19:55:44 GMT Subject: [jdk11u-dev] RFR: 8249548: backward focus traversal gets stuck in button group Message-ID: A clean backport for parity with Oracle 11.0.14. ------------- Commit messages: - Backport 22bb597d0d2d901c5c8227ea700ab27c670dd545 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/199/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=199&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8249548 Stats: 1157 lines in 5 files changed: 538 ins; 618 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/199.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/199/head:pull/199 PR: https://git.openjdk.java.net/jdk11u-dev/pull/199 From clanger at openjdk.java.net Thu Aug 5 21:13:45 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 21:13:45 GMT Subject: [jdk11u-dev] RFR: 8209772: Refactor shell test java/util/ServiceLoader/basic/basic.sh to java Message-ID: <4j50-FJIOsIHuULN0Zd4RnrKH3wk-2DE2KEyv02rxGU=.b82b392d-602b-4123-a0d5-3b0c280f0c97@github.com> Hi all, this pull request contains a backport of JDK-8209772 from the openjdk/jdk repository. The commit being backported was authored by Amy Lu on 14 Sep 2018 and was reviewed by Alan Bateman. Thanks! ------------- Commit messages: - Merge branch 'openjdk:master' into RealCLanger-backport-07392d97 - Backport 07392d976ad5e00763fb28b614aa7631d232544a Changes: https://git.openjdk.java.net/jdk11u-dev/pull/200/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=200&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8209772 Stats: 318 lines in 2 files changed: 162 ins; 156 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/200.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/200/head:pull/200 PR: https://git.openjdk.java.net/jdk11u-dev/pull/200 From clanger at openjdk.java.net Thu Aug 5 21:22:38 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 21:22:38 GMT Subject: [jdk11u-dev] RFR: 8210819: Update the host name in CNameTest.java Message-ID: Hi all, this pull request contains a backport of JDK-8210819 from the openjdk/jdk repository. The commit being backported was authored by Frank Yuan on 18 Sep 2018 and was reviewed by Chris Hegarty. Thanks! ------------- Commit messages: - Merge branch 'openjdk:master' into RealCLanger-backport-c1bbf898 - Backport c1bbf898e4a3ce6756d5ffeedd9f1ddd635b2fba Changes: https://git.openjdk.java.net/jdk11u-dev/pull/201/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=201&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8210819 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/201.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/201/head:pull/201 PR: https://git.openjdk.java.net/jdk11u-dev/pull/201 From clanger at openjdk.java.net Thu Aug 5 22:34:24 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 5 Aug 2021 22:34:24 GMT Subject: [jdk11u] RFR: Merge jdk11u-dev:master Message-ID: Test-PR for Merging. ------------- Commit messages: - 8253424: Add support for running pre-submit testing using GitHub Actions - 8249095: tools/javac/launcher/SourceLauncherTest.java fails on Windows - 8209380: ARM: cleanup maybe-uninitialized and reorder compiler warnings - 8257913: Add more known library locations to simplify Linux cross-compilation - 8238930: problem list compiler/c2/Test8004741.java - 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c - 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers - 8212040: Compilation error due to wrong usage of NSPrintJobDispositionValue in mac10.12 - 8263432: javac may report an invalid package/class clash on case insensitive filesystems - 8221988: add possibility to build with Visual Studio 2019 - ... and 8 more: https://git.openjdk.java.net/jdk11u/compare/815d3e1c...1faefed2 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.java.net/jdk11u/pull/5/files Stats: 3081 lines in 40 files changed: 2829 ins; 197 del; 55 mod Patch: https://git.openjdk.java.net/jdk11u/pull/5.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/5/head:pull/5 PR: https://git.openjdk.java.net/jdk11u/pull/5 From shade at openjdk.java.net Fri Aug 6 05:26:56 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 6 Aug 2021 05:26:56 GMT Subject: [jdk11u-dev] RFR: 8246387: switch to jtreg 5.1 [v3] In-Reply-To: References: Message-ID: > This is a compound backport that brings the entire 11u to 5.1 b1. There are many dependencies thorough the repository history, so I opted to squash them together. It seems the 11.0.13-oracle backport exists only for this issue, which indicates Oracle maintainers did the same. > > The current list of included patches is: > > > 8246387: switch to jtreg 5.1 > 8238943: switch to jtreg 5.0 > 8235866: bump jtreg requiredVersion to 4.2b16 > 8219552: bump jtreg requiredVersion to b14 in test/jdk/sanity/client/ > 8219417: bump jtreg requiredVersion to b14 > 8236111: narrow allowSmartActionArgs disabling > > > Tested on Linux x86_64 fastdebug with jtreg5.1-b1 and the following test suites: > - tier1 > - tier2 > - tier3 > - vmTestbase_nsk_jvmti > - vmTestbase_vm_metaspace > - vmTestbase_vm_defmeth > - vmTestbase_vm_mlvm > - vmTestbase_vm_compiler > - vmTestbase_nsk_jvmti > - vmTestbase_vm_metaspace > - sanity/client Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into JDK-8246387 - Update CDSTestUtils copyright - Merge branch 'master' into JDK-8246387 - Backport e47b2bc8c338a0b137106074952cded1067fc50a ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/103/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/103/files/14cde8be..86f3051b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=103&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=103&range=01-02 Stats: 3046 lines in 39 files changed: 2800 ins; 192 del; 54 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/103.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/103/head:pull/103 PR: https://git.openjdk.java.net/jdk11u-dev/pull/103 From clanger at openjdk.java.net Fri Aug 6 05:33:28 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 6 Aug 2021 05:33:28 GMT Subject: [jdk11u-dev] RFR: 8246387: switch to jtreg 5.1 [v3] In-Reply-To: <8rBn8Wj26q_kczz1P86tddlKLGFLdUxa_ylVCMMk5xw=.352288df-328e-4aa6-b7d7-de6d0eb509a4@github.com> References: <0vkWMhuHRTKRhYiDEpacF6-QgsVyH6q4AOFGmJpYNCM=.193614cb-6b41-4fe8-a569-96e98128a38a@github.com> <8rBn8Wj26q_kczz1P86tddlKLGFLdUxa_ylVCMMk5xw=.352288df-328e-4aa6-b7d7-de6d0eb509a4@github.com> Message-ID: On Thu, 5 Aug 2021 06:53:23 GMT, Aleksey Shipilev wrote: > > Do you want me to run this through SAP's nightlies once? But if you're confident you can integrate it right away. I leave it to you... > > Yes, please. I am in no rush to integrate, and have limited capacity to handle follow-up issues, so the more pre-integration testing, the merrier. Thanks! Our testing went well. So ?? from me. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/103 From shade at redhat.com Fri Aug 6 05:40:22 2021 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 6 Aug 2021 08:40:22 +0300 Subject: [11u] GHA checksums failure Message-ID: <29cf7da4-b962-7360-8e11-b0492a059dd8@redhat.com> Hi Christoph, I was trying to use the newly committed GHA workflows, but it fails with checksum errors for me: https://github.com/shipilev/jdk11u-dev/actions/runs/1103985012 make/conf/test-dependencies says: LINUX_X64_BOOT_JDK_FILENAME=openjdk-11_linux-x64_bin.tar.gz LINUX_X64_BOOT_JDK_URL=https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_linux_hotspot_11.0.12_7.tar.gz LINUX_X64_BOOT_JDK_SHA256=e99b98f851541202ab64401594901e583b764e368814320eba442095251e78cb ...while the actual checksum is: $ wget https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_linux_hotspot_11.0.12_7.tar.gz $ sha256sum OpenJDK11U-jdk_x64_linux_hotspot_11.0.12_7.tar.gz 8770f600fc3b89bf331213c7aa21f8eedd9ca5d96036d1cd48cb2748a3dbefd2 Can you please take a look? -- Thanks, -Aleksey From shade at openjdk.java.net Fri Aug 6 05:40:31 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 6 Aug 2021 05:40:31 GMT Subject: [jdk11u-dev] RFR: 8246387: switch to jtreg 5.1 [v3] In-Reply-To: References: <0vkWMhuHRTKRhYiDEpacF6-QgsVyH6q4AOFGmJpYNCM=.193614cb-6b41-4fe8-a569-96e98128a38a@github.com> <8rBn8Wj26q_kczz1P86tddlKLGFLdUxa_ylVCMMk5xw=.352288df-328e-4aa6-b7d7-de6d0eb509a4@github.com> Message-ID: On Fri, 6 Aug 2021 05:30:41 GMT, Christoph Langer wrote: > Our testing went well. So from me. Thank you, I'll arrange the push shortly. I picked up GHA from master in hopes it would provide more coverage, but I think bootstrap JDK downloads have a checksum bug: https://github.com/shipilev/jdk11u-dev/actions/runs/1103985012 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/103 From shade at redhat.com Fri Aug 6 05:41:44 2021 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 6 Aug 2021 08:41:44 +0300 Subject: [11u] GHA checksums failure In-Reply-To: <29cf7da4-b962-7360-8e11-b0492a059dd8@redhat.com> References: <29cf7da4-b962-7360-8e11-b0492a059dd8@redhat.com> Message-ID: <91034b64-c50e-d037-1374-84ba8c8d4796@redhat.com> On 8/6/21 8:40 AM, Aleksey Shipilev wrote: > Can you please take a look? I think the reason is that this commit omitted updating the checksums: https://github.com/openjdk/jdk11u-dev/pull/189/commits/73229c2d77e709bc399ca8134d60d00bc0e148e1 -- Thanks, -Aleksey From christoph.langer at sap.com Fri Aug 6 06:00:27 2021 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 6 Aug 2021 06:00:27 +0000 Subject: [11u] GHA checksums failure In-Reply-To: <91034b64-c50e-d037-1374-84ba8c8d4796@redhat.com> References: <29cf7da4-b962-7360-8e11-b0492a059dd8@redhat.com> <91034b64-c50e-d037-1374-84ba8c8d4796@redhat.com> Message-ID: Hi Aleksey, yes, I recognized this as well. I missed this because my test went green: https://github.com/RealCLanger/jdk11u-dev/actions/runs/1099309576. But having a closer look now, it just worked because the Bootstrap JDK was restored from cache. I'll file a bug and update it. Interestingly the shasum check on Windows doesn't seem to work. There the test is still green. Best regards Christoph > -----Original Message----- > From: Aleksey Shipilev > Sent: Freitag, 6. August 2021 07:42 > To: jdk-updates-dev at openjdk.java.net; Langer, Christoph > > Subject: Re: [11u] GHA checksums failure > > On 8/6/21 8:40 AM, Aleksey Shipilev wrote: > > Can you please take a look? > > I think the reason is that this commit omitted updating the checksums: > https://github.com/openjdk/jdk11u- > dev/pull/189/commits/73229c2d77e709bc399ca8134d60d00bc0e148e1 > > > -- > Thanks, > -Aleksey From lzang at openjdk.java.net Fri Aug 6 06:38:29 2021 From: lzang at openjdk.java.net (Lin Zang) Date: Fri, 6 Aug 2021 06:38:29 GMT Subject: [jdk11u-dev] RFR: 8234510: Remove file seeking requirement for writing a heap dump [v3] In-Reply-To: References: <6qKslh1zolgk5Df-FieWuhatSyjWXzxCFGbDkFno0Zs=.21ad520b-5738-4c51-a46b-894a04191fa9@github.com> Message-ID: On Thu, 5 Aug 2021 11:15:36 GMT, Christoph Langer wrote: >> BuddyLiao has updated the pull request incrementally with one additional commit since the last revision: >> >> Update full name > >> /integrate > > @buddyliao, you need to Request maintainer approval via jdk11u-fix-request label and Fix request comment in the JBS item [JDK-8234510](https://bugs.openjdk.java.net/browse/JDK-8234510), that part of the protocol hasn't changed with the migration to GitHub. Dear @RealCLanger, Thanks for reminder, as @buddyliao doesn't have the access to JBS, I have helped to add the `jdk11u-fix-request` label in JDK-8234510. BRs, Lin ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/134 From clanger at openjdk.java.net Fri Aug 6 06:52:29 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 6 Aug 2021 06:52:29 GMT Subject: [jdk11u-dev] RFR: 8234510: Remove file seeking requirement for writing a heap dump [v3] In-Reply-To: References: <6qKslh1zolgk5Df-FieWuhatSyjWXzxCFGbDkFno0Zs=.21ad520b-5738-4c51-a46b-894a04191fa9@github.com> Message-ID: On Thu, 5 Aug 2021 11:15:36 GMT, Christoph Langer wrote: >> BuddyLiao has updated the pull request incrementally with one additional commit since the last revision: >> >> Update full name > >> /integrate > > @buddyliao, you need to Request maintainer approval via jdk11u-fix-request label and Fix request comment in the JBS item [JDK-8234510](https://bugs.openjdk.java.net/browse/JDK-8234510), that part of the protocol hasn't changed with the migration to GitHub. > Dear @RealCLanger, > Thanks for reminder, as @buddyliao doesn't have the access to JBS, I have helped to add the `jdk11u-fix-request` label in JDK-8234510. > > BRs, > Lin Thank you. I approved it and will sponsor this one. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/134 From github.com+3094961+buddyliao at openjdk.java.net Fri Aug 6 06:52:30 2021 From: github.com+3094961+buddyliao at openjdk.java.net (BuddyLiao) Date: Fri, 6 Aug 2021 06:52:30 GMT Subject: [jdk11u-dev] Integrated: 8234510: Remove file seeking requirement for writing a heap dump In-Reply-To: References: Message-ID: On Thu, 15 Jul 2021 08:54:18 GMT, BuddyLiao wrote: > Backport of the heap dump enhancement: Remove file seeking requirement for writing a heap dump > > Patch did not apply cleanly, I had to resolve/modify > src/hotspot/share/services/heapDumper.cpp > > I have built it on linux x86_64 and run test-tier1 This pull request has now been integrated. Changeset: 3d12a46b Author: Bin Liao Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/3d12a46b7e8adde2de0419686bd18b6a33105161 Stats: 417 lines in 1 file changed: 161 ins; 185 del; 71 mod 8234510: Remove file seeking requirement for writing a heap dump Reviewed-by: rschmelter, clanger Backport-of: 11c073b97ef03ba46172eb2497c76c3f29b83be8 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/134 From clanger at openjdk.java.net Fri Aug 6 08:07:49 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 6 Aug 2021 08:07:49 GMT Subject: [jdk11u-dev] RFR: 8272078: Wrong Checksums in Temurin BootJDK dependencies Message-ID: <4j873t3BVq120_LYiGak9dZk7KWC4_fShUjsmjsuXbs=.a782ff5c-ac22-4081-8845-02a792e65c4d@github.com> Update checksums for Temurin 11.0.12+7 binaries ------------- Commit messages: - Update checksums for Temurin 11.0.12+7 binaries Changes: https://git.openjdk.java.net/jdk11u-dev/pull/203/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=203&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272078 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/203.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/203/head:pull/203 PR: https://git.openjdk.java.net/jdk11u-dev/pull/203 From christoph.langer at sap.com Fri Aug 6 08:10:38 2021 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 6 Aug 2021 08:10:38 +0000 Subject: [11u] GHA checksums failure In-Reply-To: References: <29cf7da4-b962-7360-8e11-b0492a059dd8@redhat.com> <91034b64-c50e-d037-1374-84ba8c8d4796@redhat.com> Message-ID: > yes, I recognized this as well. I missed this because my test went green: > https://github.com/RealCLanger/jdk11u-dev/actions/runs/1099309576. But > having a closer look now, it just worked because the Bootstrap JDK was > restored from cache. I'll file a bug and update it. Done. Fix is up for review: https://github.com/openjdk/jdk11u-dev/pull/203 Cheers Christoph From shade at openjdk.java.net Fri Aug 6 08:18:35 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 6 Aug 2021 08:18:35 GMT Subject: [jdk11u-dev] RFR: 8272078: Wrong Checksums in Temurin BootJDK dependencies In-Reply-To: <4j873t3BVq120_LYiGak9dZk7KWC4_fShUjsmjsuXbs=.a782ff5c-ac22-4081-8845-02a792e65c4d@github.com> References: <4j873t3BVq120_LYiGak9dZk7KWC4_fShUjsmjsuXbs=.a782ff5c-ac22-4081-8845-02a792e65c4d@github.com> Message-ID: On Fri, 6 Aug 2021 08:02:09 GMT, Christoph Langer wrote: > Update checksums for Temurin 11.0.12+7 binaries This looks fine to me, thanks! I verified the checksums by hand as well. ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/203 From shade at openjdk.java.net Fri Aug 6 08:29:35 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 6 Aug 2021 08:29:35 GMT Subject: [jdk11u-dev] RFR: 8272078: Wrong Checksums in Temurin BootJDK dependencies In-Reply-To: <4j873t3BVq120_LYiGak9dZk7KWC4_fShUjsmjsuXbs=.a782ff5c-ac22-4081-8845-02a792e65c4d@github.com> References: <4j873t3BVq120_LYiGak9dZk7KWC4_fShUjsmjsuXbs=.a782ff5c-ac22-4081-8845-02a792e65c4d@github.com> Message-ID: On Fri, 6 Aug 2021 08:02:09 GMT, Christoph Langer wrote: > Update checksums for Temurin 11.0.12+7 binaries @jerboaa, please approve this push to unbreak GHA :) ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/203 From sgehwolf at openjdk.java.net Fri Aug 6 09:08:31 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 6 Aug 2021 09:08:31 GMT Subject: [jdk11u-dev] RFR: 8272078: Wrong Checksums in Temurin BootJDK dependencies In-Reply-To: References: <4j873t3BVq120_LYiGak9dZk7KWC4_fShUjsmjsuXbs=.a782ff5c-ac22-4081-8845-02a792e65c4d@github.com> Message-ID: <4ZhxhC2oWqmRctK3A-unyv0kFAZTi_BFh1L2__T4a7I=.075b9daa-1aee-4458-829e-259baeeea2fc@github.com> On Fri, 6 Aug 2021 08:26:09 GMT, Aleksey Shipilev wrote: > @jerboaa, please approve this push to unbreak GHA :) Done :) ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/203 From clanger at openjdk.java.net Fri Aug 6 09:08:31 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 6 Aug 2021 09:08:31 GMT Subject: [jdk11u-dev] RFR: 8272078: Wrong Checksums in Temurin BootJDK dependencies In-Reply-To: <4ZhxhC2oWqmRctK3A-unyv0kFAZTi_BFh1L2__T4a7I=.075b9daa-1aee-4458-829e-259baeeea2fc@github.com> References: <4j873t3BVq120_LYiGak9dZk7KWC4_fShUjsmjsuXbs=.a782ff5c-ac22-4081-8845-02a792e65c4d@github.com> <4ZhxhC2oWqmRctK3A-unyv0kFAZTi_BFh1L2__T4a7I=.075b9daa-1aee-4458-829e-259baeeea2fc@github.com> Message-ID: <1eVJui5xZ2mqpk-IYODnCrT3mS-mu_5qX8pW9ALdOgs=.fbbafbad-b7e7-4680-ace0-3fd2bbefa805@github.com> On Fri, 6 Aug 2021 09:01:52 GMT, Severin Gehwolf wrote: > > @jerboaa, please approve this push to unbreak GHA :) > > Done :) Thanks! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/203 From clanger at openjdk.java.net Fri Aug 6 09:08:32 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 6 Aug 2021 09:08:32 GMT Subject: [jdk11u-dev] Integrated: 8272078: Wrong Checksums in Temurin BootJDK dependencies In-Reply-To: <4j873t3BVq120_LYiGak9dZk7KWC4_fShUjsmjsuXbs=.a782ff5c-ac22-4081-8845-02a792e65c4d@github.com> References: <4j873t3BVq120_LYiGak9dZk7KWC4_fShUjsmjsuXbs=.a782ff5c-ac22-4081-8845-02a792e65c4d@github.com> Message-ID: On Fri, 6 Aug 2021 08:02:09 GMT, Christoph Langer wrote: > Update checksums for Temurin 11.0.12+7 binaries This pull request has now been integrated. Changeset: 1538790f Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/1538790fdcad884a40f9a91ddba8587affd034d6 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8272078: Wrong Checksums in Temurin BootJDK dependencies Reviewed-by: shade ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/203 From shade at openjdk.java.net Fri Aug 6 09:09:56 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 6 Aug 2021 09:09:56 GMT Subject: [jdk11u-dev] RFR: 8246387: switch to jtreg 5.1 [v4] In-Reply-To: References: Message-ID: > This is a compound backport that brings the entire 11u to 5.1 b1. There are many dependencies thorough the repository history, so I opted to squash them together. It seems the 11.0.13-oracle backport exists only for this issue, which indicates Oracle maintainers did the same. > > The current list of included patches is: > > > 8246387: switch to jtreg 5.1 > 8238943: switch to jtreg 5.0 > 8235866: bump jtreg requiredVersion to 4.2b16 > 8219552: bump jtreg requiredVersion to b14 in test/jdk/sanity/client/ > 8219417: bump jtreg requiredVersion to b14 > 8236111: narrow allowSmartActionArgs disabling > > > Tested on Linux x86_64 fastdebug with jtreg5.1-b1 and the following test suites: > - tier1 > - tier2 > - tier3 > - vmTestbase_nsk_jvmti > - vmTestbase_vm_metaspace > - vmTestbase_vm_defmeth > - vmTestbase_vm_mlvm > - vmTestbase_vm_compiler > - vmTestbase_nsk_jvmti > - vmTestbase_vm_metaspace > - sanity/client Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'master' into JDK-8246387 - Merge branch 'master' into JDK-8246387 - Update CDSTestUtils copyright - Merge branch 'master' into JDK-8246387 - Backport e47b2bc8c338a0b137106074952cded1067fc50a ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/103/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/103/files/86f3051b..a5084cf2 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=103&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=103&range=02-03 Stats: 420 lines in 2 files changed: 161 ins; 185 del; 74 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/103.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/103/head:pull/103 PR: https://git.openjdk.java.net/jdk11u-dev/pull/103 From clanger at openjdk.java.net Fri Aug 6 09:10:56 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 6 Aug 2021 09:10:56 GMT Subject: [jdk11u-dev] RFR: 8210819: Update the host name in CNameTest.java [v2] In-Reply-To: References: Message-ID: <_NhTb5hCLe3ZtedA2Z2jBdRPfTZXvBxLK3o7pu9g83k=.3c37d85a-e6c8-4cce-a027-66bc7c6291ff@github.com> > Hi all, > > this pull request contains a backport of JDK-8210819 from the openjdk/jdk repository. > > The commit being backported was authored by Frank Yuan on 18 Sep 2018 and was reviewed by Chris Hegarty. > > Thanks! Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into RealCLanger-backport-c1bbf898 - Merge branch 'openjdk:master' into RealCLanger-backport-c1bbf898 - Backport c1bbf898e4a3ce6756d5ffeedd9f1ddd635b2fba ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/201/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/201/files/ea0f1f2c..7c4e4669 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=201&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=201&range=00-01 Stats: 420 lines in 2 files changed: 161 ins; 185 del; 74 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/201.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/201/head:pull/201 PR: https://git.openjdk.java.net/jdk11u-dev/pull/201 From clanger at openjdk.java.net Fri Aug 6 09:12:52 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 6 Aug 2021 09:12:52 GMT Subject: [jdk11u-dev] RFR: 8209772: Refactor shell test java/util/ServiceLoader/basic/basic.sh to java [v2] In-Reply-To: <4j50-FJIOsIHuULN0Zd4RnrKH3wk-2DE2KEyv02rxGU=.b82b392d-602b-4123-a0d5-3b0c280f0c97@github.com> References: <4j50-FJIOsIHuULN0Zd4RnrKH3wk-2DE2KEyv02rxGU=.b82b392d-602b-4123-a0d5-3b0c280f0c97@github.com> Message-ID: > Hi all, > > this pull request contains a backport of JDK-8209772 from the openjdk/jdk repository. > > The commit being backported was authored by Amy Lu on 14 Sep 2018 and was reviewed by Alan Bateman. > > Thanks! Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into RealCLanger-backport-07392d97 - Merge branch 'openjdk:master' into RealCLanger-backport-07392d97 - Backport 07392d976ad5e00763fb28b614aa7631d232544a ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/200/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/200/files/cff6fa85..c9e7ea31 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=200&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=200&range=00-01 Stats: 420 lines in 2 files changed: 161 ins; 185 del; 74 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/200.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/200/head:pull/200 PR: https://git.openjdk.java.net/jdk11u-dev/pull/200 From aph-open at littlepinkcloud.com Fri Aug 6 09:33:30 2021 From: aph-open at littlepinkcloud.com (Andrew Haley) Date: Fri, 6 Aug 2021 10:33:30 +0100 Subject: [jdk11u-dev] RFR: 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully In-Reply-To: References: Message-ID: On 8/5/21 8:15 PM, Sergey Nazarkin wrote: > The patch looks scary but in general it just adds a guard at the beginning of unsafe copy block. So a bunch of code just shifted right without single line modification. > > We got a few reports from the users about JVM crash when they modify file being mapped. It was definitely application issue but Unsafe contains protection for primitive types so it might be worth to have the same for copy operation. Sure, I understand. However, the only thing this patch changes is that you get a Java stack trace instead of a VM dump. Your program exits, either way. So it really is just about being graceful. The default response to enhancements in old releases is no, and there's a good reason for that. We need to learn from experience. Take, for example, JDK-8267689. That was a fix for a rare and hard-to-provoke crash when accessing misaligned Unsafe memory. The backport patch looked reasonable enough, and was working fine on the head release, but it was wrong. In fact, the head release had a subtle but latent bug, which wasn't so latent in 8u. This bug was worse than the original bug that JDK-8267689 was supposed to fix. I think we shouldn't risk regressions like that unless we actually need to. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From shade at openjdk.java.net Fri Aug 6 09:59:41 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 6 Aug 2021 09:59:41 GMT Subject: [jdk11u-dev] RFR: 8230841: Remove oopDesc::equals() Message-ID: This is the second patch in the series to cleanup/revert the GC BarrierSets to most current state. See the dependent ("this issue blocks" links) issues to see what is next. The equals APIs were added for Shenandoah GC, in the incarnation that exposed both from- and to-copies to the runtime system (see JDK-8199781). Since then, Shenandoah greatly simplified this by switching to a strong to-space invariant, which obviates the need for this API. Therefore, it was removed in JDK 14. This patch reverts JDK 11 parts to that shape as well, which should simplify 11u maintenance. ------------- Commit messages: - Backport 2d6874b861270ea67322d5976a30202bdb6adb1c Changes: https://git.openjdk.java.net/jdk11u-dev/pull/204/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=204&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8230841 Stats: 84 lines in 33 files changed: 0 ins; 11 del; 73 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/204.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/204/head:pull/204 PR: https://git.openjdk.java.net/jdk11u-dev/pull/204 From snazarkin at azul.com Fri Aug 6 11:11:18 2021 From: snazarkin at azul.com (Sergey Nazarkin) Date: Fri, 6 Aug 2021 11:11:18 +0000 Subject: [jdk11u-dev] RFR: 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully In-Reply-To: References: Message-ID: Thanks, Andrew! That sounds like a reason to not bother the community with the patch for jdk8. > On Aug 6, 2021, at 12:33, Andrew Haley wrote: > > On 8/5/21 8:15 PM, Sergey Nazarkin wrote: >> The patch looks scary but in general it just adds a guard at the beginning of unsafe copy block. So a bunch of code just shifted right without single line modification. >> >> We got a few reports from the users about JVM crash when they modify file being mapped. It was definitely application issue but Unsafe contains protection for primitive types so it might be worth to have the same for copy operation. > > Sure, I understand. However, the only thing this patch changes is that > you get a Java stack trace instead of a VM dump. Your program exits, > either way. So it really is just about being graceful. > > The default response to enhancements in old releases is no, and there's > a good reason for that. > > We need to learn from experience. Take, for example, JDK-8267689. That > was a fix for a rare and hard-to-provoke crash when accessing > misaligned Unsafe memory. The backport patch looked reasonable enough, > and was working fine on the head release, but it was wrong. In fact, > the head release had a subtle but latent bug, which wasn't so latent > in 8u. This bug was worse than the original bug that JDK-8267689 was > supposed to fix. > > I think we shouldn't risk regressions like that unless we actually > need to. > > -- > Andrew Haley (he/him) > Java Platform Lead Engineer > Red Hat UK Ltd. > https://keybase.io/andrewhaley > EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 > > > -- > Andrew Haley (he/him) > Java Platform Lead Engineer > Red Hat UK Ltd. > https://keybase.io/andrewhaley > EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From sgehwolf at openjdk.java.net Fri Aug 6 13:39:39 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 6 Aug 2021 13:39:39 GMT Subject: [jdk11u-dev] RFR: 8251549: Update docs on building for Git Message-ID: Hi, Now that OpenJDK 11u is fully on Git we should update the docs to no longer refer to Mercurial and use Git instead. The JDK 16 patch doesn't apply clean due to some differences in the file (e.g. referring to JDK 8 vs. JDK 11 in head). `doc/building.html` is the result of running `make update-build-docs` when the `building.md` file has the relevant changes. Thoughts? ------------- Commit messages: - Backport 042734cc5b17302a8f2ecdf577511bd6d5ec5e22 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/205/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=205&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8251549 Stats: 285 lines in 2 files changed: 44 ins; 75 del; 166 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/205.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/205/head:pull/205 PR: https://git.openjdk.java.net/jdk11u-dev/pull/205 From shade at openjdk.java.net Fri Aug 6 15:22:37 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 6 Aug 2021 15:22:37 GMT Subject: [jdk11u-dev] RFR: 8246387: switch to jtreg 5.1 [v4] In-Reply-To: References: Message-ID: On Fri, 6 Aug 2021 09:09:56 GMT, Aleksey Shipilev wrote: >> This is a compound backport that brings the entire 11u to 5.1 b1. There are many dependencies thorough the repository history, so I opted to squash them together. It seems the 11.0.13-oracle backport exists only for this issue, which indicates Oracle maintainers did the same. >> >> The current list of included patches is: >> >> >> 8246387: switch to jtreg 5.1 >> 8238943: switch to jtreg 5.0 >> 8235866: bump jtreg requiredVersion to 4.2b16 >> 8219552: bump jtreg requiredVersion to b14 in test/jdk/sanity/client/ >> 8219417: bump jtreg requiredVersion to b14 >> 8236111: narrow allowSmartActionArgs disabling >> >> >> Tested on Linux x86_64 fastdebug with jtreg5.1-b1 and the following test suites: >> - tier1 >> - tier2 >> - tier3 >> - vmTestbase_nsk_jvmti >> - vmTestbase_vm_metaspace >> - vmTestbase_vm_defmeth >> - vmTestbase_vm_mlvm >> - vmTestbase_vm_compiler >> - vmTestbase_nsk_jvmti >> - vmTestbase_vm_metaspace >> - sanity/client > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'master' into JDK-8246387 > - Merge branch 'master' into JDK-8246387 > - Update CDSTestUtils copyright > - Merge branch 'master' into JDK-8246387 > - Backport e47b2bc8c338a0b137106074952cded1067fc50a GHA run is complete and green now: https://github.com/shipilev/jdk11u-dev/runs/3261042243 -- I'll integrate on Sunday night. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/103 From clanger at openjdk.java.net Fri Aug 6 16:03:29 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 6 Aug 2021 16:03:29 GMT Subject: [jdk11u-dev] RFR: 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully In-Reply-To: References: Message-ID: <-3j3edP8o8jMhluz8iIkb6QwkBsWBp4QZ2NwJAWyDQ8=.50a7df43-10dc-4fa4-bfd4-c98d3beccc19@github.com> On Thu, 29 Jul 2021 12:22:06 GMT, Sergey Nazarkin wrote: > Hi! > I'd like to backport this changes to fix crash happens on memory mapped file operations. The patch applies almost cleanly except stubGenerator_arm.cpp due to miss of JEP 340 (One AArch64 Port, Not Two), and some copyright year conflicts. > Need to note that a series of follow up is required to fix some platforms build. Particularly arm32/aarch64 is not buildable without 8226871. I'll create necessary PR soon. > Tested with tier1/tier2 and new InternalErrorTest. FWIW: Testing of this change plus its three follow ups didn't show regressions in SAP's nightlies. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/173 From clanger at openjdk.java.net Fri Aug 6 17:28:46 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 6 Aug 2021 17:28:46 GMT Subject: [jdk11u-dev] RFR: 8210802: temp files left by tests in jdk/java/net/httpclient Message-ID: Hi all, this pull request contains a backport of JDK-8210802 from the openjdk/jdk repository. The commit being backported was authored by Hamlin Li on 18 Sep 2018 and was reviewed by Chris Hegarty and Christoph Langer. Thanks! ------------- Commit messages: - Backport 1adaa503bb2a5e78a358f2578cdb665f8701b0de Changes: https://git.openjdk.java.net/jdk11u-dev/pull/206/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=206&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8210802 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/206.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/206/head:pull/206 PR: https://git.openjdk.java.net/jdk11u-dev/pull/206 From stuefe at openjdk.java.net Fri Aug 6 18:29:36 2021 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Fri, 6 Aug 2021 18:29:36 GMT Subject: [jdk11u-dev] RFR: 8210802: temp files left by tests in jdk/java/net/httpclient In-Reply-To: References: Message-ID: On Fri, 6 Aug 2021 17:20:17 GMT, Christoph Langer wrote: > Hi all, > > this pull request contains a backport of JDK-8210802 from the openjdk/jdk repository. > > The commit being backported was authored by Hamlin Li on 18 Sep 2018 and was reviewed by Chris Hegarty and Christoph Langer. > > Thanks! Seems easy enough. LGTM. Though, like Alexey, I am curious which tests were affected by this. I am not sure this is even used (it seems only used by com/sun/net/httpserver/SimpleFileServer, which I don't see being used anywhere). ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/206 From clanger at openjdk.java.net Fri Aug 6 18:29:36 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 6 Aug 2021 18:29:36 GMT Subject: [jdk11u-dev] RFR: 8210802: temp files left by tests in jdk/java/net/httpclient In-Reply-To: References: Message-ID: On Fri, 6 Aug 2021 18:22:43 GMT, Thomas Stuefe wrote: > Seems easy enough. LGTM. > > Though, like Alexey, I am curious which tests were affected by this. I am not sure this is even used (it seems only used by com/sun/net/httpserver/SimpleFileServer, which I don't see being used anywhere). Yep, it's simple stupid parity to get the list empty. I'm sure it does no harm ?? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/206 From github.com+42899633+eastig at openjdk.java.net Fri Aug 6 23:36:37 2021 From: github.com+42899633+eastig at openjdk.java.net (Evgeny Astigeevich) Date: Fri, 6 Aug 2021 23:36:37 GMT Subject: [jdk11u-dev] Integrated: 8268427: Improve AlgorithmConstraints:checkAlgorithm performance In-Reply-To: <-rDfm2V6c-1KxqjiriQKYIp2uhOwuGTYD0hir2SfHy4=.9643a93e-cdc3-49f2-b170-003765127773@github.com> References: <-rDfm2V6c-1KxqjiriQKYIp2uhOwuGTYD0hir2SfHy4=.9643a93e-cdc3-49f2-b170-003765127773@github.com> Message-ID: On Wed, 4 Aug 2021 15:08:45 GMT, Evgeny Astigeevich wrote: > A backport of JDK-8233228 to 11u increased the list of disabled algorithms. For TLS the size of the list increased from 9 to 56. `sun.security.util.AbstractAlgorithmConstraints.checkAlgorithm()` uses linear search to check if an algorithm has been disabled. Its execution time significantly increased in the most common case: a checked algorithm is not disabled. > > This backport improves `AbstractAlgorithmConstraints.checkAlgorithm()` performance. > Tier1 and tier2 tests pass with the patch. > > The patch contains a microbenchmark. > Baseline results before patch: > > Benchmark (algorithm) Mode Cnt Score Error Units > AlgorithmConstraintsPermits.permits SSLv3 avgt 25 17.296 ? 0.282 ns/op > AlgorithmConstraintsPermits.permits DES avgt 25 288.010 ? 2.502 ns/op > AlgorithmConstraintsPermits.permits NULL avgt 25 459.496 ? 6.160 ns/op > AlgorithmConstraintsPermits.permits TLS1.3 avgt 25 1361.700 ? 12.871 ns/op > > > Benchmark results after patch: > > Benchmark (algorithm) Mode Cnt Score Error Units > AlgorithmConstraintsPermits.permits SSLv3 avgt 25 119.320 ? 2.572 ns/op > AlgorithmConstraintsPermits.permits DES avgt 25 82.259 ? 0.668 ns/op > AlgorithmConstraintsPermits.permits NULL avgt 25 57.302 ? 3.611 ns/op > AlgorithmConstraintsPermits.permits TLS1.3 avgt 25 465.914 ? 2.553 ns/op > > > Before the patch the list of the disabled algorithms has `SSLv3` first, `DES` second, `NULL` 9th and `TLS1.3` not on the list. As `SSLv3` is the first, accesses to it are the fastest. As we get far from the head, the access time increases. `NULL` had been the last before JDK-8233228. In a case of TLS1.3 the whole list has to be checked. > > The patch replaces the list with an ordered set. Despite the increased time for `SSLv3` all other times, especially for permitted algorithms such as `TLS1.3`, significantly decreased. This pull request has now been integrated. Changeset: 4e324294 Author: Evgeny Astigeevich Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk11u-dev/commit/4e324294d2940aa7ebaf51723fd4bc5178442b15 Stats: 112 lines in 4 files changed: 72 ins; 17 del; 23 mod 8268427: Improve AlgorithmConstraints:checkAlgorithm performance Backport-of: 3b83bc1bc331d268987f56ea4f23124a7f6ee38b ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/193 From github.com+42899633+eastig at openjdk.java.net Fri Aug 6 23:36:37 2021 From: github.com+42899633+eastig at openjdk.java.net (Evgeny Astigeevich) Date: Fri, 6 Aug 2021 23:36:37 GMT Subject: [jdk17u] Integrated: 8268427: Improve AlgorithmConstraints:checkAlgorithm performance In-Reply-To: <571bdQIPbWwpszI3EaL0etOgzS5bFwJGM4Zdt3a_owY=.df1db002-6556-4e45-a524-dec7d8334125@github.com> References: <571bdQIPbWwpszI3EaL0etOgzS5bFwJGM4Zdt3a_owY=.df1db002-6556-4e45-a524-dec7d8334125@github.com> Message-ID: On Thu, 5 Aug 2021 18:42:08 GMT, Evgeny Astigeevich wrote: > `sun.security.util.AbstractAlgorithmConstraints.checkAlgorithm()` uses linear search to check if an algorithm has been disabled. Its execution time is high in the most common case: a checked algorithm is not disabled. > > This backport replaces the list with an ordered set. This improves AbstractAlgorithmConstraints.checkAlgorithm() performance, especially for permitted algorithms. > > The patch applies cleanly. Tier1 and tier2 tests pass with the patch. This pull request has now been integrated. Changeset: 456735f7 Author: Evgeny Astigeevich Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk17u/commit/456735f772c208ff10844cc5a002bf09c9b8b7dd Stats: 112 lines in 4 files changed: 72 ins; 17 del; 23 mod 8268427: Improve AlgorithmConstraints:checkAlgorithm performance Backport-of: 3b83bc1bc331d268987f56ea4f23124a7f6ee38b ------------- PR: https://git.openjdk.java.net/jdk17u/pull/10 From shade at openjdk.java.net Mon Aug 9 04:44:50 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 9 Aug 2021 04:44:50 GMT Subject: [jdk11u-dev] Integrated: 8246387: switch to jtreg 5.1 In-Reply-To: References: Message-ID: On Tue, 6 Jul 2021 17:19:29 GMT, Aleksey Shipilev wrote: > This is a compound backport that brings the entire 11u to 5.1 b1. There are many dependencies thorough the repository history, so I opted to squash them together. It seems the 11.0.13-oracle backport exists only for this issue, which indicates Oracle maintainers did the same. > > The current list of included patches is: > > > 8246387: switch to jtreg 5.1 > 8238943: switch to jtreg 5.0 > 8235866: bump jtreg requiredVersion to 4.2b16 > 8219552: bump jtreg requiredVersion to b14 in test/jdk/sanity/client/ > 8219417: bump jtreg requiredVersion to b14 > 8236111: narrow allowSmartActionArgs disabling > > > Tested on Linux x86_64 fastdebug with jtreg5.1-b1 and the following test suites: > - tier1 > - tier2 > - tier3 > - vmTestbase_nsk_jvmti > - vmTestbase_vm_metaspace > - vmTestbase_vm_defmeth > - vmTestbase_vm_mlvm > - vmTestbase_vm_compiler > - vmTestbase_nsk_jvmti > - vmTestbase_vm_metaspace > - sanity/client This pull request has now been integrated. Changeset: 5f9429b5 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/5f9429b58f68a2d71b3dae96e15353b780c745a3 Stats: 187 lines in 24 files changed: 49 ins; 118 del; 20 mod 8246387: switch to jtreg 5.1 8238943: switch to jtreg 5.0 8235866: bump jtreg requiredVersion to 4.2b16 8219552: bump jtreg requiredVersion to b14 in test/jdk/sanity/client/ 8219417: bump jtreg requiredVersion to b14 8236111: narrow allowSmartActionArgs disabling Reviewed-by: phh, clanger Backport-of: e47b2bc8c338a0b137106074952cded1067fc50a ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/103 From shade at openjdk.java.net Mon Aug 9 06:25:42 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 9 Aug 2021 06:25:42 GMT Subject: [jdk11u-dev] RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible In-Reply-To: References: Message-ID: On Thu, 5 Aug 2021 13:43:01 GMT, Martin Doerr wrote: > Backport of JDK-8251377. Doesn't apply cleanly because Mac OS version check from JDK-8230869 is not in 11u. I just included the introduction of `isCatalinaOrAbove` and `isBigSurOrAbove` from the latter. Rest applies cleanly. This backport looks fine. ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/198 From shade at openjdk.java.net Mon Aug 9 06:31:44 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 9 Aug 2021 06:31:44 GMT Subject: [jdk11u-dev] RFR: 8251549: Update docs on building for Git In-Reply-To: References: Message-ID: On Fri, 6 Aug 2021 13:32:43 GMT, Severin Gehwolf wrote: > Hi, > > Now that OpenJDK 11u is fully on Git we should update the docs to no longer refer to Mercurial and use Git instead. The JDK 16 patch doesn't apply clean due to some differences in the file (e.g. referring to JDK 8 vs. JDK 11 in head). `doc/building.html` is the result of running `make update-build-docs` when the `building.md` file has the relevant changes. > > Thoughts? The `*.md` change looks good, but `*.html` has a lot of irrelevant changes. This is usually caused by a different version of pandoc used to generate the HTML file. Please run `make update-build-docs` on master and see what changes it brings. The usual way is to find the pandoc version that produces the minimal changes to HTML. If we don't do this, then HTML would change every time a future contributor changes MD again. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/205 From shade at openjdk.java.net Mon Aug 9 06:33:34 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 9 Aug 2021 06:33:34 GMT Subject: [jdk11u-dev] RFR: 8226319: Add forgotten test/jdk/java/net/httpclient/BodySubscribersTest.java In-Reply-To: <0mMQG-X_NkqpuwLOcYxXiSzqB_bbbdqtwoq4YUKgs5E=.c00b3dd0-9a1a-46e7-8aaf-bac7fa4ea680@github.com> References: <0mMQG-X_NkqpuwLOcYxXiSzqB_bbbdqtwoq4YUKgs5E=.c00b3dd0-9a1a-46e7-8aaf-bac7fa4ea680@github.com> Message-ID: On Thu, 29 Jul 2021 17:30:21 GMT, Zhengyu Gu wrote: > I would like to backport this patch to 11u. This patch contains missing test from JDK-8225583, which is a Oracle parity backport. > > The backport is clean. And the test passes with JDK-8225583. Wait, there are other changes in this PR, not only the test. Please see what is up here. ------------- Changes requested by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/175 From shade at openjdk.java.net Mon Aug 9 06:52:06 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 9 Aug 2021 06:52:06 GMT Subject: [jdk11u-dev] RFR: 8213694: Test Timeout.java should run in othervm mode Message-ID: Clean backport, matches 11.0.13-oracle. ------------- Commit messages: - Backport 1b20a6781f3132ee1f23c795ed24dbf5e2d59b79 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/207/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=207&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8213694 Stats: 25 lines in 1 file changed: 4 ins; 6 del; 15 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/207.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/207/head:pull/207 PR: https://git.openjdk.java.net/jdk11u-dev/pull/207 From shade at openjdk.java.net Mon Aug 9 07:01:57 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 9 Aug 2021 07:01:57 GMT Subject: [jdk11u-dev] RFR: 8251361: Potential race between Logger configuration and GCs in HttpURLConWithProxy test Message-ID: This backport is simple, but it does not apply cleanly to 11u due to context conflict with "8227539: Replace wildcard address with loopback or local host in tests - part 20". It brought `throws Exception` to `main` method. I resolved that conflict by hand. Additional testing: - [x] Affected test still passes ------------- Commit messages: - Backport ed5696dd2ce318b2480c96b5eeaf319853ce5d89 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/208/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=208&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8251361 Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/208.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/208/head:pull/208 PR: https://git.openjdk.java.net/jdk11u-dev/pull/208 From shade at openjdk.java.net Mon Aug 9 07:01:57 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 9 Aug 2021 07:01:57 GMT Subject: [jdk11u-dev] RFR: 8251361: Potential race between Logger configuration and GCs in HttpURLConWithProxy test In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 06:54:38 GMT, Aleksey Shipilev wrote: > This backport is simple, but it does not apply cleanly to 11u due to context conflict with "8227539: Replace wildcard address with loopback or local host in tests - part 20". It brought `throws Exception` to `main` method. I resolved that conflict by hand. > > Additional testing: > - [x] Affected test still passes Mhm. Bots still consider this a clean backport. Very well. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/208 From github.com+3094961+buddyliao at openjdk.java.net Mon Aug 9 07:16:00 2021 From: github.com+3094961+buddyliao at openjdk.java.net (BuddyLiao) Date: Mon, 9 Aug 2021 07:16:00 GMT Subject: [jdk11u-dev] RFR: 8237354: Add option to jcmd to write a gzipped heap dump Message-ID: Backport of the heap dump enhancement: Add option to jcmd to write a gzipped heap dump Patch did not apply cleanly, I had to resolve/modify src/hotspot/share/services/heapDumper.cpp src/hotspot/share/services/heapDumperCompression.cpp src/hotspot/share/services/heapDumperCompression.hpp I have built it on linux x86_64 and run test-tier1 ------------- Commit messages: - Backport 19be49714356f2f598924c9fefa6358679ab6dbe Changes: https://git.openjdk.java.net/jdk11u-dev/pull/209/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=209&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8237354 Stats: 1758 lines in 13 files changed: 1638 ins; 52 del; 68 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/209.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/209/head:pull/209 PR: https://git.openjdk.java.net/jdk11u-dev/pull/209 From shade at openjdk.java.net Mon Aug 9 08:23:45 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 9 Aug 2021 08:23:45 GMT Subject: [jdk11u-dev] RFR: 8236413: AbstractConnectTimeout should tolerate both NoRouteToHostException and UnresolvedAddressException Message-ID: Backporting this for `11.0.14-oracle` parity. Additional testing: - [x] `java/net/httpclient` tests still pass ------------- Commit messages: - Backport fab6158c198dd6b363bfb36e5a18107214bb134d Changes: https://git.openjdk.java.net/jdk11u-dev/pull/210/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=210&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8236413 Stats: 14 lines in 1 file changed: 7 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/210.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/210/head:pull/210 PR: https://git.openjdk.java.net/jdk11u-dev/pull/210 From dcherepanov at openjdk.java.net Mon Aug 9 08:33:59 2021 From: dcherepanov at openjdk.java.net (Dmitry Cherepanov) Date: Mon, 9 Aug 2021 08:33:59 GMT Subject: [jdk13u-dev] RFR: 8241888: Mirror jdk.security.allowNonCaAnchor system property with a security one In-Reply-To: References: Message-ID: On Thu, 5 Aug 2021 09:51:55 GMT, Alexey Bakhtin wrote: > The original patch applies almost clean: trivial fix in java.security because of jdk.jndi.object.factoriesFilter property already backported into 13u > Tests in jdk/sun/security/validator passed. Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/249 From shade at openjdk.java.net Mon Aug 9 08:52:43 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 9 Aug 2021 08:52:43 GMT Subject: [jdk11u-dev] RFR: 8210669: Some launcher tests assume a pre-JDK 9 run-time image layout Message-ID: Backporting for `11.0.13-oracle` parity. Additional testing: - [x] `tools/launcher/` pass ------------- Commit messages: - Backport 6bc30c6707aed5e5f444def64b296c0eb9021863 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/211/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=211&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8210669 Stats: 26 lines in 3 files changed: 11 ins; 6 del; 9 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/211.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/211/head:pull/211 PR: https://git.openjdk.java.net/jdk11u-dev/pull/211 From shade at openjdk.java.net Mon Aug 9 09:02:04 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 9 Aug 2021 09:02:04 GMT Subject: [jdk11u-dev] RFR: 8216532: tools/launcher/Test7029048.java fails (Solaris) Message-ID: Backporting this for `11.0.13-oracle` parity. Additional testing: - [x] `tools/launcher` tests pass ------------- Commit messages: - Backport be44ced10aa299f60e9227cc25a7541fd4203271 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/212/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=212&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8216532 Stats: 44 lines in 1 file changed: 10 ins; 10 del; 24 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/212.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/212/head:pull/212 PR: https://git.openjdk.java.net/jdk11u-dev/pull/212 From sgehwolf at openjdk.java.net Mon Aug 9 09:07:33 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 9 Aug 2021 09:07:33 GMT Subject: [jdk11u-dev] RFR: 8251549: Update docs on building for Git In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 06:28:32 GMT, Aleksey Shipilev wrote: > The `*.md` change looks good, but `*.html` has a lot of irrelevant changes. This is usually caused by a different version of pandoc used to generate the HTML file. I see. Makes sense. Do you know which pandoc version we need? I have `2.9.2.1` > Please run `make update-build-docs` on master and see what changes it brings. The usual way is to find the pandoc version that produces the minimal changes to HTML. If we don't do this, then HTML would change every time a future contributor changes MD again. OK. I'll try to figure it out. Thanks for the sanity check! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/205 From abakhtin at openjdk.java.net Mon Aug 9 09:24:43 2021 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Mon, 9 Aug 2021 09:24:43 GMT Subject: [jdk13u-dev] Integrated: 8241888: Mirror jdk.security.allowNonCaAnchor system property with a security one In-Reply-To: References: Message-ID: On Thu, 5 Aug 2021 09:51:55 GMT, Alexey Bakhtin wrote: > The original patch applies almost clean: trivial fix in java.security because of jdk.jndi.object.factoriesFilter property already backported into 13u > Tests in jdk/sun/security/validator passed. This pull request has now been integrated. Changeset: 99402953 Author: Alexey Bakhtin Committer: Dmitry Cherepanov URL: https://git.openjdk.java.net/jdk13u-dev/commit/9940295350b42b66219cabb79d66441c805ab320 Stats: 21 lines in 2 files changed: 14 ins; 1 del; 6 mod 8241888: Mirror jdk.security.allowNonCaAnchor system property with a security one Reviewed-by: dcherepanov Backport-of: 1c651455a75ff21770bb3b112a440396fce402a5 ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/249 From shade at openjdk.java.net Mon Aug 9 09:25:30 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 9 Aug 2021 09:25:30 GMT Subject: [jdk11u-dev] RFR: 8251549: Update docs on building for Git In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 09:04:37 GMT, Severin Gehwolf wrote: > > The `*.md` change looks good, but `*.html` has a lot of irrelevant changes. This is usually caused by a different version of pandoc used to generate the HTML file. > > I see. Makes sense. Do you know which pandoc version we need? I have `2.9.2.1` Look at `./make/conf/jib-profiles.js` in the 11u tree and in current master. Chances are there is no exact Pandoc version that produces the same HTML file _exactly_, but we probably want to have it as close to current version as possible. So that we generate the HTML file once here, and then stick with the particular Pandoc version going forward. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/205 From sgehwolf at openjdk.java.net Mon Aug 9 09:25:31 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 9 Aug 2021 09:25:31 GMT Subject: [jdk11u-dev] RFR: 8251549: Update docs on building for Git In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 09:18:39 GMT, Aleksey Shipilev wrote: > > > The `*.md` change looks good, but `*.html` has a lot of irrelevant changes. This is usually caused by a different version of pandoc used to generate the HTML file. > > > > > > I see. Makes sense. Do you know which pandoc version we need? I have `2.9.2.1` > > Look at `./make/conf/jib-profiles.js` in the 11u tree and in current master. Chances are there is no exact Pandoc version that produces the same HTML file _exactly_, but we probably want to have it as close to current version as possible. So that we generate the HTML file once here, and then stick with the particular Pandoc version going forward. Thanks! Found the needed version, I think. Seems to be `1.17.2` https://github.com/openjdk/jdk11u-dev/blob/master/make/devkit/createPandocBundle.sh#L34 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/205 From sgehwolf at openjdk.java.net Mon Aug 9 10:07:02 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 9 Aug 2021 10:07:02 GMT Subject: [jdk11u-dev] RFR: 8251549: Update docs on building for Git [v2] In-Reply-To: References: Message-ID: <9DPQRu9Q9GdpS2rQR_WDhWkpnXKlQB9S_AmnNhjg7RY=.cd27a77b-280c-4004-b32b-a49be8e90895@github.com> > Hi, > > Now that OpenJDK 11u is fully on Git we should update the docs to no longer refer to Mercurial and use Git instead. The JDK 16 patch doesn't apply clean due to some differences in the file (e.g. referring to JDK 8 vs. JDK 11 in head). `doc/building.html` is the result of running `make update-build-docs` when the `building.md` file has the relevant changes. > > Thoughts? Severin Gehwolf has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 042734cc5b17302a8f2ecdf577511bd6d5ec5e22 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/205/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/205/files/cce60747..bbbd50ef Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=205&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=205&range=00-01 Stats: 143 lines in 1 file changed: 3 ins; 29 del; 111 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/205.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/205/head:pull/205 PR: https://git.openjdk.java.net/jdk11u-dev/pull/205 From shade at openjdk.java.net Mon Aug 9 10:07:04 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 9 Aug 2021 10:07:04 GMT Subject: [jdk11u-dev] RFR: 8251549: Update docs on building for Git [v2] In-Reply-To: <9DPQRu9Q9GdpS2rQR_WDhWkpnXKlQB9S_AmnNhjg7RY=.cd27a77b-280c-4004-b32b-a49be8e90895@github.com> References: <9DPQRu9Q9GdpS2rQR_WDhWkpnXKlQB9S_AmnNhjg7RY=.cd27a77b-280c-4004-b32b-a49be8e90895@github.com> Message-ID: On Mon, 9 Aug 2021 10:03:49 GMT, Severin Gehwolf wrote: >> Hi, >> >> Now that OpenJDK 11u is fully on Git we should update the docs to no longer refer to Mercurial and use Git instead. The JDK 16 patch doesn't apply clean due to some differences in the file (e.g. referring to JDK 8 vs. JDK 11 in head). `doc/building.html` is the result of running `make update-build-docs` when the `building.md` file has the relevant changes. >> >> Thoughts? > > Severin Gehwolf has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 042734cc5b17302a8f2ecdf577511bd6d5ec5e22 Thanks! There are a few unrelated hunks still (formatting in cross-compilation tables), but I don't think we need to fret about those. Looks good. ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/205 From sgehwolf at openjdk.java.net Mon Aug 9 10:07:05 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 9 Aug 2021 10:07:05 GMT Subject: [jdk11u-dev] RFR: 8251549: Update docs on building for Git In-Reply-To: References: Message-ID: On Fri, 6 Aug 2021 13:32:43 GMT, Severin Gehwolf wrote: > Hi, > > Now that OpenJDK 11u is fully on Git we should update the docs to no longer refer to Mercurial and use Git instead. The JDK 16 patch doesn't apply clean due to some differences in the file (e.g. referring to JDK 8 vs. JDK 11 in head). `doc/building.html` is the result of running `make update-build-docs` when the `building.md` file has the relevant changes. > > Thoughts? @shade Updated `doc/building.html` with with pandoc `1.17.2` now. Looks clean-ish to me. Thoughts? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/205 From sgehwolf at openjdk.java.net Mon Aug 9 12:39:34 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 9 Aug 2021 12:39:34 GMT Subject: [jdk11u-dev] RFR: 8251549: Update docs on building for Git [v2] In-Reply-To: <9DPQRu9Q9GdpS2rQR_WDhWkpnXKlQB9S_AmnNhjg7RY=.cd27a77b-280c-4004-b32b-a49be8e90895@github.com> References: <9DPQRu9Q9GdpS2rQR_WDhWkpnXKlQB9S_AmnNhjg7RY=.cd27a77b-280c-4004-b32b-a49be8e90895@github.com> Message-ID: On Mon, 9 Aug 2021 10:07:02 GMT, Severin Gehwolf wrote: >> Hi, >> >> Now that OpenJDK 11u is fully on Git we should update the docs to no longer refer to Mercurial and use Git instead. The JDK 16 patch doesn't apply clean due to some differences in the file (e.g. referring to JDK 8 vs. JDK 11 in head). `doc/building.html` is the result of running `make update-build-docs` when the `building.md` file has the relevant changes. >> >> Thoughts? > > Severin Gehwolf has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 042734cc5b17302a8f2ecdf577511bd6d5ec5e22 Thanks for the review! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/205 From zgu at openjdk.java.net Mon Aug 9 13:06:34 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Mon, 9 Aug 2021 13:06:34 GMT Subject: [jdk11u-dev] RFR: 8226319: Add forgotten test/jdk/java/net/httpclient/BodySubscribersTest.java In-Reply-To: <0mMQG-X_NkqpuwLOcYxXiSzqB_bbbdqtwoq4YUKgs5E=.c00b3dd0-9a1a-46e7-8aaf-bac7fa4ea680@github.com> References: <0mMQG-X_NkqpuwLOcYxXiSzqB_bbbdqtwoq4YUKgs5E=.c00b3dd0-9a1a-46e7-8aaf-bac7fa4ea680@github.com> Message-ID: <3JydhdA3PHPCd42UAKxHgvOal0vXIbHzEt_3ahwi0ew=.1cf9caf2-465a-437a-ba65-c60a3d9ba725@github.com> On Thu, 29 Jul 2021 17:30:21 GMT, Zhengyu Gu wrote: > I would like to backport this patch to 11u. This patch contains missing test from JDK-8225583, which is a Oracle parity backport. > > The backport is clean. And the test passes with JDK-8225583. Oops, the patch contains dependency. After rebase, the branch now has conflicts. Close this PR and redo. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/175 From zgu at openjdk.java.net Mon Aug 9 13:06:34 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Mon, 9 Aug 2021 13:06:34 GMT Subject: [jdk11u-dev] Withdrawn: 8226319: Add forgotten test/jdk/java/net/httpclient/BodySubscribersTest.java In-Reply-To: <0mMQG-X_NkqpuwLOcYxXiSzqB_bbbdqtwoq4YUKgs5E=.c00b3dd0-9a1a-46e7-8aaf-bac7fa4ea680@github.com> References: <0mMQG-X_NkqpuwLOcYxXiSzqB_bbbdqtwoq4YUKgs5E=.c00b3dd0-9a1a-46e7-8aaf-bac7fa4ea680@github.com> Message-ID: On Thu, 29 Jul 2021 17:30:21 GMT, Zhengyu Gu wrote: > I would like to backport this patch to 11u. This patch contains missing test from JDK-8225583, which is a Oracle parity backport. > > The backport is clean. And the test passes with JDK-8225583. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/175 From abakhtin at openjdk.java.net Mon Aug 9 13:35:04 2021 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Mon, 9 Aug 2021 13:35:04 GMT Subject: [jdk13u-dev] RFR: 8254631: Better support ALPN byte wire values in SunJSSE Message-ID: <3EzWGG0iSK0P4LXU7yNRkWihFEOcuSS8u50Kj0rnvfo=.f151e39e-d4b0-4f50-abe4-1bb81a889fa9@github.com> Applies cleanly, but the javadoc parts are removed as documented in CSR JDK-8271938 sun/security/ssl/ALPN test passed ------------- Commit messages: - Backport fe5cccc1ec76a5c29b1f55af311823f84483395b Changes: https://git.openjdk.java.net/jdk13u-dev/pull/250/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=250&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8254631 Stats: 345 lines in 3 files changed: 336 ins; 1 del; 8 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/250.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/250/head:pull/250 PR: https://git.openjdk.java.net/jdk13u-dev/pull/250 From zgu at openjdk.java.net Mon Aug 9 13:35:16 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Mon, 9 Aug 2021 13:35:16 GMT Subject: [jdk11u-dev] RFR: 8226319: Add forgotten test/jdk/java/net/httpclient/BodySubscribersTest.java Message-ID: A clean backport to add missing test case of JDK-8225583. ------------- Commit messages: - Backport d577d9c678b9b14227731d9cf7b2328100d66428 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/213/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=213&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8226319 Stats: 159 lines in 1 file changed: 159 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/213.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/213/head:pull/213 PR: https://git.openjdk.java.net/jdk11u-dev/pull/213 From shade at openjdk.java.net Mon Aug 9 15:29:50 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 9 Aug 2021 15:29:50 GMT Subject: [jdk11u-dev] RFR: 8258703: Incorrect 512-bit vector registers restore on x86_32 Message-ID: <95JY36jybqreU4GxyYXAqKQpAkXzfpfHLGRx_miXeQg=.83ebbba2-4c87-451c-9978-d86e6d7d9217@github.com> Currently, there are x86_32 failures in GHA: compiler/runtime/Test7196199.java compiler/runtime/safepoints/TestRegisterRestoring.java compiler/vectorization/TestVectorsNotSavedAtSafepoint.java This backport is supposed to fix at least one of them. ------------- Commit messages: - Backport 216c2ec077447718ae912831647250561a969f4e Changes: https://git.openjdk.java.net/jdk11u-dev/pull/214/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=214&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8258703 Stats: 12 lines in 1 file changed: 6 ins; 5 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/214.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/214/head:pull/214 PR: https://git.openjdk.java.net/jdk11u-dev/pull/214 From shade at openjdk.java.net Mon Aug 9 15:36:36 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 9 Aug 2021 15:36:36 GMT Subject: [jdk11u-dev] RFR: 8226319: Add forgotten test/jdk/java/net/httpclient/BodySubscribersTest.java In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 13:24:06 GMT, Zhengyu Gu wrote: > A clean backport to add missing test case of JDK-8225583. Looks fine. Since it is now a clean backport, it only requires a push approval (jdk11u-fix-yes). ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/213 From vkempik at openjdk.java.net Mon Aug 9 18:43:00 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Mon, 9 Aug 2021 18:43:00 GMT Subject: [jdk11u-dev] RFR: 8248414: AArch64: Remove uses of long and unsigned long ints Message-ID: This is a backport of 8248414 to jdk11u-dev The backport didn't apply clean, partially due to backport of JDK-8247766 It's needed for mac-aarch and win-aarch64 ports It will be followed by 8250824 and 8251930. ------------- Commit messages: - few more long removals - 8248414: AArch64: Remove uses of long and unsigned long ints Changes: https://git.openjdk.java.net/jdk11u-dev/pull/215/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=215&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8248414 Stats: 557 lines in 21 files changed: 322 ins; 9 del; 226 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/215.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/215/head:pull/215 PR: https://git.openjdk.java.net/jdk11u-dev/pull/215 From vkempik at openjdk.java.net Mon Aug 9 19:30:10 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Mon, 9 Aug 2021 19:30:10 GMT Subject: [jdk11u-dev] RFR: 8248414: AArch64: Remove uses of long and unsigned long ints [v2] In-Reply-To: References: Message-ID: > This is a backport of 8248414 to jdk11u-dev > > The backport didn't apply clean, partially due to backport of JDK-8247766 > > It's needed for mac-aarch and win-aarch64 ports > > It will be followed by 8250824 and 8251930. > > Sections of aarch64.ad file between line 10260-12560 were regenerated from aarch64_ad.m4 > > Original commit - https://github.com/openjdk/jdk/commit/c7d84850bfdbd112a495fab453a79832e3810f47 Vladimir Kempik has updated the pull request incrementally with two additional commits since the last revision: - LogicalImmOp update - python file update ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/215/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/215/files/242b7f02..ff1edfc9 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=215&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=215&range=00-01 Stats: 12 lines in 2 files changed: 0 ins; 0 del; 12 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/215.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/215/head:pull/215 PR: https://git.openjdk.java.net/jdk11u-dev/pull/215 From shade at openjdk.java.net Tue Aug 10 08:07:38 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 10 Aug 2021 08:07:38 GMT Subject: [jdk11u-dev] RFR: 8230841: Remove oopDesc::equals() In-Reply-To: References: Message-ID: On Fri, 6 Aug 2021 09:53:57 GMT, Aleksey Shipilev wrote: > This is the second patch in the series to cleanup/revert the GC BarrierSets to most current state. See the dependent ("this issue blocks" links) issues to see what is next. > > The equals APIs were added for Shenandoah GC, in the incarnation that exposed both from- and to-copies to the runtime system (see JDK-8199781). Since then, Shenandoah greatly simplified this by switching to a strong to-space invariant, which obviates the need for this API. Therefore, it was removed in JDK 14. This patch reverts JDK 11 parts to that shape as well, which should simplify 11u maintenance. Paging @rkennke to sanity check this. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/204 From shade at openjdk.java.net Tue Aug 10 09:31:48 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 10 Aug 2021 09:31:48 GMT Subject: [jdk11u-dev] RFR: 8210934: Move sun/net/www/protocol/http/GetErrorStream.java to OpenJDK Message-ID: Backporting to match `11.0.13-oracle`. Additional testing: - [x] New test passes on Linux x86_64 fastdebug ------------- Commit messages: - Backport 3edf95fc4452dfce79d03152a882d03c625a5436 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/217/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=217&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8210934 Stats: 89 lines in 1 file changed: 89 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/217.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/217/head:pull/217 PR: https://git.openjdk.java.net/jdk11u-dev/pull/217 From shade at openjdk.java.net Tue Aug 10 09:41:48 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 10 Aug 2021 09:41:48 GMT Subject: [jdk11u-dev] RFR: 8213235: java/nio/channels/SocketChannel/AsyncCloseChannel.java fails with threads that didn't exit Message-ID: <2-KCwYA5dTZ0fSdEWqtUVRxC5-mliDuRtezNT5VdNqo=.a1833b57-0a98-4828-9d4b-679dd0a9a2e3@github.com> Backporting to match `11.0.13-oracle`. This backport contains two fixes that are done in lock-step with each other. ------------- Commit messages: - Backport a6f0e10fe8fdfe933684e0304f4918e54cb104e7 - Backport 836e02e1f1ef696c73269123e5ec2b71f56fb5ce Changes: https://git.openjdk.java.net/jdk11u-dev/pull/218/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=218&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8213235 Stats: 10 lines in 1 file changed: 3 ins; 1 del; 6 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/218.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/218/head:pull/218 PR: https://git.openjdk.java.net/jdk11u-dev/pull/218 From shade at openjdk.java.net Tue Aug 10 09:47:37 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 10 Aug 2021 09:47:37 GMT Subject: [jdk11u-dev] RFR: 8272197: Update 11u GHA workflow with Shenandoah configurations Message-ID: <1idzbNF_UxWFlXp4bw42XZyErX4KYIvs1W0yUtgTcT8=.6bac8397-370b-4dad-970b-49fc48faf464@github.com> I have noticed that 11u GHA workflow builds/tests without Shenandoah. This is because Shenandoah is not enabled by default in 11u, in contrast to mainline. Which means the workflow that we have picked from mainline does not enable Shenandoah. Instead of changing the build defaults for 11u, I suggest we add Shenandoah configs to testing. Example run: https://github.com/shipilev/jdk11u-dev/runs/3288861982 ------------- Commit messages: - 8272197: Update 11u GHA workflow with Shenandoah configurations Changes: https://git.openjdk.java.net/jdk11u-dev/pull/216/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=216&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272197 Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/216.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/216/head:pull/216 PR: https://git.openjdk.java.net/jdk11u-dev/pull/216 From shade at openjdk.java.net Tue Aug 10 09:53:53 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 10 Aug 2021 09:53:53 GMT Subject: [jdk11u-dev] RFR: 8235216: typo in test filename Message-ID: Clean backport to match `11.0.13-oracle`. Additional testing: - [x] `tools/javac/file` tests pass ------------- Commit messages: - Backport 5eef59d22df7b434093ec26ff8e933ca19d1c070 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/219/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=219&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8235216 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/219.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/219/head:pull/219 PR: https://git.openjdk.java.net/jdk11u-dev/pull/219 From shade at openjdk.java.net Tue Aug 10 09:54:42 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 10 Aug 2021 09:54:42 GMT Subject: [jdk11u-dev] RFR: 8246261: TCKLocalTime.java failed due to "AssertionError: expected [18:14:22] but found [18:14:23]" Message-ID: Clean backport to match 11.0.13-oracle. Additional testing: - [x] Affected test still passes ------------- Commit messages: - Backport d347d2ebf9de415e59d04d68f84074e2c1ea334e Changes: https://git.openjdk.java.net/jdk11u-dev/pull/220/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=220&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8246261 Stats: 31 lines in 3 files changed: 1 ins; 21 del; 9 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/220.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/220/head:pull/220 PR: https://git.openjdk.java.net/jdk11u-dev/pull/220 From sgehwolf at openjdk.java.net Tue Aug 10 10:00:29 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 10 Aug 2021 10:00:29 GMT Subject: [jdk11u-dev] RFR: 8272197: Update 11u GHA workflow with Shenandoah configurations In-Reply-To: <1idzbNF_UxWFlXp4bw42XZyErX4KYIvs1W0yUtgTcT8=.6bac8397-370b-4dad-970b-49fc48faf464@github.com> References: <1idzbNF_UxWFlXp4bw42XZyErX4KYIvs1W0yUtgTcT8=.6bac8397-370b-4dad-970b-49fc48faf464@github.com> Message-ID: On Tue, 10 Aug 2021 07:37:58 GMT, Aleksey Shipilev wrote: > I have noticed that 11u GHA workflow builds/tests without Shenandoah. This is because Shenandoah is not enabled by default in 11u, in contrast to mainline. Which means the workflow that we have picked from mainline does not enable Shenandoah. > > Instead of changing the build defaults for 11u, I suggest we add Shenandoah configs to testing. > > Example run: > https://github.com/shipilev/jdk11u-dev/runs/3288861982 Looks good to me. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/216 From vkempik at openjdk.java.net Tue Aug 10 11:49:00 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 10 Aug 2021 11:49:00 GMT Subject: [jdk15u-dev] RFR: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status Message-ID: Please review this backport to jdk15u, not applying clean due to the different location of thread statuses enum. A rather simple, sanytizing fix for a corner case. ------------- Commit messages: - Backport 7e518f42c9346abdf0c8059b45d3dfef95ed69bb Changes: https://git.openjdk.java.net/jdk15u-dev/pull/90/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=90&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269934 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/90.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/90/head:pull/90 PR: https://git.openjdk.java.net/jdk15u-dev/pull/90 From rkennke at openjdk.java.net Tue Aug 10 12:05:29 2021 From: rkennke at openjdk.java.net (Roman Kennke) Date: Tue, 10 Aug 2021 12:05:29 GMT Subject: [jdk11u-dev] RFR: 8230841: Remove oopDesc::equals() In-Reply-To: References: Message-ID: On Fri, 6 Aug 2021 09:53:57 GMT, Aleksey Shipilev wrote: > This is the second patch in the series to cleanup/revert the GC BarrierSets to most current state. See the dependent ("this issue blocks" links) issues to see what is next. > > The equals APIs were added for Shenandoah GC, in the incarnation that exposed both from- and to-copies to the runtime system (see JDK-8199781). Since then, Shenandoah greatly simplified this by switching to a strong to-space invariant, which obviates the need for this API. Therefore, it was removed in JDK 14. This patch reverts JDK 11 parts to that shape as well, which should simplify 11u maintenance. LGTM. One small comment, I leave this up to you. Thanks! src/hotspot/share/classfile/systemDictionary.cpp line 521: > 519: = ObjectSynchronizer::current_thread_holds_lock((JavaThread*)THREAD, lockObject); > 520: assert(calledholdinglock,"must hold lock for notify"); > 521: assert((lockObject() != _system_loader_lock_obj && !is_parallelCapable(lockObject)), "unexpected double_lock_wait"); I know it's pre-existing, but there is one ( and ) too many. ------------- Marked as reviewed by rkennke (Committer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/204 From dcherepanov at openjdk.java.net Tue Aug 10 13:11:41 2021 From: dcherepanov at openjdk.java.net (Dmitry Cherepanov) Date: Tue, 10 Aug 2021 13:11:41 GMT Subject: [jdk15u-dev] RFR: 8254631: Better support ALPN byte wire values in SunJSSE In-Reply-To: <8LMo2gaCIycAlsW3ytf-ZeGicQwMnG-QOx-i6oS57Qg=.28b3d29c-7fec-4879-bd00-e3594a785fda@github.com> References: <8LMo2gaCIycAlsW3ytf-ZeGicQwMnG-QOx-i6oS57Qg=.28b3d29c-7fec-4879-bd00-e3594a785fda@github.com> Message-ID: On Thu, 5 Aug 2021 10:53:27 GMT, Alexey Bakhtin wrote: > Applies cleanly, but the javadoc parts are removed as documented in CSR JDK-8271938 > sun/security/ssl/ALPN test passed Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/89 From dcherepanov at openjdk.java.net Tue Aug 10 13:16:41 2021 From: dcherepanov at openjdk.java.net (Dmitry Cherepanov) Date: Tue, 10 Aug 2021 13:16:41 GMT Subject: [jdk13u-dev] RFR: 8254631: Better support ALPN byte wire values in SunJSSE In-Reply-To: <3EzWGG0iSK0P4LXU7yNRkWihFEOcuSS8u50Kj0rnvfo=.f151e39e-d4b0-4f50-abe4-1bb81a889fa9@github.com> References: <3EzWGG0iSK0P4LXU7yNRkWihFEOcuSS8u50Kj0rnvfo=.f151e39e-d4b0-4f50-abe4-1bb81a889fa9@github.com> Message-ID: On Mon, 9 Aug 2021 13:28:27 GMT, Alexey Bakhtin wrote: > Applies cleanly, but the javadoc parts are removed as documented in CSR JDK-8271938 > sun/security/ssl/ALPN test passed Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/250 From abakhtin at openjdk.java.net Tue Aug 10 13:37:46 2021 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Tue, 10 Aug 2021 13:37:46 GMT Subject: [jdk15u-dev] Integrated: 8254631: Better support ALPN byte wire values in SunJSSE In-Reply-To: <8LMo2gaCIycAlsW3ytf-ZeGicQwMnG-QOx-i6oS57Qg=.28b3d29c-7fec-4879-bd00-e3594a785fda@github.com> References: <8LMo2gaCIycAlsW3ytf-ZeGicQwMnG-QOx-i6oS57Qg=.28b3d29c-7fec-4879-bd00-e3594a785fda@github.com> Message-ID: On Thu, 5 Aug 2021 10:53:27 GMT, Alexey Bakhtin wrote: > Applies cleanly, but the javadoc parts are removed as documented in CSR JDK-8271938 > sun/security/ssl/ALPN test passed This pull request has now been integrated. Changeset: 9e553f30 Author: Alexey Bakhtin Committer: Dmitry Cherepanov URL: https://git.openjdk.java.net/jdk15u-dev/commit/9e553f30bb5c51a3daa4cfd8c2518ae6d9a03d67 Stats: 345 lines in 3 files changed: 336 ins; 1 del; 8 mod 8254631: Better support ALPN byte wire values in SunJSSE Reviewed-by: dcherepanov Backport-of: fe5cccc1ec76a5c29b1f55af311823f84483395b ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/89 From abakhtin at openjdk.java.net Tue Aug 10 13:39:36 2021 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Tue, 10 Aug 2021 13:39:36 GMT Subject: [jdk13u-dev] Integrated: 8254631: Better support ALPN byte wire values in SunJSSE In-Reply-To: <3EzWGG0iSK0P4LXU7yNRkWihFEOcuSS8u50Kj0rnvfo=.f151e39e-d4b0-4f50-abe4-1bb81a889fa9@github.com> References: <3EzWGG0iSK0P4LXU7yNRkWihFEOcuSS8u50Kj0rnvfo=.f151e39e-d4b0-4f50-abe4-1bb81a889fa9@github.com> Message-ID: <6qC82cRAnRt4z6kIJMj41baFvBym7lW0S02N0sRvGAs=.2c92c2c8-37b1-4369-9c18-f635f6c8a31c@github.com> On Mon, 9 Aug 2021 13:28:27 GMT, Alexey Bakhtin wrote: > Applies cleanly, but the javadoc parts are removed as documented in CSR JDK-8271938 > sun/security/ssl/ALPN test passed This pull request has now been integrated. Changeset: 481b6f8f Author: Alexey Bakhtin Committer: Dmitry Cherepanov URL: https://git.openjdk.java.net/jdk13u-dev/commit/481b6f8f0f0c11371591327dec4a5a52217e034a Stats: 345 lines in 3 files changed: 336 ins; 1 del; 8 mod 8254631: Better support ALPN byte wire values in SunJSSE Reviewed-by: dcherepanov Backport-of: fe5cccc1ec76a5c29b1f55af311823f84483395b ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/250 From abakhtin at openjdk.java.net Tue Aug 10 16:54:06 2021 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Tue, 10 Aug 2021 16:54:06 GMT Subject: [jdk13u-dev] RFR: 8215712: Parsing extension failure may alert decode_error Message-ID: The original patch applies clean. sun/security/ssl and javax/net/ssl tests passed This patch is also required for clean backport of JDK-8206925 ------------- Commit messages: - Backport 36af90acc0f7367c8828319833856ec84d842a1f Changes: https://git.openjdk.java.net/jdk13u-dev/pull/251/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=251&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8215712 Stats: 506 lines in 21 files changed: 77 ins; 193 del; 236 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/251.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/251/head:pull/251 PR: https://git.openjdk.java.net/jdk13u-dev/pull/251 From mbalao at openjdk.java.net Tue Aug 10 20:14:46 2021 From: mbalao at openjdk.java.net (Martin Balao) Date: Tue, 10 Aug 2021 20:14:46 GMT Subject: [jdk11u-dev] RFR: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup Message-ID: <3CKUi_TelBU1v3h0gMy5EAbA77pIcG1KKvwxCZvoPVU=.ade30ddd-9cea-4533-8aba-55f19b4a3b4d@github.com> Hi all, this pull request contains a backport of commit 67869b49 from the openjdk/jdk repository. The commit being backported was authored by Martin Balao on 10 Aug 2021 and was reviewed by Weijun Wang. Thanks! ------------- Commit messages: - Backport 67869b491ae1eaf311dfb8c61a9e94329a822ffc Changes: https://git.openjdk.java.net/jdk11u-dev/pull/221/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=221&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270137 Stats: 97 lines in 3 files changed: 47 ins; 9 del; 41 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/221.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/221/head:pull/221 PR: https://git.openjdk.java.net/jdk11u-dev/pull/221 From shade at openjdk.java.net Wed Aug 11 06:10:29 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 11 Aug 2021 06:10:29 GMT Subject: [jdk11u-dev] RFR: 8230841: Remove oopDesc::equals() In-Reply-To: References: Message-ID: On Tue, 10 Aug 2021 11:58:30 GMT, Roman Kennke wrote: >> This is the second patch in the series to cleanup/revert the GC BarrierSets to most current state. See the dependent ("this issue blocks" links) issues to see what is next. >> >> The equals APIs were added for Shenandoah GC, in the incarnation that exposed both from- and to-copies to the runtime system (see JDK-8199781). Since then, Shenandoah greatly simplified this by switching to a strong to-space invariant, which obviates the need for this API. Therefore, it was removed in JDK 14. This patch reverts JDK 11 parts to that shape as well, which should simplify 11u maintenance. > > src/hotspot/share/classfile/systemDictionary.cpp line 521: > >> 519: = ObjectSynchronizer::current_thread_holds_lock((JavaThread*)THREAD, lockObject); >> 520: assert(calledholdinglock,"must hold lock for notify"); >> 521: assert((lockObject() != _system_loader_lock_obj && !is_parallelCapable(lockObject)), "unexpected double_lock_wait"); > > I know it's pre-existing, but there is one ( and ) too many. Thanks! It is like that in the upstream version (16u), so I would leave it as is. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/204 From shade at openjdk.java.net Wed Aug 11 07:11:04 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 11 Aug 2021 07:11:04 GMT Subject: [jdk11u-dev] RFR: 8214937: sun/security/tools/jarsigner/warnings/NoTimestampTest.java failed due to unexpected expiration date Message-ID: Backporting for `11.0.13-oracle` parity. Additional testing: - [x] Affected test still passes ------------- Commit messages: - Backport 017c702b8ae43b69b47ecc1091e9d4a010b7597d Changes: https://git.openjdk.java.net/jdk11u-dev/pull/223/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=223&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8214937 Stats: 19 lines in 1 file changed: 15 ins; 4 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/223.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/223/head:pull/223 PR: https://git.openjdk.java.net/jdk11u-dev/pull/223 From clanger at openjdk.java.net Wed Aug 11 07:14:57 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 11 Aug 2021 07:14:57 GMT Subject: [jdk11u] RFR: Merge jdk11u-dev:master [v2] In-Reply-To: References: Message-ID: > Weekly merge for jdk-11.0.13+2. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u/pull/5/files - new: https://git.openjdk.java.net/jdk11u/pull/5/files/1faefed2..5f9429b5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=5&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=5&range=00-01 Stats: 719 lines in 30 files changed: 282 ins; 320 del; 117 mod Patch: https://git.openjdk.java.net/jdk11u/pull/5.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/5/head:pull/5 PR: https://git.openjdk.java.net/jdk11u/pull/5 From clanger at openjdk.java.net Wed Aug 11 07:14:58 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 11 Aug 2021 07:14:58 GMT Subject: [jdk11u] Integrated: Merge jdk11u-dev:master In-Reply-To: References: Message-ID: On Thu, 5 Aug 2021 22:29:25 GMT, Christoph Langer wrote: > Weekly merge for jdk-11.0.13+2. This pull request has now been integrated. Changeset: fdbaa230 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u/commit/fdbaa2304d320cf8dde875dc7a575a3f384ab692 Stats: 3800 lines in 68 files changed: 3114 ins; 520 del; 166 mod Merge ------------- PR: https://git.openjdk.java.net/jdk11u/pull/5 From shade at openjdk.java.net Wed Aug 11 07:15:42 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 11 Aug 2021 07:15:42 GMT Subject: [jdk11u-dev] RFR: 8211092: test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java fails intermittently when cleaning up Message-ID: Backporting for `11.0.13-oracle` parity. The 11u patch misses the ProblemList removals, as both the addition and removal only happened in 12. (See JDK-8211099 and dependents). Additional testing: - [x] Affected test still passes ------------- Commit messages: - Backport 20f6faa03049bdb70089dd773686ebc749d4f57a Changes: https://git.openjdk.java.net/jdk11u-dev/pull/224/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=224&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8211092 Stats: 39 lines in 1 file changed: 24 ins; 3 del; 12 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/224.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/224/head:pull/224 PR: https://git.openjdk.java.net/jdk11u-dev/pull/224 From shade at openjdk.java.net Wed Aug 11 07:36:02 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 11 Aug 2021 07:36:02 GMT Subject: [jdk11u-dev] RFR: 8242882: opening jar file with large manifest might throw NegativeArraySizeException Message-ID: Unclean backport to match `11.0.13-oracle`. The uncleanliness is due to ambuity in `JarUtils.createJarFile` that does not have the overload with just `(Path, Path)`, as it was added in later JDKs. I added the `Paths.get(".")` to do the same thing. JarUtils.createJarFile(jarFilePath.toAbsolutePath(), jarSourceRoot, Paths.get(".")); Additional testing: - [x] New test fails without the patch - [x] New test passes with the patch ------------- Commit messages: - Backport 782d45bdec6efdb7e689e0839718ecd7bac2c767 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/225/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=225&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8242882 Stats: 85 lines in 2 files changed: 84 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/225.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/225/head:pull/225 PR: https://git.openjdk.java.net/jdk11u-dev/pull/225 From shade at openjdk.java.net Wed Aug 11 07:39:51 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 11 Aug 2021 07:39:51 GMT Subject: [jdk11u-dev] RFR: 8268776: Test `ADatagramSocket.java` missing /othervm from @run tag Message-ID: Clean backport to match `11.0.13-oracle`. Additional testing: - [x] Affected test still passes ------------- Commit messages: - Backport 7d7bdbe135018f1452fa133b294575014e3e871b Changes: https://git.openjdk.java.net/jdk11u-dev/pull/226/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=226&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268776 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/226.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/226/head:pull/226 PR: https://git.openjdk.java.net/jdk11u-dev/pull/226 From shade at openjdk.java.net Wed Aug 11 07:46:49 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 11 Aug 2021 07:46:49 GMT Subject: [jdk11u-dev] RFR: 8158066: SourceDebugExtensionTest fails to rename file Message-ID: Backporting to match `11.0.13-oracle`. Additional testing: - [x] Linux, test is still passing - [ ] Windows (GHA), test is passing (taken off problem list with this patch) ------------- Commit messages: - Backport b979952d6233c19d7c7a5bd8435c841adeac0de1 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/227/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=227&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8158066 Stats: 25 lines in 3 files changed: 14 ins; 2 del; 9 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/227.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/227/head:pull/227 PR: https://git.openjdk.java.net/jdk11u-dev/pull/227 From shade at openjdk.java.net Wed Aug 11 07:52:47 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 11 Aug 2021 07:52:47 GMT Subject: [jdk11u-dev] RFR: 8210407: Refactor java.util.Calendar:i18n shell tests to plain java tests Message-ID: Backporting for `11.0.13-oracle` parity. Additional testing: - [x] New tests pass on Linux x86_64 - [x] `java/util/Calendar` tests pass - [x] Eyeballing new test outputs ------------- Commit messages: - Backport 533bd0a60425f27fd77a3001b665cf544f20af6f Changes: https://git.openjdk.java.net/jdk11u-dev/pull/228/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=228&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8210407 Stats: 349 lines in 7 files changed: 157 ins; 188 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/228.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/228/head:pull/228 PR: https://git.openjdk.java.net/jdk11u-dev/pull/228 From shade at openjdk.java.net Wed Aug 11 07:55:57 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 11 Aug 2021 07:55:57 GMT Subject: [jdk11u-dev] RFR: 8210406: Refactor java.util.PluggableLocale:i18n shell tests to plain java tests Message-ID: Backporting for `11.0.13-oracle` parity. Additional testing: - [x] New tests pass on Linux x86_64 - [x] `java/util/PluggableLocale` tests pass - [x] Eyeballing new test outputs ------------- Commit messages: - Backport 3c2c6bce0249c0674951338afbc7a310e2b36912 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/229/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=229&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8210406 Stats: 1027 lines in 65 files changed: 274 ins; 625 del; 128 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/229.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/229/head:pull/229 PR: https://git.openjdk.java.net/jdk11u-dev/pull/229 From shade at openjdk.java.net Wed Aug 11 08:05:54 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 11 Aug 2021 08:05:54 GMT Subject: [jdk11u-dev] RFR: 8209768: Refactor java/util/prefs/CheckUserPrefsStorage.sh to plain java test Message-ID: Backporting for `11.0.13-oracle` parity. Additional testing: - [x] New test passes - [x] `java/util/prefs` tests pass - [x] Eyeballing new test output ------------- Commit messages: - Backport f095a9ee49ba0e36e0503b6db1dce81df66f5356 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/230/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=230&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8209768 Stats: 125 lines in 4 files changed: 50 ins; 71 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/230.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/230/head:pull/230 PR: https://git.openjdk.java.net/jdk11u-dev/pull/230 From shade at openjdk.java.net Wed Aug 11 08:11:45 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 11 Aug 2021 08:11:45 GMT Subject: [jdk11u-dev] RFR: 8210908: Refactor java/util/prefs/PrefsSpi.sh to plain java test Message-ID: Backporting for `11.0.13-oracle` parity. This is an unclean backport, because `JarUtils.createJarFile` does not have the overload that accepts only `(Path, Path)`. I fixed it as follows: diff --git a/test/jdk/java/util/prefs/PrefsSpiTest.java b/test/jdk/java/util/prefs/PrefsSpiTest.java index 0369c60cae2..7e5b59ff754 100644 --- a/test/jdk/java/util/prefs/PrefsSpiTest.java +++ b/test/jdk/java/util/prefs/PrefsSpiTest.java @@ -34,6 +34,7 @@ import java.io.File; import java.nio.file.Files; import java.nio.file.Path; +import java.nio.file.Paths; import java.util.ArrayList; import java.util.List; @@ -74,7 +75,7 @@ public class PrefsSpiTest { Files.copy(source, target, REPLACE_EXISTING); } - JarUtils.createJarFile(SPIJAR, xdir); + JarUtils.createJarFile(SPIJAR, xdir, Paths.get(".")); } @DataProvider Additional testing: - [x] New test passes - [x] `java/util/prefs` tests pass - [x] Eyeballing new test output ------------- Commit messages: - Backport 6ce0aeb00b10738b25f0f53ff785bfc099ef28c4 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/231/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=231&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8210908 Stats: 282 lines in 5 files changed: 176 ins; 104 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/231.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/231/head:pull/231 PR: https://git.openjdk.java.net/jdk11u-dev/pull/231 From rkennke at openjdk.java.net Wed Aug 11 10:16:25 2021 From: rkennke at openjdk.java.net (Roman Kennke) Date: Wed, 11 Aug 2021 10:16:25 GMT Subject: [jdk11u-dev] RFR: 8230841: Remove oopDesc::equals() In-Reply-To: References: Message-ID: <7eaVRlK34trrnvBLyoi_rMZk0AhCCJg--a4FJChS8YM=.83e4b34a-fd75-4344-aeae-1995b1ee1271@github.com> On Wed, 11 Aug 2021 06:07:36 GMT, Aleksey Shipilev wrote: > Thanks! It is like that in the upstream version (16u), so I would leave it as is. Ok, I leave that up to you! The change is good to go then! Thanks! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/204 From zgu at openjdk.java.net Wed Aug 11 13:46:01 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 11 Aug 2021 13:46:01 GMT Subject: [jdk11u-dev] RFR: 8226602: Test convenience reactive primitives from java.net.http with RS TCK Message-ID: A clean backport for parity with Oracle 11.0.14. Test: - [x] All new tests passed on Linux x86_64 ------------- Commit messages: - Backport 3395bb591bd55bd7a510b5045c201f3d130b16a2 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/232/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=232&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8226602 Stats: 9984 lines in 57 files changed: 9984 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/232.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/232/head:pull/232 PR: https://git.openjdk.java.net/jdk11u-dev/pull/232 From mbalao at openjdk.java.net Wed Aug 11 19:04:29 2021 From: mbalao at openjdk.java.net (Martin Balao) Date: Wed, 11 Aug 2021 19:04:29 GMT Subject: [jdk11u-dev] Integrated: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup In-Reply-To: <3CKUi_TelBU1v3h0gMy5EAbA77pIcG1KKvwxCZvoPVU=.ade30ddd-9cea-4533-8aba-55f19b4a3b4d@github.com> References: <3CKUi_TelBU1v3h0gMy5EAbA77pIcG1KKvwxCZvoPVU=.ade30ddd-9cea-4533-8aba-55f19b4a3b4d@github.com> Message-ID: On Tue, 10 Aug 2021 20:06:23 GMT, Martin Balao wrote: > Hi all, > > this pull request contains a backport of commit 67869b49 from the openjdk/jdk repository. > > The commit being backported was authored by Martin Balao on 10 Aug 2021 and was reviewed by Weijun Wang. > > Thanks! This pull request has now been integrated. Changeset: bdfc60ab Author: Martin Balao URL: https://git.openjdk.java.net/jdk11u-dev/commit/bdfc60abbd85c1f533b878b058a86164ccacb548 Stats: 97 lines in 3 files changed: 47 ins; 9 del; 41 mod 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup Backport-of: 67869b491ae1eaf311dfb8c61a9e94329a822ffc ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/221 From hohensee at amazon.com Wed Aug 11 20:12:36 2021 From: hohensee at amazon.com (Hohensee, Paul) Date: Wed, 11 Aug 2021 20:12:36 +0000 Subject: [jdk11u-dev] RFR: 8210908: Refactor java/util/prefs/PrefsSpi.sh to plain java test Message-ID: <2E2B2454-84F2-499C-8885-5CF8789DAE27@amazon.com> Lgtm. Thanks, Paul ?-----Original Message----- From: jdk-updates-dev on behalf of Aleksey Shipilev Date: Wednesday, August 11, 2021 at 1:13 AM To: "jdk-updates-dev at openjdk.java.net" Subject: [jdk11u-dev] RFR: 8210908: Refactor java/util/prefs/PrefsSpi.sh to plain java test Backporting for `11.0.13-oracle` parity. This is an unclean backport, because `JarUtils.createJarFile` does not have the overload that accepts only `(Path, Path)`. I fixed it as follows: diff --git a/test/jdk/java/util/prefs/PrefsSpiTest.java b/test/jdk/java/util/prefs/PrefsSpiTest.java index 0369c60cae2..7e5b59ff754 100644 --- a/test/jdk/java/util/prefs/PrefsSpiTest.java +++ b/test/jdk/java/util/prefs/PrefsSpiTest.java @@ -34,6 +34,7 @@ import java.io.File; import java.nio.file.Files; import java.nio.file.Path; +import java.nio.file.Paths; import java.util.ArrayList; import java.util.List; @@ -74,7 +75,7 @@ public class PrefsSpiTest { Files.copy(source, target, REPLACE_EXISTING); } - JarUtils.createJarFile(SPIJAR, xdir); + JarUtils.createJarFile(SPIJAR, xdir, Paths.get(".")); } @DataProvider Additional testing: - [x] New test passes - [x] `java/util/prefs` tests pass - [x] Eyeballing new test output ------------- Commit messages: - Backport 6ce0aeb00b10738b25f0f53ff785bfc099ef28c4 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/231/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=231&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8210908 Stats: 282 lines in 5 files changed: 176 ins; 104 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/231.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/231/head:pull/231 PR: https://git.openjdk.java.net/jdk11u-dev/pull/231 From phh at openjdk.java.net Wed Aug 11 20:22:24 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 11 Aug 2021 20:22:24 GMT Subject: [jdk11u-dev] RFR: 8210908: Refactor java/util/prefs/PrefsSpi.sh to plain java test In-Reply-To: References: Message-ID: <5NiGxl6rjPfypkUHoC2CvzQhcllIQfHw0IsEjDN15W8=.7439f0f8-712c-46e3-88d7-3956dd20c349@github.com> On Wed, 11 Aug 2021 08:05:02 GMT, Aleksey Shipilev wrote: > Backporting for `11.0.13-oracle` parity. > > This is an unclean backport, because `JarUtils.createJarFile` does not have the overload that accepts only `(Path, Path)`. I fixed it as follows: > > > diff --git a/test/jdk/java/util/prefs/PrefsSpiTest.java b/test/jdk/java/util/prefs/PrefsSpiTest.java > index 0369c60cae2..7e5b59ff754 100644 > --- a/test/jdk/java/util/prefs/PrefsSpiTest.java > +++ b/test/jdk/java/util/prefs/PrefsSpiTest.java > @@ -34,6 +34,7 @@ > import java.io.File; > import java.nio.file.Files; > import java.nio.file.Path; > +import java.nio.file.Paths; > import java.util.ArrayList; > import java.util.List; > > @@ -74,7 +75,7 @@ public class PrefsSpiTest { > Files.copy(source, target, REPLACE_EXISTING); > } > > - JarUtils.createJarFile(SPIJAR, xdir); > + JarUtils.createJarFile(SPIJAR, xdir, Paths.get(".")); > } > > @DataProvider > > > Additional testing: > - [x] New test passes > - [x] `java/util/prefs` tests pass > - [x] Eyeballing new test output Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/231 From phh at openjdk.java.net Wed Aug 11 20:26:23 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 11 Aug 2021 20:26:23 GMT Subject: [jdk11u-dev] RFR: 8242882: opening jar file with large manifest might throw NegativeArraySizeException In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 07:29:13 GMT, Aleksey Shipilev wrote: > Unclean backport to match `11.0.13-oracle`. The uncleanliness is due to ambuity in `JarUtils.createJarFile` that does not have the overload with just `(Path, Path)`, as it was added in later JDKs. I added the `Paths.get(".")` to do the same thing. > > > JarUtils.createJarFile(jarFilePath.toAbsolutePath(), jarSourceRoot, Paths.get(".")); > > > Additional testing: > - [x] New test fails without the patch > - [x] New test passes with the patch Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/225 From phh at openjdk.java.net Wed Aug 11 21:58:29 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 11 Aug 2021 21:58:29 GMT Subject: [jdk11u-dev] RFR: 8211092: test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java fails intermittently when cleaning up In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 07:08:33 GMT, Aleksey Shipilev wrote: > Backporting for `11.0.13-oracle` parity. The 11u patch misses the ProblemList removals, as both the addition and removal only happened in 12. (See JDK-8211099 and dependents). > > Additional testing: > - [x] Affected test still passes Marked as reviewed by phh (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/224 From phh at openjdk.java.net Wed Aug 11 22:02:39 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 11 Aug 2021 22:02:39 GMT Subject: [jdk15u-dev] RFR: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status In-Reply-To: References: Message-ID: On Tue, 10 Aug 2021 11:42:26 GMT, Vladimir Kempik wrote: > Please review this backport to jdk15u, not applying clean due to the different location of > thread statuses enum. > A rather simple, sanytizing fix for a corner case. Marked as reviewed by phh (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/90 From phh at openjdk.java.net Wed Aug 11 22:07:24 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 11 Aug 2021 22:07:24 GMT Subject: [jdk11u-dev] RFR: 8213235: java/nio/channels/SocketChannel/AsyncCloseChannel.java fails with threads that didn't exit In-Reply-To: <2-KCwYA5dTZ0fSdEWqtUVRxC5-mliDuRtezNT5VdNqo=.a1833b57-0a98-4828-9d4b-679dd0a9a2e3@github.com> References: <2-KCwYA5dTZ0fSdEWqtUVRxC5-mliDuRtezNT5VdNqo=.a1833b57-0a98-4828-9d4b-679dd0a9a2e3@github.com> Message-ID: On Tue, 10 Aug 2021 09:35:16 GMT, Aleksey Shipilev wrote: > Backporting to match `11.0.13-oracle`. This backport contains two fixes that are done in lock-step with each other. Marked as reviewed by phh (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/218 From phh at openjdk.java.net Wed Aug 11 23:37:24 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 11 Aug 2021 23:37:24 GMT Subject: [jdk11u-dev] RFR: 8248414: AArch64: Remove uses of long and unsigned long ints [v2] In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 19:30:10 GMT, Vladimir Kempik wrote: >> This is a backport of 8248414 to jdk11u-dev >> >> The backport didn't apply clean, partially due to backport of JDK-8247766 >> >> It's needed for mac-aarch and win-aarch64 ports >> >> It will be followed by 8250824 and 8251930. >> >> Sections of aarch64.ad file between line 10260-12560 were regenerated from aarch64_ad.m4 >> >> Original commit - https://github.com/openjdk/jdk/commit/c7d84850bfdbd112a495fab453a79832e3810f47 > > Vladimir Kempik has updated the pull request incrementally with two additional commits since the last revision: > > - LogicalImmOp update > - python file update Marked as reviewed by phh (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/215 From phh at openjdk.java.net Wed Aug 11 23:54:25 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 11 Aug 2021 23:54:25 GMT Subject: [jdk11u-dev] RFR: 8237354: Add option to jcmd to write a gzipped heap dump In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 07:08:36 GMT, BuddyLiao wrote: > Backport of the heap dump enhancement: Add option to jcmd to write a gzipped heap dump > > Patch did not apply cleanly, I had to resolve/modify > > src/hotspot/share/services/heapDumper.cpp > src/hotspot/share/services/heapDumperCompression.cpp > src/hotspot/share/services/heapDumperCompression.hpp > > I have built it on linux x86_64 and run test-tier1 Can you elaborate on what you had to change in the modified files? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/209 From shade at openjdk.java.net Thu Aug 12 08:22:51 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 12 Aug 2021 08:22:51 GMT Subject: [jdk11u-dev] RFR: 8252194: Add automated test for fix done in JDK-8218469 Message-ID: Clean backport to match `11.0.13-oracle`. Additional testing: - [x] New test passes on Linux/GTK3 ------------- Commit messages: - Backport 1ae6b533fbba433e64868aa3b6846041e3a91136 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/233/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=233&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8252194 Stats: 148 lines in 1 file changed: 148 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/233.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/233/head:pull/233 PR: https://git.openjdk.java.net/jdk11u-dev/pull/233 From shade at openjdk.java.net Thu Aug 12 08:26:43 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 12 Aug 2021 08:26:43 GMT Subject: [jdk11u-dev] RFR: 8251254: Add automated test for fix done in JDK-8218472 Message-ID: Clean backport to match `11.0.13-oracle`. Additional testing: - [x] New test passes on Linux/GTK3 ------------- Commit messages: - Backport 8bf5b1d18b951df92f47661a124723678979cf04 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/234/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=234&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8251254 Stats: 146 lines in 1 file changed: 146 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/234.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/234/head:pull/234 PR: https://git.openjdk.java.net/jdk11u-dev/pull/234 From shade at openjdk.java.net Thu Aug 12 08:30:37 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 12 Aug 2021 08:30:37 GMT Subject: [jdk11u-dev] RFR: 8252825: Add automated test for fix done in JDK-8218479 Message-ID: <49kMSO0dYOFp_u9dt54f8OblRKju745Jb405Ngdhz-Y=.c4b4cec1-317a-44f2-a41a-1440fc42c383@github.com> Clean backport. Additional testing: - [x] New test passes on Linux/GTK3 ------------- Commit messages: - Backport 55c7e769c801f95f1c457fecdfbf07bace0a194f Changes: https://git.openjdk.java.net/jdk11u-dev/pull/235/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=235&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8252825 Stats: 140 lines in 1 file changed: 140 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/235.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/235/head:pull/235 PR: https://git.openjdk.java.net/jdk11u-dev/pull/235 From shade at openjdk.java.net Thu Aug 12 08:35:50 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 12 Aug 2021 08:35:50 GMT Subject: [jdk11u-dev] RFR: 8251252: Add automated testcase for fix done in JDK-8214253 Message-ID: Clean backport. Additional testing: - [x] New test still passes ------------- Commit messages: - Backport b6c861f9f8c8558ed6dc727d3379e58411d8f3f0 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/236/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=236&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8251252 Stats: 194 lines in 1 file changed: 194 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/236.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/236/head:pull/236 PR: https://git.openjdk.java.net/jdk11u-dev/pull/236 From shade at openjdk.java.net Thu Aug 12 08:39:39 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 12 Aug 2021 08:39:39 GMT Subject: [jdk11u-dev] RFR: 8251166: Add automated testcases for changes done in JDK-8214112 Message-ID: Clean backport. Additional testing: - [x] New tests pass on Linux/GTK3 ------------- Commit messages: - Backport a0d6a8a1741489103d8448a1cd33626b6ac39cc9 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/237/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=237&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8251166 Stats: 469 lines in 3 files changed: 469 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/237.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/237/head:pull/237 PR: https://git.openjdk.java.net/jdk11u-dev/pull/237 From shade at openjdk.java.net Thu Aug 12 08:50:46 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 12 Aug 2021 08:50:46 GMT Subject: [jdk11u-dev] RFR: 8214195: Align stdout messages in test/jdk/java/math/BigInteger/PrimitiveConversionTests.java Message-ID: Clean backport. Additional testing: - [x] Affected test still passes ------------- Commit messages: - Backport 389a110e56a250ff1c2f8728059a88c052d7b803 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/238/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=238&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8214195 Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/238.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/238/head:pull/238 PR: https://git.openjdk.java.net/jdk11u-dev/pull/238 From dcherepanov at openjdk.java.net Thu Aug 12 09:11:28 2021 From: dcherepanov at openjdk.java.net (Dmitry Cherepanov) Date: Thu, 12 Aug 2021 09:11:28 GMT Subject: [jdk13u-dev] RFR: 8215712: Parsing extension failure may alert decode_error In-Reply-To: References: Message-ID: <_6ggNYf4QZpbFrbH5BIo62L3YjmJiAolvQsTn58jNiM=.4f524809-851c-4522-a0ce-7bbc1cb25154@github.com> On Tue, 10 Aug 2021 16:46:01 GMT, Alexey Bakhtin wrote: > The original patch applies clean. > sun/security/ssl and javax/net/ssl tests passed > > This patch is also required for clean backport of JDK-8206925 Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/251 From abakhtin at openjdk.java.net Thu Aug 12 09:46:40 2021 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Thu, 12 Aug 2021 09:46:40 GMT Subject: [jdk13u-dev] Integrated: 8215712: Parsing extension failure may alert decode_error In-Reply-To: References: Message-ID: On Tue, 10 Aug 2021 16:46:01 GMT, Alexey Bakhtin wrote: > The original patch applies clean. > sun/security/ssl and javax/net/ssl tests passed > > This patch is also required for clean backport of JDK-8206925 This pull request has now been integrated. Changeset: 9fe85883 Author: Alexey Bakhtin Committer: Dmitry Cherepanov URL: https://git.openjdk.java.net/jdk13u-dev/commit/9fe85883b6a35877fb5017db397e4f393367c2c8 Stats: 506 lines in 21 files changed: 77 ins; 193 del; 236 mod 8215712: Parsing extension failure may alert decode_error Reviewed-by: dcherepanov Backport-of: 36af90acc0f7367c8828319833856ec84d842a1f ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/251 From shade at openjdk.java.net Thu Aug 12 10:27:37 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 12 Aug 2021 10:27:37 GMT Subject: [jdk11u-dev] RFR: 8225082: Remove IdenTrust certificate that is expiring in September 2021 Message-ID: Backport to match `11.0.13-oracle`. There is a conflict in `@bug` line in the test: the bug IDs are in different order. I took the liberty to change the order match the incoming patch, which would simplify future backports here. Additional testing: - [x] `VerifyCACerts` test passes ------------- Commit messages: - Backport 2ec45dc2dd3a6bcb4f68ee7cde5858d63614305a Changes: https://git.openjdk.java.net/jdk11u-dev/pull/239/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=239&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8225082 Stats: 34 lines in 2 files changed: 0 ins; 31 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/239.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/239/head:pull/239 PR: https://git.openjdk.java.net/jdk11u-dev/pull/239 From abakhtin at openjdk.java.net Thu Aug 12 11:11:52 2021 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Thu, 12 Aug 2021 11:11:52 GMT Subject: [jdk13u-dev] RFR: 8206925: Support the certificate_authorities extension Message-ID: <06w-1jef7atcL_-odlEb79tOjk9MYrK-ZUsqhk4mrlw=.b6b6db52-f69a-4742-b03e-3d9c2b67b3c7@github.com> I'd like to backport it to 13u as soon as it is in 8u and 11u already Applied cleanly All sun/security/ssl javax/net/ssl tests (including 3 new tests) are passed ------------- Commit messages: - Backport 17a298962c35d5c8ebae73fdb8a969139551b5a7 Changes: https://git.openjdk.java.net/jdk13u-dev/pull/252/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=252&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8206925 Stats: 1135 lines in 8 files changed: 1037 ins; 46 del; 52 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/252.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/252/head:pull/252 PR: https://git.openjdk.java.net/jdk13u-dev/pull/252 From shade at openjdk.java.net Thu Aug 12 11:12:36 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 12 Aug 2021 11:12:36 GMT Subject: [jdk11u-dev] RFR: 8254850: Update terminology in java.awt.GridBagLayout source code comments Message-ID: Clean backport to match `11.0.13-oracle`. ------------- Commit messages: - Backport 9ed0b7640338194365f7d8a53bc2df3b0c96e821 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/240/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=240&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8254850 Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/240.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/240/head:pull/240 PR: https://git.openjdk.java.net/jdk11u-dev/pull/240 From phh at openjdk.java.net Thu Aug 12 13:10:24 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Thu, 12 Aug 2021 13:10:24 GMT Subject: [jdk11u-dev] RFR: 8225082: Remove IdenTrust certificate that is expiring in September 2021 In-Reply-To: References: Message-ID: On Thu, 12 Aug 2021 10:18:54 GMT, Aleksey Shipilev wrote: > Backport to match `11.0.13-oracle`. There is a conflict in `@bug` line in the test: the bug IDs are in different order. I took the liberty to change the order match the incoming patch, which would simplify future backports here. > > Additional testing: > - [x] `VerifyCACerts` test passes Marked as reviewed by phh (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/239 From sgehwolf at openjdk.java.net Thu Aug 12 15:31:31 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Thu, 12 Aug 2021 15:31:31 GMT Subject: [jdk11u-dev] RFR: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux Message-ID: Please review this backport of JDK-8255790 which fixes a crash of simple FileDialog-using apps on some systems (for example F34 when not using system harfbuzz). See JDK-8272149. In a nutshell, this patch is a not quite complete revert of JDK-8249821. I.e. the OpenJDK 11u version of it. It does not revert the source code re-structuring, though. The JDK 17 patch doesn't apply clean. I've mostly hand-picked changes from the original patch. Note that JDK-8272332 is included in this backport. The differences mostly stem from differences in DISABLED_WARNINGS_ settings when BUILD_FONTMANAGER is being called. Testing: Build on an affected system with/without --with-harfbuzz=system. Reproducer from JDK-8272149 (crashes before, passes after) ------------- Commit messages: - Backport 05fe06a6bafc089c6466ccbdea335e5dbfdaf335 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/241/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=241&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8255790 Stats: 98 lines in 1 file changed: 5 ins; 64 del; 29 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/241.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/241/head:pull/241 PR: https://git.openjdk.java.net/jdk11u-dev/pull/241 From sgehwolf at openjdk.java.net Thu Aug 12 15:51:45 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Thu, 12 Aug 2021 15:51:45 GMT Subject: [jdk17u] RFR: 8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790 Message-ID: Hi, This pull request contains a backport of commit d38b3143 from the openjdk/jdk repository. The issue applies to JDK 17 as well. The commit being backported was authored by Severin Gehwolf on 12 Aug 2021 and was reviewed by Phil Race. ------------- Commit messages: - Backport d38b31438dd4730ee2149c02277d60c35b9d7d81 Changes: https://git.openjdk.java.net/jdk17u/pull/11/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=11&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272332 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u/pull/11.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/11/head:pull/11 PR: https://git.openjdk.java.net/jdk17u/pull/11 From kvn at openjdk.java.net Thu Aug 12 19:35:00 2021 From: kvn at openjdk.java.net (Vladimir Kozlov) Date: Thu, 12 Aug 2021 19:35:00 GMT Subject: [jdk17u] RFR: 8271589: fatal error with variable shift count integer rotate operation. Message-ID: 8271589: fatal error with variable shift count integer rotate operation. Reviewed-by: kvn, sviswanathan ------------- Commit messages: - 8271589: fatal error with variable shift count integer rotate operation. Changes: https://git.openjdk.java.net/jdk17u/pull/12/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=12&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271589 Stats: 103 lines in 3 files changed: 91 ins; 2 del; 10 mod Patch: https://git.openjdk.java.net/jdk17u/pull/12.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/12/head:pull/12 PR: https://git.openjdk.java.net/jdk17u/pull/12 From kvn at openjdk.java.net Fri Aug 13 00:10:45 2021 From: kvn at openjdk.java.net (Vladimir Kozlov) Date: Fri, 13 Aug 2021 00:10:45 GMT Subject: [jdk17u] Integrated: 8271589: fatal error with variable shift count integer rotate operation. In-Reply-To: References: Message-ID: On Thu, 12 Aug 2021 19:28:07 GMT, Vladimir Kozlov wrote: > 8271589: fatal error with variable shift count integer rotate operation. > > Reviewed-by: kvn, sviswanathan This pull request has now been integrated. Changeset: 9c213825 Author: Vladimir Kozlov URL: https://git.openjdk.java.net/jdk17u/commit/9c213825ae635e2e84af777bc7136d7614060743 Stats: 103 lines in 3 files changed: 91 ins; 2 del; 10 mod 8271589: fatal error with variable shift count integer rotate operation. Backport-of: 392fcc9df7e1547672f727e8fdc8de73ffdfe534 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/12 From shade at openjdk.java.net Fri Aug 13 06:53:32 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 06:53:32 GMT Subject: [jdk11u-dev] RFR: 8252825: Add automated test for fix done in JDK-8218479 In-Reply-To: <49kMSO0dYOFp_u9dt54f8OblRKju745Jb405Ngdhz-Y=.c4b4cec1-317a-44f2-a41a-1440fc42c383@github.com> References: <49kMSO0dYOFp_u9dt54f8OblRKju745Jb405Ngdhz-Y=.c4b4cec1-317a-44f2-a41a-1440fc42c383@github.com> Message-ID: On Thu, 12 Aug 2021 08:22:22 GMT, Aleksey Shipilev wrote: > Clean backport. > > Additional testing: > - [x] New test passes on Linux/GTK3 Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/235 From shade at openjdk.java.net Fri Aug 13 06:54:38 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 06:54:38 GMT Subject: [jdk11u-dev] RFR: 8214195: Align stdout messages in test/jdk/java/math/BigInteger/PrimitiveConversionTests.java In-Reply-To: References: Message-ID: On Thu, 12 Aug 2021 08:40:13 GMT, Aleksey Shipilev wrote: > Clean backport. > > Additional testing: > - [x] Affected test still passes Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/238 From shade at openjdk.java.net Fri Aug 13 06:54:40 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 06:54:40 GMT Subject: [jdk11u-dev] RFR: 8251166: Add automated testcases for changes done in JDK-8214112 In-Reply-To: References: Message-ID: <9z1bKXcdKnfP5SftSVp3vUH0LnEfZAJ79nnJW5w7PKU=.2db5eb41-cead-4b9f-ab0b-45785eb3178d@github.com> On Thu, 12 Aug 2021 08:32:07 GMT, Aleksey Shipilev wrote: > Clean backport. > > Additional testing: > - [x] New tests pass on Linux/GTK3 Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/237 From shade at openjdk.java.net Fri Aug 13 06:54:39 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 06:54:39 GMT Subject: [jdk11u-dev] Integrated: 8214195: Align stdout messages in test/jdk/java/math/BigInteger/PrimitiveConversionTests.java In-Reply-To: References: Message-ID: <_5k2c01Dt05QijFXP8B0gRlGkMSbVL2FdZ-p4LsJvG8=.2267e8b1-53f1-4f1c-964c-a33b2e412b6d@github.com> On Thu, 12 Aug 2021 08:40:13 GMT, Aleksey Shipilev wrote: > Clean backport. > > Additional testing: > - [x] Affected test still passes This pull request has now been integrated. Changeset: b117eccd Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/b117eccddf1dd401bdb8925b53cd222bf82b5b1a Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod 8214195: Align stdout messages in test/jdk/java/math/BigInteger/PrimitiveConversionTests.java Backport-of: 389a110e56a250ff1c2f8728059a88c052d7b803 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/238 From shade at openjdk.java.net Fri Aug 13 06:54:41 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 06:54:41 GMT Subject: [jdk11u-dev] Integrated: 8251166: Add automated testcases for changes done in JDK-8214112 In-Reply-To: References: Message-ID: On Thu, 12 Aug 2021 08:32:07 GMT, Aleksey Shipilev wrote: > Clean backport. > > Additional testing: > - [x] New tests pass on Linux/GTK3 This pull request has now been integrated. Changeset: 0459ea5b Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/0459ea5b645178bffe8dfa2910a7606c644cf5b5 Stats: 469 lines in 3 files changed: 469 ins; 0 del; 0 mod 8251166: Add automated testcases for changes done in JDK-8214112 Backport-of: a0d6a8a1741489103d8448a1cd33626b6ac39cc9 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/237 From shade at openjdk.java.net Fri Aug 13 06:55:39 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 06:55:39 GMT Subject: [jdk11u-dev] RFR: 8251254: Add automated test for fix done in JDK-8218472 In-Reply-To: References: Message-ID: <-qnnBT2c3QUpu6nV5gDVk0SbuKjo17zlFqUToTLFPS0=.0b7b7856-532e-4793-a3b1-3805d5ee8588@github.com> On Thu, 12 Aug 2021 08:17:58 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. > > Additional testing: > - [x] New test passes on Linux/GTK3 Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/234 From shade at openjdk.java.net Fri Aug 13 06:55:41 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 06:55:41 GMT Subject: [jdk11u-dev] Integrated: 8251254: Add automated test for fix done in JDK-8218472 In-Reply-To: References: Message-ID: <7n6ceyCrgLWR35QKJexPf857Bd2Dp5qTNUiWtuQSyPE=.82e927bd-74de-478d-bd61-9549ded90ab6@github.com> On Thu, 12 Aug 2021 08:17:58 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. > > Additional testing: > - [x] New test passes on Linux/GTK3 This pull request has now been integrated. Changeset: 1a7a9d8f Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/1a7a9d8fc047ae16eb0d71aba842ea161d0dac96 Stats: 146 lines in 1 file changed: 146 ins; 0 del; 0 mod 8251254: Add automated test for fix done in JDK-8218472 Backport-of: 8bf5b1d18b951df92f47661a124723678979cf04 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/234 From shade at openjdk.java.net Fri Aug 13 06:56:31 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 06:56:31 GMT Subject: [jdk11u-dev] Integrated: 8252825: Add automated test for fix done in JDK-8218479 In-Reply-To: <49kMSO0dYOFp_u9dt54f8OblRKju745Jb405Ngdhz-Y=.c4b4cec1-317a-44f2-a41a-1440fc42c383@github.com> References: <49kMSO0dYOFp_u9dt54f8OblRKju745Jb405Ngdhz-Y=.c4b4cec1-317a-44f2-a41a-1440fc42c383@github.com> Message-ID: On Thu, 12 Aug 2021 08:22:22 GMT, Aleksey Shipilev wrote: > Clean backport. > > Additional testing: > - [x] New test passes on Linux/GTK3 This pull request has now been integrated. Changeset: 7109ca2d Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/7109ca2d6ed585d8233617e3bbb4da8cedb52faa Stats: 140 lines in 1 file changed: 140 ins; 0 del; 0 mod 8252825: Add automated test for fix done in JDK-8218479 Backport-of: 55c7e769c801f95f1c457fecdfbf07bace0a194f ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/235 From shade at openjdk.java.net Fri Aug 13 06:57:30 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 06:57:30 GMT Subject: [jdk11u-dev] RFR: 8251252: Add automated testcase for fix done in JDK-8214253 In-Reply-To: References: Message-ID: On Thu, 12 Aug 2021 08:26:21 GMT, Aleksey Shipilev wrote: > Clean backport. > > Additional testing: > - [x] New test still passes Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/236 From shade at openjdk.java.net Fri Aug 13 06:57:32 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 06:57:32 GMT Subject: [jdk11u-dev] Integrated: 8251252: Add automated testcase for fix done in JDK-8214253 In-Reply-To: References: Message-ID: On Thu, 12 Aug 2021 08:26:21 GMT, Aleksey Shipilev wrote: > Clean backport. > > Additional testing: > - [x] New test still passes This pull request has now been integrated. Changeset: d2d4db52 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/d2d4db522d6798907d5f002cca794c3ac84cde74 Stats: 194 lines in 1 file changed: 194 ins; 0 del; 0 mod 8251252: Add automated testcase for fix done in JDK-8214253 Backport-of: b6c861f9f8c8558ed6dc727d3379e58411d8f3f0 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/236 From shade at openjdk.java.net Fri Aug 13 06:59:27 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 06:59:27 GMT Subject: [jdk11u-dev] RFR: 8213694: Test Timeout.java should run in othervm mode In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 06:44:09 GMT, Aleksey Shipilev wrote: > Clean backport, matches 11.0.13-oracle. Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/207 From shade at openjdk.java.net Fri Aug 13 06:59:27 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 06:59:27 GMT Subject: [jdk11u-dev] Integrated: 8213694: Test Timeout.java should run in othervm mode In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 06:44:09 GMT, Aleksey Shipilev wrote: > Clean backport, matches 11.0.13-oracle. This pull request has now been integrated. Changeset: 94b633aa Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/94b633aad628950d66df9d6704e48d23da3dee0c Stats: 25 lines in 1 file changed: 4 ins; 6 del; 15 mod 8213694: Test Timeout.java should run in othervm mode Backport-of: 1b20a6781f3132ee1f23c795ed24dbf5e2d59b79 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/207 From shade at openjdk.java.net Fri Aug 13 06:59:29 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 06:59:29 GMT Subject: [jdk11u-dev] RFR: 8252194: Add automated test for fix done in JDK-8218469 In-Reply-To: References: Message-ID: <7r0WYv0J7vGFMH_MoxK8_AE7WAGq98JDLPFeTOqlNqo=.ffb2131d-7225-4148-a808-75bb8e41d304@github.com> On Thu, 12 Aug 2021 08:13:34 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. > > Additional testing: > - [x] New test passes on Linux/GTK3 Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/233 From shade at openjdk.java.net Fri Aug 13 06:59:31 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 06:59:31 GMT Subject: [jdk11u-dev] Integrated: 8252194: Add automated test for fix done in JDK-8218469 In-Reply-To: References: Message-ID: On Thu, 12 Aug 2021 08:13:34 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. > > Additional testing: > - [x] New test passes on Linux/GTK3 This pull request has now been integrated. Changeset: 9fec49cf Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/9fec49cf74142dcc9260a2de3780f9c4394154c3 Stats: 148 lines in 1 file changed: 148 ins; 0 del; 0 mod 8252194: Add automated test for fix done in JDK-8218469 Backport-of: 1ae6b533fbba433e64868aa3b6846041e3a91136 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/233 From shade at openjdk.java.net Fri Aug 13 07:01:37 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:01:37 GMT Subject: [jdk11u-dev] RFR: 8251361: Potential race between Logger configuration and GCs in HttpURLConWithProxy test In-Reply-To: References: Message-ID: <24-2yyHB5msiwwd2k7vDy-TcNfUAjDRiKsFIJx-ldms=.f8bd98b4-d2b1-4201-bd16-ade1f2020c96@github.com> On Mon, 9 Aug 2021 06:54:38 GMT, Aleksey Shipilev wrote: > This backport is simple, but it does not apply cleanly to 11u due to context conflict with "8227539: Replace wildcard address with loopback or local host in tests - part 20". It brought `throws Exception` to `main` method. I resolved that conflict by hand. > > Additional testing: > - [x] Affected test still passes Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/208 From shade at openjdk.java.net Fri Aug 13 07:01:37 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:01:37 GMT Subject: [jdk11u-dev] Integrated: 8251361: Potential race between Logger configuration and GCs in HttpURLConWithProxy test In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 06:54:38 GMT, Aleksey Shipilev wrote: > This backport is simple, but it does not apply cleanly to 11u due to context conflict with "8227539: Replace wildcard address with loopback or local host in tests - part 20". It brought `throws Exception` to `main` method. I resolved that conflict by hand. > > Additional testing: > - [x] Affected test still passes This pull request has now been integrated. Changeset: d8e1e62d Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/d8e1e62de0f1077c5a8cc61369931326691b9fef Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod 8251361: Potential race between Logger configuration and GCs in HttpURLConWithProxy test Keep a static reference to the logger to prevent its inadvertent garbage collection while the test is running. Backport-of: ed5696dd2ce318b2480c96b5eeaf319853ce5d89 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/208 From shade at openjdk.java.net Fri Aug 13 07:03:28 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:03:28 GMT Subject: [jdk11u-dev] RFR: 8236413: AbstractConnectTimeout should tolerate both NoRouteToHostException and UnresolvedAddressException In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 08:16:44 GMT, Aleksey Shipilev wrote: > Backporting this for `11.0.14-oracle` parity. > > Additional testing: > - [x] `java/net/httpclient` tests still pass Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/210 From shade at openjdk.java.net Fri Aug 13 07:03:29 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:03:29 GMT Subject: [jdk11u-dev] Integrated: 8236413: AbstractConnectTimeout should tolerate both NoRouteToHostException and UnresolvedAddressException In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 08:16:44 GMT, Aleksey Shipilev wrote: > Backporting this for `11.0.14-oracle` parity. > > Additional testing: > - [x] `java/net/httpclient` tests still pass This pull request has now been integrated. Changeset: d24982fc Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/d24982fc8b45ffef7c666b757f9340154de05d8c Stats: 14 lines in 1 file changed: 7 ins; 0 del; 7 mod 8236413: AbstractConnectTimeout should tolerate both NoRouteToHostException and UnresolvedAddressException Backport-of: fab6158c198dd6b363bfb36e5a18107214bb134d ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/210 From shade at openjdk.java.net Fri Aug 13 07:04:26 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:04:26 GMT Subject: [jdk11u-dev] RFR: 8258703: Incorrect 512-bit vector registers restore on x86_32 In-Reply-To: <95JY36jybqreU4GxyYXAqKQpAkXzfpfHLGRx_miXeQg=.83ebbba2-4c87-451c-9978-d86e6d7d9217@github.com> References: <95JY36jybqreU4GxyYXAqKQpAkXzfpfHLGRx_miXeQg=.83ebbba2-4c87-451c-9978-d86e6d7d9217@github.com> Message-ID: On Mon, 9 Aug 2021 15:20:55 GMT, Aleksey Shipilev wrote: > Currently, there are x86_32 failures in GHA: > > > compiler/runtime/Test7196199.java > compiler/runtime/safepoints/TestRegisterRestoring.java > compiler/vectorization/TestVectorsNotSavedAtSafepoint.java > > > This backport is supposed to fix all three of them. Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/214 From shade at openjdk.java.net Fri Aug 13 07:04:27 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:04:27 GMT Subject: [jdk11u-dev] Integrated: 8258703: Incorrect 512-bit vector registers restore on x86_32 In-Reply-To: <95JY36jybqreU4GxyYXAqKQpAkXzfpfHLGRx_miXeQg=.83ebbba2-4c87-451c-9978-d86e6d7d9217@github.com> References: <95JY36jybqreU4GxyYXAqKQpAkXzfpfHLGRx_miXeQg=.83ebbba2-4c87-451c-9978-d86e6d7d9217@github.com> Message-ID: On Mon, 9 Aug 2021 15:20:55 GMT, Aleksey Shipilev wrote: > Currently, there are x86_32 failures in GHA: > > > compiler/runtime/Test7196199.java > compiler/runtime/safepoints/TestRegisterRestoring.java > compiler/vectorization/TestVectorsNotSavedAtSafepoint.java > > > This backport is supposed to fix all three of them. This pull request has now been integrated. Changeset: 8e63ecb8 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/8e63ecb8f0f428e83470312df3657f8480634115 Stats: 12 lines in 1 file changed: 6 ins; 5 del; 1 mod 8258703: Incorrect 512-bit vector registers restore on x86_32 Backport-of: 216c2ec077447718ae912831647250561a969f4e ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/214 From shade at openjdk.java.net Fri Aug 13 07:07:24 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:07:24 GMT Subject: [jdk11u-dev] RFR: 8210669: Some launcher tests assume a pre-JDK 9 run-time image layout In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 08:45:19 GMT, Aleksey Shipilev wrote: > Backporting for `11.0.13-oracle` parity. > > Additional testing: > - [x] `tools/launcher/` pass Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/211 From shade at openjdk.java.net Fri Aug 13 07:07:24 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:07:24 GMT Subject: [jdk11u-dev] Integrated: 8210669: Some launcher tests assume a pre-JDK 9 run-time image layout In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 08:45:19 GMT, Aleksey Shipilev wrote: > Backporting for `11.0.13-oracle` parity. > > Additional testing: > - [x] `tools/launcher/` pass This pull request has now been integrated. Changeset: 270786f6 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/270786f60aa2a729a059ef6008f0f3743d8c1e68 Stats: 26 lines in 3 files changed: 11 ins; 6 del; 9 mod 8210669: Some launcher tests assume a pre-JDK 9 run-time image layout Backport-of: 6bc30c6707aed5e5f444def64b296c0eb9021863 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/211 From shade at openjdk.java.net Fri Aug 13 07:13:29 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:13:29 GMT Subject: [jdk11u-dev] RFR: 8210934: Move sun/net/www/protocol/http/GetErrorStream.java to OpenJDK In-Reply-To: References: Message-ID: On Tue, 10 Aug 2021 09:23:25 GMT, Aleksey Shipilev wrote: > Backporting to match `11.0.13-oracle`. > > Additional testing: > - [x] New test passes on Linux x86_64 fastdebug Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/217 From shade at openjdk.java.net Fri Aug 13 07:13:31 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:13:31 GMT Subject: [jdk11u-dev] Integrated: 8210934: Move sun/net/www/protocol/http/GetErrorStream.java to OpenJDK In-Reply-To: References: Message-ID: On Tue, 10 Aug 2021 09:23:25 GMT, Aleksey Shipilev wrote: > Backporting to match `11.0.13-oracle`. > > Additional testing: > - [x] New test passes on Linux x86_64 fastdebug This pull request has now been integrated. Changeset: 8434e339 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/8434e3399e65a9c0807d637834af9e74cc9f60e2 Stats: 89 lines in 1 file changed: 89 ins; 0 del; 0 mod 8210934: Move sun/net/www/protocol/http/GetErrorStream.java to OpenJDK Repalce internet website dependency with a built-in http server Backport-of: 3edf95fc4452dfce79d03152a882d03c625a5436 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/217 From shade at openjdk.java.net Fri Aug 13 07:14:37 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:14:37 GMT Subject: [jdk11u-dev] RFR: 8216532: tools/launcher/Test7029048.java fails (Solaris) In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 08:54:16 GMT, Aleksey Shipilev wrote: > Backporting this for `11.0.13-oracle` parity. > > Additional testing: > - [x] `tools/launcher` tests pass Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/212 From shade at openjdk.java.net Fri Aug 13 07:14:38 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:14:38 GMT Subject: [jdk11u-dev] Integrated: 8216532: tools/launcher/Test7029048.java fails (Solaris) In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 08:54:16 GMT, Aleksey Shipilev wrote: > Backporting this for `11.0.13-oracle` parity. > > Additional testing: > - [x] `tools/launcher` tests pass This pull request has now been integrated. Changeset: ec71e348 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/ec71e3482334668dd7c30a893918b2df37f2b023 Stats: 44 lines in 1 file changed: 10 ins; 10 del; 24 mod 8216532: tools/launcher/Test7029048.java fails (Solaris) Backport-of: be44ced10aa299f60e9227cc25a7541fd4203271 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/212 From shade at openjdk.java.net Fri Aug 13 07:15:29 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:15:29 GMT Subject: [jdk11u-dev] RFR: 8246261: TCKLocalTime.java failed due to "AssertionError: expected [18:14:22] but found [18:14:23]" In-Reply-To: References: Message-ID: On Tue, 10 Aug 2021 09:49:09 GMT, Aleksey Shipilev wrote: > Clean backport to match 11.0.13-oracle. > > Additional testing: > - [x] Affected test still passes Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/220 From shade at openjdk.java.net Fri Aug 13 07:15:29 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:15:29 GMT Subject: [jdk11u-dev] Integrated: 8246261: TCKLocalTime.java failed due to "AssertionError: expected [18:14:22] but found [18:14:23]" In-Reply-To: References: Message-ID: On Tue, 10 Aug 2021 09:49:09 GMT, Aleksey Shipilev wrote: > Clean backport to match 11.0.13-oracle. > > Additional testing: > - [x] Affected test still passes This pull request has now been integrated. Changeset: 177d1776 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/177d177696205d79d093b4b5b8976ab738db0a59 Stats: 31 lines in 3 files changed: 1 ins; 21 del; 9 mod 8246261: TCKLocalTime.java failed due to "AssertionError: expected [18:14:22] but found [18:14:23]" Backport-of: d347d2ebf9de415e59d04d68f84074e2c1ea334e ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/220 From shade at openjdk.java.net Fri Aug 13 07:16:30 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:16:30 GMT Subject: [jdk11u-dev] RFR: 8242882: opening jar file with large manifest might throw NegativeArraySizeException In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 07:29:13 GMT, Aleksey Shipilev wrote: > Unclean backport to match `11.0.13-oracle`. The uncleanliness is due to ambuity in `JarUtils.createJarFile` that does not have the overload with just `(Path, Path)`, as it was added in later JDKs. I added the `Paths.get(".")` to do the same thing. > > > JarUtils.createJarFile(jarFilePath.toAbsolutePath(), jarSourceRoot, Paths.get(".")); > > > Additional testing: > - [x] New test fails without the patch > - [x] New test passes with the patch Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/225 From shade at openjdk.java.net Fri Aug 13 07:16:34 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:16:34 GMT Subject: [jdk11u-dev] RFR: 8235216: typo in test filename In-Reply-To: References: Message-ID: On Tue, 10 Aug 2021 09:45:05 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. > > Additional testing: > - [x] `tools/javac/file` tests pass Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/219 From shade at openjdk.java.net Fri Aug 13 07:16:36 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:16:36 GMT Subject: [jdk11u-dev] Integrated: 8235216: typo in test filename In-Reply-To: References: Message-ID: On Tue, 10 Aug 2021 09:45:05 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. > > Additional testing: > - [x] `tools/javac/file` tests pass This pull request has now been integrated. Changeset: 868921f8 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/868921f8a32818a8a8c6e64345b05d816647fc9c Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8235216: typo in test filename Renamed MutliReleaseModuleInfoTest.java to MultiReleaseModuleInfoTest.java Backport-of: 5eef59d22df7b434093ec26ff8e933ca19d1c070 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/219 From shade at openjdk.java.net Fri Aug 13 07:17:29 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:17:29 GMT Subject: [jdk11u-dev] RFR: 8214937: sun/security/tools/jarsigner/warnings/NoTimestampTest.java failed due to unexpected expiration date In-Reply-To: References: Message-ID: <2jOuHYTVfxwKobd_4sZtYNVkkyV5UZV9YlnsCcUOVXM=.0508e795-ada7-41c4-ae34-6e47f6b9a24d@github.com> On Wed, 11 Aug 2021 07:02:18 GMT, Aleksey Shipilev wrote: > Backporting for `11.0.13-oracle` parity. > > Additional testing: > - [x] Affected test still passes Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/223 From shade at openjdk.java.net Fri Aug 13 07:17:29 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:17:29 GMT Subject: [jdk11u-dev] RFR: 8213235: java/nio/channels/SocketChannel/AsyncCloseChannel.java fails with threads that didn't exit In-Reply-To: <2-KCwYA5dTZ0fSdEWqtUVRxC5-mliDuRtezNT5VdNqo=.a1833b57-0a98-4828-9d4b-679dd0a9a2e3@github.com> References: <2-KCwYA5dTZ0fSdEWqtUVRxC5-mliDuRtezNT5VdNqo=.a1833b57-0a98-4828-9d4b-679dd0a9a2e3@github.com> Message-ID: <8wvcnvOw8tAUuV7DwYey45_tA9nVPaHZfNIg8YmIN_4=.ac563452-c06c-4570-aaee-eabe1669cd7d@github.com> On Tue, 10 Aug 2021 09:35:16 GMT, Aleksey Shipilev wrote: > Backporting to match `11.0.13-oracle`. This backport contains two fixes that are done in lock-step with each other. Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/218 From shade at openjdk.java.net Fri Aug 13 07:17:30 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:17:30 GMT Subject: [jdk11u-dev] Integrated: 8214937: sun/security/tools/jarsigner/warnings/NoTimestampTest.java failed due to unexpected expiration date In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 07:02:18 GMT, Aleksey Shipilev wrote: > Backporting for `11.0.13-oracle` parity. > > Additional testing: > - [x] Affected test still passes This pull request has now been integrated. Changeset: 236a4693 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/236a4693ca17e3ee1c46b5ec3a0e039f1b423c6a Stats: 19 lines in 1 file changed: 15 ins; 4 del; 0 mod 8214937: sun/security/tools/jarsigner/warnings/NoTimestampTest.java failed due to unexpected expiration date Backport-of: 017c702b8ae43b69b47ecc1091e9d4a010b7597d ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/223 From shade at openjdk.java.net Fri Aug 13 07:17:30 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:17:30 GMT Subject: [jdk11u-dev] Integrated: 8213235: java/nio/channels/SocketChannel/AsyncCloseChannel.java fails with threads that didn't exit In-Reply-To: <2-KCwYA5dTZ0fSdEWqtUVRxC5-mliDuRtezNT5VdNqo=.a1833b57-0a98-4828-9d4b-679dd0a9a2e3@github.com> References: <2-KCwYA5dTZ0fSdEWqtUVRxC5-mliDuRtezNT5VdNqo=.a1833b57-0a98-4828-9d4b-679dd0a9a2e3@github.com> Message-ID: On Tue, 10 Aug 2021 09:35:16 GMT, Aleksey Shipilev wrote: > Backporting to match `11.0.13-oracle`. This backport contains two fixes that are done in lock-step with each other. This pull request has now been integrated. Changeset: 93b826b9 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/93b826b90111911cf9b47313753427bde61a6ceb Stats: 10 lines in 1 file changed: 3 ins; 1 del; 6 mod 8213235: java/nio/channels/SocketChannel/AsyncCloseChannel.java fails with threads that didn't exit 8213576: Make test AsyncCloseChannel.java run in othervm Reviewed-by: phh Backport-of: a6f0e10fe8fdfe933684e0304f4918e54cb104e7 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/218 From shade at openjdk.java.net Fri Aug 13 07:18:25 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:18:25 GMT Subject: [jdk11u-dev] RFR: 8210406: Refactor java.util.PluggableLocale:i18n shell tests to plain java tests In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 07:48:43 GMT, Aleksey Shipilev wrote: > Backporting for `11.0.13-oracle` parity. > > Additional testing: > - [x] New tests pass on Linux x86_64 > - [x] `java/util/PluggableLocale` tests pass > - [x] Eyeballing new test outputs Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/229 From shade at openjdk.java.net Fri Aug 13 07:18:26 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:18:26 GMT Subject: [jdk11u-dev] RFR: 8158066: SourceDebugExtensionTest fails to rename file In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 07:38:17 GMT, Aleksey Shipilev wrote: > Backporting to match `11.0.13-oracle`. > > Additional testing: > - [x] Linux, test is still passing Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/227 From shade at openjdk.java.net Fri Aug 13 07:19:31 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:19:31 GMT Subject: [jdk11u-dev] RFR: 8211092: test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java fails intermittently when cleaning up In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 07:08:33 GMT, Aleksey Shipilev wrote: > Backporting for `11.0.13-oracle` parity. The 11u patch misses the ProblemList removals, as both the addition and removal only happened in 12. (See JDK-8211099 and dependents). > > Additional testing: > - [x] Affected test still passes Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/224 From shade at openjdk.java.net Fri Aug 13 07:19:33 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:19:33 GMT Subject: [jdk11u-dev] RFR: 8268776: Test `ADatagramSocket.java` missing /othervm from @run tag In-Reply-To: References: Message-ID: <0E8KX_UU0uGFUFor_fe1foByKS9GCW4VOwZCUK7I57Q=.e0522dbc-3389-4b8f-94d6-9e939eef80a7@github.com> On Wed, 11 Aug 2021 07:30:37 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. > > Additional testing: > - [x] Affected test still passes Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/226 From shade at openjdk.java.net Fri Aug 13 07:19:32 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:19:32 GMT Subject: [jdk11u-dev] Integrated: 8211092: test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java fails intermittently when cleaning up In-Reply-To: References: Message-ID: <-vzsKOdEVLDy7KAQUj223649PdtLzPwvVF2QJRODQMA=.068939cd-f2d9-4dd5-9da4-b4ec509fb6ee@github.com> On Wed, 11 Aug 2021 07:08:33 GMT, Aleksey Shipilev wrote: > Backporting for `11.0.13-oracle` parity. The 11u patch misses the ProblemList removals, as both the addition and removal only happened in 12. (See JDK-8211099 and dependents). > > Additional testing: > - [x] Affected test still passes This pull request has now been integrated. Changeset: dffc5f4b Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/dffc5f4b6f198158788980e5d35697ec3f8513ce Stats: 39 lines in 1 file changed: 24 ins; 3 del; 12 mod 8211092: test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java fails intermittently when cleaning up Reviewed-by: phh Backport-of: 20f6faa03049bdb70089dd773686ebc749d4f57a ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/224 From shade at openjdk.java.net Fri Aug 13 07:19:33 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:19:33 GMT Subject: [jdk11u-dev] Integrated: 8268776: Test `ADatagramSocket.java` missing /othervm from @run tag In-Reply-To: References: Message-ID: <7Wnem3waWi5J4aCRxCGQ_aQdZBH4e71CQZ5G_cSHDKs=.aa9c42d7-ca2f-4a0b-8e36-a292549ecfc1@github.com> On Wed, 11 Aug 2021 07:30:37 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. > > Additional testing: > - [x] Affected test still passes This pull request has now been integrated. Changeset: 51cd6851 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/51cd6851c15d28fe017e78e64f7db0577d3b75ae Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8268776: Test `ADatagramSocket.java` missing /othervm from @run tag Backport-of: 7d7bdbe135018f1452fa133b294575014e3e871b ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/226 From shade at openjdk.java.net Fri Aug 13 07:20:36 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:20:36 GMT Subject: [jdk11u-dev] RFR: 8210407: Refactor java.util.Calendar:i18n shell tests to plain java tests In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 07:44:46 GMT, Aleksey Shipilev wrote: > Backporting for `11.0.13-oracle` parity. > > Additional testing: > - [x] New tests pass on Linux x86_64 > - [x] `java/util/Calendar` tests pass > - [x] Eyeballing new test outputs Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/228 From shade at openjdk.java.net Fri Aug 13 07:20:39 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:20:39 GMT Subject: [jdk11u-dev] Integrated: 8210407: Refactor java.util.Calendar:i18n shell tests to plain java tests In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 07:44:46 GMT, Aleksey Shipilev wrote: > Backporting for `11.0.13-oracle` parity. > > Additional testing: > - [x] New tests pass on Linux x86_64 > - [x] `java/util/Calendar` tests pass > - [x] Eyeballing new test outputs This pull request has now been integrated. Changeset: 50a6d9d4 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/50a6d9d44220ea86181dd11f7110b44bd8037280 Stats: 349 lines in 7 files changed: 157 ins; 188 del; 4 mod 8210407: Refactor java.util.Calendar:i18n shell tests to plain java tests Backport-of: 533bd0a60425f27fd77a3001b665cf544f20af6f ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/228 From shade at openjdk.java.net Fri Aug 13 07:21:29 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:21:29 GMT Subject: [jdk11u-dev] RFR: 8210908: Refactor java/util/prefs/PrefsSpi.sh to plain java test In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 08:05:02 GMT, Aleksey Shipilev wrote: > Backporting for `11.0.13-oracle` parity. > > This is an unclean backport, because `JarUtils.createJarFile` does not have the overload that accepts only `(Path, Path)`. I fixed it as follows: > > > diff --git a/test/jdk/java/util/prefs/PrefsSpiTest.java b/test/jdk/java/util/prefs/PrefsSpiTest.java > index 0369c60cae2..7e5b59ff754 100644 > --- a/test/jdk/java/util/prefs/PrefsSpiTest.java > +++ b/test/jdk/java/util/prefs/PrefsSpiTest.java > @@ -34,6 +34,7 @@ > import java.io.File; > import java.nio.file.Files; > import java.nio.file.Path; > +import java.nio.file.Paths; > import java.util.ArrayList; > import java.util.List; > > @@ -74,7 +75,7 @@ public class PrefsSpiTest { > Files.copy(source, target, REPLACE_EXISTING); > } > > - JarUtils.createJarFile(SPIJAR, xdir); > + JarUtils.createJarFile(SPIJAR, xdir, Paths.get(".")); > } > > @DataProvider > > > Additional testing: > - [x] New test passes > - [x] `java/util/prefs` tests pass > - [x] Eyeballing new test output Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/231 From shade at openjdk.java.net Fri Aug 13 07:21:33 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:21:33 GMT Subject: [jdk11u-dev] Integrated: 8158066: SourceDebugExtensionTest fails to rename file In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 07:38:17 GMT, Aleksey Shipilev wrote: > Backporting to match `11.0.13-oracle`. > > Additional testing: > - [x] Linux, test is still passing This pull request has now been integrated. Changeset: 156c9394 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/156c939436c6ca26fb05b26ca3852e01aa0fb19d Stats: 25 lines in 3 files changed: 14 ins; 2 del; 9 mod 8158066: SourceDebugExtensionTest fails to rename file Backport-of: b979952d6233c19d7c7a5bd8435c841adeac0de1 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/227 From shade at openjdk.java.net Fri Aug 13 07:22:29 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:22:29 GMT Subject: [jdk11u-dev] Integrated: 8210406: Refactor java.util.PluggableLocale:i18n shell tests to plain java tests In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 07:48:43 GMT, Aleksey Shipilev wrote: > Backporting for `11.0.13-oracle` parity. > > Additional testing: > - [x] New tests pass on Linux x86_64 > - [x] `java/util/PluggableLocale` tests pass > - [x] Eyeballing new test outputs This pull request has now been integrated. Changeset: b11ac531 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/b11ac5313808a737e954d7af6ef1b4b6c5412fa6 Stats: 1027 lines in 65 files changed: 274 ins; 625 del; 128 mod 8210406: Refactor java.util.PluggableLocale:i18n shell tests to plain java tests Backport-of: 3c2c6bce0249c0674951338afbc7a310e2b36912 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/229 From shade at openjdk.java.net Fri Aug 13 07:22:32 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:22:32 GMT Subject: [jdk11u-dev] Integrated: 8242882: opening jar file with large manifest might throw NegativeArraySizeException In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 07:29:13 GMT, Aleksey Shipilev wrote: > Unclean backport to match `11.0.13-oracle`. The uncleanliness is due to ambuity in `JarUtils.createJarFile` that does not have the overload with just `(Path, Path)`, as it was added in later JDKs. I added the `Paths.get(".")` to do the same thing. > > > JarUtils.createJarFile(jarFilePath.toAbsolutePath(), jarSourceRoot, Paths.get(".")); > > > Additional testing: > - [x] New test fails without the patch > - [x] New test passes with the patch This pull request has now been integrated. Changeset: 7b6f391b Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/7b6f391bc12bcdacd2351c6b165f938506159a03 Stats: 85 lines in 2 files changed: 84 ins; 0 del; 1 mod 8242882: opening jar file with large manifest might throw NegativeArraySizeException Reviewed-by: phh Backport-of: 782d45bdec6efdb7e689e0839718ecd7bac2c767 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/225 From shade at openjdk.java.net Fri Aug 13 07:23:28 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:23:28 GMT Subject: [jdk11u-dev] RFR: 8272197: Update 11u GHA workflow with Shenandoah configurations In-Reply-To: <1idzbNF_UxWFlXp4bw42XZyErX4KYIvs1W0yUtgTcT8=.6bac8397-370b-4dad-970b-49fc48faf464@github.com> References: <1idzbNF_UxWFlXp4bw42XZyErX4KYIvs1W0yUtgTcT8=.6bac8397-370b-4dad-970b-49fc48faf464@github.com> Message-ID: <3HDQVqwdqSXbevdEfxBkIMQKJMyRzEGlAGB2gLdcSzc=.a8abb59e-6aa6-47b1-9015-251c3632144f@github.com> On Tue, 10 Aug 2021 07:37:58 GMT, Aleksey Shipilev wrote: > I have noticed that 11u GHA workflow builds/tests without Shenandoah. This is because Shenandoah is not enabled by default in 11u, in contrast to mainline. Which means the workflow that we have picked from mainline does not enable Shenandoah. > > Instead of changing the build defaults for 11u, I suggest we add Shenandoah configs to testing. > > Example run: > https://github.com/shipilev/jdk11u-dev/runs/3288861982 I've got the push approval. But I want to see the @TheRealMDoerr, @GoeLin, @RealCLanger opinions before I push. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/216 From shade at openjdk.java.net Fri Aug 13 07:24:27 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:24:27 GMT Subject: [jdk11u-dev] Integrated: 8210908: Refactor java/util/prefs/PrefsSpi.sh to plain java test In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 08:05:02 GMT, Aleksey Shipilev wrote: > Backporting for `11.0.13-oracle` parity. > > This is an unclean backport, because `JarUtils.createJarFile` does not have the overload that accepts only `(Path, Path)`. I fixed it as follows: > > > diff --git a/test/jdk/java/util/prefs/PrefsSpiTest.java b/test/jdk/java/util/prefs/PrefsSpiTest.java > index 0369c60cae2..7e5b59ff754 100644 > --- a/test/jdk/java/util/prefs/PrefsSpiTest.java > +++ b/test/jdk/java/util/prefs/PrefsSpiTest.java > @@ -34,6 +34,7 @@ > import java.io.File; > import java.nio.file.Files; > import java.nio.file.Path; > +import java.nio.file.Paths; > import java.util.ArrayList; > import java.util.List; > > @@ -74,7 +75,7 @@ public class PrefsSpiTest { > Files.copy(source, target, REPLACE_EXISTING); > } > > - JarUtils.createJarFile(SPIJAR, xdir); > + JarUtils.createJarFile(SPIJAR, xdir, Paths.get(".")); > } > > @DataProvider > > > Additional testing: > - [x] New test passes > - [x] `java/util/prefs` tests pass > - [x] Eyeballing new test output This pull request has now been integrated. Changeset: 97930e74 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/97930e74ecf1007742ac1fc0c9fc5ea5d89695a0 Stats: 282 lines in 5 files changed: 176 ins; 104 del; 2 mod 8210908: Refactor java/util/prefs/PrefsSpi.sh to plain java test Reviewed-by: phh Backport-of: 6ce0aeb00b10738b25f0f53ff785bfc099ef28c4 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/231 From shade at openjdk.java.net Fri Aug 13 07:26:25 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:26:25 GMT Subject: [jdk11u-dev] Integrated: 8254850: Update terminology in java.awt.GridBagLayout source code comments In-Reply-To: References: Message-ID: On Thu, 12 Aug 2021 11:05:00 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. This pull request has now been integrated. Changeset: b1e63774 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/b1e63774d0bf25b9e89ab6a75c1f021a017a0643 Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod 8254850: Update terminology in java.awt.GridBagLayout source code comments Backport-of: 9ed0b7640338194365f7d8a53bc2df3b0c96e821 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/240 From shade at openjdk.java.net Fri Aug 13 07:26:24 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 07:26:24 GMT Subject: [jdk11u-dev] RFR: 8254850: Update terminology in java.awt.GridBagLayout source code comments In-Reply-To: References: Message-ID: On Thu, 12 Aug 2021 11:05:00 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/240 From clanger at openjdk.java.net Fri Aug 13 09:05:31 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 13 Aug 2021 09:05:31 GMT Subject: [jdk11u-dev] Integrated: 8209772: Refactor shell test java/util/ServiceLoader/basic/basic.sh to java In-Reply-To: <4j50-FJIOsIHuULN0Zd4RnrKH3wk-2DE2KEyv02rxGU=.b82b392d-602b-4123-a0d5-3b0c280f0c97@github.com> References: <4j50-FJIOsIHuULN0Zd4RnrKH3wk-2DE2KEyv02rxGU=.b82b392d-602b-4123-a0d5-3b0c280f0c97@github.com> Message-ID: On Thu, 5 Aug 2021 21:05:15 GMT, Christoph Langer wrote: > Hi all, > > this pull request contains a backport of JDK-8209772 from the openjdk/jdk repository. > > The commit being backported was authored by Amy Lu on 14 Sep 2018 and was reviewed by Alan Bateman. > > Thanks! This pull request has now been integrated. Changeset: b1570640 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/b1570640f2d5ac8924e3a2c81513e9909088b6f2 Stats: 318 lines in 2 files changed: 162 ins; 156 del; 0 mod 8209772: Refactor shell test java/util/ServiceLoader/basic/basic.sh to java Backport-of: 07392d976ad5e00763fb28b614aa7631d232544a ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/200 From clanger at openjdk.java.net Fri Aug 13 09:06:27 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 13 Aug 2021 09:06:27 GMT Subject: [jdk11u-dev] Integrated: 8210819: Update the host name in CNameTest.java In-Reply-To: References: Message-ID: On Thu, 5 Aug 2021 21:14:22 GMT, Christoph Langer wrote: > Hi all, > > this pull request contains a backport of JDK-8210819 from the openjdk/jdk repository. > > The commit being backported was authored by Frank Yuan on 18 Sep 2018 and was reviewed by Chris Hegarty. > > Thanks! This pull request has now been integrated. Changeset: de358645 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/de358645ee3b4e4c450852c6b659bb64a711f710 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8210819: Update the host name in CNameTest.java Backport-of: c1bbf898e4a3ce6756d5ffeedd9f1ddd635b2fba ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/201 From clanger at openjdk.java.net Fri Aug 13 09:07:27 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 13 Aug 2021 09:07:27 GMT Subject: [jdk11u-dev] Integrated: 8210802: temp files left by tests in jdk/java/net/httpclient In-Reply-To: References: Message-ID: On Fri, 6 Aug 2021 17:20:17 GMT, Christoph Langer wrote: > Hi all, > > this pull request contains a backport of JDK-8210802 from the openjdk/jdk repository. > > The commit being backported was authored by Hamlin Li on 18 Sep 2018 and was reviewed by Chris Hegarty and Christoph Langer. > > Thanks! This pull request has now been integrated. Changeset: b9c24c34 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/b9c24c34961976bec38f6ea0c7af960106b042da Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8210802: temp files left by tests in jdk/java/net/httpclient Reviewed-by: stuefe Backport-of: 1adaa503bb2a5e78a358f2578cdb665f8701b0de ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/206 From vkempik at openjdk.java.net Fri Aug 13 11:49:26 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Fri, 13 Aug 2021 11:49:26 GMT Subject: [jdk11u-dev] RFR: 8248414: AArch64: Remove uses of long and unsigned long ints [v2] In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 23:34:46 GMT, Paul Hohensee wrote: >> Vladimir Kempik has updated the pull request incrementally with two additional commits since the last revision: >> >> - LogicalImmOp update >> - python file update > > Marked as reviewed by phh (Reviewer). Hello @phohensee , as this backport is also part of winaarch64 backport, I'm going to withdraw this to not make MS folks to do the job twice, could your repeat your approval there as well, the patches are almost identical https://github.com/openjdk/jdk11u-dev/pull/222 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/215 From phh at openjdk.java.net Fri Aug 13 13:31:24 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 13 Aug 2021 13:31:24 GMT Subject: [jdk11u-dev] RFR: 8248414: AArch64: Remove uses of long and unsigned long ints [v2] In-Reply-To: References: Message-ID: <0S6GQ6g3oIfRuRvDDvMG6_dg8uf2Hw1GwDR6aVFxDgs=.f46163ea-8208-4e25-8e3b-40b94f8df279@github.com> On Mon, 9 Aug 2021 19:30:10 GMT, Vladimir Kempik wrote: >> This is a backport of 8248414 to jdk11u-dev >> >> The backport didn't apply clean, partially due to backport of JDK-8247766 >> >> It's needed for mac-aarch and win-aarch64 ports >> >> It will be followed by 8250824 and 8251930. >> >> Sections of aarch64.ad file between line 10260-12560 were regenerated from aarch64_ad.m4 >> >> Original commit - https://github.com/openjdk/jdk/commit/c7d84850bfdbd112a495fab453a79832e3810f47 > > Vladimir Kempik has updated the pull request incrementally with two additional commits since the last revision: > > - LogicalImmOp update > - python file update Yes, this patch is almost identical to a small part of [#222](https://github.com/openjdk/jdk11u-dev/pull/222), but the latter is huge. I'll take a shot at reviewing it though. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/215 From shade at openjdk.java.net Fri Aug 13 14:39:42 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 14:39:42 GMT Subject: [jdk11u-dev] RFR: 8213409: Refactor sun.text.IntHashtable:i18n shell tests to plain java tests Message-ID: <9Toh3FXxaXBBnRWeC2YH1bFr38BydC7yYzurwMI7-OE=.24e77aae-93b0-4b4f-bb86-98bb6c2f8024@github.com> Clean backport to match `11.0.13-oracle`. Additional testing: - [x] Affected tests still pass ------------- Commit messages: - Backport e048289d95294f0fb8f1607a120c04de33106000 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/242/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=242&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8213409 Stats: 116 lines in 3 files changed: 30 ins; 82 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/242.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/242/head:pull/242 PR: https://git.openjdk.java.net/jdk11u-dev/pull/242 From phh at openjdk.java.net Fri Aug 13 14:42:22 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 13 Aug 2021 14:42:22 GMT Subject: [jdk11u-dev] RFR: 8248414: AArch64: Remove uses of long and unsigned long ints [v2] In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 19:30:10 GMT, Vladimir Kempik wrote: >> This is a backport of 8248414 to jdk11u-dev >> >> The backport didn't apply clean, partially due to backport of JDK-8247766 >> >> It's needed for mac-aarch and win-aarch64 ports >> >> It will be followed by 8250824 and 8251930. >> >> Sections of aarch64.ad file between line 10260-12560 were regenerated from aarch64_ad.m4 >> >> Original commit - https://github.com/openjdk/jdk/commit/c7d84850bfdbd112a495fab453a79832e3810f47 > > Vladimir Kempik has updated the pull request incrementally with two additional commits since the last revision: > > - LogicalImmOp update > - python file update On second thought, see my comment on [#222](https://github.com/openjdk/jdk11u-dev/pull/222). I'd prefer to push this backport separately. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/215 From shade at openjdk.java.net Fri Aug 13 14:43:40 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 14:43:40 GMT Subject: [jdk11u-dev] RFR: 8214520: [TEST_BUG] sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java failed with incorrect jtreg tags order Message-ID: Clean backport to match `11.0.13-oracle`. ------------- Commit messages: - Backport f47bd19cbc9bd7a8b9e8d8cdafb9c207ecd6f6f6 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/243/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=243&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8214520 Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/243.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/243/head:pull/243 PR: https://git.openjdk.java.net/jdk11u-dev/pull/243 From shade at openjdk.java.net Fri Aug 13 14:45:34 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 14:45:34 GMT Subject: [jdk11u-dev] RFR: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open Message-ID: Clean backport to match `11.0.13-oracle`. Additional testing: - [x] Affected test still passes ------------- Commit messages: - Backport aa3862403bf5977844e1c362494619f44ce069dc Changes: https://git.openjdk.java.net/jdk11u-dev/pull/244/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=244&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8248352 Stats: 11 lines in 1 file changed: 2 ins; 4 del; 5 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/244.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/244/head:pull/244 PR: https://git.openjdk.java.net/jdk11u-dev/pull/244 From shade at openjdk.java.net Fri Aug 13 14:50:40 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 13 Aug 2021 14:50:40 GMT Subject: [jdk11u-dev] RFR: 8262862: Harden tests sun/security/x509/URICertStore/ExtensionsWithLDAP.java and krb5/canonicalize/Test.java Message-ID: Clean backport to match `11.0.13-oracle`. Additional testing: - [x] Affected tests still pass ------------- Commit messages: - Backport e1cad97049642ab201d53ff608937f7e7ef3ff3e Changes: https://git.openjdk.java.net/jdk11u-dev/pull/245/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=245&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262862 Stats: 32 lines in 2 files changed: 7 ins; 20 del; 5 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/245.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/245/head:pull/245 PR: https://git.openjdk.java.net/jdk11u-dev/pull/245 From phh at openjdk.java.net Fri Aug 13 20:14:32 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 13 Aug 2021 20:14:32 GMT Subject: [jdk11u-dev] RFR: 8248403: AArch64: Remove uses of kernel integer types Message-ID: Backport applies cleanly net of context differences. Testing: tier1. ------------- Commit messages: - Backport 6a91c73dda1cb197d74f0cb3b491d9c47f4bb40c Changes: https://git.openjdk.java.net/jdk11u-dev/pull/246/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=246&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8248403 Stats: 104 lines in 7 files changed: 1 ins; 0 del; 103 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/246.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/246/head:pull/246 PR: https://git.openjdk.java.net/jdk11u-dev/pull/246 From phh at openjdk.java.net Fri Aug 13 20:23:22 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 13 Aug 2021 20:23:22 GMT Subject: [jdk11u-dev] RFR: 8248414: AArch64: Remove uses of long and unsigned long ints [v2] In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 19:30:10 GMT, Vladimir Kempik wrote: >> This is a backport of 8248414 to jdk11u-dev >> >> The backport didn't apply clean, partially due to backport of JDK-8247766 >> >> It's needed for mac-aarch and win-aarch64 ports >> >> It will be followed by 8250824 and 8251930. >> >> Sections of aarch64.ad file between line 10260-12560 were regenerated from aarch64_ad.m4 >> >> Original commit - https://github.com/openjdk/jdk/commit/c7d84850bfdbd112a495fab453a79832e3810f47 > > Vladimir Kempik has updated the pull request incrementally with two additional commits since the last revision: > > - LogicalImmOp update > - python file update Did a little more spelunking and found that some of the changes in this patch (e.g., aarch64.ad) are in [JDK-8248403](https://bugs.openjdk.java.net/browse/JDK-8248403). I did a quick backport of that issue, see [#246](https://github.com/openjdk/jdk11u-dev/pull/246). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/215 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 13 20:39:38 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 13 Aug 2021 20:39:38 GMT Subject: [jdk11u-dev] RFR: JDK-8253947: Implementation: JEP 388: Windows AArch64 Support Message-ID: This is a more recent version of https://github.com/openjdk/jdk11u/pull/2. Changes since then: - [JDK-8254634](https://bugs.openjdk.java.net/browse/JDK-8254634) (backport of [Build failure with VS 2019 (16.5.0) due to C2039 and C2873](https://bugs.openjdk.java.net/browse/JDK-8241087)) was removed, as it had been committed separately. - [JDK-8269391](https://bugs.openjdk.java.net/browse/JDK-8269391) (backport of [AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter](https://bugs.openjdk.java.net/browse/JDK-8265756)) was added. - [JDK-8271095](https://bugs.openjdk.java.net/browse/JDK-8271095) (backport of [C4530 was reported from VS 2019 at access bridge](https://bugs.openjdk.java.net/browse/JDK-8263136)) was added. - [JDK-8271002](https://bugs.openjdk.java.net/browse/JDK-8271002) (backport of [AArch64: Fix MacroAssembler::get_thread convention](https://bugs.openjdk.java.net/browse/JDK-8261072)) was added. - [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) was added, containing the Windows/AArch64 related part of [JDK-8271571](https://bugs.openjdk.java.net/browse/JDK-8271571) (backport of [AArch64: Backtracing broken on PAC enabled systems](https://bugs.openjdk.java.net/browse/JDK-8266749)), necessary for a correct build. - Various small merge conflict resolutions. Similarly to how it was done on tip, we have incorporated parts of [JDK-8253015: Aarch64: Move linux code out from generic CPU feature detection](https://bugs.openjdk.java.net/browse/JDK-8253015) by @AntonKozlov into the [JDK-8253947: Implementation: JEP 388: Windows AArch64 Support](https://bugs.openjdk.java.net/browse/JDK-8253947) commit. Please let me know how I can make the review process easier / faster. ------------- Commit messages: - 8272181: Windows-AArch64: Backport fix of `Backtracing broken on PAC enabled systems` - 8261072: AArch64: Fix MacroAssembler::get_thread convention - 8263136: C4530 was reported from VS 2019 at access bridge - 8269391: AArch64: initialize memory allocated for locals according to... - 8264184: JVMCI: Enable it for Windows+AArch64 - 8264183: Windows-AArch64: Enable and test ZGC and ShenandoahGC - 8264182: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build - 8253947: Implementation: JEP 388: Windows AArch64 Support - 8254645: AArch64: follow up for JDK-8248414 - 8254644: C1: Fix signature mismatch of LIRGenerator::strengh_reduce_multiply - ... and 8 more: https://git.openjdk.java.net/jdk11u-dev/compare/bdfc60ab...9dd09a22 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/222/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=222&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253947 Stats: 4922 lines in 93 files changed: 2840 ins; 313 del; 1769 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/222.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/222/head:pull/222 PR: https://git.openjdk.java.net/jdk11u-dev/pull/222 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 13 20:39:38 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 13 Aug 2021 20:39:38 GMT Subject: [jdk11u-dev] RFR: JDK-8253947: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: References: Message-ID: On Tue, 10 Aug 2021 21:43:47 GMT, Reka Kovacs wrote: > This is a more recent version of https://github.com/openjdk/jdk11u/pull/2. > > Changes since then: > - [JDK-8254634](https://bugs.openjdk.java.net/browse/JDK-8254634) (backport of [Build failure with VS 2019 (16.5.0) due to C2039 and C2873](https://bugs.openjdk.java.net/browse/JDK-8241087)) was removed, as it had been committed separately. > - [JDK-8269391](https://bugs.openjdk.java.net/browse/JDK-8269391) (backport of [AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter](https://bugs.openjdk.java.net/browse/JDK-8265756)) was added. > - [JDK-8271095](https://bugs.openjdk.java.net/browse/JDK-8271095) (backport of [C4530 was reported from VS 2019 at access bridge](https://bugs.openjdk.java.net/browse/JDK-8263136)) was added. > - [JDK-8271002](https://bugs.openjdk.java.net/browse/JDK-8271002) (backport of [AArch64: Fix MacroAssembler::get_thread convention](https://bugs.openjdk.java.net/browse/JDK-8261072)) was added. > - [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) was added, containing the Windows/AArch64 related part of [JDK-8271571](https://bugs.openjdk.java.net/browse/JDK-8271571) (backport of [AArch64: Backtracing broken on PAC enabled systems](https://bugs.openjdk.java.net/browse/JDK-8266749)), necessary for a correct build. > - Various small merge conflict resolutions. > > Similarly to how it was done on tip, we have incorporated parts of [JDK-8253015: Aarch64: Move linux code out from generic CPU feature detection](https://bugs.openjdk.java.net/browse/JDK-8253015) by @AntonKozlov into the [JDK-8253947: Implementation: JEP 388: Windows AArch64 Support](https://bugs.openjdk.java.net/browse/JDK-8253947) commit. > > Please let me know how I can make the review process easier / faster. Removed tabs and trailing spaces from [8253947](https://github.com/openjdk/jdk11u-dev/pull/222/commits/2fd8469026bc09957de091ffabe262737a47dad3) and [8254640](https://github.com/openjdk/jdk11u-dev/pull/222/commits/61b8020beaf4bac02989b1f498225de49bde7ad0). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/222 From burban at openjdk.java.net Fri Aug 13 20:39:39 2021 From: burban at openjdk.java.net (Bernhard Urban-Forster) Date: Fri, 13 Aug 2021 20:39:39 GMT Subject: [jdk11u-dev] RFR: JDK-8253947: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: References: Message-ID: <4GOTJ_hn-jCGAFhscUM7GVuChN1TDA65-Du_v6w9Las=.db705181-5c54-4c39-ac73-dc1b1b406e93@github.com> On Wed, 11 Aug 2021 20:55:56 GMT, Reka Kovacs wrote: >> This is a more recent version of https://github.com/openjdk/jdk11u/pull/2. >> >> Changes since then: >> - [JDK-8254634](https://bugs.openjdk.java.net/browse/JDK-8254634) (backport of [Build failure with VS 2019 (16.5.0) due to C2039 and C2873](https://bugs.openjdk.java.net/browse/JDK-8241087)) was removed, as it had been committed separately. >> - [JDK-8269391](https://bugs.openjdk.java.net/browse/JDK-8269391) (backport of [AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter](https://bugs.openjdk.java.net/browse/JDK-8265756)) was added. >> - [JDK-8271095](https://bugs.openjdk.java.net/browse/JDK-8271095) (backport of [C4530 was reported from VS 2019 at access bridge](https://bugs.openjdk.java.net/browse/JDK-8263136)) was added. >> - [JDK-8271002](https://bugs.openjdk.java.net/browse/JDK-8271002) (backport of [AArch64: Fix MacroAssembler::get_thread convention](https://bugs.openjdk.java.net/browse/JDK-8261072)) was added. >> - [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) was added, containing the Windows/AArch64 related part of [JDK-8271571](https://bugs.openjdk.java.net/browse/JDK-8271571) (backport of [AArch64: Backtracing broken on PAC enabled systems](https://bugs.openjdk.java.net/browse/JDK-8266749)), necessary for a correct build. >> - Various small merge conflict resolutions. >> >> Similarly to how it was done on tip, we have incorporated parts of [JDK-8253015: Aarch64: Move linux code out from generic CPU feature detection](https://bugs.openjdk.java.net/browse/JDK-8253015) by @AntonKozlov into the [JDK-8253947: Implementation: JEP 388: Windows AArch64 Support](https://bugs.openjdk.java.net/browse/JDK-8253947) commit. >> >> Please let me know how I can make the review process easier / faster. > > Removed tabs and trailing spaces from [8253947](https://github.com/openjdk/jdk11u-dev/pull/222/commits/2fd8469026bc09957de091ffabe262737a47dad3) and [8254640](https://github.com/openjdk/jdk11u-dev/pull/222/commits/61b8020beaf4bac02989b1f498225de49bde7ad0). Thanks @rnkovacs for taking this over ?? Overall it looks good to me (but I'm not a formal reviewer). Do you have some numbers handy on the tests passed before/after this change on other platforms like Linux/AArch64 and Windows/x86_64 that you could share here? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/222 From vkempik at openjdk.java.net Fri Aug 13 20:39:39 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Fri, 13 Aug 2021 20:39:39 GMT Subject: [jdk11u-dev] RFR: JDK-8253947: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: References: Message-ID: On Tue, 10 Aug 2021 21:43:47 GMT, Reka Kovacs wrote: > This is a more recent version of https://github.com/openjdk/jdk11u/pull/2. > > Changes since then: > - [JDK-8254634](https://bugs.openjdk.java.net/browse/JDK-8254634) (backport of [Build failure with VS 2019 (16.5.0) due to C2039 and C2873](https://bugs.openjdk.java.net/browse/JDK-8241087)) was removed, as it had been committed separately. > - [JDK-8269391](https://bugs.openjdk.java.net/browse/JDK-8269391) (backport of [AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter](https://bugs.openjdk.java.net/browse/JDK-8265756)) was added. > - [JDK-8271095](https://bugs.openjdk.java.net/browse/JDK-8271095) (backport of [C4530 was reported from VS 2019 at access bridge](https://bugs.openjdk.java.net/browse/JDK-8263136)) was added. > - [JDK-8271002](https://bugs.openjdk.java.net/browse/JDK-8271002) (backport of [AArch64: Fix MacroAssembler::get_thread convention](https://bugs.openjdk.java.net/browse/JDK-8261072)) was added. > - [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) was added, containing the Windows/AArch64 related part of [JDK-8271571](https://bugs.openjdk.java.net/browse/JDK-8271571) (backport of [AArch64: Backtracing broken on PAC enabled systems](https://bugs.openjdk.java.net/browse/JDK-8266749)), necessary for a correct build. > - Various small merge conflict resolutions. > > Similarly to how it was done on tip, we have incorporated parts of [JDK-8253015: Aarch64: Move linux code out from generic CPU feature detection](https://bugs.openjdk.java.net/browse/JDK-8253015) by @AntonKozlov into the [JDK-8253947: Implementation: JEP 388: Windows AArch64 Support](https://bugs.openjdk.java.net/browse/JDK-8253947) commit. > > Please let me know how I can make the review process easier / faster. Hello for 8248414 which is part of this PR, I have made a similar PR few days ago, I will withdraw it. You backport seems identical except one thing 1) ul was replaced with ull few times https://github.com/openjdk/jdk11u-dev/pull/215/files#diff-9c5120cff0dd87fbd1122067c44170768702b61cba7b1faf0c04dcba4c8fdfa3L135 this patch ( the place to patch ) is not present in you tree at all, that's strange. Also, could you please be more specific, which parts of https://github.com/openjdk/jdk/commit/ec9bee68 were taken and which wasn't ? it's not trivial to find them in this PR. Thanks ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/222 From phh at openjdk.java.net Fri Aug 13 20:39:39 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 13 Aug 2021 20:39:39 GMT Subject: [jdk11u-dev] RFR: JDK-8253947: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: References: Message-ID: On Tue, 10 Aug 2021 21:43:47 GMT, Reka Kovacs wrote: > This is a more recent version of https://github.com/openjdk/jdk11u/pull/2. > > Changes since then: > - [JDK-8254634](https://bugs.openjdk.java.net/browse/JDK-8254634) (backport of [Build failure with VS 2019 (16.5.0) due to C2039 and C2873](https://bugs.openjdk.java.net/browse/JDK-8241087)) was removed, as it had been committed separately. > - [JDK-8269391](https://bugs.openjdk.java.net/browse/JDK-8269391) (backport of [AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter](https://bugs.openjdk.java.net/browse/JDK-8265756)) was added. > - [JDK-8271095](https://bugs.openjdk.java.net/browse/JDK-8271095) (backport of [C4530 was reported from VS 2019 at access bridge](https://bugs.openjdk.java.net/browse/JDK-8263136)) was added. > - [JDK-8271002](https://bugs.openjdk.java.net/browse/JDK-8271002) (backport of [AArch64: Fix MacroAssembler::get_thread convention](https://bugs.openjdk.java.net/browse/JDK-8261072)) was added. > - [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) was added, containing the Windows/AArch64 related part of [JDK-8271571](https://bugs.openjdk.java.net/browse/JDK-8271571) (backport of [AArch64: Backtracing broken on PAC enabled systems](https://bugs.openjdk.java.net/browse/JDK-8266749)), necessary for a correct build. > - Various small merge conflict resolutions. > > Similarly to how it was done on tip, we have incorporated parts of [JDK-8253015: Aarch64: Move linux code out from generic CPU feature detection](https://bugs.openjdk.java.net/browse/JDK-8253015) by @AntonKozlov into the [JDK-8253947: Implementation: JEP 388: Windows AArch64 Support](https://bugs.openjdk.java.net/browse/JDK-8253947) commit. > > Please let me know how I can make the review process easier / faster. Copy-paste errors are one of the problems that can occur with a giant squashed backport such as this one. It's difficult to review because it's a lot of code and there's no way to tell which code belongs to which JBS issue, and there's no way to triage the almost inevitable problems that will occur with such a large patch. I'd prefer separate per-JBS-issue backports, such as Vladimir's [#215](https://github.com/openjdk/jdk11u-dev/pull/215). I ordered, by resolution date, the parents of the above JBS issue merged with the ones from [#2](https://github.com/openjdk/jdk11u/pull/2). https://bugs.openjdk.java.net/browse/JDK-8248403 https://bugs.openjdk.java.net/browse/JDK-8248414 https://bugs.openjdk.java.net/browse/JDK-8248671 https://bugs.openjdk.java.net/browse/JDK-8248666 https://bugs.openjdk.java.net/browse/JDK-8248668 https://bugs.openjdk.java.net/browse/JDK-8248657 https://bugs.openjdk.java.net/browse/JDK-8248682 https://bugs.openjdk.java.net/browse/JDK-8250810 https://bugs.openjdk.java.net/browse/JDK-8250824 https://bugs.openjdk.java.net/browse/JDK-8248816 https://bugs.openjdk.java.net/browse/JDK-8254072 https://bugs.openjdk.java.net/browse/JDK-8254827 https://bugs.openjdk.java.net/browse/JDK-8261072 https://bugs.openjdk.java.net/browse/JDK-8263136 https://bugs.openjdk.java.net/browse/JDK-8265756 https://bugs.openjdk.java.net/browse/JDK-8252114 https://bugs.openjdk.java.net/browse/JDK-8272181 I didn't include the umbrella issue https://bugs.openjdk.java.net/browse/JDK-8248238. I've posted a backport PR for [JDK-8248403](https://bugs.openjdk.java.net/browse/JDK-8248403) at [#246](https://github.com/openjdk/jdk11u-dev/pull/246). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/222 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 13 22:57:23 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 13 Aug 2021 22:57:23 GMT Subject: [jdk11u-dev] RFR: JDK-8253947: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: References: Message-ID: On Fri, 13 Aug 2021 12:07:37 GMT, Vladimir Kempik wrote: >> This is a more recent version of https://github.com/openjdk/jdk11u/pull/2. >> >> Changes since then: >> - [JDK-8254634](https://bugs.openjdk.java.net/browse/JDK-8254634) (backport of [Build failure with VS 2019 (16.5.0) due to C2039 and C2873](https://bugs.openjdk.java.net/browse/JDK-8241087)) was removed, as it had been committed separately. >> - [JDK-8269391](https://bugs.openjdk.java.net/browse/JDK-8269391) (backport of [AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter](https://bugs.openjdk.java.net/browse/JDK-8265756)) was added. >> - [JDK-8271095](https://bugs.openjdk.java.net/browse/JDK-8271095) (backport of [C4530 was reported from VS 2019 at access bridge](https://bugs.openjdk.java.net/browse/JDK-8263136)) was added. >> - [JDK-8271002](https://bugs.openjdk.java.net/browse/JDK-8271002) (backport of [AArch64: Fix MacroAssembler::get_thread convention](https://bugs.openjdk.java.net/browse/JDK-8261072)) was added. >> - [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) was added, containing the Windows/AArch64 related part of [JDK-8271571](https://bugs.openjdk.java.net/browse/JDK-8271571) (backport of [AArch64: Backtracing broken on PAC enabled systems](https://bugs.openjdk.java.net/browse/JDK-8266749)), necessary for a correct build. >> - Various small merge conflict resolutions. >> >> Similarly to how it was done on tip, we have incorporated parts of [JDK-8253015: Aarch64: Move linux code out from generic CPU feature detection](https://bugs.openjdk.java.net/browse/JDK-8253015) by @AntonKozlov into the [JDK-8253947: Implementation: JEP 388: Windows AArch64 Support](https://bugs.openjdk.java.net/browse/JDK-8253947) commit. >> >> Please let me know how I can make the review process easier / faster. > > Also, could you please be more specific, which parts of https://github.com/openjdk/jdk/commit/ec9bee68 were taken and which wasn't ? > it's not trivial to find them in this PR. > Thanks @VladimirKempik, changes to - src/hotspot/cpu/aarch64/vm_version_aarch64.cpp, - src/hotspot/cpu/aarch64/vm_version_aarch64.hpp, and - src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp were taken over from [openjdk/jdk at ec9bee6](https://github.com/openjdk/jdk/commit/ec9bee68). However, now that we're breaking up the PR into its elements, it might make sense to backport this whole commit separately too. WDYT? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/222 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 13 23:07:26 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 13 Aug 2021 23:07:26 GMT Subject: [jdk11u-dev] RFR: JDK-8253947: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: References: Message-ID: On Fri, 13 Aug 2021 20:35:22 GMT, Paul Hohensee wrote: >> This is a more recent version of https://github.com/openjdk/jdk11u/pull/2. >> >> Changes since then: >> - [JDK-8254634](https://bugs.openjdk.java.net/browse/JDK-8254634) (backport of [Build failure with VS 2019 (16.5.0) due to C2039 and C2873](https://bugs.openjdk.java.net/browse/JDK-8241087)) was removed, as it had been committed separately. >> - [JDK-8269391](https://bugs.openjdk.java.net/browse/JDK-8269391) (backport of [AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter](https://bugs.openjdk.java.net/browse/JDK-8265756)) was added. >> - [JDK-8271095](https://bugs.openjdk.java.net/browse/JDK-8271095) (backport of [C4530 was reported from VS 2019 at access bridge](https://bugs.openjdk.java.net/browse/JDK-8263136)) was added. >> - [JDK-8271002](https://bugs.openjdk.java.net/browse/JDK-8271002) (backport of [AArch64: Fix MacroAssembler::get_thread convention](https://bugs.openjdk.java.net/browse/JDK-8261072)) was added. >> - [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) was added, containing the Windows/AArch64 related part of [JDK-8271571](https://bugs.openjdk.java.net/browse/JDK-8271571) (backport of [AArch64: Backtracing broken on PAC enabled systems](https://bugs.openjdk.java.net/browse/JDK-8266749)), necessary for a correct build. >> - Various small merge conflict resolutions. >> >> Similarly to how it was done on tip, we have incorporated parts of [JDK-8253015: Aarch64: Move linux code out from generic CPU feature detection](https://bugs.openjdk.java.net/browse/JDK-8253015) by @AntonKozlov into the [JDK-8253947: Implementation: JEP 388: Windows AArch64 Support](https://bugs.openjdk.java.net/browse/JDK-8253947) commit. >> >> Please let me know how I can make the review process easier / faster. > > I've posted a backport PR for [JDK-8248403](https://bugs.openjdk.java.net/browse/JDK-8248403) at [#246](https://github.com/openjdk/jdk11u-dev/pull/246). Thank you @phohensee. I understand that reviewing such a huge patch is a pain, and the chance of overlooking something goes up with size. I'll proceed to open PRs for the rest of the issues. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/222 From clanger at openjdk.java.net Sat Aug 14 05:11:21 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Sat, 14 Aug 2021 05:11:21 GMT Subject: [jdk11u-dev] RFR: 8230841: Remove oopDesc::equals() In-Reply-To: References: Message-ID: On Fri, 6 Aug 2021 09:53:57 GMT, Aleksey Shipilev wrote: > This is the second patch in the series to cleanup/revert the GC BarrierSets to most current state. See the dependent ("this issue blocks" links) issues to see what is next. > > The equals APIs were added for Shenandoah GC, in the incarnation that exposed both from- and to-copies to the runtime system (see JDK-8199781). Since then, Shenandoah greatly simplified this by switching to a strong to-space invariant, which obviates the need for this API. Therefore, it was removed in JDK 14. This patch reverts JDK 11 parts to that shape as well, which should simplify 11u maintenance. Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/204 From stuefe at openjdk.java.net Sat Aug 14 09:32:24 2021 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Sat, 14 Aug 2021 09:32:24 GMT Subject: [jdk11u-dev] RFR: 8248403: AArch64: Remove uses of kernel integer types In-Reply-To: References: Message-ID: On Fri, 13 Aug 2021 20:05:39 GMT, Paul Hohensee wrote: > Backport applies cleanly net of context differences. Testing: tier1. LGTM ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/246 From aph at openjdk.java.net Sat Aug 14 09:48:23 2021 From: aph at openjdk.java.net (Andrew Haley) Date: Sat, 14 Aug 2021 09:48:23 GMT Subject: [jdk11u-dev] RFR: 8248414: AArch64: Remove uses of long and unsigned long ints [v2] In-Reply-To: References: Message-ID: On Fri, 13 Aug 2021 14:38:54 GMT, Paul Hohensee wrote: > On second thought, see my comment on [#222](https://github.com/openjdk/jdk11u-dev/pull/222). I'd prefer to push this backport separately. Yes, definitely. The two integer type cleanup patches were because of Windows/Mac, but they are logically independent of the ports. It really wouldn't help to merge them. In general, it is a good idea to commit pure cleanups (which these were, in the sense that they had no behavioral effect) separately from functional changes. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/215 From hshi at openjdk.java.net Sat Aug 14 10:44:39 2021 From: hshi at openjdk.java.net (Hui Shi) Date: Sat, 14 Aug 2021 10:44:39 GMT Subject: [jdk11u-dev] RFR: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj Message-ID: Please help review this backport for 8272131: C2 crash in PhaseMacroExpand::generate_slow_arraycopy because arraycopy node's _ioproj_fallthrough is NULL. Conflicts when backport In jdk18: field name is fallthrough_ioproj , and it is in PhaseMacroExpand's CallProjections class. In jdk11: field name is _ioproj_fallthrough, and it is directly in PhaseMacroExpand class. ------------- Commit messages: - Backport 5350b9901c6cebe5d40bbba9a31d1f26285b1cd6 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/247/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=247&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272131 Stats: 75 lines in 2 files changed: 72 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/247.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/247/head:pull/247 PR: https://git.openjdk.java.net/jdk11u-dev/pull/247 From hshi at openjdk.java.net Sat Aug 14 11:22:45 2021 From: hshi at openjdk.java.net (Hui Shi) Date: Sat, 14 Aug 2021 11:22:45 GMT Subject: [jdk11u-dev] RFR: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj [v2] In-Reply-To: References: Message-ID: > Please help review this backport for 8272131: C2 crash in PhaseMacroExpand::generate_slow_arraycopy because arraycopy node's _ioproj_fallthrough is NULL. > > Conflicts when backport > In jdk18: field name is fallthrough_ioproj , and it is in PhaseMacroExpand's CallProjections class. > In jdk11: field name is _ioproj_fallthrough, and it is directly in PhaseMacroExpand class. Hui Shi has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: ?Backport 5350b9901c6cebe5d40bbba9a31d1f26285b1cd6 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/247/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/247/files/645b47ad..4afdf7d7 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=247&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=247&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/247.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/247/head:pull/247 PR: https://git.openjdk.java.net/jdk11u-dev/pull/247 From aph at openjdk.java.net Sat Aug 14 12:14:24 2021 From: aph at openjdk.java.net (Andrew Haley) Date: Sat, 14 Aug 2021 12:14:24 GMT Subject: [jdk11u-dev] RFR: 8248414: AArch64: Remove uses of long and unsigned long ints [v2] In-Reply-To: References: Message-ID: On Sat, 14 Aug 2021 09:45:49 GMT, Andrew Haley wrote: > In general, it is a good idea to commit pure cleanups (which these were, in the sense that they had no behavioral effect) separately from functional changes. Substantial cleanups,I mean. I have no objection to tidying up bits and pieces as we go along,and John Rose has said that we should. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/215 From phh at openjdk.java.net Sat Aug 14 12:39:23 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Sat, 14 Aug 2021 12:39:23 GMT Subject: [jdk11u-dev] RFR: 8248403: AArch64: Remove uses of kernel integer types In-Reply-To: References: Message-ID: On Fri, 13 Aug 2021 20:05:39 GMT, Paul Hohensee wrote: > Backport applies cleanly net of context differences. Testing: tier1. Thank you, Thomas. Tagged. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/246 From hshi at openjdk.java.net Sat Aug 14 12:57:22 2021 From: hshi at openjdk.java.net (Hui Shi) Date: Sat, 14 Aug 2021 12:57:22 GMT Subject: [jdk11u-dev] Withdrawn: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj In-Reply-To: References: Message-ID: On Sat, 14 Aug 2021 10:40:10 GMT, Hui Shi wrote: > Please help review this backport for 8272131: C2 crash in PhaseMacroExpand::generate_slow_arraycopy because arraycopy node's _ioproj_fallthrough is NULL. > > Conflicts when backport > In jdk18: field name is fallthrough_ioproj , and it is in PhaseMacroExpand's CallProjections class. > In jdk11: field name is _ioproj_fallthrough, and it is directly in PhaseMacroExpand class. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/247 From hshi at openjdk.java.net Sat Aug 14 13:17:41 2021 From: hshi at openjdk.java.net (Hui Shi) Date: Sat, 14 Aug 2021 13:17:41 GMT Subject: [jdk11u-dev] RFR: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj Message-ID: Please help review this backport for 8272131: C2 crash in PhaseMacroExpand::generate_slow_arraycopy because arraycopy node's _ioproj_fallthrough is NULL. Conflicts when backport In jdk18: field name is fallthrough_ioproj , and it is in PhaseMacroExpand's CallProjections class. In jdk11: field name is _ioproj_fallthrough, and it is directly in PhaseMacroExpand class. ------------- Commit messages: - ?Backport 5350b9901c6cebe5d40bbba9a31d1f26285b1cd6 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/248/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=248&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272131 Stats: 75 lines in 2 files changed: 71 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/248.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/248/head:pull/248 PR: https://git.openjdk.java.net/jdk11u-dev/pull/248 From hshi at openjdk.java.net Sat Aug 14 13:20:26 2021 From: hshi at openjdk.java.net (Hui Shi) Date: Sat, 14 Aug 2021 13:20:26 GMT Subject: [jdk11u-dev] Withdrawn: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj In-Reply-To: References: Message-ID: On Sat, 14 Aug 2021 13:11:34 GMT, Hui Shi wrote: > Please help review this backport for 8272131: C2 crash in PhaseMacroExpand::generate_slow_arraycopy because arraycopy node's _ioproj_fallthrough is NULL. > > Conflicts when backport > In jdk18: field name is fallthrough_ioproj , and it is in PhaseMacroExpand's CallProjections class. > In jdk11: field name is _ioproj_fallthrough, and it is directly in PhaseMacroExpand class. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/248 From hshi at openjdk.java.net Sun Aug 15 01:35:47 2021 From: hshi at openjdk.java.net (Hui Shi) Date: Sun, 15 Aug 2021 01:35:47 GMT Subject: [jdk11u-dev] RFR: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj Message-ID: Please help review this backport for 8272131: C2 crash in PhaseMacroExpand::generate_slow_arraycopy because arraycopy node's _ioproj_fallthrough is NULL. Conflicts when backport In jdk18: field name is fallthrough_ioproj , and it is in PhaseMacroExpand's CallProjections class. In jdk11: field name is _ioproj_fallthrough, and it is directly in PhaseMacroExpand class. ------------- Commit messages: - ?Backport 5350b9901c6cebe5d40bbba9a31d1f26285b1cd6 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/250/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=250&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272131 Stats: 75 lines in 2 files changed: 71 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/250.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/250/head:pull/250 PR: https://git.openjdk.java.net/jdk11u-dev/pull/250 From hshi at openjdk.java.net Sun Aug 15 09:03:31 2021 From: hshi at openjdk.java.net (Hui Shi) Date: Sun, 15 Aug 2021 09:03:31 GMT Subject: [jdk11u-dev] RFR: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj In-Reply-To: References: Message-ID: On Sun, 15 Aug 2021 01:28:35 GMT, Hui Shi wrote: > Please help review this backport for 8272131: C2 crash in PhaseMacroExpand::generate_slow_arraycopy because arraycopy node's _ioproj_fallthrough is NULL. > > Conflicts when backport > In jdk18: field name is fallthrough_ioproj , and it is in PhaseMacroExpand's CallProjections class. > In jdk11: field name is _ioproj_fallthrough, and it is directly in PhaseMacroExpand class. I followed instructions in https://wiki.openjdk.java.net/display/SKARA/Backports. But wonder why backport lable is added automatically. $ git checkout -b backport-5a526c1c $ git fetch https://github.com/openjdk/jdk 5a526c1c5716f6d9a7fc94741bcdb2f424d342df $ git cherry-pick --no-commit FETCH_HEAD $ # resolve conflicts $ git commit -m 'Backport 5a526c1c5716f6d9a7fc94741bcdb2f424d342df' $ git push -u origin backport-5a526c1c ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/250 From shade at openjdk.java.net Sun Aug 15 11:55:27 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Sun, 15 Aug 2021 11:55:27 GMT Subject: [jdk11u-dev] RFR: 8262862: Harden tests sun/security/x509/URICertStore/ExtensionsWithLDAP.java and krb5/canonicalize/Test.java In-Reply-To: References: Message-ID: On Fri, 13 Aug 2021 14:41:38 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. > > Additional testing: > - [x] Affected tests still pass Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/245 From shade at openjdk.java.net Sun Aug 15 11:55:28 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Sun, 15 Aug 2021 11:55:28 GMT Subject: [jdk11u-dev] Integrated: 8262862: Harden tests sun/security/x509/URICertStore/ExtensionsWithLDAP.java and krb5/canonicalize/Test.java In-Reply-To: References: Message-ID: On Fri, 13 Aug 2021 14:41:38 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. > > Additional testing: > - [x] Affected tests still pass This pull request has now been integrated. Changeset: ac8510bc Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/ac8510bc19d6626116fd4e2dc893430b96957b21 Stats: 32 lines in 2 files changed: 7 ins; 20 del; 5 mod 8262862: Harden tests sun/security/x509/URICertStore/ExtensionsWithLDAP.java and krb5/canonicalize/Test.java Backport-of: e1cad97049642ab201d53ff608937f7e7ef3ff3e ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/245 From shade at openjdk.java.net Sun Aug 15 11:57:36 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Sun, 15 Aug 2021 11:57:36 GMT Subject: [jdk11u-dev] RFR: 8225082: Remove IdenTrust certificate that is expiring in September 2021 In-Reply-To: References: Message-ID: On Thu, 12 Aug 2021 10:18:54 GMT, Aleksey Shipilev wrote: > Backport to match `11.0.13-oracle`. There is a conflict in `@bug` line in the test: the bug IDs are in different order. I took the liberty to change the order match the incoming patch, which would simplify future backports here. > > Additional testing: > - [x] `VerifyCACerts` test passes Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/239 From shade at openjdk.java.net Sun Aug 15 11:57:35 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Sun, 15 Aug 2021 11:57:35 GMT Subject: [jdk11u-dev] RFR: 8214520: [TEST_BUG] sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java failed with incorrect jtreg tags order In-Reply-To: References: Message-ID: On Fri, 13 Aug 2021 14:34:02 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/243 From shade at openjdk.java.net Sun Aug 15 11:57:36 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Sun, 15 Aug 2021 11:57:36 GMT Subject: [jdk11u-dev] Integrated: 8214520: [TEST_BUG] sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java failed with incorrect jtreg tags order In-Reply-To: References: Message-ID: <1RdFgBG2vpY14j63i5NqU4NIynGn9bY-xbHJeniHAes=.cf4d73e4-4749-4e1e-a5bd-7f0972238c59@github.com> On Fri, 13 Aug 2021 14:34:02 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. This pull request has now been integrated. Changeset: 80972c52 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/80972c52202ebdb34e28aec0c3297f56b88403ae Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod 8214520: [TEST_BUG] sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java failed with incorrect jtreg tags order Backport-of: f47bd19cbc9bd7a8b9e8d8cdafb9c207ecd6f6f6 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/243 From shade at openjdk.java.net Sun Aug 15 11:58:31 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Sun, 15 Aug 2021 11:58:31 GMT Subject: [jdk11u-dev] RFR: 8230841: Remove oopDesc::equals() In-Reply-To: References: Message-ID: On Fri, 6 Aug 2021 09:53:57 GMT, Aleksey Shipilev wrote: > This is the second patch in the series to cleanup/revert the GC BarrierSets to most current state. See the dependent ("this issue blocks" links) issues to see what is next. > > The equals APIs were added for Shenandoah GC, in the incarnation that exposed both from- and to-copies to the runtime system (see JDK-8199781). Since then, Shenandoah greatly simplified this by switching to a strong to-space invariant, which obviates the need for this API. Therefore, it was removed in JDK 14. This patch reverts JDK 11 parts to that shape as well, which should simplify 11u maintenance. Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/204 From shade at openjdk.java.net Sun Aug 15 11:59:31 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Sun, 15 Aug 2021 11:59:31 GMT Subject: [jdk11u-dev] RFR: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open In-Reply-To: References: Message-ID: On Fri, 13 Aug 2021 14:38:11 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. > > Additional testing: > - [x] Affected test still passes Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/244 From shade at openjdk.java.net Sun Aug 15 11:59:28 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Sun, 15 Aug 2021 11:59:28 GMT Subject: [jdk11u-dev] RFR: 8209768: Refactor java/util/prefs/CheckUserPrefsStorage.sh to plain java test In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 07:56:59 GMT, Aleksey Shipilev wrote: > Backporting for `11.0.13-oracle` parity. > > Additional testing: > - [x] New test passes > - [x] `java/util/prefs` tests pass > - [x] Eyeballing new test output Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/230 From shade at openjdk.java.net Sun Aug 15 11:59:31 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Sun, 15 Aug 2021 11:59:31 GMT Subject: [jdk11u-dev] Integrated: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open In-Reply-To: References: Message-ID: On Fri, 13 Aug 2021 14:38:11 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. > > Additional testing: > - [x] Affected test still passes This pull request has now been integrated. Changeset: 2c3f99da Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/2c3f99daae789c099234d36fc444deff51129393 Stats: 11 lines in 1 file changed: 2 ins; 4 del; 5 mod 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open Backport-of: aa3862403bf5977844e1c362494619f44ce069dc ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/244 From shade at openjdk.java.net Sun Aug 15 11:59:32 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Sun, 15 Aug 2021 11:59:32 GMT Subject: [jdk11u-dev] Integrated: 8209768: Refactor java/util/prefs/CheckUserPrefsStorage.sh to plain java test In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 07:56:59 GMT, Aleksey Shipilev wrote: > Backporting for `11.0.13-oracle` parity. > > Additional testing: > - [x] New test passes > - [x] `java/util/prefs` tests pass > - [x] Eyeballing new test output This pull request has now been integrated. Changeset: 8a470e1f Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/8a470e1f5edbcbf1d2dce977719f1b1774636ed2 Stats: 125 lines in 4 files changed: 50 ins; 71 del; 4 mod 8209768: Refactor java/util/prefs/CheckUserPrefsStorage.sh to plain java test Backport-of: f095a9ee49ba0e36e0503b6db1dce81df66f5356 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/230 From shade at openjdk.java.net Sun Aug 15 12:00:34 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Sun, 15 Aug 2021 12:00:34 GMT Subject: [jdk11u-dev] RFR: 8213409: Refactor sun.text.IntHashtable:i18n shell tests to plain java tests In-Reply-To: <9Toh3FXxaXBBnRWeC2YH1bFr38BydC7yYzurwMI7-OE=.24e77aae-93b0-4b4f-bb86-98bb6c2f8024@github.com> References: <9Toh3FXxaXBBnRWeC2YH1bFr38BydC7yYzurwMI7-OE=.24e77aae-93b0-4b4f-bb86-98bb6c2f8024@github.com> Message-ID: On Fri, 13 Aug 2021 14:30:50 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. > > Additional testing: > - [x] Affected tests still pass Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/242 From shade at openjdk.java.net Sun Aug 15 12:00:36 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Sun, 15 Aug 2021 12:00:36 GMT Subject: [jdk11u-dev] Integrated: 8213409: Refactor sun.text.IntHashtable:i18n shell tests to plain java tests In-Reply-To: <9Toh3FXxaXBBnRWeC2YH1bFr38BydC7yYzurwMI7-OE=.24e77aae-93b0-4b4f-bb86-98bb6c2f8024@github.com> References: <9Toh3FXxaXBBnRWeC2YH1bFr38BydC7yYzurwMI7-OE=.24e77aae-93b0-4b4f-bb86-98bb6c2f8024@github.com> Message-ID: On Fri, 13 Aug 2021 14:30:50 GMT, Aleksey Shipilev wrote: > Clean backport to match `11.0.13-oracle`. > > Additional testing: > - [x] Affected tests still pass This pull request has now been integrated. Changeset: 8738bb5f Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/8738bb5f82358cf98f407353deeba058d9ae117e Stats: 116 lines in 3 files changed: 30 ins; 82 del; 4 mod 8213409: Refactor sun.text.IntHashtable:i18n shell tests to plain java tests Backport-of: e048289d95294f0fb8f1607a120c04de33106000 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/242 From shade at openjdk.java.net Sun Aug 15 12:01:40 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Sun, 15 Aug 2021 12:01:40 GMT Subject: [jdk11u-dev] Integrated: 8225082: Remove IdenTrust certificate that is expiring in September 2021 In-Reply-To: References: Message-ID: On Thu, 12 Aug 2021 10:18:54 GMT, Aleksey Shipilev wrote: > Backport to match `11.0.13-oracle`. There is a conflict in `@bug` line in the test: the bug IDs are in different order. I took the liberty to change the order match the incoming patch, which would simplify future backports here. > > Additional testing: > - [x] `VerifyCACerts` test passes This pull request has now been integrated. Changeset: 55545f44 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/55545f44aef62a15086b10cccf362a01baf7d378 Stats: 34 lines in 2 files changed: 0 ins; 31 del; 3 mod 8225082: Remove IdenTrust certificate that is expiring in September 2021 Reviewed-by: phh Backport-of: 2ec45dc2dd3a6bcb4f68ee7cde5858d63614305a ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/239 From shade at openjdk.java.net Sun Aug 15 12:01:40 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Sun, 15 Aug 2021 12:01:40 GMT Subject: [jdk11u-dev] Integrated: 8230841: Remove oopDesc::equals() In-Reply-To: References: Message-ID: <5YDSvWIR2G4Z4ed5s34UaaZoqkmTbcUlXo4pHRMGKPg=.9c5f4d94-8435-477b-9834-9273db532936@github.com> On Fri, 6 Aug 2021 09:53:57 GMT, Aleksey Shipilev wrote: > This is the second patch in the series to cleanup/revert the GC BarrierSets to most current state. See the dependent ("this issue blocks" links) issues to see what is next. > > The equals APIs were added for Shenandoah GC, in the incarnation that exposed both from- and to-copies to the runtime system (see JDK-8199781). Since then, Shenandoah greatly simplified this by switching to a strong to-space invariant, which obviates the need for this API. Therefore, it was removed in JDK 14. This patch reverts JDK 11 parts to that shape as well, which should simplify 11u maintenance. This pull request has now been integrated. Changeset: 12312a39 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/12312a3906eaa88a2f07d30c57e8e5b40eb2f510 Stats: 84 lines in 33 files changed: 0 ins; 11 del; 73 mod 8230841: Remove oopDesc::equals() Reviewed-by: rkennke, clanger Backport-of: 2d6874b861270ea67322d5976a30202bdb6adb1c ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/204 From vkempik at openjdk.java.net Sun Aug 15 13:32:27 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Sun, 15 Aug 2021 13:32:27 GMT Subject: [jdk11u-dev] RFR: JDK-8253947: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: References: Message-ID: On Fri, 13 Aug 2021 12:07:37 GMT, Vladimir Kempik wrote: >> This is a more recent version of https://github.com/openjdk/jdk11u/pull/2. >> >> Changes since then: >> - [JDK-8254634](https://bugs.openjdk.java.net/browse/JDK-8254634) (backport of [Build failure with VS 2019 (16.5.0) due to C2039 and C2873](https://bugs.openjdk.java.net/browse/JDK-8241087)) was removed, as it had been committed separately. >> - [JDK-8269391](https://bugs.openjdk.java.net/browse/JDK-8269391) (backport of [AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter](https://bugs.openjdk.java.net/browse/JDK-8265756)) was added. >> - [JDK-8271095](https://bugs.openjdk.java.net/browse/JDK-8271095) (backport of [C4530 was reported from VS 2019 at access bridge](https://bugs.openjdk.java.net/browse/JDK-8263136)) was added. >> - [JDK-8271002](https://bugs.openjdk.java.net/browse/JDK-8271002) (backport of [AArch64: Fix MacroAssembler::get_thread convention](https://bugs.openjdk.java.net/browse/JDK-8261072)) was added. >> - [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) was added, containing the Windows/AArch64 related part of [JDK-8271571](https://bugs.openjdk.java.net/browse/JDK-8271571) (backport of [AArch64: Backtracing broken on PAC enabled systems](https://bugs.openjdk.java.net/browse/JDK-8266749)), necessary for a correct build. >> - Various small merge conflict resolutions. >> >> Similarly to how it was done on tip, we have incorporated parts of [JDK-8253015: Aarch64: Move linux code out from generic CPU feature detection](https://bugs.openjdk.java.net/browse/JDK-8253015) by @AntonKozlov into the [JDK-8253947: Implementation: JEP 388: Windows AArch64 Support](https://bugs.openjdk.java.net/browse/JDK-8253947) commit. >> >> Please let me know how I can make the review process easier / faster. > > Also, could you please be more specific, which parts of https://github.com/openjdk/jdk/commit/ec9bee68 were taken and which wasn't ? > it's not trivial to find them in this PR. > Thanks > @VladimirKempik, changes to > > * src/hotspot/cpu/aarch64/vm_version_aarch64.cpp, > * src/hotspot/cpu/aarch64/vm_version_aarch64.hpp, and > * src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp > > were taken over from [openjdk/jdk at ec9bee6](https://github.com/openjdk/jdk/commit/ec9bee68). However, now that we're breaking up the PR into its elements, it might make sense to backport this whole commit separately too. WDYT? Ok, I will do the JDK-8248414 ( it's already reviewed) and its follow-ups: JDK-8250824 and JDK-JDK-8251930. And Anton's fix for vm_version ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/222 From clanger at openjdk.java.net Sun Aug 15 15:27:27 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Sun, 15 Aug 2021 15:27:27 GMT Subject: [jdk11u-dev] RFR: 8272197: Update 11u GHA workflow with Shenandoah configurations In-Reply-To: <1idzbNF_UxWFlXp4bw42XZyErX4KYIvs1W0yUtgTcT8=.6bac8397-370b-4dad-970b-49fc48faf464@github.com> References: <1idzbNF_UxWFlXp4bw42XZyErX4KYIvs1W0yUtgTcT8=.6bac8397-370b-4dad-970b-49fc48faf464@github.com> Message-ID: <0k_LUFu70yOo-3XqCvVeNOWIXZSMMqxY7gw26Fi63wI=.6f20b2a6-86b5-4cfe-95ad-7bd0ce54b478@github.com> On Tue, 10 Aug 2021 07:37:58 GMT, Aleksey Shipilev wrote: > I have noticed that 11u GHA workflow builds/tests without Shenandoah. This is because Shenandoah is not enabled by default in 11u, in contrast to mainline. Which means the workflow that we have picked from mainline does not enable Shenandoah. > > Instead of changing the build defaults for 11u, I suggest we add Shenandoah configs to testing. > > Example run: > https://github.com/shipilev/jdk11u-dev/runs/3288861982 This is ok for us. We currently don't enable shenandoahgc in SapMachine 11 builds but our internal OpenJDK tests would cover the non-shenandoah configurations so we should be good. I guess most downstream vendors enable shenandoah. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/216 From shade at openjdk.java.net Mon Aug 16 05:40:29 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 16 Aug 2021 05:40:29 GMT Subject: [jdk11u-dev] RFR: 8272197: Update 11u GHA workflow with Shenandoah configurations In-Reply-To: <1idzbNF_UxWFlXp4bw42XZyErX4KYIvs1W0yUtgTcT8=.6bac8397-370b-4dad-970b-49fc48faf464@github.com> References: <1idzbNF_UxWFlXp4bw42XZyErX4KYIvs1W0yUtgTcT8=.6bac8397-370b-4dad-970b-49fc48faf464@github.com> Message-ID: <3CR14-4rFAzsv_KWkQzVkqlNfH9Ixhu5YJmmIXJ9Y5w=.c3c0b4de-f03c-4cd0-b601-63ffd78e5d94@github.com> On Tue, 10 Aug 2021 07:37:58 GMT, Aleksey Shipilev wrote: > I have noticed that 11u GHA workflow builds/tests without Shenandoah. This is because Shenandoah is not enabled by default in 11u, in contrast to mainline. Which means the workflow that we have picked from mainline does not enable Shenandoah. > > Instead of changing the build defaults for 11u, I suggest we add Shenandoah configs to testing. > > Example run: > https://github.com/shipilev/jdk11u-dev/runs/3288861982 All right, thank you! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/216 From shade at openjdk.java.net Mon Aug 16 05:40:30 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 16 Aug 2021 05:40:30 GMT Subject: [jdk11u-dev] Integrated: 8272197: Update 11u GHA workflow with Shenandoah configurations In-Reply-To: <1idzbNF_UxWFlXp4bw42XZyErX4KYIvs1W0yUtgTcT8=.6bac8397-370b-4dad-970b-49fc48faf464@github.com> References: <1idzbNF_UxWFlXp4bw42XZyErX4KYIvs1W0yUtgTcT8=.6bac8397-370b-4dad-970b-49fc48faf464@github.com> Message-ID: On Tue, 10 Aug 2021 07:37:58 GMT, Aleksey Shipilev wrote: > I have noticed that 11u GHA workflow builds/tests without Shenandoah. This is because Shenandoah is not enabled by default in 11u, in contrast to mainline. Which means the workflow that we have picked from mainline does not enable Shenandoah. > > Instead of changing the build defaults for 11u, I suggest we add Shenandoah configs to testing. > > Example run: > https://github.com/shipilev/jdk11u-dev/runs/3288861982 This pull request has now been integrated. Changeset: 3db0637a Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/3db0637a88204b33307c9d261c22459c6e023f1f Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod 8272197: Update 11u GHA workflow with Shenandoah configurations Reviewed-by: sgehwolf, clanger ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/216 From sgehwolf at openjdk.java.net Mon Aug 16 10:00:46 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 16 Aug 2021 10:00:46 GMT Subject: [jdk17u] Integrated: 8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790 In-Reply-To: References: Message-ID: On Thu, 12 Aug 2021 15:44:00 GMT, Severin Gehwolf wrote: > Hi, > > This pull request contains a backport of commit d38b3143 from the openjdk/jdk repository. The issue applies to JDK 17 as well. > > The commit being backported was authored by Severin Gehwolf on 12 Aug 2021 and was reviewed by Phil Race. This pull request has now been integrated. Changeset: e506cb23 Author: Severin Gehwolf URL: https://git.openjdk.java.net/jdk17u/commit/e506cb23cfce35d1bc997d1e280f4dc40c9b3397 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790 Backport-of: d38b31438dd4730ee2149c02277d60c35b9d7d81 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/11 From phh at openjdk.java.net Mon Aug 16 12:48:26 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Mon, 16 Aug 2021 12:48:26 GMT Subject: [jdk11u-dev] Integrated: 8248403: AArch64: Remove uses of kernel integer types In-Reply-To: References: Message-ID: <6mYaPpxSibfBN3YvhzlNQWNdfanxuZNMRqGh5lHuEj0=.065a7d2b-3901-4315-9d2e-1150f9762cd9@github.com> On Fri, 13 Aug 2021 20:05:39 GMT, Paul Hohensee wrote: > Backport applies cleanly net of context differences. Testing: tier1. This pull request has now been integrated. Changeset: 5ce46d96 Author: Paul Hohensee URL: https://git.openjdk.java.net/jdk11u-dev/commit/5ce46d9679fd9c9010bcfe55fd723a0f068b3333 Stats: 104 lines in 7 files changed: 1 ins; 0 del; 103 mod 8248403: AArch64: Remove uses of kernel integer types Reviewed-by: stuefe Backport-of: 6a91c73dda1cb197d74f0cb3b491d9c47f4bb40c ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/246 From phh at openjdk.java.net Mon Aug 16 20:22:26 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Mon, 16 Aug 2021 20:22:26 GMT Subject: [jdk11u-dev] RFR: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj In-Reply-To: References: Message-ID: On Sun, 15 Aug 2021 01:28:35 GMT, Hui Shi wrote: > Please help review this backport for 8272131: C2 crash in PhaseMacroExpand::generate_slow_arraycopy because arraycopy node's _ioproj_fallthrough is NULL. > > Conflicts when backport > In jdk18: field name is fallthrough_ioproj , and it is in PhaseMacroExpand's CallProjections class. > In jdk11: field name is _ioproj_fallthrough, and it is directly in PhaseMacroExpand class. Marked as reviewed by phh (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/250 From github.com+3094961+buddyliao at openjdk.java.net Tue Aug 17 07:34:23 2021 From: github.com+3094961+buddyliao at openjdk.java.net (BuddyLiao) Date: Tue, 17 Aug 2021 07:34:23 GMT Subject: [jdk11u-dev] RFR: 8237354: Add option to jcmd to write a gzipped heap dump In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 23:50:32 GMT, Paul Hohensee wrote: > Can you elaborate on what you had to change in the modified files? Hi Paul, thank you for your kindly review, I had elaborate on the changes at the beginning of this issue. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/209 From github.com+3094961+buddyliao at openjdk.java.net Tue Aug 17 07:50:24 2021 From: github.com+3094961+buddyliao at openjdk.java.net (BuddyLiao) Date: Tue, 17 Aug 2021 07:50:24 GMT Subject: [jdk11u-dev] RFR: 8215624: Add parallel heap iteration for jmap =?UTF-8?B?4oCTaGlzdG8=?= In-Reply-To: References: Message-ID: On Tue, 13 Jul 2021 09:50:45 GMT, BuddyLiao wrote: > Unclean backport, since original patch does not apply cleanly to 11u, because jmap command parameter is different between each other, and the code structure has little changed. > > 8215624: Add parallel heap iteration for jmap -histo > 8253763: ParallelObjectIterator should have virtual destructor Would anyone help me to review this backport? Thank you! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/127 From phh at openjdk.java.net Tue Aug 17 13:28:24 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 17 Aug 2021 13:28:24 GMT Subject: [jdk11u-dev] RFR: 8237354: Add option to jcmd to write a gzipped heap dump In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 07:08:36 GMT, BuddyLiao wrote: > Backport of the heap dump enhancement: Add option to jcmd to write a gzipped heap dump > > Patch did not apply cleanly, I had to resolve/modify > > 1) src/hotspot/share/services/heapDumper.cpp > function "int dump(const char* path, bool overwrite = false)" has some different from the jdk-master, since patch 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea is backport before this one, so this patch can't backport clearly > > 2) src/hotspot/share/services/heapDumperCompression.cpp > MonitorLockerEx is named MonitorLocker in jdk-master, MonitorLockerEx.wait should have parameters, the constructor of MonitorLockerEx and MutexUnlockerEx also different from jdk-master > > 3) src/hotspot/share/services/heapDumperCompression.hpp > FileWriter is different from jdk-master since backport of 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea before this patch. > > I have built it on linux x86_64 and run test-tier1 Thanks you for pointing that out. :) I was reading only the email. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/209 From phh at openjdk.java.net Tue Aug 17 14:52:22 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 17 Aug 2021 14:52:22 GMT Subject: [jdk11u-dev] RFR: 8237354: Add option to jcmd to write a gzipped heap dump In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 07:08:36 GMT, BuddyLiao wrote: > Backport of the heap dump enhancement: Add option to jcmd to write a gzipped heap dump > > Patch did not apply cleanly, I had to resolve/modify > > 1) src/hotspot/share/services/heapDumper.cpp > function "int dump(const char* path, bool overwrite = false)" has some different from the jdk-master, since patch 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea is backport before this one, so this patch can't backport clearly > > 2) src/hotspot/share/services/heapDumperCompression.cpp > MonitorLockerEx is named MonitorLocker in jdk-master, MonitorLockerEx.wait should have parameters, the constructor of MonitorLockerEx and MutexUnlockerEx also different from jdk-master > > 3) src/hotspot/share/services/heapDumperCompression.hpp > FileWriter is different from jdk-master since backport of 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea before this patch. > > I have built it on linux x86_64 and run test-tier1 If MonitorLockerEx.wait() needs parameters, why does the call to wait() in heapDumperCompression.cpp at line 258 lack one? The two other uses pass Mutex::_no_safepoint_check_flag, which seems the correct thing to do given that all three constructors are passed Mutex::_no_safepoint_check_flag. ------------- Changes requested by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/209 From rhalade at openjdk.java.net Tue Aug 17 16:13:57 2021 From: rhalade at openjdk.java.net (Rajan Halade) Date: Tue, 17 Aug 2021 16:13:57 GMT Subject: [jdk17u] RFR: 8225083: Remove Google certificate that is expiring in December 2021 Message-ID: Clean backport to JDK 17u ------------- Commit messages: - Backport 1cbf41a87b153c010c51fdbae832e00314422193 Changes: https://git.openjdk.java.net/jdk17u/pull/13/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=13&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8225083 Stats: 34 lines in 2 files changed: 0 ins; 31 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u/pull/13.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/13/head:pull/13 PR: https://git.openjdk.java.net/jdk17u/pull/13 From phh at openjdk.java.net Tue Aug 17 18:58:25 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 17 Aug 2021 18:58:25 GMT Subject: [jdk11u-dev] RFR: 8237354: Add option to jcmd to write a gzipped heap dump In-Reply-To: References: Message-ID: <9oFFKySMoMLezbxyS4RUGJw-8OYvaxEC7vFIaZwp1Xc=.f44f0b99-e55d-4233-8312-96e4f197ddfd@github.com> On Mon, 9 Aug 2021 07:08:36 GMT, BuddyLiao wrote: > Backport of the heap dump enhancement: Add option to jcmd to write a gzipped heap dump > > Patch did not apply cleanly, I had to resolve/modify > > 1) src/hotspot/share/services/heapDumper.cpp > function "int dump(const char* path, bool overwrite = false)" has some different from the jdk-master, since patch 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea is backport before this one, so this patch can't backport clearly > > 2) src/hotspot/share/services/heapDumperCompression.cpp > MonitorLockerEx is named MonitorLocker in jdk-master, MonitorLockerEx.wait should have parameters, the constructor of MonitorLockerEx and MutexUnlockerEx also different from jdk-master > > 3) src/hotspot/share/services/heapDumperCompression.hpp > FileWriter is different from jdk-master since backport of 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea before this patch. > > I have built it on linux x86_64 and run test-tier1 I applied the patch and ran the serviceability/dcmd/gc tests with "make run-test". HeapDumpAllTest crashed due to the lack of the the line 258 change. Adding that cured that crash, but the new HeapDumpCompressedTest test fails due to lack of a backport of [JDK-](https://bugs.openjdk.java.net/browse/JDK-8233790). 8233790 guarantees that the "Unable to create" string for which the test checks will be in the output file. That backport looks useful to me, so I'd do it as a pre-req to this one. ------------- Changes requested by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/209 From darcy at openjdk.java.net Tue Aug 17 22:37:46 2021 From: darcy at openjdk.java.net (Joe Darcy) Date: Tue, 17 Aug 2021 22:37:46 GMT Subject: [jdk17u] RFR: 8261088: Repeatable annotations without @Target cannot have containers that target module declarations Message-ID: 8261088: Repeatable annotations without @Target cannot have containers that target module declarations ------------- Commit messages: - Backport 60c11fef006124e6c2be6d958c78dc344bb777d5 Changes: https://git.openjdk.java.net/jdk17u/pull/14/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=14&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261088 Stats: 88 lines in 4 files changed: 66 ins; 16 del; 6 mod Patch: https://git.openjdk.java.net/jdk17u/pull/14.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/14/head:pull/14 PR: https://git.openjdk.java.net/jdk17u/pull/14 From darcy at openjdk.java.net Tue Aug 17 22:52:47 2021 From: darcy at openjdk.java.net (Joe Darcy) Date: Tue, 17 Aug 2021 22:52:47 GMT Subject: [jdk17u] Integrated: 8261088: Repeatable annotations without @Target cannot have containers that target module declarations In-Reply-To: References: Message-ID: On Tue, 17 Aug 2021 22:30:00 GMT, Joe Darcy wrote: > 8261088: Repeatable annotations without @Target cannot have containers that target module declarations This pull request has now been integrated. Changeset: cb7e311d Author: Joe Darcy URL: https://git.openjdk.java.net/jdk17u/commit/cb7e311dc68b4d8c7eeba5697a9a48abb0a05cff Stats: 88 lines in 4 files changed: 66 ins; 16 del; 6 mod 8261088: Repeatable annotations without @Target cannot have containers that target module declarations Backport-of: 60c11fef006124e6c2be6d958c78dc344bb777d5 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/14 From github.com+3094961+buddyliao at openjdk.java.net Wed Aug 18 02:31:21 2021 From: github.com+3094961+buddyliao at openjdk.java.net (BuddyLiao) Date: Wed, 18 Aug 2021 02:31:21 GMT Subject: [jdk11u-dev] RFR: 8237354: Add option to jcmd to write a gzipped heap dump In-Reply-To: <9oFFKySMoMLezbxyS4RUGJw-8OYvaxEC7vFIaZwp1Xc=.f44f0b99-e55d-4233-8312-96e4f197ddfd@github.com> References: <9oFFKySMoMLezbxyS4RUGJw-8OYvaxEC7vFIaZwp1Xc=.f44f0b99-e55d-4233-8312-96e4f197ddfd@github.com> Message-ID: On Tue, 17 Aug 2021 18:56:02 GMT, Paul Hohensee wrote: > I applied the patch and ran the serviceability/dcmd/gc tests with "make run-test". HeapDumpAllTest crashed due to the lack of the the line 258 change. Adding that cured that crash, but the new HeapDumpCompressedTest test failed due to lack of a backport of [JDK-8233790](https://bugs.openjdk.java.net/browse/JDK-8233790). 8233790 guarantees that the "Unable to create" string for which the test checks will be in the output file. That backport looks useful to me, so I'd do it as a pre-req to this one. Hi Paul, thank you for pointing out the lack of line 258, I will fix it and update the patch. I know JDK-8233790 is a fix for the HeapDumpCompressedTest, I will backport it after this patch merge. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/209 From github.com+3094961+buddyliao at openjdk.java.net Wed Aug 18 02:44:41 2021 From: github.com+3094961+buddyliao at openjdk.java.net (BuddyLiao) Date: Wed, 18 Aug 2021 02:44:41 GMT Subject: [jdk11u-dev] RFR: 8237354: Add option to jcmd to write a gzipped heap dump [v2] In-Reply-To: References: Message-ID: > Backport of the heap dump enhancement: Add option to jcmd to write a gzipped heap dump > > Patch did not apply cleanly, I had to resolve/modify > > 1) src/hotspot/share/services/heapDumper.cpp > function "int dump(const char* path, bool overwrite = false)" has some different from the jdk-master, since patch 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea is backport before this one, so this patch can't backport clearly > > 2) src/hotspot/share/services/heapDumperCompression.cpp > MonitorLockerEx is named MonitorLocker in jdk-master, MonitorLockerEx.wait should have parameters, the constructor of MonitorLockerEx and MutexUnlockerEx also different from jdk-master > > 3) src/hotspot/share/services/heapDumperCompression.hpp > FileWriter is different from jdk-master since backport of 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea before this patch. > > I have built it on linux x86_64 and run test-tier1 BuddyLiao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'master' of https://git.openjdk.java.net/jdk11u-dev into backport-19be49714356f2f598924c9fefa6358679ab6dbe - Backport 19be49714356f2f598924c9fefa6358679ab6dbe ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/209/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=209&range=01 Stats: 1758 lines in 13 files changed: 1638 ins; 52 del; 68 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/209.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/209/head:pull/209 PR: https://git.openjdk.java.net/jdk11u-dev/pull/209 From github.com+3094961+buddyliao at openjdk.java.net Wed Aug 18 02:44:42 2021 From: github.com+3094961+buddyliao at openjdk.java.net (BuddyLiao) Date: Wed, 18 Aug 2021 02:44:42 GMT Subject: [jdk11u-dev] RFR: 8237354: Add option to jcmd to write a gzipped heap dump [v2] In-Reply-To: References: Message-ID: On Tue, 17 Aug 2021 14:49:09 GMT, Paul Hohensee wrote: > If MonitorLockerEx.wait() needs parameters, why does the call to wait() in heapDumperCompression.cpp at line 258 lack one? The two other uses pass Mutex::_no_safepoint_check_flag, which seems the correct thing to do given that all three constructors are passed Mutex::_no_safepoint_check_flag. Thank you for pointing out this, I have fixed it. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/209 From thartmann at openjdk.java.net Wed Aug 18 10:10:55 2021 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 18 Aug 2021 10:10:55 GMT Subject: [jdk17u] RFR: 8271925: ZGC: Arraycopy stub passes invalid oop to load barrier Message-ID: Backport of [JDK-8271925](https://bugs.openjdk.java.net/browse/JDK-8271925). Applies cleanly. ------------- Commit messages: - 8271925: ZGC: Arraycopy stub passes invalid oop to load barrier Changes: https://git.openjdk.java.net/jdk17u/pull/15/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=15&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271925 Stats: 9 lines in 1 file changed: 3 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk17u/pull/15.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/15/head:pull/15 PR: https://git.openjdk.java.net/jdk17u/pull/15 From thartmann at openjdk.java.net Wed Aug 18 10:13:52 2021 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 18 Aug 2021 10:13:52 GMT Subject: [jdk17u] RFR: 8270098: ZGC: ZBarrierSetC2::clone_at_expansion fails with "Guard against surprises" assert Message-ID: Backport of [JDK-8270098](https://bugs.openjdk.java.net/browse/JDK-8270098). Applies cleanly. ------------- Commit messages: - 8270098: ZGC: ZBarrierSetC2::clone_at_expansion fails with "Guard against surprises" assert Changes: https://git.openjdk.java.net/jdk17u/pull/16/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=16&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270098 Stats: 106 lines in 2 files changed: 83 ins; 11 del; 12 mod Patch: https://git.openjdk.java.net/jdk17u/pull/16.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/16/head:pull/16 PR: https://git.openjdk.java.net/jdk17u/pull/16 From goetz at openjdk.java.net Wed Aug 18 10:16:41 2021 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 18 Aug 2021 10:16:41 GMT Subject: [jdk11u] RFR: Merge jdk11u-dev:master Message-ID: Merge changes for build 3 to jdk11u ------------- Commit messages: - Merge - 8248403: AArch64: Remove uses of kernel integer types - 8272197: Update 11u GHA workflow with Shenandoah configurations - 8225082: Remove IdenTrust certificate that is expiring in September 2021 - 8230841: Remove oopDesc::equals() - 8209768: Refactor java/util/prefs/CheckUserPrefsStorage.sh to plain java test - 8213409: Refactor sun.text.IntHashtable:i18n shell tests to plain java tests - 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open - 8214520: [TEST_BUG] sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java failed with incorrect jtreg tags order - 8262862: Harden tests sun/security/x509/URICertStore/ExtensionsWithLDAP.java and krb5/canonicalize/Test.java - ... and 29 more: https://git.openjdk.java.net/jdk11u/compare/fdbaa230...18387aec The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.java.net/jdk11u/pull/8/files Stats: 4139 lines in 168 files changed: 2291 ins; 1360 del; 488 mod Patch: https://git.openjdk.java.net/jdk11u/pull/8.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/8/head:pull/8 PR: https://git.openjdk.java.net/jdk11u/pull/8 From thartmann at openjdk.java.net Wed Aug 18 10:16:47 2021 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 18 Aug 2021 10:16:47 GMT Subject: [jdk17u] RFR: 8268019: C2: assert(no_dead_loop) failed: dead loop detected Message-ID: Backport of [JDK-8268019](https://bugs.openjdk.java.net/browse/JDK-8268019). Applies cleanly. ------------- Commit messages: - 8268019: C2: assert(no_dead_loop) failed: dead loop detected Changes: https://git.openjdk.java.net/jdk17u/pull/17/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=17&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268019 Stats: 83 lines in 2 files changed: 78 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk17u/pull/17.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/17/head:pull/17 PR: https://git.openjdk.java.net/jdk17u/pull/17 From thartmann at openjdk.java.net Wed Aug 18 10:23:55 2021 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 18 Aug 2021 10:23:55 GMT Subject: [jdk17u] RFR: 8268963: [IR Framework] Some default regexes matching on PrintOptoAssembly in IRNode.java do not work on all platforms Message-ID: Backport of [JDK-8268963](https://bugs.openjdk.java.net/browse/JDK-8268963). Applies cleanly. ------------- Commit messages: - 8268963: [IR Framework] Some default regexes matching on PrintOptoAssembly in IRNode.java do not work on all platforms Changes: https://git.openjdk.java.net/jdk17u/pull/18/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=18&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268963 Stats: 331 lines in 7 files changed: 193 ins; 26 del; 112 mod Patch: https://git.openjdk.java.net/jdk17u/pull/18.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/18/head:pull/18 PR: https://git.openjdk.java.net/jdk17u/pull/18 From shade at openjdk.java.net Wed Aug 18 10:40:43 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 18 Aug 2021 10:40:43 GMT Subject: [jdk11u-dev] RFR: 8272628: Problemlist gc/stress/gcbasher/TestGCBasherWithCMS.java for x86_32 Message-ID: <73PhuI6Atst9FUfQFFkaWto9QwbonYBYxfypkIXl3_E=.fc6dcb49-9494-44ca-a220-d47f56f0fde1@github.com> This problem-lists the failing CMS test for x86_32 to get clean GHA runs. Additional testing: - [x] Linux x86_64 fastdebug, test still runs and passes - [x] Linux x86_32 fastdebug, test is now skipped ------------- Commit messages: - 8272628: Problemlist gc/stress/gcbasher/TestGCBasherWithCMS.java for x86_32 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/252/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=252&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272628 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/252.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/252/head:pull/252 PR: https://git.openjdk.java.net/jdk11u-dev/pull/252 From thartmann at openjdk.java.net Wed Aug 18 10:43:45 2021 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 18 Aug 2021 10:43:45 GMT Subject: [jdk17u] RFR: 8271276: C2: Wrong JVM state used for receiver null check Message-ID: Backport of [JDK-8271276](https://bugs.openjdk.java.net/browse/JDK-8271276). Applies cleanly. ------------- Commit messages: - 8271276: C2: Wrong JVM state used for receiver null check Changes: https://git.openjdk.java.net/jdk17u/pull/19/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=19&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271276 Stats: 57 lines in 2 files changed: 50 ins; 7 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u/pull/19.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/19/head:pull/19 PR: https://git.openjdk.java.net/jdk17u/pull/19 From thartmann at openjdk.java.net Wed Aug 18 10:47:56 2021 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 18 Aug 2021 10:47:56 GMT Subject: [jdk17u] RFR: 8271203: C2: assert(iff->Opcode() == Op_If || iff->Opcode() == Op_CountedLoopEnd || iff->Opcode() == Op_RangeCheck) failed: Check this code when new subtype is added Message-ID: Backport of [JDK-8271203](https://bugs.openjdk.java.net/browse/JDK-8271203). Applies cleanly. ------------- Commit messages: - 8271203: C2: assert(iff->Opcode() == Op_If || iff->Opcode() == Op_CountedLoopEnd || iff->Opcode() == Op_RangeCheck) failed: Check this code when new subtype is added Changes: https://git.openjdk.java.net/jdk17u/pull/20/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=20&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271203 Stats: 66 lines in 2 files changed: 64 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u/pull/20.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/20/head:pull/20 PR: https://git.openjdk.java.net/jdk17u/pull/20 From thartmann at openjdk.java.net Wed Aug 18 10:48:00 2021 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 18 Aug 2021 10:48:00 GMT Subject: [jdk17u] RFR: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj Message-ID: Backport of [JDK-8272131](https://bugs.openjdk.java.net/browse/JDK-8272131). Applies cleanly. ------------- Commit messages: - 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj Changes: https://git.openjdk.java.net/jdk17u/pull/21/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=21&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272131 Stats: 75 lines in 2 files changed: 71 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk17u/pull/21.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/21/head:pull/21 PR: https://git.openjdk.java.net/jdk17u/pull/21 From phh at openjdk.java.net Wed Aug 18 12:01:35 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 18 Aug 2021 12:01:35 GMT Subject: [jdk11u-dev] RFR: 8237354: Add option to jcmd to write a gzipped heap dump [v2] In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 02:44:41 GMT, BuddyLiao wrote: >> Backport of the heap dump enhancement: Add option to jcmd to write a gzipped heap dump >> >> Patch did not apply cleanly, I had to resolve/modify >> >> 1) src/hotspot/share/services/heapDumper.cpp >> function "int dump(const char* path, bool overwrite = false)" has some different from the jdk-master, since patch 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea is backport before this one, so this patch can't backport clearly >> >> 2) src/hotspot/share/services/heapDumperCompression.cpp >> MonitorLockerEx is named MonitorLocker in jdk-master, MonitorLockerEx.wait should have parameters, the constructor of MonitorLockerEx and MutexUnlockerEx also different from jdk-master >> >> 3) src/hotspot/share/services/heapDumperCompression.hpp >> FileWriter is different from jdk-master since backport of 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea before this patch. >> >> I have built it on linux x86_64 and run test-tier1 > > BuddyLiao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' of https://git.openjdk.java.net/jdk11u-dev into backport-19be49714356f2f598924c9fefa6358679ab6dbe > - Backport 19be49714356f2f598924c9fefa6358679ab6dbe I strongly recommend backporting JDK-8233790 first. The general update release rule is to backport dependencies first, then the dependent issue. It's easier to review that way. Also, I doubt the maintainers will approve a backport such as this one that breaks a test, even if the test is broken for only a short time. At a minimum, automated test systems will notice the failure and provoke work on the part of their owners. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/209 From sgehwolf at openjdk.java.net Wed Aug 18 12:38:27 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Wed, 18 Aug 2021 12:38:27 GMT Subject: [jdk11u-dev] RFR: 8272628: Problemlist gc/stress/gcbasher/TestGCBasherWithCMS.java for x86_32 In-Reply-To: <73PhuI6Atst9FUfQFFkaWto9QwbonYBYxfypkIXl3_E=.fc6dcb49-9494-44ca-a220-d47f56f0fde1@github.com> References: <73PhuI6Atst9FUfQFFkaWto9QwbonYBYxfypkIXl3_E=.fc6dcb49-9494-44ca-a220-d47f56f0fde1@github.com> Message-ID: On Wed, 18 Aug 2021 10:36:00 GMT, Aleksey Shipilev wrote: > This problem-lists the failing CMS test for x86_32 to get clean GHA runs. > > Additional testing: > - [x] Linux x86_64 fastdebug, test still runs and passes > - [x] Linux x86_32 fastdebug, test is now skipped LGTM ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/252 From shade at openjdk.java.net Wed Aug 18 12:40:44 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 18 Aug 2021 12:40:44 GMT Subject: [jdk11u-dev] RFR: 8213007: Update the link in test/jdk/sun/security/provider/SecureRandom/DrbgCavp.java Message-ID: Clean backport to match 11.0.13-oracle. ------------- Commit messages: - Backport ae77ef7d7a4633474f7d1a45b9246f13c0711d23 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/253/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=253&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8213007 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/253.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/253/head:pull/253 PR: https://git.openjdk.java.net/jdk11u-dev/pull/253 From shade at openjdk.java.net Wed Aug 18 12:49:46 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 18 Aug 2021 12:49:46 GMT Subject: [jdk11u-dev] RFR: 8225790: Two NestedDialogs tests fail on Ubuntu Message-ID: Clean backport to stabilize the tests and match `11.0.13-oracle`. Additional testing: - [x] Ubuntu 20.04 passes ------------- Commit messages: - Backport 21e67e54604e60f57106be32d48ba75ebf8c1130 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/254/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=254&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8225790 Stats: 788 lines in 4 files changed: 81 ins; 610 del; 97 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/254.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/254/head:pull/254 PR: https://git.openjdk.java.net/jdk11u-dev/pull/254 From shade at openjdk.java.net Wed Aug 18 12:58:31 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 18 Aug 2021 12:58:31 GMT Subject: [jdk11u-dev] RFR: 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException Message-ID: Clean backport to stabilize the test and match `11.0.13-oracle`. ------------- Commit messages: - Backport 54dfd47fa838614926363ff0f9b5bbc91c3792d0 - Backport eccfec498d4062b582282f3b73bba84206a36046 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/255/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=255&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8219804 Stats: 32 lines in 1 file changed: 23 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/255.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/255/head:pull/255 PR: https://git.openjdk.java.net/jdk11u-dev/pull/255 From thartmann at openjdk.java.net Wed Aug 18 13:23:39 2021 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 18 Aug 2021 13:23:39 GMT Subject: [jdk17u] Integrated: 8270098: ZGC: ZBarrierSetC2::clone_at_expansion fails with "Guard against surprises" assert In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 10:07:11 GMT, Tobias Hartmann wrote: > Backport of [JDK-8270098](https://bugs.openjdk.java.net/browse/JDK-8270098). Applies cleanly. This pull request has now been integrated. Changeset: 52c3e7dc Author: Tobias Hartmann URL: https://git.openjdk.java.net/jdk17u/commit/52c3e7dcf19339ec91ba0050b2fc00a58f99caae Stats: 106 lines in 2 files changed: 83 ins; 11 del; 12 mod 8270098: ZGC: ZBarrierSetC2::clone_at_expansion fails with "Guard against surprises" assert Backport-of: 2384e128886ce8d60cb76e6cdae3a76ccebb9e89 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/16 From thartmann at openjdk.java.net Wed Aug 18 13:24:38 2021 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 18 Aug 2021 13:24:38 GMT Subject: [jdk17u] Integrated: 8268019: C2: assert(no_dead_loop) failed: dead loop detected In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 10:08:35 GMT, Tobias Hartmann wrote: > Backport of [JDK-8268019](https://bugs.openjdk.java.net/browse/JDK-8268019). Applies cleanly. This pull request has now been integrated. Changeset: 90341dbc Author: Tobias Hartmann URL: https://git.openjdk.java.net/jdk17u/commit/90341dbccdc02f686b0d672a4b4ec109e30f9d17 Stats: 83 lines in 2 files changed: 78 ins; 0 del; 5 mod 8268019: C2: assert(no_dead_loop) failed: dead loop detected Backport-of: 489e5fd12a37a45f4f5ea64b05f85c6f99f70811 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/17 From thartmann at openjdk.java.net Wed Aug 18 13:25:40 2021 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 18 Aug 2021 13:25:40 GMT Subject: [jdk17u] Integrated: 8271925: ZGC: Arraycopy stub passes invalid oop to load barrier In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 10:02:25 GMT, Tobias Hartmann wrote: > Backport of [JDK-8271925](https://bugs.openjdk.java.net/browse/JDK-8271925). Applies cleanly. This pull request has now been integrated. Changeset: 9489ab7b Author: Tobias Hartmann URL: https://git.openjdk.java.net/jdk17u/commit/9489ab7b8b882fe15730fb6723b5c26ce27ed7f9 Stats: 9 lines in 1 file changed: 3 ins; 0 del; 6 mod 8271925: ZGC: Arraycopy stub passes invalid oop to load barrier Backport-of: d53d94b14d09bbcbfd9bbc0d214ead9bd52e7f58 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/15 From thartmann at openjdk.java.net Wed Aug 18 13:26:27 2021 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 18 Aug 2021 13:26:27 GMT Subject: [jdk17u] Integrated: 8268963: [IR Framework] Some default regexes matching on PrintOptoAssembly in IRNode.java do not work on all platforms In-Reply-To: References: Message-ID: <_Fryzca0pQ4iCDrdMdBV6oysfeSHoHt1iv5Pbk9-aNY=.bb1615b9-0cd2-425d-a14f-aee6973b4ac5@github.com> On Wed, 18 Aug 2021 10:15:28 GMT, Tobias Hartmann wrote: > Backport of [JDK-8268963](https://bugs.openjdk.java.net/browse/JDK-8268963). Applies cleanly. This pull request has now been integrated. Changeset: 32f026ab Author: Tobias Hartmann URL: https://git.openjdk.java.net/jdk17u/commit/32f026ab7464596ad9452d9b67b51601989b9c8a Stats: 331 lines in 7 files changed: 193 ins; 26 del; 112 mod 8268963: [IR Framework] Some default regexes matching on PrintOptoAssembly in IRNode.java do not work on all platforms Backport-of: 9856ace828617d3f2f9a6282e650009d3af65749 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/18 From goetz at openjdk.java.net Wed Aug 18 13:37:00 2021 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 18 Aug 2021 13:37:00 GMT Subject: [jdk11u] RFR: Merge jdk11u-dev:master [v2] In-Reply-To: References: Message-ID: > Merge changes for build 3 to jdk11u Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge - Merge ------------- Changes: - all: https://git.openjdk.java.net/jdk11u/pull/8/files - new: https://git.openjdk.java.net/jdk11u/pull/8/files/18387aec..18387aec Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=8&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=8&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u/pull/8.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/8/head:pull/8 PR: https://git.openjdk.java.net/jdk11u/pull/8 From goetz at openjdk.java.net Wed Aug 18 13:37:02 2021 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 18 Aug 2021 13:37:02 GMT Subject: [jdk11u] Integrated: Merge jdk11u-dev:master In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 08:04:38 GMT, Goetz Lindenmaier wrote: > Merge changes for build 3 to jdk11u This pull request has now been integrated. Changeset: 3a32efcd Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u/commit/3a32efcd73fb33243bcf6598907b773080be926c Stats: 4139 lines in 168 files changed: 2291 ins; 1360 del; 488 mod Merge ------------- PR: https://git.openjdk.java.net/jdk11u/pull/8 From zgu at openjdk.java.net Wed Aug 18 14:06:30 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 18 Aug 2021 14:06:30 GMT Subject: [jdk11u-dev] Integrated: 8226319: Add forgotten test/jdk/java/net/httpclient/BodySubscribersTest.java In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 13:24:06 GMT, Zhengyu Gu wrote: > A clean backport to add missing test case of JDK-8225583. This pull request has now been integrated. Changeset: 6722cee4 Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk11u-dev/commit/6722cee430ebaa33b0a5ace9cd69c5b54e1af062 Stats: 159 lines in 1 file changed: 159 ins; 0 del; 0 mod 8226319: Add forgotten test/jdk/java/net/httpclient/BodySubscribersTest.java Reviewed-by: shade Backport-of: d577d9c678b9b14227731d9cf7b2328100d66428 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/213 From thartmann at openjdk.java.net Wed Aug 18 14:11:47 2021 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 18 Aug 2021 14:11:47 GMT Subject: [jdk17u] Integrated: 8271276: C2: Wrong JVM state used for receiver null check In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 10:35:37 GMT, Tobias Hartmann wrote: > Backport of [JDK-8271276](https://bugs.openjdk.java.net/browse/JDK-8271276). Applies cleanly. This pull request has now been integrated. Changeset: 66bd0d57 Author: Tobias Hartmann URL: https://git.openjdk.java.net/jdk17u/commit/66bd0d57ee29ad0fed0cd201a5420cb08854508f Stats: 57 lines in 2 files changed: 50 ins; 7 del; 0 mod 8271276: C2: Wrong JVM state used for receiver null check Backport-of: e8f1219d6f471c89fe15b19c56e3062dd668466f ------------- PR: https://git.openjdk.java.net/jdk17u/pull/19 From thartmann at openjdk.java.net Wed Aug 18 14:12:39 2021 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 18 Aug 2021 14:12:39 GMT Subject: [jdk17u] Integrated: 8271203: C2: assert(iff->Opcode() == Op_If || iff->Opcode() == Op_CountedLoopEnd || iff->Opcode() == Op_RangeCheck) failed: Check this code when new subtype is added In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 10:39:26 GMT, Tobias Hartmann wrote: > Backport of [JDK-8271203](https://bugs.openjdk.java.net/browse/JDK-8271203). Applies cleanly. This pull request has now been integrated. Changeset: 8a20dfe5 Author: Tobias Hartmann URL: https://git.openjdk.java.net/jdk17u/commit/8a20dfe5467d1ab8d04dcc0f347610ec35737a6b Stats: 66 lines in 2 files changed: 64 ins; 0 del; 2 mod 8271203: C2: assert(iff->Opcode() == Op_If || iff->Opcode() == Op_CountedLoopEnd || iff->Opcode() == Op_RangeCheck) failed: Check this code when new subtype is added Backport-of: 3f38a50c528cccc30ca9e513b15ce9866d92aa82 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/20 From zgu at openjdk.java.net Wed Aug 18 14:26:28 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 18 Aug 2021 14:26:28 GMT Subject: [jdk11u-dev] Integrated: 8226602: Test convenience reactive primitives from java.net.http with RS TCK In-Reply-To: References: Message-ID: On Wed, 11 Aug 2021 13:34:03 GMT, Zhengyu Gu wrote: > A clean backport for parity with Oracle 11.0.14. > > Test: > - [x] All new tests passed on Linux x86_64 This pull request has now been integrated. Changeset: 0621d9d3 Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk11u-dev/commit/0621d9d3963d55df2a2b51bfbeed1403a5bfb5df Stats: 9984 lines in 57 files changed: 9984 ins; 0 del; 0 mod 8226602: Test convenience reactive primitives from java.net.http with RS TCK Backport-of: 3395bb591bd55bd7a510b5045c201f3d130b16a2 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/232 From thartmann at openjdk.java.net Wed Aug 18 15:22:34 2021 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 18 Aug 2021 15:22:34 GMT Subject: [jdk17u] Integrated: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 10:41:19 GMT, Tobias Hartmann wrote: > Backport of [JDK-8272131](https://bugs.openjdk.java.net/browse/JDK-8272131). Applies cleanly. This pull request has now been integrated. Changeset: 790d9a9f Author: Tobias Hartmann URL: https://git.openjdk.java.net/jdk17u/commit/790d9a9fdaaf074f5fefa5dcc60a0a1f538e8653 Stats: 75 lines in 2 files changed: 71 ins; 0 del; 4 mod 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj Backport-of: 5350b9901c6cebe5d40bbba9a31d1f26285b1cd6 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/21 From shade at openjdk.java.net Wed Aug 18 15:48:27 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 18 Aug 2021 15:48:27 GMT Subject: [jdk11u-dev] RFR: 8272628: Problemlist gc/stress/gcbasher/TestGCBasherWithCMS.java for x86_32 In-Reply-To: <73PhuI6Atst9FUfQFFkaWto9QwbonYBYxfypkIXl3_E=.fc6dcb49-9494-44ca-a220-d47f56f0fde1@github.com> References: <73PhuI6Atst9FUfQFFkaWto9QwbonYBYxfypkIXl3_E=.fc6dcb49-9494-44ca-a220-d47f56f0fde1@github.com> Message-ID: On Wed, 18 Aug 2021 10:36:00 GMT, Aleksey Shipilev wrote: > This problem-lists the failing CMS test for x86_32 to get clean GHA runs. > > Additional testing: > - [x] Linux x86_64 fastdebug, test still runs and passes > - [x] Linux x86_32 fastdebug, test is now skipped Thank you, got the push approval as well. I'll integrate to reduce noise in 11u testing. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/252 From shade at openjdk.java.net Wed Aug 18 15:48:27 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 18 Aug 2021 15:48:27 GMT Subject: [jdk11u-dev] Integrated: 8272628: Problemlist gc/stress/gcbasher/TestGCBasherWithCMS.java for x86_32 In-Reply-To: <73PhuI6Atst9FUfQFFkaWto9QwbonYBYxfypkIXl3_E=.fc6dcb49-9494-44ca-a220-d47f56f0fde1@github.com> References: <73PhuI6Atst9FUfQFFkaWto9QwbonYBYxfypkIXl3_E=.fc6dcb49-9494-44ca-a220-d47f56f0fde1@github.com> Message-ID: On Wed, 18 Aug 2021 10:36:00 GMT, Aleksey Shipilev wrote: > This problem-lists the failing CMS test for x86_32 to get clean GHA runs. > > Additional testing: > - [x] Linux x86_64 fastdebug, test still runs and passes > - [x] Linux x86_32 fastdebug, test is now skipped This pull request has now been integrated. Changeset: 8f402b26 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/8f402b26c164241b0ac705a5c42c80c646872fe7 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8272628: Problemlist gc/stress/gcbasher/TestGCBasherWithCMS.java for x86_32 Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/252 From shade at openjdk.java.net Wed Aug 18 16:28:43 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 18 Aug 2021 16:28:43 GMT Subject: [jdk11u-dev] RFR: 8251358: Clean up Access configuration after Shenandoah barrier change Message-ID: This is third (and final) patch in the series to cleanup/revert the GC BarrierSets to most current state. The primitive accesses APIs were added for Shenandoah GC, in the incarnation that exposed both from- and to-copies to the runtime system (see JDK-8199781). Since then, Shenandoah greatly simplified this by switching to a strong to-space invariant, which obviates the need for this API. Therefore, it was removed in JDK 14. This patch reverts JDK 11 parts to that shape as well, which should simplify 11u maintenance. This patch effectively reverts additions of: 8199735: Mark word updates need to use Access API 8251358: Clean up Access configuration after Shenandoah barrier change Note that it leaves HeapAccess barriers over mark words, which means the GC code would potentially experience (nop, empty) GC barriers when accessing mark word. While awkward, this is the way current post-JDK-8251358 behaves. This should probably be cleaned up upstream first, see JDK-8272654. ------------- Commit messages: - Backport e63b90cc17d3ad08361f0a959f919ae79dd768bf Changes: https://git.openjdk.java.net/jdk11u-dev/pull/251/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=251&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8251358 Stats: 238 lines in 43 files changed: 1 ins; 91 del; 146 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/251.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/251/head:pull/251 PR: https://git.openjdk.java.net/jdk11u-dev/pull/251 From hseigel at openjdk.java.net Wed Aug 18 18:54:42 2021 From: hseigel at openjdk.java.net (Harold Seigel) Date: Wed, 18 Aug 2021 18:54:42 GMT Subject: [jdk17u] Integrated: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon Message-ID: The patch for this backport applied cleanly and was tested by running the accompanying test and regression tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows. and Mach5 tiers 3-5 on Linux x64 and Linux aarch64. Harold ------------- Commit messages: - Backport 4d6593ce0243457e7431a5990957a8f880e0a3fb Changes: https://git.openjdk.java.net/jdk17u/pull/22/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=22&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272124 Stats: 57 lines in 2 files changed: 54 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u/pull/22.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/22/head:pull/22 PR: https://git.openjdk.java.net/jdk17u/pull/22 From hseigel at openjdk.java.net Wed Aug 18 18:54:42 2021 From: hseigel at openjdk.java.net (Harold Seigel) Date: Wed, 18 Aug 2021 18:54:42 GMT Subject: [jdk17u] Integrated: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 18:46:34 GMT, Harold Seigel wrote: > The patch for this backport applied cleanly and was tested by running the accompanying test and regression tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows. and Mach5 tiers 3-5 on Linux x64 and Linux aarch64. > Harold This pull request has now been integrated. Changeset: f0028333 Author: Harold Seigel URL: https://git.openjdk.java.net/jdk17u/commit/f0028333d83c39b434c26f66a6a92e446e7047cd Stats: 57 lines in 2 files changed: 54 ins; 0 del; 3 mod 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon Backport-of: 4d6593ce0243457e7431a5990957a8f880e0a3fb ------------- PR: https://git.openjdk.java.net/jdk17u/pull/22 From rhalade at openjdk.java.net Wed Aug 18 20:30:36 2021 From: rhalade at openjdk.java.net (Rajan Halade) Date: Wed, 18 Aug 2021 20:30:36 GMT Subject: [jdk17u] Integrated: 8225083: Remove Google certificate that is expiring in December 2021 In-Reply-To: References: Message-ID: On Tue, 17 Aug 2021 16:07:11 GMT, Rajan Halade wrote: > Hi all, > > This pull request contains a clean backport of commit 1cbf41a8 from the openjdk/jdk repository. > > The commit being backported was authored by Rajan Halade on 17 Aug 2021 and was reviewed by Xue-Lei Andrew Fan and Sean Mullan. > > Thanks! This pull request has now been integrated. Changeset: 551354e0 Author: Rajan Halade URL: https://git.openjdk.java.net/jdk17u/commit/551354e0d3c7fba5c304c20fc38db38e3c49b01d Stats: 34 lines in 2 files changed: 0 ins; 31 del; 3 mod 8225083: Remove Google certificate that is expiring in December 2021 Backport-of: 1cbf41a87b153c010c51fdbae832e00314422193 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/13 From hshi at openjdk.java.net Thu Aug 19 00:59:27 2021 From: hshi at openjdk.java.net (Hui Shi) Date: Thu, 19 Aug 2021 00:59:27 GMT Subject: [jdk11u-dev] RFR: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj In-Reply-To: References: Message-ID: On Mon, 16 Aug 2021 20:19:08 GMT, Paul Hohensee wrote: >> Please help review this backport for 8272131: C2 crash in PhaseMacroExpand::generate_slow_arraycopy because arraycopy node's _ioproj_fallthrough is NULL. >> >> Conflicts when backport >> In jdk18: field name is fallthrough_ioproj , and it is in PhaseMacroExpand's CallProjections class. >> In jdk11: field name is _ioproj_fallthrough, and it is directly in PhaseMacroExpand class. > > Marked as reviewed by phh (Reviewer). @phohensee Thanks for your review. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/250 From github.com+3094961+buddyliao at openjdk.java.net Thu Aug 19 01:12:24 2021 From: github.com+3094961+buddyliao at openjdk.java.net (BuddyLiao) Date: Thu, 19 Aug 2021 01:12:24 GMT Subject: [jdk11u-dev] RFR: 8237354: Add option to jcmd to write a gzipped heap dump [v2] In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 11:58:24 GMT, Paul Hohensee wrote: > I strongly recommend backporting JDK-8233790 first. The general update release rule is to backport dependencies first, then the dependent issue. It's easier to review that way. Also, I doubt the maintainers will approve a backport such as this one that breaks a test, even if the test is broken for only a short time. At a minimum, automated test systems will notice the failure and provoke work on the part of their owners. Sounds reasonable, I will backport JDK-8233790 first. Thank you for your suggestion. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/209 From tvoniadka at openjdk.java.net Thu Aug 19 03:19:46 2021 From: tvoniadka at openjdk.java.net (Thejasvi Voniadka) Date: Thu, 19 Aug 2021 03:19:46 GMT Subject: [jdk17u] RFR: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails Message-ID: This is a straight, clean backport of the following bug: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails The patch applies cleanly, and the test passes on all platforms post the fix. ------------- Commit messages: - Backport 45abbeed2f4f2899a3c1595b0cd8e573990a16fa Changes: https://git.openjdk.java.net/jdk17u/pull/23/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=23&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8243543 Stats: 246 lines in 2 files changed: 49 ins; 7 del; 190 mod Patch: https://git.openjdk.java.net/jdk17u/pull/23.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/23/head:pull/23 PR: https://git.openjdk.java.net/jdk17u/pull/23 From tvoniadka at openjdk.java.net Thu Aug 19 04:18:28 2021 From: tvoniadka at openjdk.java.net (Thejasvi Voniadka) Date: Thu, 19 Aug 2021 04:18:28 GMT Subject: [jdk17u] Integrated: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails In-Reply-To: References: Message-ID: On Thu, 19 Aug 2021 03:11:45 GMT, Thejasvi Voniadka wrote: > This is a straight, clean backport of the following bug: > > 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails > > The patch applies cleanly, and the test passes on all platforms post the fix. This pull request has now been integrated. Changeset: efeb10b5 Author: Thejasvi Voniadka Committer: Abdul Kolarkunnu URL: https://git.openjdk.java.net/jdk17u/commit/efeb10b5ca589d6095ce1100770396e8a84ff5c5 Stats: 246 lines in 2 files changed: 49 ins; 7 del; 190 mod 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails Backport-of: 45abbeed2f4f2899a3c1595b0cd8e573990a16fa ------------- PR: https://git.openjdk.java.net/jdk17u/pull/23 From tvoniadka at openjdk.java.net Thu Aug 19 04:34:46 2021 From: tvoniadka at openjdk.java.net (Thejasvi Voniadka) Date: Thu, 19 Aug 2021 04:34:46 GMT Subject: [jdk17u] Integrated: 8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java OCSP response error Message-ID: This is a straight, clean backport of the following change: 8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java OCSP response error Patch applies clean, and test passes on all platforms post patch. ------------- Commit messages: - Backport f4b3ee5dca8cfdc2fbb8ee64a1e8cdb8894b0061 Changes: https://git.openjdk.java.net/jdk17u/pull/24/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=24&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270280 Stats: 29 lines in 2 files changed: 0 ins; 4 del; 25 mod Patch: https://git.openjdk.java.net/jdk17u/pull/24.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/24/head:pull/24 PR: https://git.openjdk.java.net/jdk17u/pull/24 From tvoniadka at openjdk.java.net Thu Aug 19 04:34:46 2021 From: tvoniadka at openjdk.java.net (Thejasvi Voniadka) Date: Thu, 19 Aug 2021 04:34:46 GMT Subject: [jdk17u] Integrated: 8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java OCSP response error In-Reply-To: References: Message-ID: On Thu, 19 Aug 2021 04:20:31 GMT, Thejasvi Voniadka wrote: > This is a straight, clean backport of the following change: > > 8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java OCSP response error > > Patch applies clean, and test passes on all platforms post patch. This pull request has now been integrated. Changeset: e9fd4b9f Author: Thejasvi Voniadka Committer: Abdul Kolarkunnu URL: https://git.openjdk.java.net/jdk17u/commit/e9fd4b9fc41cbb0c0005a2770628c143f5cfb7c1 Stats: 29 lines in 2 files changed: 0 ins; 4 del; 25 mod 8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java OCSP response error Backport-of: f4b3ee5dca8cfdc2fbb8ee64a1e8cdb8894b0061 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/24 From tvoniadka at openjdk.java.net Thu Aug 19 04:47:42 2021 From: tvoniadka at openjdk.java.net (Thejasvi Voniadka) Date: Thu, 19 Aug 2021 04:47:42 GMT Subject: [jdk17u] RFR: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked Message-ID: This is a straight, clean backport of the following change: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked The patch applies clean, and the test passes on all platforms following the change. ------------- Commit messages: - Backport d6bb846159be7e46fba0c3ca2915617f945e0b42 Changes: https://git.openjdk.java.net/jdk17u/pull/25/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=25&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8248899 Stats: 380 lines in 2 files changed: 34 ins; 32 del; 314 mod Patch: https://git.openjdk.java.net/jdk17u/pull/25.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/25/head:pull/25 PR: https://git.openjdk.java.net/jdk17u/pull/25 From tvoniadka at openjdk.java.net Thu Aug 19 05:14:28 2021 From: tvoniadka at openjdk.java.net (Thejasvi Voniadka) Date: Thu, 19 Aug 2021 05:14:28 GMT Subject: [jdk17u] Integrated: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked In-Reply-To: References: Message-ID: On Thu, 19 Aug 2021 04:37:15 GMT, Thejasvi Voniadka wrote: > This is a straight, clean backport of the following change: > > 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked > > The patch applies clean, and the test passes on all platforms following the change. This pull request has now been integrated. Changeset: 704e6b93 Author: Thejasvi Voniadka Committer: Abdul Kolarkunnu URL: https://git.openjdk.java.net/jdk17u/commit/704e6b93aaa3a411f87b591902209e6b32140a8f Stats: 380 lines in 2 files changed: 34 ins; 32 del; 314 mod 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked Backport-of: d6bb846159be7e46fba0c3ca2915617f945e0b42 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/25 From github.com+3094961+buddyliao at openjdk.java.net Thu Aug 19 05:58:22 2021 From: github.com+3094961+buddyliao at openjdk.java.net (BuddyLiao) Date: Thu, 19 Aug 2021 05:58:22 GMT Subject: [jdk11u-dev] RFR: 8237354: Add option to jcmd to write a gzipped heap dump [v2] In-Reply-To: References: Message-ID: On Thu, 19 Aug 2021 01:08:58 GMT, BuddyLiao wrote: > I strongly recommend backporting JDK-8233790 first. The general update release rule is to backport dependencies first, then the dependent issue. It's easier to review that way. Also, I doubt the maintainers will approve a backport such as this one that breaks a test, even if the test is broken for only a short time. At a minimum, automated test systems will notice the failure and provoke work on the part of their owners. Hi Paul, I have backported JDK-8233790 in https://github.com/openjdk/jdk11u-dev/pull/256, would you help me to review this patch first? Thank you. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/209 From github.com+3094961+buddyliao at openjdk.java.net Thu Aug 19 05:58:32 2021 From: github.com+3094961+buddyliao at openjdk.java.net (BuddyLiao) Date: Thu, 19 Aug 2021 05:58:32 GMT Subject: [jdk11u-dev] RFR: 8233790: Forward output from heap dumper to jcmd/jmap Message-ID: <3nq2lxQx57gzahXjY5KpLdoWPBm55JtCkTPUVyWIiQU=.4c9f3ab5-dbfd-48c1-8507-e89263afb83c@github.com> Backport of the heap dump enhancement: Forward output from heap dumper to jcmd/jmap Patch did not apply cleanly, I had to resolve/modify src/hotspot/share/services/diagnosticCommand.cpp src/hotspot/share/services/heapDumper.cpp src/hotspot/share/services/heapDumper.hpp since patch 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea is backport before this one, so this patch can't backport cleanly ------------- Commit messages: - Backport b2a967382980bbaca2c2f7d08eab565024ede40e Changes: https://git.openjdk.java.net/jdk11u-dev/pull/256/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=256&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8233790 Stats: 47 lines in 4 files changed: 3 ins; 29 del; 15 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/256.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/256/head:pull/256 PR: https://git.openjdk.java.net/jdk11u-dev/pull/256 From shade at openjdk.java.net Thu Aug 19 07:09:41 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 19 Aug 2021 07:09:41 GMT Subject: [jdk11u-dev] RFR: 8236177: assert(status == 0) failed: error ETIMEDOUT(60), cond_wait Message-ID: <1rBksZr1JQiKmh3h8T4SNMgk4ZTrh5M_gbwF17u_fag=.13725ecf-5af4-4b32-bc6a-f425493a1f5f@github.com> Unclean backport: some of `pthread_cond_wait` uses are not present in 11u (added later by JDK-8210832), I ignored them. ------------- Commit messages: - Backport 91ed3fc599583270d180c44efc3f1793dfa69325 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/257/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=257&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8236177 Stats: 12 lines in 2 files changed: 10 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/257.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/257/head:pull/257 PR: https://git.openjdk.java.net/jdk11u-dev/pull/257 From shade at openjdk.java.net Thu Aug 19 08:59:36 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 19 Aug 2021 08:59:36 GMT Subject: [jdk17u] RFR: 8269924: Shenandoah: Introduce weak/strong marking asserts Message-ID: Clean backport. Additional testing: - [x] `hotspot_gc_shenandoah` is passing ------------- Commit messages: - Backport 515113d8589875e76980ebf7473cb81f778bb86f Changes: https://git.openjdk.java.net/jdk17u/pull/26/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=26&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269924 Stats: 46 lines in 2 files changed: 46 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u/pull/26.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/26/head:pull/26 PR: https://git.openjdk.java.net/jdk17u/pull/26 From shade at openjdk.java.net Thu Aug 19 09:06:39 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 19 Aug 2021 09:06:39 GMT Subject: [jdk17u] RFR: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient Message-ID: Clean backport to improve test stability. Additional testing: - [x] Affected tests still pass ------------- Commit messages: - Backport 23d2996fee54afcc386a505a65d3236aab874e9e Changes: https://git.openjdk.java.net/jdk17u/pull/27/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=27&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269478 Stats: 97 lines in 2 files changed: 68 ins; 18 del; 11 mod Patch: https://git.openjdk.java.net/jdk17u/pull/27.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/27/head:pull/27 PR: https://git.openjdk.java.net/jdk17u/pull/27 From shade at openjdk.java.net Thu Aug 19 09:14:35 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 19 Aug 2021 09:14:35 GMT Subject: [jdk17u] RFR: 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode Message-ID: Clean backport to stabilize the test. Additional testing: - [x] Affected test still passes ------------- Commit messages: - Backport 4f322a9b6c9cfdf080df23326daa45733f1b9aad Changes: https://git.openjdk.java.net/jdk17u/pull/28/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=28&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270096 Stats: 17 lines in 1 file changed: 7 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/jdk17u/pull/28.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/28/head:pull/28 PR: https://git.openjdk.java.net/jdk17u/pull/28 From shade at openjdk.java.net Thu Aug 19 09:27:40 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 19 Aug 2021 09:27:40 GMT Subject: [jdk11u-dev] RFR: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient Message-ID: Clean backport to improve test stability. Additional testing: - [x] Affected tests still pass ------------- Commit messages: - Backport 23d2996fee54afcc386a505a65d3236aab874e9e Changes: https://git.openjdk.java.net/jdk11u-dev/pull/258/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=258&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269478 Stats: 97 lines in 2 files changed: 68 ins; 18 del; 11 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/258.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/258/head:pull/258 PR: https://git.openjdk.java.net/jdk11u-dev/pull/258 From shade at openjdk.java.net Thu Aug 19 09:34:52 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 19 Aug 2021 09:34:52 GMT Subject: [jdk11u-dev] RFR: 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode Message-ID: Clean backport to stabilize the test. Additional testing: - [x] Affected test still passes ------------- Commit messages: - Backport 4f322a9b6c9cfdf080df23326daa45733f1b9aad Changes: https://git.openjdk.java.net/jdk11u-dev/pull/259/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=259&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270096 Stats: 17 lines in 1 file changed: 7 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/259.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/259/head:pull/259 PR: https://git.openjdk.java.net/jdk11u-dev/pull/259 From shade at openjdk.java.net Thu Aug 19 10:12:57 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 19 Aug 2021 10:12:57 GMT Subject: [jdk17u] RFR: 8270094: Shenandoah: Provide human-readable labels for test configurations Message-ID: Clean backport to improve testing UX. Additional testing: - [x] hotspot_gc_shenandoah passes ------------- Commit messages: - Backport 676f1d76cab9108655f2ce462db321b975563eb7 Changes: https://git.openjdk.java.net/jdk17u/pull/29/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=29&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270094 Stats: 227 lines in 81 files changed: 19 ins; 0 del; 208 mod Patch: https://git.openjdk.java.net/jdk17u/pull/29.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/29/head:pull/29 PR: https://git.openjdk.java.net/jdk17u/pull/29 From shade at openjdk.java.net Thu Aug 19 12:29:37 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 19 Aug 2021 12:29:37 GMT Subject: [jdk11u-dev] RFR: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1 Message-ID: <-rREx2zK_B5taJxeu2p9CLmOCVCfzAUVmaUd2wQJMUU=.6706b7e9-b2f4-4bc1-8c71-8f0961d68055@github.com> Unclean backport, because the context is a bit different (StoreVal -> IU renaming already happened). Additional testing: - [x] Affected test still passes on AArch64, x86_64 - [ ] `hotspot_gc_shenandoah` passes on AArch64 ------------- Commit messages: - Backport 4fb1980fd0539230fdc310aad63bbda8cb1725e6 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/260/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=260&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8252853 Stats: 16 lines in 2 files changed: 6 ins; 7 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/260.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/260/head:pull/260 PR: https://git.openjdk.java.net/jdk11u-dev/pull/260 From zgu at openjdk.java.net Thu Aug 19 12:43:29 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Thu, 19 Aug 2021 12:43:29 GMT Subject: [jdk11u-dev] RFR: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1 In-Reply-To: <-rREx2zK_B5taJxeu2p9CLmOCVCfzAUVmaUd2wQJMUU=.6706b7e9-b2f4-4bc1-8c71-8f0961d68055@github.com> References: <-rREx2zK_B5taJxeu2p9CLmOCVCfzAUVmaUd2wQJMUU=.6706b7e9-b2f4-4bc1-8c71-8f0961d68055@github.com> Message-ID: <2-URavQFRWspc8rHBhFD0IJ8wBFNOGkmdTjflmMHq-w=.b1c05746-66c6-4360-b42c-eda913c4f676@github.com> On Thu, 19 Aug 2021 12:23:02 GMT, Aleksey Shipilev wrote: > Unclean backport, because the context is a bit different (StoreVal -> IU renaming already happened). > > Additional testing: > - [x] Affected test still passes on AArch64, x86_64 > - [ ] `hotspot_gc_shenandoah` passes on AArch64 Looks good. ------------- Marked as reviewed by zgu (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/260 From hshi at openjdk.java.net Thu Aug 19 12:58:34 2021 From: hshi at openjdk.java.net (Hui Shi) Date: Thu, 19 Aug 2021 12:58:34 GMT Subject: [jdk11u-dev] Integrated: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj In-Reply-To: References: Message-ID: On Sun, 15 Aug 2021 01:28:35 GMT, Hui Shi wrote: > Please help review this backport for 8272131: C2 crash in PhaseMacroExpand::generate_slow_arraycopy because arraycopy node's _ioproj_fallthrough is NULL. > > Conflicts when backport > In jdk18: field name is fallthrough_ioproj , and it is in PhaseMacroExpand's CallProjections class. > In jdk11: field name is _ioproj_fallthrough, and it is directly in PhaseMacroExpand class. This pull request has now been integrated. Changeset: 90d52935 Author: Hui Shi Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk11u-dev/commit/90d529355b0fa36ca3378efae8dc6ba4b5203869 Stats: 75 lines in 2 files changed: 71 ins; 0 del; 4 mod 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj Reviewed-by: phh ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/250 From rkennke at openjdk.java.net Thu Aug 19 13:45:23 2021 From: rkennke at openjdk.java.net (Roman Kennke) Date: Thu, 19 Aug 2021 13:45:23 GMT Subject: [jdk11u-dev] RFR: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1 In-Reply-To: <-rREx2zK_B5taJxeu2p9CLmOCVCfzAUVmaUd2wQJMUU=.6706b7e9-b2f4-4bc1-8c71-8f0961d68055@github.com> References: <-rREx2zK_B5taJxeu2p9CLmOCVCfzAUVmaUd2wQJMUU=.6706b7e9-b2f4-4bc1-8c71-8f0961d68055@github.com> Message-ID: On Thu, 19 Aug 2021 12:23:02 GMT, Aleksey Shipilev wrote: > Unclean backport, because the context is a bit different (StoreVal -> IU renaming already happened). > > Additional testing: > - [x] Affected test still passes on AArch64, x86_64 > - [ ] `hotspot_gc_shenandoah` passes on AArch64 Marked as reviewed by rkennke (Committer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/260 From phh at openjdk.java.net Thu Aug 19 19:18:24 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Thu, 19 Aug 2021 19:18:24 GMT Subject: [jdk11u-dev] RFR: 8233790: Forward output from heap dumper to jcmd/jmap In-Reply-To: <3nq2lxQx57gzahXjY5KpLdoWPBm55JtCkTPUVyWIiQU=.4c9f3ab5-dbfd-48c1-8507-e89263afb83c@github.com> References: <3nq2lxQx57gzahXjY5KpLdoWPBm55JtCkTPUVyWIiQU=.4c9f3ab5-dbfd-48c1-8507-e89263afb83c@github.com> Message-ID: On Thu, 19 Aug 2021 05:53:02 GMT, BuddyLiao wrote: > Backport of the heap dump enhancement: Forward output from heap dumper to jcmd/jmap > > Patch did not apply cleanly, I had to resolve/modify > src/hotspot/share/services/diagnosticCommand.cpp > src/hotspot/share/services/heapDumper.cpp > src/hotspot/share/services/heapDumper.hpp > > since patch 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea is backport before this one, so this patch can't backport cleanly Marked as reviewed by phh (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/256 From phh at openjdk.java.net Thu Aug 19 19:31:23 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Thu, 19 Aug 2021 19:31:23 GMT Subject: [jdk11u-dev] RFR: 8248414: AArch64: Remove uses of long and unsigned long ints [v2] In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 19:30:10 GMT, Vladimir Kempik wrote: >> This is a backport of 8248414 to jdk11u-dev >> >> The backport didn't apply clean, partially due to backport of JDK-8247766 >> >> It's needed for mac-aarch and win-aarch64 ports >> >> It will be followed by 8250824 and 8251930. >> >> Sections of aarch64.ad file between line 10260-12560 were regenerated from aarch64_ad.m4 >> >> Original commit - https://github.com/openjdk/jdk/commit/c7d84850bfdbd112a495fab453a79832e3810f47 > > Vladimir Kempik has updated the pull request incrementally with two additional commits since the last revision: > > - LogicalImmOp update > - python file update Hi, Vladimir. Note that the current patch has a conflict in immediate_aarch64.cpp due to the backport of JDK-8248403. Note that your current patch has a conflict due to the backport of JDK-8248403. Please update the PR. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/215 From vkempik at openjdk.java.net Thu Aug 19 21:08:42 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Thu, 19 Aug 2021 21:08:42 GMT Subject: [jdk11u-dev] RFR: 8248414: AArch64: Remove uses of long and unsigned long ints [v3] In-Reply-To: References: Message-ID: <1dijA_mQVgrBysPVyeYs-TG2CBvvOjr2NIM7SLG5h8Y=.99d3f246-3381-44bc-85fd-8ba4da62aeae@github.com> > This is a backport of 8248414 to jdk11u-dev > > The backport didn't apply clean, partially due to backport of JDK-8247766 > > It's needed for mac-aarch and win-aarch64 ports > > It will be followed by 8250824 and 8251930. > > Sections of aarch64.ad file between line 10260-12560 were regenerated from aarch64_ad.m4 > > Original commit - https://github.com/openjdk/jdk/commit/c7d84850bfdbd112a495fab453a79832e3810f47 Vladimir Kempik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge branch 'master' into JDK-8248414_1 - LogicalImmOp update - python file update - few more long removals - 8248414: AArch64: Remove uses of long and unsigned long ints ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/215/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=215&range=02 Stats: 567 lines in 22 files changed: 321 ins; 9 del; 237 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/215.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/215/head:pull/215 PR: https://git.openjdk.java.net/jdk11u-dev/pull/215 From vkempik at openjdk.java.net Thu Aug 19 21:08:43 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Thu, 19 Aug 2021 21:08:43 GMT Subject: [jdk11u-dev] RFR: 8248414: AArch64: Remove uses of long and unsigned long ints [v2] In-Reply-To: References: Message-ID: <2MVb7pQPObZScK4iw1mDhLxFW-_MtChWHpgfT2f5Fxo=.f8b247a0-bff5-47ae-90d9-a69cd6787130@github.com> On Mon, 9 Aug 2021 19:30:10 GMT, Vladimir Kempik wrote: >> This is a backport of 8248414 to jdk11u-dev >> >> The backport didn't apply clean, partially due to backport of JDK-8247766 >> >> It's needed for mac-aarch and win-aarch64 ports >> >> It will be followed by 8250824 and 8251930. >> >> Sections of aarch64.ad file between line 10260-12560 were regenerated from aarch64_ad.m4 >> >> Original commit - https://github.com/openjdk/jdk/commit/c7d84850bfdbd112a495fab453a79832e3810f47 > > Vladimir Kempik has updated the pull request incrementally with two additional commits since the last revision: > > - LogicalImmOp update > - python file update Thanks for heads up! fixed merge conflict ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/215 From phh at openjdk.java.net Thu Aug 19 21:25:25 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Thu, 19 Aug 2021 21:25:25 GMT Subject: [jdk11u-dev] RFR: 8248414: AArch64: Remove uses of long and unsigned long ints [v3] In-Reply-To: <1dijA_mQVgrBysPVyeYs-TG2CBvvOjr2NIM7SLG5h8Y=.99d3f246-3381-44bc-85fd-8ba4da62aeae@github.com> References: <1dijA_mQVgrBysPVyeYs-TG2CBvvOjr2NIM7SLG5h8Y=.99d3f246-3381-44bc-85fd-8ba4da62aeae@github.com> Message-ID: On Thu, 19 Aug 2021 21:08:42 GMT, Vladimir Kempik wrote: >> This is a backport of 8248414 to jdk11u-dev >> >> The backport didn't apply clean, partially due to backport of JDK-8247766 >> >> It's needed for mac-aarch and win-aarch64 ports >> >> It will be followed by 8250824 and 8251930. >> >> Sections of aarch64.ad file between line 10260-12560 were regenerated from aarch64_ad.m4 >> >> Original commit - https://github.com/openjdk/jdk/commit/c7d84850bfdbd112a495fab453a79832e3810f47 > > Vladimir Kempik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: > > - Merge branch 'master' into JDK-8248414_1 > - LogicalImmOp update > - python file update > - few more long removals > - 8248414: AArch64: Remove uses of long and unsigned long ints Marked as reviewed by phh (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/215 From vkempik at azul.com Thu Aug 19 22:03:54 2021 From: vkempik at azul.com (Vladimir Kempik) Date: Thu, 19 Aug 2021 22:03:54 +0000 Subject: 11.0.12.1 might be needed due to JDK-8272602. 13 and 15 too. Message-ID: <336F0933-E478-4D69-9C98-91EA0B083AB1@azul.com> Hello Just heads up. https://bugs.openjdk.java.net/browse/JDK-8260616 introduced regression https://bugs.openjdk.java.net/browse/JDK-8272602 This affects openjdk 11/13/15 release trains ( and Oracle?s jdk11 too). The fix is WiP. The issue is macos-only. The issue affects netbeans, Idea (if running using openjdk, not JBR), some other (yet to be discovered) apps. As soon as it?s ready and backported, do we want to have 11.0.12.1 release ? Yuri, same applies to 13/15. Regards, Vladimir. From lzang at openjdk.java.net Fri Aug 20 01:56:21 2021 From: lzang at openjdk.java.net (Lin Zang) Date: Fri, 20 Aug 2021 01:56:21 GMT Subject: [jdk11u-dev] RFR: 8233790: Forward output from heap dumper to jcmd/jmap In-Reply-To: <3nq2lxQx57gzahXjY5KpLdoWPBm55JtCkTPUVyWIiQU=.4c9f3ab5-dbfd-48c1-8507-e89263afb83c@github.com> References: <3nq2lxQx57gzahXjY5KpLdoWPBm55JtCkTPUVyWIiQU=.4c9f3ab5-dbfd-48c1-8507-e89263afb83c@github.com> Message-ID: <5DpDNBwCOG2Ia5Lhs2RxybbctSOJeC_iPcLXlQLjb_A=.4d74475c-3725-4fa3-9af9-83e5b96d6a4a@github.com> On Thu, 19 Aug 2021 05:53:02 GMT, Bin Liao wrote: > Backport of the heap dump enhancement: Forward output from heap dumper to jcmd/jmap > > Patch did not apply cleanly, I had to resolve/modify > src/hotspot/share/services/diagnosticCommand.cpp > src/hotspot/share/services/heapDumper.cpp > src/hotspot/share/services/heapDumper.hpp > > since patch 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea is backport before this one, so this patch can't backport cleanly I have helped to add "jdk11u-fix-request" label at https://bugs.openjdk.java.net/browse/JDK-8233790. Thanks! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/256 From lzang at openjdk.java.net Fri Aug 20 01:57:23 2021 From: lzang at openjdk.java.net (Lin Zang) Date: Fri, 20 Aug 2021 01:57:23 GMT Subject: [jdk11u-dev] RFR: 8237354: Add option to jcmd to write a gzipped heap dump [v2] In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 02:44:41 GMT, Bin Liao wrote: >> Backport of the heap dump enhancement: Add option to jcmd to write a gzipped heap dump >> >> Patch did not apply cleanly, I had to resolve/modify >> >> 1) src/hotspot/share/services/heapDumper.cpp >> function "int dump(const char* path, bool overwrite = false)" has some different from the jdk-master, since patch 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea is backport before this one, so this patch can't backport clearly >> >> 2) src/hotspot/share/services/heapDumperCompression.cpp >> MonitorLockerEx is named MonitorLocker in jdk-master, MonitorLockerEx.wait should have parameters, the constructor of MonitorLockerEx and MutexUnlockerEx also different from jdk-master >> >> 3) src/hotspot/share/services/heapDumperCompression.hpp >> FileWriter is different from jdk-master since backport of 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea before this patch. >> >> I have built it on linux x86_64 and run test-tier1 > > Bin Liao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' of https://git.openjdk.java.net/jdk11u-dev into backport-19be49714356f2f598924c9fefa6358679ab6dbe > - Backport 19be49714356f2f598924c9fefa6358679ab6dbe I have helped to add "jdk11u-fix-request" label at https://bugs.openjdk.java.net/browse/JDK-8237354 Thanks! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/209 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 20 06:17:31 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 20 Aug 2021 06:17:31 GMT Subject: [jdk11u-dev] RFR: 8248671: AArch64: Remove unused variables Message-ID: Tiny change, applies cleanly. ------------- Commit messages: - Backport dff37f89c5db93ce12f45334c4ab1d02390dea95 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/261/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=261&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8248671 Stats: 2 lines in 2 files changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/261.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/261/head:pull/261 PR: https://git.openjdk.java.net/jdk11u-dev/pull/261 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 20 06:40:33 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 20 Aug 2021 06:40:33 GMT Subject: [jdk11u-dev] RFR: 8248666: AArch64: Use THREAD_LOCAL instead of __thread Message-ID: Not a clean backport. Original patch used a macro called THREAD_LOCAL, this backport uses THREAD_LOCAL_DECL. THREAD_LOCAL_DECL was renamed to THREAD_LOCAL by [JDK-8230877](https://bugs.openjdk.java.net/browse/JDK-8230877) in JDK 14. Testing: tier1. ------------- Commit messages: - Backport 2f8653fbf0f4ed2ab0e40b2bb541ef2eff913469 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/262/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=262&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8248666 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/262.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/262/head:pull/262 PR: https://git.openjdk.java.net/jdk11u-dev/pull/262 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 20 07:01:38 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 20 Aug 2021 07:01:38 GMT Subject: [jdk11u-dev] RFR: 8248668: AArch64: Avoid MIN/MAX macros when using MSVC Message-ID: Changes apply cleanly. Testing: tier1. ------------- Commit messages: - Backport 26680f0c1a998d41f87170b2d5a6487932ed33bb Changes: https://git.openjdk.java.net/jdk11u-dev/pull/263/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=263&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8248668 Stats: 5 lines in 3 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/263.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/263/head:pull/263 PR: https://git.openjdk.java.net/jdk11u-dev/pull/263 From snazarki at openjdk.java.net Fri Aug 20 07:03:35 2021 From: snazarki at openjdk.java.net (Sergey Nazarkin) Date: Fri, 20 Aug 2021 07:03:35 GMT Subject: [jdk13u-dev] Integrated: 8229254: solaris_x64 build fails after JDK-8191278 In-Reply-To: References: Message-ID: <0cAghYb59RRWyl_nvkDzXH2QkQJymAduSdvyDnPMXp8=.c8ade602-44f0-4d8f-ae0b-7acbc67bd738@github.com> On Thu, 29 Jul 2021 12:42:18 GMT, Sergey Nazarkin wrote: > This is follow up for JDK-8191278. Applies cleanly. This pull request has now been integrated. Changeset: 2ce25659 Author: Sergey Nazarkin Committer: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk13u-dev/commit/2ce2565983f67474c5dbf8e8a8276d0b62b540f6 Stats: 5 lines in 2 files changed: 4 ins; 0 del; 1 mod 8229254: solaris_x64 build fails after JDK-8191278 Backport-of: 9e633ae0657897636a4ade580a7a2e9844252389 ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/245 From vkempik at openjdk.java.net Fri Aug 20 07:17:05 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Fri, 20 Aug 2021 07:17:05 GMT Subject: [jdk15u-dev] RFR: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used Message-ID: Clean backport to 15u ------------- Commit messages: - Backport ddcd851c43aa97477c7e406490c0c7c7d71ac629 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/91/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=91&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272602 Stats: 110 lines in 2 files changed: 108 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/91.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/91/head:pull/91 PR: https://git.openjdk.java.net/jdk15u-dev/pull/91 From vkempik at openjdk.java.net Fri Aug 20 07:19:52 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Fri, 20 Aug 2021 07:19:52 GMT Subject: [jdk13u-dev] RFR: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used Message-ID: Clean backport to jdk13u-dev ------------- Commit messages: - Backport ddcd851c43aa97477c7e406490c0c7c7d71ac629 Changes: https://git.openjdk.java.net/jdk13u-dev/pull/253/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=253&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272602 Stats: 110 lines in 2 files changed: 108 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/253.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/253/head:pull/253 PR: https://git.openjdk.java.net/jdk13u-dev/pull/253 From vkempik at openjdk.java.net Fri Aug 20 07:23:38 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Fri, 20 Aug 2021 07:23:38 GMT Subject: [jdk11u-dev] RFR: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used Message-ID: Clean backport to jdk11u-dev ------------- Commit messages: - Backport ddcd851c43aa97477c7e406490c0c7c7d71ac629 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/264/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=264&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272602 Stats: 110 lines in 2 files changed: 108 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/264.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/264/head:pull/264 PR: https://git.openjdk.java.net/jdk11u-dev/pull/264 From yan at openjdk.java.net Fri Aug 20 07:26:22 2021 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Fri, 20 Aug 2021 07:26:22 GMT Subject: [jdk15u-dev] RFR: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 07:08:31 GMT, Vladimir Kempik wrote: > Clean backport to 15u It would be nice to run some manual client tests in addition to the regular DEV run ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/91 From yan at openjdk.java.net Fri Aug 20 07:29:28 2021 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Fri, 20 Aug 2021 07:29:28 GMT Subject: [jdk13u-dev] RFR: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 07:11:43 GMT, Vladimir Kempik wrote: > Clean backport to jdk13u-dev for 13 even more, could you run some additional client tests? ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/253 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 20 07:43:22 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 20 Aug 2021 07:43:22 GMT Subject: [jdk11u-dev] RFR: JDK-8253947: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: References: Message-ID: On Sun, 15 Aug 2021 13:29:16 GMT, Vladimir Kempik wrote: > > @VladimirKempik, changes to > > > > * src/hotspot/cpu/aarch64/vm_version_aarch64.cpp, > > * src/hotspot/cpu/aarch64/vm_version_aarch64.hpp, and > > * src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp > > > > were taken over from [openjdk/jdk at ec9bee6](https://github.com/openjdk/jdk/commit/ec9bee68). However, now that we're breaking up the PR into its elements, it might make sense to backport this whole commit separately too. WDYT? > > Ok, I will do the JDK-8248414 ( it's already reviewed) and its follow-ups: JDK-8250824 and JDK-JDK-8251930. Thank you. I assume these are prerequisites to JDK-8253015. > And Anton's fix for vm_version Which one is that? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/222 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 20 07:43:22 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 20 Aug 2021 07:43:22 GMT Subject: [jdk11u-dev] RFR: JDK-8253947: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: References: Message-ID: On Fri, 13 Aug 2021 20:35:22 GMT, Paul Hohensee wrote: >> This is a more recent version of https://github.com/openjdk/jdk11u/pull/2. >> >> Changes since then: >> - [JDK-8254634](https://bugs.openjdk.java.net/browse/JDK-8254634) (backport of [Build failure with VS 2019 (16.5.0) due to C2039 and C2873](https://bugs.openjdk.java.net/browse/JDK-8241087)) was removed, as it had been committed separately. >> - [JDK-8269391](https://bugs.openjdk.java.net/browse/JDK-8269391) (backport of [AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter](https://bugs.openjdk.java.net/browse/JDK-8265756)) was added. >> - [JDK-8271095](https://bugs.openjdk.java.net/browse/JDK-8271095) (backport of [C4530 was reported from VS 2019 at access bridge](https://bugs.openjdk.java.net/browse/JDK-8263136)) was added. >> - [JDK-8271002](https://bugs.openjdk.java.net/browse/JDK-8271002) (backport of [AArch64: Fix MacroAssembler::get_thread convention](https://bugs.openjdk.java.net/browse/JDK-8261072)) was added. >> - [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) was added, containing the Windows/AArch64 related part of [JDK-8271571](https://bugs.openjdk.java.net/browse/JDK-8271571) (backport of [AArch64: Backtracing broken on PAC enabled systems](https://bugs.openjdk.java.net/browse/JDK-8266749)), necessary for a correct build. >> - Various small merge conflict resolutions. >> >> Similarly to how it was done on tip, we have incorporated parts of [JDK-8253015: Aarch64: Move linux code out from generic CPU feature detection](https://bugs.openjdk.java.net/browse/JDK-8253015) by @AntonKozlov into the [JDK-8253947: Implementation: JEP 388: Windows AArch64 Support](https://bugs.openjdk.java.net/browse/JDK-8253947) commit. >> >> Please let me know how I can make the review process easier / faster. > > I've posted a backport PR for [JDK-8248403](https://bugs.openjdk.java.net/browse/JDK-8248403) at [#246](https://github.com/openjdk/jdk11u-dev/pull/246). Following @phohensee's list of JBS issues, links to the individual PRs: - #246 - #215 - #261 - #262 - #263 - 8248657: Windows: strengthening in ThreadCritical regarding memory model - 8248682: AArch64: Use ATTRIBUTE_ALIGNED helper - 8250810: Push missing parts of JDK-8248817 - 8250824: AArch64: follow up for JDK-8248414 - 8248816: C1: Fix signature mismatch of LIRGenerator::strengh_reduce_multiply - 8253015: Aarch64: Move linux code out from generic CPU feature detection **(new)** - 8248238: Implementation: JEP 388: Windows AArch64 Support - 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build - 8254827: JVMCI: Enable it for Windows+AArch64 - 8261072: AArch64: Fix MacroAssembler::get_thread convention - 8263136: C4530 was reported from VS 2019 at access bridge - 8265756: AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter - 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC - 8272181: Windows-AArch64: Backport fix of `Backtracing broken on PAC enabled systems` ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/222 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 20 08:17:35 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 20 Aug 2021 08:17:35 GMT Subject: [jdk11u-dev] RFR: 8248657: Windows: strengthening in ThreadCritical regarding memory model Message-ID: Removed line [L59](https://github.com/openjdk/jdk11u-dev/pull/265/files#diff-7eb55bd4224b99f2ae0f2df4c3e65e586af8998933eeeba6ea4615ce558a36fbL59) in src/hotspot/os/windows/threadCritical_windows.cpp has changed between 11 and tip ([JDK-8234740](https://bugs.openjdk.java.net/browse/JDK-8234740)), otherwise the backport is clean. Testing: tier1. ------------- Commit messages: - Backport 6af643e5a1f9f22ecd29a652ebfb9b6d0bf210a4 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/265/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=265&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8248657 Stats: 37 lines in 1 file changed: 8 ins; 20 del; 9 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/265.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/265/head:pull/265 PR: https://git.openjdk.java.net/jdk11u-dev/pull/265 From vkempik at openjdk.java.net Fri Aug 20 08:38:26 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Fri, 20 Aug 2021 08:38:26 GMT Subject: [jdk11u-dev] RFR: JDK-8253947: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: References: Message-ID: <2zfZ38NtIrZVIuIHMwp-G6Zz4-j6-rlMIP2Kx6LJOgE=.1e10bb3a-3cc2-4a3f-9e4e-57878910b54c@github.com> On Sun, 15 Aug 2021 13:29:16 GMT, Vladimir Kempik wrote: >> Also, could you please be more specific, which parts of https://github.com/openjdk/jdk/commit/ec9bee68 were taken and which wasn't ? >> it's not trivial to find them in this PR. >> Thanks > >> @VladimirKempik, changes to >> >> * src/hotspot/cpu/aarch64/vm_version_aarch64.cpp, >> * src/hotspot/cpu/aarch64/vm_version_aarch64.hpp, and >> * src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp >> >> were taken over from [openjdk/jdk at ec9bee6](https://github.com/openjdk/jdk/commit/ec9bee68). However, now that we're breaking up the PR into its elements, it might make sense to backport this whole commit separately too. WDYT? > > Ok, I will do the JDK-8248414 ( it's already reviewed) and its follow-ups: JDK-8250824 and JDK-JDK-8251930. > And Anton's fix for vm_version > > > @VladimirKempik, changes to > > > > > > * src/hotspot/cpu/aarch64/vm_version_aarch64.cpp, > > > * src/hotspot/cpu/aarch64/vm_version_aarch64.hpp, and > > > * src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp > > > > > > were taken over from [openjdk/jdk at ec9bee6](https://github.com/openjdk/jdk/commit/ec9bee68). However, now that we're breaking up the PR into its elements, it might make sense to backport this whole commit separately too. WDYT? > > > > > > Ok, I will do the JDK-8248414 ( it's already reviewed) and its follow-ups: JDK-8250824 and JDK-JDK-8251930. > > Thank you. I assume these are prerequisites to JDK-8253015. > > > And Anton's fix for vm_version > > Which one is that? You can take https://bugs.openjdk.java.net/browse/JDK-8253015 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/222 From vkempik at openjdk.java.net Fri Aug 20 08:41:34 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Fri, 20 Aug 2021 08:41:34 GMT Subject: [jdk13u-dev] RFR: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used In-Reply-To: References: Message-ID: <9qRcUfxv3h00RvVvjaCRo4sNwqgg-MzO7yMmqVvTLZM=.22864902-21ab-450b-b614-c5b33536c7b4@github.com> On Fri, 20 Aug 2021 07:11:43 GMT, Vladimir Kempik wrote: > Clean backport to jdk13u-dev running tier1/tier2 atm, will check netbeans too ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/253 From luhenry at openjdk.java.net Fri Aug 20 09:32:23 2021 From: luhenry at openjdk.java.net (Ludovic Henry) Date: Fri, 20 Aug 2021 09:32:23 GMT Subject: [jdk11u-dev] RFR: 8248668: AArch64: Avoid MIN/MAX macros when using MSVC In-Reply-To: References: Message-ID: <14dT06g0eTO5myNndGqEK_u8d6jsfXe26xI2p5pS_TI=.91fd35a5-c379-4159-96ff-0f74dc530a05@github.com> On Fri, 20 Aug 2021 06:52:08 GMT, Reka Kovacs wrote: > Changes apply cleanly. Testing: tier1. @rnkovacs could we also attribute the contributor to the author of the change on jdk/jdk (monica.beckwith at microsoft.com, luhenry at openjdk.org)? Thank you! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/263 From luhenry at openjdk.java.net Fri Aug 20 09:33:33 2021 From: luhenry at openjdk.java.net (Ludovic Henry) Date: Fri, 20 Aug 2021 09:33:33 GMT Subject: [jdk11u-dev] RFR: 8248657: Windows: strengthening in ThreadCritical regarding memory model In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 08:07:35 GMT, Reka Kovacs wrote: > Removed line [L59](https://github.com/openjdk/jdk11u-dev/pull/265/files#diff-7eb55bd4224b99f2ae0f2df4c3e65e586af8998933eeeba6ea4615ce558a36fbL59) in src/hotspot/os/windows/threadCritical_windows.cpp has changed between 11 and tip ([JDK-8234740](https://bugs.openjdk.java.net/browse/JDK-8234740)), otherwise the backport is clean. Testing: tier1. @rnkovacs could we also attribute the contributor to the author of the change on jdk/jdk (luhenry at openjdk.org)? Thank you! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/265 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 20 09:37:26 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 20 Aug 2021 09:37:26 GMT Subject: [jdk11u-dev] RFR: 8248668: AArch64: Avoid MIN/MAX macros when using MSVC In-Reply-To: <14dT06g0eTO5myNndGqEK_u8d6jsfXe26xI2p5pS_TI=.91fd35a5-c379-4159-96ff-0f74dc530a05@github.com> References: <14dT06g0eTO5myNndGqEK_u8d6jsfXe26xI2p5pS_TI=.91fd35a5-c379-4159-96ff-0f74dc530a05@github.com> Message-ID: On Fri, 20 Aug 2021 09:28:50 GMT, Ludovic Henry wrote: >> Changes apply cleanly. Testing: tier1. > > @rnkovacs could we also attribute the contributor to the author of the change on jdk/jdk (monica.beckwith at microsoft.com, luhenry at openjdk.org)? Thank you! Hi @luhenry, sorry, I was trying to follow the new [SKARA Backports doc](https://wiki.openjdk.java.net/display/SKARA/Backports) saying "Note that author metadata recorded in the backport commit is the author of the backport commit, not the author of the original commit. Likewise the reviewers recorded in the commit message are the reviewers of the backport commit, not the reviewers of the original commit." I am more than happy to add you two though if that's OK with everyone. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/263 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 20 10:39:33 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 20 Aug 2021 10:39:33 GMT Subject: [jdk11u-dev] RFR: 8248682: AArch64: Use ATTRIBUTE_ALIGNED helper Message-ID: Changes apply cleanly. This PR is step 7 out of 19 in the Windows/AArch64 port. ------------- Commit messages: - Backport 0417fcf13f7f2159499d325f2b3ace49d2643557 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/266/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=266&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8248682 Stats: 8 lines in 2 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/266.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/266/head:pull/266 PR: https://git.openjdk.java.net/jdk11u-dev/pull/266 From shade at openjdk.java.net Fri Aug 20 11:53:37 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 20 Aug 2021 11:53:37 GMT Subject: [jdk11u-dev] RFR: 8272772: Shenandoah: compiler/c2/aarch64/TestVolatilesShenandoah.java fails in 11u Message-ID: Shenandoah-specific, 11u-specific test bug. See more details in bug report. Attention @rkennke, @adinn. Changes: - `argcount` is incorrect, should be `9`, matches other configs with single option - `\(elided\)` should be escaped - `useCompressedOops` should be handled - 11u version still has `UseBarriersForVolatlie` block, so I had to add it for Shenandoah - `TestVolatilesShenandoah.java` should use itself in `@driver` statements Additional testing: - [x] Affected test now passes on AArch64 11u ------------- Commit messages: - 8272772: Shenandoah: compiler/c2/aarch64/TestVolatilesShenandoah.java fails in 11u Changes: https://git.openjdk.java.net/jdk11u-dev/pull/267/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=267&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272772 Stats: 30 lines in 2 files changed: 11 ins; 0 del; 19 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/267.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/267/head:pull/267 PR: https://git.openjdk.java.net/jdk11u-dev/pull/267 From rkennke at openjdk.java.net Fri Aug 20 11:53:37 2021 From: rkennke at openjdk.java.net (Roman Kennke) Date: Fri, 20 Aug 2021 11:53:37 GMT Subject: [jdk11u-dev] RFR: 8272772: Shenandoah: compiler/c2/aarch64/TestVolatilesShenandoah.java fails in 11u In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 11:46:12 GMT, Aleksey Shipilev wrote: > Shenandoah-specific, 11u-specific test bug. See more details in bug report. > > Attention @rkennke, @adinn. > > Changes: > - `argcount` is incorrect, should be `9`, matches other configs with single option > - `\(elided\)` should be escaped > - `useCompressedOops` should be handled > - 11u version still has `UseBarriersForVolatlie` block, so I had to add it for Shenandoah > - `TestVolatilesShenandoah.java` should use itself in `@driver` statements > > Additional testing: > - [x] Affected test now passes on AArch64 11u Looks good to me. ------------- Marked as reviewed by rkennke (Committer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/267 From luhenry at openjdk.java.net Fri Aug 20 13:05:23 2021 From: luhenry at openjdk.java.net (Ludovic Henry) Date: Fri, 20 Aug 2021 13:05:23 GMT Subject: [jdk11u-dev] RFR: 8248668: AArch64: Avoid MIN/MAX macros when using MSVC In-Reply-To: References: <14dT06g0eTO5myNndGqEK_u8d6jsfXe26xI2p5pS_TI=.91fd35a5-c379-4159-96ff-0f74dc530a05@github.com> Message-ID: On Fri, 20 Aug 2021 09:33:27 GMT, Reka Kovacs wrote: >> @rnkovacs could we also attribute the contributor to the author of the change on jdk/jdk (monica.beckwith at microsoft.com, luhenry at openjdk.org)? Thank you! > > Hi @luhenry, sorry, I was trying to follow the new [SKARA Backports doc](https://wiki.openjdk.java.net/display/SKARA/Backports) saying "Note that author metadata recorded in the backport commit is the author of the backport commit, not the author of the original commit. Likewise the reviewers recorded in the commit message are the reviewers of the backport commit, not the reviewers of the original commit." I am more than happy to add you two though if that's OK with everyone. @rnkovacs I was not aware of [SKARA Backports doc](https://wiki.openjdk.java.net/display/SKARA/Backports), thanks for pointing it out. Up to you then! And thank you for backporting all of that to JDK 11, can't wait to try it out :) ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/263 From vkempik at openjdk.java.net Fri Aug 20 13:05:35 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Fri, 20 Aug 2021 13:05:35 GMT Subject: [jdk15u-dev] RFR: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used In-Reply-To: References: Message-ID: <_u_yoJ3fp9uWcYNNU3qHQO3zgg9vJD1uDfcPejU1wgs=.a739a4fb-de0c-4790-88e4-dd4f681834f9@github.com> On Fri, 20 Aug 2021 07:08:31 GMT, Vladimir Kempik wrote: > Clean backport to 15u testing: jdk:tier1, tier2, netbeans autocompletion by crtl+space ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/91 From phh at openjdk.java.net Fri Aug 20 13:52:24 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 20 Aug 2021 13:52:24 GMT Subject: [jdk11u-dev] RFR: 8233790: Forward output from heap dumper to jcmd/jmap In-Reply-To: <3nq2lxQx57gzahXjY5KpLdoWPBm55JtCkTPUVyWIiQU=.4c9f3ab5-dbfd-48c1-8507-e89263afb83c@github.com> References: <3nq2lxQx57gzahXjY5KpLdoWPBm55JtCkTPUVyWIiQU=.4c9f3ab5-dbfd-48c1-8507-e89263afb83c@github.com> Message-ID: On Thu, 19 Aug 2021 05:53:02 GMT, Bin Liao wrote: > Backport of the heap dump enhancement: Forward output from heap dumper to jcmd/jmap > > Patch did not apply cleanly, I had to resolve/modify > src/hotspot/share/services/diagnosticCommand.cpp > src/hotspot/share/services/heapDumper.cpp > src/hotspot/share/services/heapDumper.hpp > > since patch 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea is backport before this one, so this patch can't backport cleanly I'll push as soon as I get Maintainer approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/256 From vkempik at openjdk.java.net Fri Aug 20 15:02:40 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Fri, 20 Aug 2021 15:02:40 GMT Subject: [jdk15u-dev] Integrated: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status In-Reply-To: References: Message-ID: On Tue, 10 Aug 2021 11:42:26 GMT, Vladimir Kempik wrote: > Please review this backport to jdk15u, not applying clean due to the different location of > thread statuses enum. > A rather simple, sanytizing fix for a corner case. This pull request has now been integrated. Changeset: 513a0353 Author: Vladimir Kempik URL: https://git.openjdk.java.net/jdk15u-dev/commit/513a035366d333ef133889f1cfde4e0e0a747d98 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status Reviewed-by: phh Backport-of: 7e518f42c9346abdf0c8059b45d3dfef95ed69bb ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/90 From vkempik at openjdk.java.net Fri Aug 20 15:02:43 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Fri, 20 Aug 2021 15:02:43 GMT Subject: [jdk15u-dev] Integrated: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 07:08:31 GMT, Vladimir Kempik wrote: > Clean backport to 15u This pull request has now been integrated. Changeset: 3074e6b4 Author: Vladimir Kempik URL: https://git.openjdk.java.net/jdk15u-dev/commit/3074e6b41b07d9e76487c3f5680b84a6eb3b29b1 Stats: 110 lines in 2 files changed: 108 ins; 1 del; 1 mod 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used Backport-of: ddcd851c43aa97477c7e406490c0c7c7d71ac629 ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/91 From shade at openjdk.java.net Fri Aug 20 15:30:35 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 20 Aug 2021 15:30:35 GMT Subject: [jdk11u-dev] RFR: 8232782: Shenandoah: streamline post-LRB CAS barrier (aarch64) Message-ID: Unclean backport to improve Shenandoah AArch64 performance and provide grounds for subsequent backports. There were conflicts in `shenandoah_aarch64.ad`, as there is `weakCompareAndSwapPAcq_shenandoah` and `weakCompareAndSwapNAcq_shenandoah` are missing in 11u. Additional testing: - [x] Linux AArch64 `hotspot_gc_shenandoah` - [x] Linux AArch64 `tier1` with `-XX:+UseShenandoahGC` - [x] Linux AArch64 `tier2` with `-XX:+UseShenandoahGC` - [ ] Linux AArch64 jcstress `-m quick` with `-XX:+UseShenandoahGC` ------------- Commit messages: - Backport c5bb02358472a993fbefe816302411483273656c Changes: https://git.openjdk.java.net/jdk11u-dev/pull/268/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=268&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8232782 Stats: 184 lines in 4 files changed: 139 ins; 6 del; 39 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/268.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/268/head:pull/268 PR: https://git.openjdk.java.net/jdk11u-dev/pull/268 From vkempik at openjdk.java.net Fri Aug 20 15:32:31 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Fri, 20 Aug 2021 15:32:31 GMT Subject: [jdk13u-dev] RFR: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used In-Reply-To: References: Message-ID: <111r1OCKqpH9AOew6KoFx5yZfZfrIe6x1XqNlKuK6i8=.da161160-2412-4dc6-9bf0-076269bd8d39@github.com> On Fri, 20 Aug 2021 07:11:43 GMT, Vladimir Kempik wrote: > Clean backport to jdk13u-dev testing: tier1, jdk:tier2, netbeans autocompletion by crtl+space ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/253 From vkempik at openjdk.java.net Fri Aug 20 15:41:34 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Fri, 20 Aug 2021 15:41:34 GMT Subject: [jdk13u-dev] Integrated: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 07:11:43 GMT, Vladimir Kempik wrote: > Clean backport to jdk13u-dev This pull request has now been integrated. Changeset: c8350fcc Author: Vladimir Kempik URL: https://git.openjdk.java.net/jdk13u-dev/commit/c8350fcced3624995e657069fdf82045d83df740 Stats: 110 lines in 2 files changed: 108 ins; 1 del; 1 mod 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used Backport-of: ddcd851c43aa97477c7e406490c0c7c7d71ac629 ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/253 From abakhtin at openjdk.java.net Fri Aug 20 15:45:31 2021 From: abakhtin at openjdk.java.net (Alexey Bakhtin) Date: Fri, 20 Aug 2021 15:45:31 GMT Subject: [jdk13u-dev] Integrated: 8206925: Support the certificate_authorities extension In-Reply-To: <06w-1jef7atcL_-odlEb79tOjk9MYrK-ZUsqhk4mrlw=.b6b6db52-f69a-4742-b03e-3d9c2b67b3c7@github.com> References: <06w-1jef7atcL_-odlEb79tOjk9MYrK-ZUsqhk4mrlw=.b6b6db52-f69a-4742-b03e-3d9c2b67b3c7@github.com> Message-ID: On Thu, 12 Aug 2021 11:03:10 GMT, Alexey Bakhtin wrote: > I'd like to backport it to 13u as soon as it is in 8u and 11u already > Applied cleanly > All sun/security/ssl javax/net/ssl tests (including 3 new tests) are passed This pull request has now been integrated. Changeset: 239e7275 Author: Alexey Bakhtin Committer: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk13u-dev/commit/239e72758b0ce55f1afa6148e9e6912a7bdf65c1 Stats: 1135 lines in 8 files changed: 1037 ins; 46 del; 52 mod 8206925: Support the certificate_authorities extension Backport-of: 17a298962c35d5c8ebae73fdb8a969139551b5a7 ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/252 From vkempik at openjdk.java.net Fri Aug 20 16:14:22 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Fri, 20 Aug 2021 16:14:22 GMT Subject: [jdk11u-dev] RFR: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 07:15:30 GMT, Vladimir Kempik wrote: > Clean backport to jdk11u-dev Testing: tier1 by GHA, tier2 WiP, netbeans autocompletion ( control+space key combo), included testcase ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/264 From darcy at openjdk.java.net Fri Aug 20 16:46:51 2021 From: darcy at openjdk.java.net (Joe Darcy) Date: Fri, 20 Aug 2021 16:46:51 GMT Subject: [jdk17u] Integrated: 8272326: java/util/Random/RandomTestMoments.java had two Gaussian fails Message-ID: 8272326: java/util/Random/RandomTestMoments.java had two Gaussian fails ------------- Commit messages: - Backport cf64c3e7e226eacf675d984db52872b0a8343a46 Changes: https://git.openjdk.java.net/jdk17u/pull/30/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=30&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272326 Stats: 5 lines in 2 files changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u/pull/30.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/30/head:pull/30 PR: https://git.openjdk.java.net/jdk17u/pull/30 From darcy at openjdk.java.net Fri Aug 20 16:46:52 2021 From: darcy at openjdk.java.net (Joe Darcy) Date: Fri, 20 Aug 2021 16:46:52 GMT Subject: [jdk17u] Integrated: 8272326: java/util/Random/RandomTestMoments.java had two Gaussian fails In-Reply-To: References: Message-ID: <9RYvNmSGIaG_L5aBebJu36YiHDcPg1kTikxM0Gw7HYc=.b43fbaf5-ca02-4725-95b3-3ebdcebed954@github.com> On Fri, 20 Aug 2021 16:30:46 GMT, Joe Darcy wrote: > 8272326: java/util/Random/RandomTestMoments.java had two Gaussian fails This pull request has now been integrated. Changeset: 24e5c1a0 Author: Joe Darcy URL: https://git.openjdk.java.net/jdk17u/commit/24e5c1a040923b0f55eb9be0a0cbf501b253537d Stats: 5 lines in 2 files changed: 3 ins; 0 del; 2 mod 8272326: java/util/Random/RandomTestMoments.java had two Gaussian fails Backport-of: cf64c3e7e226eacf675d984db52872b0a8343a46 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/30 From vkempik at openjdk.java.net Fri Aug 20 18:13:33 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Fri, 20 Aug 2021 18:13:33 GMT Subject: [jdk11u-dev] Integrated: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 07:15:30 GMT, Vladimir Kempik wrote: > Clean backport to jdk11u-dev This pull request has now been integrated. Changeset: f4772b52 Author: Vladimir Kempik URL: https://git.openjdk.java.net/jdk11u-dev/commit/f4772b52b80a5c95a33c5147f36b6686a021bc29 Stats: 110 lines in 2 files changed: 108 ins; 1 del; 1 mod 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used Backport-of: ddcd851c43aa97477c7e406490c0c7c7d71ac629 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/264 From phh at openjdk.java.net Fri Aug 20 18:57:28 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 20 Aug 2021 18:57:28 GMT Subject: [jdk11u-dev] RFR: 8248666: AArch64: Use THREAD_LOCAL instead of __thread In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 06:28:24 GMT, Reka Kovacs wrote: > Not a clean backport. Original patch used a macro called THREAD_LOCAL, this backport uses THREAD_LOCAL_DECL. THREAD_LOCAL_DECL was renamed to THREAD_LOCAL by [JDK-8230877](https://bugs.openjdk.java.net/browse/JDK-8230877) in JDK 14. Testing: tier1. > > This PR is step 4 out of 19 in the Windows/AArch64 port. Marked as reviewed by phh (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/262 From prr at openjdk.java.net Fri Aug 20 20:32:01 2021 From: prr at openjdk.java.net (Phil Race) Date: Fri, 20 Aug 2021 20:32:01 GMT Subject: [jdk17u] Integrated: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used Message-ID: Backport 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used ------------- Commit messages: - Backport git ddcd851c43aa97477c7e406490c0c7c7d71ac629 Changes: https://git.openjdk.java.net/jdk17u/pull/31/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=31&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272602 Stats: 110 lines in 2 files changed: 108 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u/pull/31.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/31/head:pull/31 PR: https://git.openjdk.java.net/jdk17u/pull/31 From prr at openjdk.java.net Fri Aug 20 20:32:04 2021 From: prr at openjdk.java.net (Phil Race) Date: Fri, 20 Aug 2021 20:32:04 GMT Subject: [jdk17u] Integrated: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 20:20:10 GMT, Phil Race wrote: > Backport 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used This pull request has now been integrated. Changeset: bf920d94 Author: Phil Race URL: https://git.openjdk.java.net/jdk17u/commit/bf920d94924af48b9681a1165744d0a1e5e98211 Stats: 110 lines in 2 files changed: 108 ins; 1 del; 1 mod 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used Backport-of: ddcd851c43aa97477c7e406490c0c7c7d71ac629 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/31 From phh at openjdk.java.net Fri Aug 20 20:32:32 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 20 Aug 2021 20:32:32 GMT Subject: [jdk11u-dev] RFR: 8248657: Windows: strengthening in ThreadCritical regarding memory model In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 08:07:35 GMT, Reka Kovacs wrote: > Removed line [L59](https://github.com/openjdk/jdk11u-dev/pull/265/files#diff-7eb55bd4224b99f2ae0f2df4c3e65e586af8998933eeeba6ea4615ce558a36fbL59) in src/hotspot/os/windows/threadCritical_windows.cpp has changed between 11 and tip ([JDK-8234740](https://bugs.openjdk.java.net/browse/JDK-8234740)), otherwise the backport is clean. Testing: tier1. > > This PR is step 6 out of 19 in the Windows/AArch64 port. Tagged. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/265 From phh at openjdk.java.net Fri Aug 20 20:44:21 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 20 Aug 2021 20:44:21 GMT Subject: [jdk11u-dev] RFR: 8232782: Shenandoah: streamline post-LRB CAS barrier (aarch64) In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 15:24:23 GMT, Aleksey Shipilev wrote: > Unclean backport to improve Shenandoah AArch64 performance and provide grounds for subsequent backports. > > There were conflicts in `shenandoah_aarch64.ad`, as there is `weakCompareAndSwapPAcq_shenandoah` and `weakCompareAndSwapNAcq_shenandoah` are missing in 11u. > > Additional testing: > - [x] Linux AArch64 `hotspot_gc_shenandoah` > - [x] Linux AArch64 `tier1` with `-XX:+UseShenandoahGC` > - [x] Linux AArch64 `tier2` with `-XX:+UseShenandoahGC` > - [x] Linux AArch64 jcstress `-m quick` with `-XX:+UseShenandoahGC` Marked as reviewed by phh (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/268 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 20 22:25:28 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 20 Aug 2021 22:25:28 GMT Subject: [jdk11u-dev] RFR: 8248666: AArch64: Use THREAD_LOCAL instead of __thread In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 06:28:24 GMT, Reka Kovacs wrote: > Not a clean backport. Original patch used a macro called THREAD_LOCAL, this backport uses THREAD_LOCAL_DECL. THREAD_LOCAL_DECL was renamed to THREAD_LOCAL by [JDK-8230877](https://bugs.openjdk.java.net/browse/JDK-8230877) in JDK 14. Testing: tier1. > > This PR is step 4 out of 19 in the Windows/AArch64 port. Thank you, Paul! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/262 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 20 22:27:25 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 20 Aug 2021 22:27:25 GMT Subject: [jdk11u-dev] RFR: 8248657: Windows: strengthening in ThreadCritical regarding memory model In-Reply-To: References: Message-ID: <2fnBOSSxgCNqME7fdYdmJu6uhDhlkyCyH_xola62pQA=.6cd8ae10-4e93-49dd-9ede-2dc6d13250af@github.com> On Fri, 20 Aug 2021 08:07:35 GMT, Reka Kovacs wrote: > Removed line [L59](https://github.com/openjdk/jdk11u-dev/pull/265/files#diff-7eb55bd4224b99f2ae0f2df4c3e65e586af8998933eeeba6ea4615ce558a36fbL59) in src/hotspot/os/windows/threadCritical_windows.cpp has changed between 11 and tip ([JDK-8234740](https://bugs.openjdk.java.net/browse/JDK-8234740)), otherwise the backport is clean. Testing: tier1. > > This PR is step 6 out of 19 in the Windows/AArch64 port. Thanks! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/265 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 20 22:56:34 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 20 Aug 2021 22:56:34 GMT Subject: [jdk11u-dev] RFR: 8248816: C1: Fix signature conflict in LIRGenerator::strength_reduce_multiply Message-ID: Changes apply cleanly. This is step 10 out of 19 in the Windows/AArch64 backport. ------------- Commit messages: - Backport d3776c7d30f23489c04518d20d441c2ec2f06705 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/269/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=269&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8248816 Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/269.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/269/head:pull/269 PR: https://git.openjdk.java.net/jdk11u-dev/pull/269 From github.com+25946952+rnkovacs at openjdk.java.net Sun Aug 22 13:34:26 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Sun, 22 Aug 2021 13:34:26 GMT Subject: [jdk11u-dev] RFR: 8248816: C1: Fix signature conflict in LIRGenerator::strength_reduce_multiply In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 22:48:53 GMT, Reka Kovacs wrote: > Changes apply cleanly. > > This is step 10 out of 19 in the Windows/AArch64 backport. I don't think the test failure on Windows x64 is caused by this patch - it doesn't touch x64 related code, and the failure is there in #263 too. Didn't come up in my testing. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/269 From github.com+25946952+rnkovacs at openjdk.java.net Sun Aug 22 14:20:38 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Sun, 22 Aug 2021 14:20:38 GMT Subject: [jdk11u-dev] RFR: 8263136: C4530 was reported from VS 2019 at access bridge Message-ID: Changes apply cleanly. This is part of the Windows/AArch64 port. ------------- Commit messages: - Backport d339320e0b648e28bcc0c07801ae9376a33fc975 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/270/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=270&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263136 Stats: 9 lines in 1 file changed: 2 ins; 1 del; 6 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/270.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/270/head:pull/270 PR: https://git.openjdk.java.net/jdk11u-dev/pull/270 From github.com+25946952+rnkovacs at openjdk.java.net Sun Aug 22 17:08:49 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Sun, 22 Aug 2021 17:08:49 GMT Subject: [jdk11u-dev] RFR: 8261072: AArch64: Fix MacroAssembler::get_thread convention Message-ID: <2RcCV4w6COz7Wmj0xH6MhGDFlqhSLgdAOOlL-Xc1_rQ=.ae7482e0-6edc-46fb-bd7d-683d73246d86@github.com> Clean backport. The non-Linux path will only be exercised once [JEP 388](https://github.com/openjdk/jdk11u-dev/pull/222) is in. This is part of the Windows/AArch64 port. ------------- Commit messages: - Backport b670efd896a2905b6842b8199261aa2f3d7c12b9 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/271/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=271&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261072 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/271.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/271/head:pull/271 PR: https://git.openjdk.java.net/jdk11u-dev/pull/271 From github.com+25946952+rnkovacs at openjdk.java.net Sun Aug 22 17:21:48 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Sun, 22 Aug 2021 17:21:48 GMT Subject: [jdk11u-dev] RFR: 8265756: AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter Message-ID: Changes apply cleanly. This is part of the Windows/AArch64 port. ------------- Commit messages: - Backport f6e26f6f33cd06ec4d8e911972a193aea9fab557 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/272/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=272&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265756 Stats: 123 lines in 3 files changed: 116 ins; 5 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/272.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/272/head:pull/272 PR: https://git.openjdk.java.net/jdk11u-dev/pull/272 From dholmes at openjdk.java.net Sun Aug 22 23:13:54 2021 From: dholmes at openjdk.java.net (David Holmes) Date: Sun, 22 Aug 2021 23:13:54 GMT Subject: [jdk17u] RFR: 8272472: StackGuardPages test doesn't build with glibc 2.34 Message-ID: <2dqn_r2-k6oFFb8q0gMt2rvu2AGhGYuorsn0GFzjD4s=.a985d9b8-7e99-47e8-ac83-85f76409da38@github.com> 8272472: StackGuardPages test doesn't build with glibc 2.34 ------------- Commit messages: - Backport f77a1a156f3da9068d012d9227c7ee0fee58f571 Changes: https://git.openjdk.java.net/jdk17u/pull/32/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=32&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272472 Stats: 11 lines in 1 file changed: 9 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u/pull/32.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/32/head:pull/32 PR: https://git.openjdk.java.net/jdk17u/pull/32 From clanger at openjdk.java.net Mon Aug 23 05:23:28 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 23 Aug 2021 05:23:28 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master Message-ID: The commit 3a32efcd73fb33243bcf6598907b773080be926c, tagged as jdk-11.0.13+3, is not contained in branch master of jdk11u-dev. We should merge it back from jdk11u. ------------- Commit messages: - Merge - Merge The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.java.net/jdk11u-dev/pull/273/files Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/273.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/273/head:pull/273 PR: https://git.openjdk.java.net/jdk11u-dev/pull/273 From clanger at openjdk.java.net Mon Aug 23 06:28:27 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 23 Aug 2021 06:28:27 GMT Subject: [jdk11u-dev] RFR: 8251549: Update docs on building for Git [v2] In-Reply-To: <9DPQRu9Q9GdpS2rQR_WDhWkpnXKlQB9S_AmnNhjg7RY=.cd27a77b-280c-4004-b32b-a49be8e90895@github.com> References: <9DPQRu9Q9GdpS2rQR_WDhWkpnXKlQB9S_AmnNhjg7RY=.cd27a77b-280c-4004-b32b-a49be8e90895@github.com> Message-ID: On Mon, 9 Aug 2021 10:07:02 GMT, Severin Gehwolf wrote: >> Hi, >> >> Now that OpenJDK 11u is fully on Git we should update the docs to no longer refer to Mercurial and use Git instead. The JDK 16 patch doesn't apply clean due to some differences in the file (e.g. referring to JDK 8 vs. JDK 11 in head). `doc/building.html` is the result of running `make update-build-docs` when the `building.md` file has the relevant changes. >> >> Thoughts? > > Severin Gehwolf has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. LGTM, thanks for backporting. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/205 From clanger at openjdk.java.net Mon Aug 23 06:43:57 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 23 Aug 2021 06:43:57 GMT Subject: [jdk17u] RFR: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup Message-ID: <0BZ7XGy8ivmfaXNG471uHdvajmX56XsEeQ3YD1VL4GY=.e4bc32e0-92a9-4680-b18a-db632560f2fa@github.com> Hi all, this pull request contains a backport of JDK-8270137 from the openjdk/jdk repository. The commit being backported was authored by Martin Balao on 10 Aug 2021 and was reviewed by Weijun Wang. Thanks! ------------- Commit messages: - Backport 67869b491ae1eaf311dfb8c61a9e94329a822ffc Changes: https://git.openjdk.java.net/jdk17u/pull/33/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=33&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270137 Stats: 97 lines in 3 files changed: 47 ins; 9 del; 41 mod Patch: https://git.openjdk.java.net/jdk17u/pull/33.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/33/head:pull/33 PR: https://git.openjdk.java.net/jdk17u/pull/33 From clanger at openjdk.java.net Mon Aug 23 06:47:53 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 23 Aug 2021 06:47:53 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master [v2] In-Reply-To: References: Message-ID: > The commit 3a32efcd73fb33243bcf6598907b773080be926c, tagged as jdk-11.0.13+3, is not contained in branch master of jdk11u-dev. We should merge it back from jdk11u. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/273/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/273/files/3a32efcd..3a32efcd Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=273&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=273&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/273.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/273/head:pull/273 PR: https://git.openjdk.java.net/jdk11u-dev/pull/273 From clanger at openjdk.java.net Mon Aug 23 06:47:55 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 23 Aug 2021 06:47:55 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: References: Message-ID: On Mon, 23 Aug 2021 05:17:48 GMT, Christoph Langer wrote: > The commit 3a32efcd73fb33243bcf6598907b773080be926c, tagged as jdk-11.0.13+3, is not contained in branch master of jdk11u-dev. We should merge it back from jdk11u. This pull request has now been integrated. Changeset: 3a88ae73 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/3a88ae7313921766d22187f542912efeb6c315e8 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Merge ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/273 From tvoniadka at openjdk.java.net Mon Aug 23 07:29:02 2021 From: tvoniadka at openjdk.java.net (Thejasvi Voniadka) Date: Mon, 23 Aug 2021 07:29:02 GMT Subject: [jdk17u] RFR: 8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled Message-ID: This is a clean, straight backport of the following bug: 8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled Patch applies clean, and test passes post patch. ------------- Commit messages: - Backport 4bd37c315333325b69db8d55c0c3aaf74c95024f Changes: https://git.openjdk.java.net/jdk17u/pull/34/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=34&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272708 Stats: 6 lines in 1 file changed: 0 ins; 4 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/34/head:pull/34 PR: https://git.openjdk.java.net/jdk17u/pull/34 From shade at openjdk.java.net Mon Aug 23 07:41:50 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 23 Aug 2021 07:41:50 GMT Subject: [jdk17u] RFR: 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode In-Reply-To: References: Message-ID: On Thu, 19 Aug 2021 09:06:15 GMT, Aleksey Shipilev wrote: > Clean backport to stabilize the test. > > Additional testing: > - [x] Affected test still passes Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/28 From shade at openjdk.java.net Mon Aug 23 07:42:42 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 23 Aug 2021 07:42:42 GMT Subject: [jdk17u] RFR: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient In-Reply-To: References: Message-ID: On Thu, 19 Aug 2021 09:00:02 GMT, Aleksey Shipilev wrote: > Clean backport to improve test stability. > > Additional testing: > - [x] Affected tests still pass Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/27 From shade at openjdk.java.net Mon Aug 23 07:42:42 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 23 Aug 2021 07:42:42 GMT Subject: [jdk17u] Integrated: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient In-Reply-To: References: Message-ID: On Thu, 19 Aug 2021 09:00:02 GMT, Aleksey Shipilev wrote: > Clean backport to improve test stability. > > Additional testing: > - [x] Affected tests still pass This pull request has now been integrated. Changeset: 9554fba4 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk17u/commit/9554fba495f51a0a8772b4a40a4eefa1a6782877 Stats: 97 lines in 2 files changed: 68 ins; 18 del; 11 mod 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient Backport-of: 23d2996fee54afcc386a505a65d3236aab874e9e ------------- PR: https://git.openjdk.java.net/jdk17u/pull/27 From shade at openjdk.java.net Mon Aug 23 07:43:33 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 23 Aug 2021 07:43:33 GMT Subject: [jdk17u] RFR: 8270094: Shenandoah: Provide human-readable labels for test configurations In-Reply-To: References: Message-ID: On Thu, 19 Aug 2021 10:05:26 GMT, Aleksey Shipilev wrote: > Clean backport to improve testing UX. > > Additional testing: > - [x] hotspot_gc_shenandoah passes Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/29 From shade at openjdk.java.net Mon Aug 23 07:43:34 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 23 Aug 2021 07:43:34 GMT Subject: [jdk17u] Integrated: 8270094: Shenandoah: Provide human-readable labels for test configurations In-Reply-To: References: Message-ID: On Thu, 19 Aug 2021 10:05:26 GMT, Aleksey Shipilev wrote: > Clean backport to improve testing UX. > > Additional testing: > - [x] hotspot_gc_shenandoah passes This pull request has now been integrated. Changeset: 3c1023c1 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk17u/commit/3c1023c1b97525be00afbf4f73e4af2f4fa56f03 Stats: 227 lines in 81 files changed: 19 ins; 0 del; 208 mod 8270094: Shenandoah: Provide human-readable labels for test configurations Backport-of: 676f1d76cab9108655f2ce462db321b975563eb7 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/29 From shade at openjdk.java.net Mon Aug 23 07:44:34 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 23 Aug 2021 07:44:34 GMT Subject: [jdk17u] Integrated: 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode In-Reply-To: References: Message-ID: <8VEAfsnmXeeHhGtzTY4kh9fXj-bhtotz01RX9pr6YGI=.e393e775-0b40-4460-808c-3defcda8321c@github.com> On Thu, 19 Aug 2021 09:06:15 GMT, Aleksey Shipilev wrote: > Clean backport to stabilize the test. > > Additional testing: > - [x] Affected test still passes This pull request has now been integrated. Changeset: 7d6c3ade Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk17u/commit/7d6c3adef36a727348ddd313e465bf141a574a33 Stats: 17 lines in 1 file changed: 7 ins; 0 del; 10 mod 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode Backport-of: 4f322a9b6c9cfdf080df23326daa45733f1b9aad ------------- PR: https://git.openjdk.java.net/jdk17u/pull/28 From tvoniadka at openjdk.java.net Mon Aug 23 07:50:35 2021 From: tvoniadka at openjdk.java.net (Thejasvi Voniadka) Date: Mon, 23 Aug 2021 07:50:35 GMT Subject: [jdk17u] Integrated: 8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled In-Reply-To: References: Message-ID: On Mon, 23 Aug 2021 07:20:44 GMT, Thejasvi Voniadka wrote: > This is a clean, straight backport of the following bug: > > 8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled > > Patch applies clean, and test passes post patch. This pull request has now been integrated. Changeset: 567fdbf4 Author: Thejasvi Voniadka Committer: Abdul Kolarkunnu URL: https://git.openjdk.java.net/jdk17u/commit/567fdbf4b5b002fa9e11ba68f3f496938229737e Stats: 6 lines in 1 file changed: 0 ins; 4 del; 2 mod 8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled Backport-of: 4bd37c315333325b69db8d55c0c3aaf74c95024f ------------- PR: https://git.openjdk.java.net/jdk17u/pull/34 From github.com+25946952+rnkovacs at openjdk.java.net Mon Aug 23 08:02:44 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 23 Aug 2021 08:02:44 GMT Subject: [jdk11u-dev] RFR: 8250810: Push missing parts of JDK-8248817 Message-ID: <5rQ17hdgRiagcdC76vWlrx6oEEFuTtr94tvxWPPBdfs=.e750270f-2a2d-4906-a3e2-a8151d29fcca@github.com> This is a refactoring patch with no functional change. It didn't apply cleanly. Differences to the original commit: In `thread_windows_x86.cpp`: - Some removed lines were simpler on tip because of [JDK-8248240](https://github.com/openjdk/jdk/commit/a6e794b3e85d28537bf740d9d7e68339707d38e1#diff-d4111d540c34b1e0f4acac1e92877ce458b29d70126ccb113b439261a503ed95). In `os_windows.cpp`: - The block around L2461 is no longer present on tip, that and a bit of the next block can be simplified. - The conditions on L2539 ([JDK-8234372](https://github.com/openjdk/jdk/commit/4e4d1f2b4dad61b4c4590f1d3a956b9ad86ff74c#diff-84938e7dfe64805a850b8a729495117a972a474622fff12bb97ee45cbc2184f2)) and L2549 ([JDK-8213199](https://github.com/openjdk/jdk/commit/7c3f2b06f13e3d28b74193d8acac4478e8c12bdb#diff-84938e7dfe64805a850b8a729495117a972a474622fff12bb97ee45cbc2184f2)) (original line numbers) are different on tip. We actually didn't touch those, they only show up colored in the diff because of the whitespace changes. - The surrounding code is different around L2586 because of [JDK-8191278](https://github.com/openjdk/jdk/commit/aedbb7580334cb9131f547845f9b7aa3916ddf4b#diff-84938e7dfe64805a850b8a729495117a972a474622fff12bb97ee45cbc2184f2), but the changes are the same. ------------- Commit messages: - Backport a4eaf9536c272862b5ec856bf263679be09bddc9 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/274/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=274&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8250810 Stats: 76 lines in 2 files changed: 6 ins; 33 del; 37 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/274.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/274/head:pull/274 PR: https://git.openjdk.java.net/jdk11u-dev/pull/274 From sgehwolf at openjdk.java.net Mon Aug 23 08:22:29 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 23 Aug 2021 08:22:29 GMT Subject: [jdk11u-dev] Integrated: 8251549: Update docs on building for Git In-Reply-To: References: Message-ID: <5j08QpeLwidzYotGhN2ocm9Yblll5VZNvlTGolC6nhA=.083feb7d-6e6d-4801-9f7a-1c94eb6f1e4f@github.com> On Fri, 6 Aug 2021 13:32:43 GMT, Severin Gehwolf wrote: > Hi, > > Now that OpenJDK 11u is fully on Git we should update the docs to no longer refer to Mercurial and use Git instead. The JDK 16 patch doesn't apply clean due to some differences in the file (e.g. referring to JDK 8 vs. JDK 11 in head). `doc/building.html` is the result of running `make update-build-docs` when the `building.md` file has the relevant changes. > > Thoughts? This pull request has now been integrated. Changeset: ba097cae Author: Severin Gehwolf URL: https://git.openjdk.java.net/jdk11u-dev/commit/ba097caea1d491054e2a89ce5a3c0b06173ac96d Stats: 146 lines in 2 files changed: 16 ins; 73 del; 57 mod 8251549: Update docs on building for Git Reviewed-by: shade, clanger Backport-of: 042734cc5b17302a8f2ecdf577511bd6d5ec5e22 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/205 From shade at openjdk.java.net Mon Aug 23 08:26:27 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 23 Aug 2021 08:26:27 GMT Subject: [jdk11u-dev] RFR: 8232782: Shenandoah: streamline post-LRB CAS barrier (aarch64) In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 15:24:23 GMT, Aleksey Shipilev wrote: > Unclean backport to improve Shenandoah AArch64 performance and provide grounds for subsequent backports. > > There were conflicts in `shenandoah_aarch64.ad`, as there is `weakCompareAndSwapPAcq_shenandoah` and `weakCompareAndSwapNAcq_shenandoah` are missing in 11u. > > Additional testing: > - [x] Linux AArch64 `hotspot_gc_shenandoah` > - [x] Linux AArch64 `tier1` with `-XX:+UseShenandoahGC` > - [x] Linux AArch64 `tier2` with `-XX:+UseShenandoahGC` > - [x] Linux AArch64 jcstress `-m quick` with `-XX:+UseShenandoahGC` Thank you, @phh! @rkennke, do you have any concerns with this patch? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/268 From shade at openjdk.java.net Mon Aug 23 08:27:41 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 23 Aug 2021 08:27:41 GMT Subject: [jdk11u-dev] RFR: 8272472: StackGuardPages test doesn't build with glibc 2.34 Message-ID: Clean backport to get newer glibc working for this test. Additional testing: - [x] Test still works on older glibc ------------- Commit messages: - Backport f77a1a156f3da9068d012d9227c7ee0fee58f571 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/275/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=275&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272472 Stats: 11 lines in 1 file changed: 9 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/275.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/275/head:pull/275 PR: https://git.openjdk.java.net/jdk11u-dev/pull/275 From shade at openjdk.java.net Mon Aug 23 09:13:06 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 23 Aug 2021 09:13:06 GMT Subject: [jdk11u-dev] RFR: 8223923: C2: Missing interference with mismatched unsafe accesses Message-ID: Clean backport to fix C2 bug. Additional testing: - [x] New test fails without the C2 fix, passes with it - [x] Linux x86_64 tier1 passes with the fix ------------- Commit messages: - Backport 86add21a85ec57de00aecb0a18bc99567a91d0d8 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/276/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=276&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8223923 Stats: 84 lines in 2 files changed: 76 ins; 2 del; 6 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/276.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/276/head:pull/276 PR: https://git.openjdk.java.net/jdk11u-dev/pull/276 From shade at openjdk.java.net Mon Aug 23 09:16:42 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 23 Aug 2021 09:16:42 GMT Subject: [jdk17u] RFR: 8269280: (bf) Replace StringBuffer in *Buffer.toString() Message-ID: Clean backport to improve performance in post-BiasedLocking world. Additional testing: - [x] `java/nio/Buffer` tests are passing - [x] Re-generating the test code from the new template yields the same contents ------------- Commit messages: - Backport 3a8f3d6cac0ab859704db533bf1f63431fbd9253 Changes: https://git.openjdk.java.net/jdk17u/pull/35/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=35&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269280 Stats: 654 lines in 9 files changed: 638 ins; 5 del; 11 mod Patch: https://git.openjdk.java.net/jdk17u/pull/35.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/35/head:pull/35 PR: https://git.openjdk.java.net/jdk17u/pull/35 From shade at openjdk.java.net Mon Aug 23 09:34:43 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 23 Aug 2021 09:34:43 GMT Subject: [jdk11u-dev] RFR: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked Message-ID: Unclean backport to match `11.0.14-oracle`. The conflict is in ProblemList, because it is slightly different in 11u, I resolved that conflict by hand. Additional testing: - [x] Affected test passes ------------- Commit messages: - Backport d6bb846159be7e46fba0c3ca2915617f945e0b42 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/277/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=277&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8248899 Stats: 380 lines in 2 files changed: 34 ins; 32 del; 314 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/277.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/277/head:pull/277 PR: https://git.openjdk.java.net/jdk11u-dev/pull/277 From clanger at openjdk.java.net Mon Aug 23 10:25:29 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 23 Aug 2021 10:25:29 GMT Subject: [jdk11u-dev] RFR: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux In-Reply-To: References: Message-ID: On Thu, 12 Aug 2021 15:24:24 GMT, Severin Gehwolf wrote: > Please review this backport of JDK-8255790 which fixes a crash of simple FileDialog-using apps on some systems (for example F34 when not using system harfbuzz). See JDK-8272149. In a nutshell, this patch is a not quite complete revert of JDK-8249821. I.e. the OpenJDK 11u version of it. It does not revert the source code re-structuring, though. The JDK 17 patch doesn't apply clean. I've mostly hand-picked changes from the original patch. Note that JDK-8272332 is included in this backport. The differences mostly stem from differences in DISABLED_WARNINGS_ settings when BUILD_FONTMANAGER is being called. > > Testing: Build on an affected system with/without --with-harfbuzz=system. Reproducer from JDK-8272149 (crashes before, passes after) At eyeballing this looks good to me. If you can wait, I'd like to run it through SAP's testing tonight and let you know the results tomorrow. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/241 From sgehwolf at openjdk.java.net Mon Aug 23 10:31:25 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 23 Aug 2021 10:31:25 GMT Subject: [jdk11u-dev] RFR: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux In-Reply-To: References: Message-ID: On Mon, 23 Aug 2021 10:22:34 GMT, Christoph Langer wrote: > At eyeballing this looks good to me. If you can wait, I'd like to run it through SAP's testing tonight and let you know the results tomorrow. Sure, I'll wait. Thanks for the extra tests. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/241 From sgehwolf at openjdk.java.net Mon Aug 23 13:19:49 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 23 Aug 2021 13:19:49 GMT Subject: [jdk11u-dev] RFR: 8264016: [JVMCI] add some thread local fields for use by JVMCI Message-ID: Please review this JVMCI-related backport for OpenJDK 11u. It adds some thread-local fields and is useful so as to be able to run graal js on stock OpenJDK. The JDK 17 patch didn't apply clean due to context differences, which got fairly trivially resolved. Testing: test/hotspot/jtreg/compiler/jvmci and manual test using upstream Graal unit test. Thoughts? ------------- Commit messages: - Backport 182b11c31aa1d697ed254042c3350330ca3ac6e4 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/278/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=278&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8264016 Stats: 14 lines in 3 files changed: 14 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/278.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/278/head:pull/278 PR: https://git.openjdk.java.net/jdk11u-dev/pull/278 From shade at openjdk.java.net Mon Aug 23 13:45:24 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 23 Aug 2021 13:45:24 GMT Subject: [jdk11u-dev] RFR: 8264016: [JVMCI] add some thread local fields for use by JVMCI In-Reply-To: References: Message-ID: On Mon, 23 Aug 2021 13:12:27 GMT, Severin Gehwolf wrote: > Please review this JVMCI-related backport for OpenJDK 11u. It adds some thread-local fields and is useful so as to be able to run graal js on stock OpenJDK. The JDK 17 patch didn't apply clean due to context differences, which got fairly trivially resolved. > > Testing: test/hotspot/jtreg/compiler/jvmci and manual test using upstream Graal unit test. > > Thoughts? This looks fine to me. Please try to build without JVMCI too, for extra sanity? ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/278 From sgehwolf at openjdk.java.net Mon Aug 23 14:21:28 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 23 Aug 2021 14:21:28 GMT Subject: [jdk11u-dev] RFR: 8264016: [JVMCI] add some thread local fields for use by JVMCI In-Reply-To: References: Message-ID: <_JB2rGwdy7lG0GiYb07edt1uJhUgkt6EHhhjJi116R0=.4c39fd8f-581d-424e-8bee-e961bbf30b6f@github.com> On Mon, 23 Aug 2021 13:42:37 GMT, Aleksey Shipilev wrote: > Please try to build without JVMCI too, for extra sanity? Sure, done. Works fine here :) ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/278 From sgehwolf at openjdk.java.net Mon Aug 23 14:21:41 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 23 Aug 2021 14:21:41 GMT Subject: [jdk11u-dev] RFR: 8263776: [JVMCI] add helper to perform Java upcalls Message-ID: Here is a backport for JDK-8263776. The patch doesn't apply cleanly since it uses features only introduced with JDK-8230199 (JDK 15+, not in OpenJDK 11u). This patch is the same labsopenjdk 11 uses. This patch is also needed for using graal js with plain OpenJDK. Testing: test/hotspot/jtreg/compiler/jvmci and manual upstream Graal unit test. ------------- Commit messages: - Backport 6b4c654186e49528eeae7249fdcd0f2d1a98b3ad Changes: https://git.openjdk.java.net/jdk11u-dev/pull/279/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=279&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263776 Stats: 116 lines in 3 files changed: 116 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/279.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/279/head:pull/279 PR: https://git.openjdk.java.net/jdk11u-dev/pull/279 From sgehwolf at openjdk.java.net Mon Aug 23 14:26:35 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 23 Aug 2021 14:26:35 GMT Subject: [jdk11u-dev] RFR: 8263776: [JVMCI] add helper to perform Java upcalls In-Reply-To: References: Message-ID: On Mon, 23 Aug 2021 14:00:49 GMT, Severin Gehwolf wrote: > Here is a backport for JDK-8263776. The patch doesn't apply cleanly since it uses features only introduced with JDK-8230199 (JDK 15+, not in OpenJDK 11u). This patch is the same labsopenjdk 11 uses. This patch is also needed for using graal js with plain OpenJDK. > > Testing: test/hotspot/jtreg/compiler/jvmci and manual upstream Graal unit test. I'm pretty sure the GHA tier1 failure of `gc/stress/gcold/TestGCOldWithCMS.java` on Linux x86 is unrelated as this is an JVMCI only change. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/279 From shade at openjdk.java.net Mon Aug 23 14:34:26 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 23 Aug 2021 14:34:26 GMT Subject: [jdk11u-dev] RFR: 8263776: [JVMCI] add helper to perform Java upcalls In-Reply-To: References: Message-ID: <7wco05J7hRzI4xOvDgpIDF655fi6ZH-L0W2WwVOz3TY=.f9ee248f-f6c0-4445-a9f1-79d998fe6d43@github.com> On Mon, 23 Aug 2021 14:00:49 GMT, Severin Gehwolf wrote: > Here is a backport for JDK-8263776. The patch doesn't apply cleanly since it uses features only introduced with JDK-8230199 (JDK 15+, not in OpenJDK 11u). This patch is the same labsopenjdk 11 uses. This patch is also needed for using graal js with plain OpenJDK. > > Testing: test/hotspot/jtreg/compiler/jvmci and manual upstream Graal unit test. I have questions :) src/hotspot/share/jvmci/jvmciRuntime.cpp line 455: > 453: } > 454: > 455: inline void do_object() { _jca->push_oop(next_object()); } Excess whitespace before `_jca`. src/hotspot/share/jvmci/jvmciRuntime.cpp line 470: > 468: inline void do_array(int begin, int end) { if (!is_return_type()) do_object(); } > 469: > 470: inline void do_void() { } Excess whitespace before `{ }`. src/hotspot/share/jvmci/jvmciRuntime.cpp line 513: > 511: return value->f; > 512: case T_DOUBLE: > 513: return value->d; The original commit uses `value->i` and `value->j` here. Of course, `value->f` and `value->d` look more correct, but do you understand why this difference? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/279 From shade at openjdk.java.net Mon Aug 23 14:34:27 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 23 Aug 2021 14:34:27 GMT Subject: [jdk11u-dev] RFR: 8263776: [JVMCI] add helper to perform Java upcalls In-Reply-To: References: Message-ID: <0O0pr4A8dzBYKm6HayVIRLcBKazJzESyqVBPfaTQa20=.66b9c6f7-93d7-4f91-ac72-90da32555ea7@github.com> On Mon, 23 Aug 2021 14:24:12 GMT, Severin Gehwolf wrote: > I'm pretty sure the GHA tier1 failure of `gc/stress/gcold/TestGCOldWithCMS.java` on Linux x86 is unrelated as this is an JVMCI only change. Yes, it looks like another instance of [JDK-8272195](https://bugs.openjdk.java.net/browse/JDK-8272195). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/279 From rob.mckenna at oracle.com Mon Aug 23 15:46:37 2021 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Mon, 23 Aug 2021 15:46:37 +0000 Subject: [17u Communication] Heads up: Final few days for 17.0.1 fixes Message-ID: Hi folks, Just a heads up: we expect to stop accepting fixes for 17.0.1 by the end of this week. If you need something in 17.0.1 please file a fix request ASAP. -Rob P.S. I didn't send around a "repo open" mail, but the repo will remain open for 17.0.2 of course. From phh at openjdk.java.net Mon Aug 23 15:52:24 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Mon, 23 Aug 2021 15:52:24 GMT Subject: [jdk11u-dev] RFR: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked In-Reply-To: References: Message-ID: <6lchwWl6sMLZzSli6eHkroiR4lZdLIdh3_wVwevdSvc=.259c602e-8ae1-47f8-95dd-f88316dd8e9b@github.com> On Mon, 23 Aug 2021 09:25:58 GMT, Aleksey Shipilev wrote: > Unclean backport to match `11.0.14-oracle`. The conflict is in ProblemList, because it is slightly different in 11u, I resolved that conflict by hand. > > Additional testing: > - [x] Affected test passes Marked as reviewed by phh (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/277 From github.com+25946952+rnkovacs at openjdk.java.net Mon Aug 23 15:54:45 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 23 Aug 2021 15:54:45 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build Message-ID: Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) This is part of the Windows/AArch64 port. ------------- Commit messages: - Backport d2812f780e87511736f2d41bc57a69c2a898b583 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/280/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=280&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8254072 Stats: 29 lines in 10 files changed: 4 ins; 5 del; 20 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/280.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/280/head:pull/280 PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From sgehwolf at openjdk.java.net Mon Aug 23 16:31:26 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 23 Aug 2021 16:31:26 GMT Subject: [jdk11u-dev] RFR: 8263776: [JVMCI] add helper to perform Java upcalls In-Reply-To: <7wco05J7hRzI4xOvDgpIDF655fi6ZH-L0W2WwVOz3TY=.f9ee248f-f6c0-4445-a9f1-79d998fe6d43@github.com> References: <7wco05J7hRzI4xOvDgpIDF655fi6ZH-L0W2WwVOz3TY=.f9ee248f-f6c0-4445-a9f1-79d998fe6d43@github.com> Message-ID: <_JqBNe6NoFMdBl9ZKb9Nori81Jvfi2Gx4WKqC4Zpxm4=.bcb9af18-9ffe-448d-b361-b468149061d3@github.com> On Mon, 23 Aug 2021 14:29:13 GMT, Aleksey Shipilev wrote: >> Here is a backport for JDK-8263776. The patch doesn't apply cleanly since it uses features only introduced with JDK-8230199 (JDK 15+, not in OpenJDK 11u). This patch is the same labsopenjdk 11 uses. This patch is also needed for using graal js with plain OpenJDK. >> >> Testing: test/hotspot/jtreg/compiler/jvmci and manual upstream Graal unit test. > > src/hotspot/share/jvmci/jvmciRuntime.cpp line 513: > >> 511: return value->f; >> 512: case T_DOUBLE: >> 513: return value->d; > > The original commit uses `value->i` and `value->j` here. Of course, `value->f` and `value->d` look more correct, but do you understand why this difference? The original change handles `T_INT` and `T_FLOAT` (same bit width) with a single case statement. Same for `T_DOUBLE` and `T_LONG`. Therefore returning the more generic union types `value->i` and `value->j` respectively. I'm not sure this actually makes any difference. This seems the cleaner way to handle it. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/279 From sgehwolf at openjdk.java.net Mon Aug 23 16:36:51 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 23 Aug 2021 16:36:51 GMT Subject: [jdk11u-dev] RFR: 8263776: [JVMCI] add helper to perform Java upcalls [v2] In-Reply-To: References: Message-ID: > Here is a backport for JDK-8263776. The patch doesn't apply cleanly since it uses features only introduced with JDK-8230199 (JDK 15+, not in OpenJDK 11u). This patch is the same labsopenjdk 11 uses. This patch is also needed for using graal js with plain OpenJDK. > > Testing: test/hotspot/jtreg/compiler/jvmci and manual upstream Graal unit test. Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision: Cleanup whitespace ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/279/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/279/files/59d1b306..7b7e3407 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=279&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=279&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/279.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/279/head:pull/279 PR: https://git.openjdk.java.net/jdk11u-dev/pull/279 From phh at openjdk.java.net Mon Aug 23 16:44:27 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Mon, 23 Aug 2021 16:44:27 GMT Subject: [jdk11u-dev] RFR: 8250810: Push missing parts of JDK-8248817 In-Reply-To: <5rQ17hdgRiagcdC76vWlrx6oEEFuTtr94tvxWPPBdfs=.e750270f-2a2d-4906-a3e2-a8151d29fcca@github.com> References: <5rQ17hdgRiagcdC76vWlrx6oEEFuTtr94tvxWPPBdfs=.e750270f-2a2d-4906-a3e2-a8151d29fcca@github.com> Message-ID: On Mon, 23 Aug 2021 07:49:47 GMT, Reka Kovacs wrote: > This is a refactoring patch with no functional change. It didn't apply cleanly. Differences to the original commit: > > In `thread_windows_x86.cpp`: > - Some removed lines were simpler on tip because of [JDK-8248240](https://github.com/openjdk/jdk/commit/a6e794b3e85d28537bf740d9d7e68339707d38e1#diff-d4111d540c34b1e0f4acac1e92877ce458b29d70126ccb113b439261a503ed95). > > In `os_windows.cpp`: > - The block around L2461 is no longer present on tip, that and a bit of the next block can be simplified. > - The conditions on L2539 ([JDK-8234372](https://github.com/openjdk/jdk/commit/4e4d1f2b4dad61b4c4590f1d3a956b9ad86ff74c#diff-84938e7dfe64805a850b8a729495117a972a474622fff12bb97ee45cbc2184f2)) and L2549 ([JDK-8213199](https://github.com/openjdk/jdk/commit/7c3f2b06f13e3d28b74193d8acac4478e8c12bdb#diff-84938e7dfe64805a850b8a729495117a972a474622fff12bb97ee45cbc2184f2)) (original line numbers) are different on tip. We actually didn't touch those, they only show up colored in the diff because of the whitespace changes. > - The surrounding code is different around L2586 because of [JDK-8191278](https://github.com/openjdk/jdk/commit/aedbb7580334cb9131f547845f9b7aa3916ddf4b#diff-84938e7dfe64805a850b8a729495117a972a474622fff12bb97ee45cbc2184f2), but the changes are the same. Why not backport 8248817 first? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/274 From github.com+25946952+rnkovacs at openjdk.java.net Mon Aug 23 17:04:24 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 23 Aug 2021 17:04:24 GMT Subject: [jdk11u-dev] RFR: 8250810: Push missing parts of JDK-8248817 In-Reply-To: <5rQ17hdgRiagcdC76vWlrx6oEEFuTtr94tvxWPPBdfs=.e750270f-2a2d-4906-a3e2-a8151d29fcca@github.com> References: <5rQ17hdgRiagcdC76vWlrx6oEEFuTtr94tvxWPPBdfs=.e750270f-2a2d-4906-a3e2-a8151d29fcca@github.com> Message-ID: On Mon, 23 Aug 2021 07:49:47 GMT, Reka Kovacs wrote: > This is a refactoring patch with no functional change. It didn't apply cleanly. Differences to the original commit: > > In `thread_windows_x86.cpp`: > - Some removed lines were simpler on tip because of [JDK-8248240](https://github.com/openjdk/jdk/commit/a6e794b3e85d28537bf740d9d7e68339707d38e1#diff-d4111d540c34b1e0f4acac1e92877ce458b29d70126ccb113b439261a503ed95). > > In `os_windows.cpp`: > - The block around L2461 is no longer present on tip, that and a bit of the next block can be simplified. > - The conditions on L2539 ([JDK-8234372](https://github.com/openjdk/jdk/commit/4e4d1f2b4dad61b4c4590f1d3a956b9ad86ff74c#diff-84938e7dfe64805a850b8a729495117a972a474622fff12bb97ee45cbc2184f2)) and L2549 ([JDK-8213199](https://github.com/openjdk/jdk/commit/7c3f2b06f13e3d28b74193d8acac4478e8c12bdb#diff-84938e7dfe64805a850b8a729495117a972a474622fff12bb97ee45cbc2184f2)) (original line numbers) are different on tip. We actually didn't touch those, they only show up colored in the diff because of the whitespace changes. > - The surrounding code is different around L2586 because of [JDK-8191278](https://github.com/openjdk/jdk/commit/aedbb7580334cb9131f547845f9b7aa3916ddf4b#diff-84938e7dfe64805a850b8a729495117a972a474622fff12bb97ee45cbc2184f2), but the changes are the same. Hm, I remember visiting that bug, but I just assumed we've done that already without checking more carefully. Thanks for noticing! I'll add it to the list. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/274 From github.com+25946952+rnkovacs at openjdk.java.net Mon Aug 23 19:56:21 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 23 Aug 2021 19:56:21 GMT Subject: [jdk11u-dev] RFR: 8248668: AArch64: Avoid MIN/MAX macros when using MSVC In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 06:52:08 GMT, Reka Kovacs wrote: > Changes apply cleanly. Testing: tier1. > > This is part of the Windows/AArch64 port. I'm not sure what's up with the Windows x64 hotspot test failure (it says `STATUS:Passed.`, times out, and produces a seemingly empty `newfailures.txt` at the same time), but this patch only touches AArch64-related files. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/263 From clanger at openjdk.java.net Mon Aug 23 21:17:36 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 23 Aug 2021 21:17:36 GMT Subject: [jdk11u-dev] RFR: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj In-Reply-To: References: Message-ID: On Thu, 19 Aug 2021 00:55:21 GMT, Hui Shi wrote: >> Marked as reviewed by phh (Reviewer). > > @phohensee Thanks for your review. @huishi-hs: This PR was integrated before jdk11u approval was given in JBS. No problem in this case - I have retroactively approved it. But please take care to wait for JBS approval next time. (@phohensee: As sponsor, you should probably also check that approval was given. Sponsoring to me includes guiding non-comitters who contribute only occasionally or for the first time through the process ??) Thanks. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/250 From phh at openjdk.java.net Mon Aug 23 21:22:42 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Mon, 23 Aug 2021 21:22:42 GMT Subject: [jdk11u-dev] RFR: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj In-Reply-To: References: Message-ID: On Sun, 15 Aug 2021 01:28:35 GMT, Hui Shi wrote: > Please help review this backport for 8272131: C2 crash in PhaseMacroExpand::generate_slow_arraycopy because arraycopy node's _ioproj_fallthrough is NULL. > > Conflicts when backport > In jdk18: field name is fallthrough_ioproj , and it is in PhaseMacroExpand's CallProjections class. > In jdk11: field name is _ioproj_fallthrough, and it is directly in PhaseMacroExpand class. Hmm. I had thought it was tagged jdk11u-fix-yes before I pushed. My apologies. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/250 From clanger at openjdk.java.net Mon Aug 23 21:45:29 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 23 Aug 2021 21:45:29 GMT Subject: [jdk11u-dev] RFR: 8215624: Add parallel heap iteration for jmap =?UTF-8?B?4oCTaGlzdG8=?= In-Reply-To: References: Message-ID: On Tue, 17 Aug 2021 07:47:33 GMT, Bin Liao wrote: >> Unclean backport, since original patch does not apply cleanly to 11u, because jmap command parameter is different between each other, and the code structure has little changed. >> >> 8215624: Add parallel heap iteration for jmap -histo >> 8253763: ParallelObjectIterator should have virtual destructor > > Would anyone help me to review this backport? Thank you! Hi, @buddyliao, we can have a look. First of all, I see that you have included JDK-8253763 in this commit, which seems to make sense. Can you please add the issue to this PR via the "/issue add" command? Furthermore, JDK-8251570 seems to be a follow up. Do you plan to backport this as well? If so, you could use a "dependent PR" to also propose a backport for this and we can test it together. Please let me know and I can guide you on how to do it. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/127 From clanger at openjdk.java.net Mon Aug 23 21:45:30 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 23 Aug 2021 21:45:30 GMT Subject: [jdk11u-dev] RFR: 8215624: Add parallel heap iteration for jmap =?UTF-8?B?4oCTaGlzdG8=?= In-Reply-To: References: Message-ID: On Tue, 13 Jul 2021 09:50:45 GMT, Bin Liao wrote: > Unclean backport, since original patch does not apply cleanly to 11u, because jmap command parameter is different between each other, and the code structure has little changed. > > 8215624: Add parallel heap iteration for jmap -histo > 8253763: ParallelObjectIterator should have virtual destructor Another thing: Could you please enable Github Actions for this PR by merging jdk11u-dev master? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/127 From clanger at openjdk.java.net Mon Aug 23 21:59:23 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 23 Aug 2021 21:59:23 GMT Subject: [jdk11u-dev] RFR: 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 12:49:48 GMT, Aleksey Shipilev wrote: > Backport to stabilize the test and match `11.0.13-oracle`. > It contains two bugfixes that are clean backports on their own. > > Additional testing: > - [x] Affected test still passes LGTM ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/255 From clanger at openjdk.java.net Mon Aug 23 22:22:29 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 23 Aug 2021 22:22:29 GMT Subject: [jdk11u-dev] RFR: 8248671: AArch64: Remove unused variables In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 06:05:29 GMT, Reka Kovacs wrote: > Tiny change, applies cleanly. > > This is part of the Windows/AArch64 port. @rnkovacs You need to request push approval for jdk11u backports, even when a PR is marked as "ready". So you should have waited with /integrate until the JBS issue (https://bugs.openjdk.java.net/browse/JDK-8248671) has label jdk11u-fix-xes. I have approved and sponsored this now. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/261 From github.com+25946952+rnkovacs at openjdk.java.net Mon Aug 23 22:22:29 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 23 Aug 2021 22:22:29 GMT Subject: [jdk11u-dev] Integrated: 8248671: AArch64: Remove unused variables In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 06:05:29 GMT, Reka Kovacs wrote: > Tiny change, applies cleanly. > > This is part of the Windows/AArch64 port. This pull request has now been integrated. Changeset: c81c8e84 Author: Reka Kovacs Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/c81c8e846896c502546ef5f4c92e142d58d1771f Stats: 2 lines in 2 files changed: 0 ins; 2 del; 0 mod 8248671: AArch64: Remove unused variables Remove unused variables in the AArch64 backend. Detected by compiling with MSVC, which warns about them. Co-authored-by: Bernhard Urban-Forster Backport-of: dff37f89c5db93ce12f45334c4ab1d02390dea95 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/261 From clanger at openjdk.java.net Mon Aug 23 22:31:27 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 23 Aug 2021 22:31:27 GMT Subject: [jdk11u-dev] RFR: JDK-8253947: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: References: Message-ID: <5muM-4NZ2lDqig_Ad-ZP5nooARMvps_MhKBkR0j39mU=.9565dbd4-e2a7-4b5d-99ef-3f070c3f7705@github.com> On Tue, 10 Aug 2021 21:43:47 GMT, Reka Kovacs wrote: > This is a more recent version of https://github.com/openjdk/jdk11u/pull/2. > > Changes since then: > - [JDK-8254634](https://bugs.openjdk.java.net/browse/JDK-8254634) (backport of [Build failure with VS 2019 (16.5.0) due to C2039 and C2873](https://bugs.openjdk.java.net/browse/JDK-8241087)) was removed, as it had been committed separately. > - [JDK-8269391](https://bugs.openjdk.java.net/browse/JDK-8269391) (backport of [AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter](https://bugs.openjdk.java.net/browse/JDK-8265756)) was added. > - [JDK-8271095](https://bugs.openjdk.java.net/browse/JDK-8271095) (backport of [C4530 was reported from VS 2019 at access bridge](https://bugs.openjdk.java.net/browse/JDK-8263136)) was added. > - [JDK-8271002](https://bugs.openjdk.java.net/browse/JDK-8271002) (backport of [AArch64: Fix MacroAssembler::get_thread convention](https://bugs.openjdk.java.net/browse/JDK-8261072)) was added. > - [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) was added, containing the Windows/AArch64 related part of [JDK-8271571](https://bugs.openjdk.java.net/browse/JDK-8271571) (backport of [AArch64: Backtracing broken on PAC enabled systems](https://bugs.openjdk.java.net/browse/JDK-8266749)), necessary for a correct build. > - Various small merge conflict resolutions. > > Similarly to how it was done on tip, we have incorporated parts of [JDK-8253015: Aarch64: Move linux code out from generic CPU feature detection](https://bugs.openjdk.java.net/browse/JDK-8253015) by @AntonKozlov into the [JDK-8253947: Implementation: JEP 388: Windows AArch64 Support](https://bugs.openjdk.java.net/browse/JDK-8253947) commit. > > Please let me know how I can make the review process easier / faster. Hi, I have a suggestion: For this series of backports you can use dependent PRs. That is, you create a standard PR for the first change. Then, create the next backport to the branch "pr/#" which will appear in the repo after the first PR is opened. This way, the whole chain is based upon each other and can be reviewed in parallel. You have to integrate the PRs in order then. Once a PR is merged, its successor will automatically be updated to target the master branch. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/222 From clanger at openjdk.java.net Mon Aug 23 22:35:27 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 23 Aug 2021 22:35:27 GMT Subject: [jdk11u-dev] RFR: 8272772: Shenandoah: compiler/c2/aarch64/TestVolatilesShenandoah.java fails in 11u In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 11:46:12 GMT, Aleksey Shipilev wrote: > Shenandoah-specific, 11u-specific test bug. See more details in bug report. > > Attention @rkennke, @adinn. > > Changes: > - `argcount` is incorrect, should be `9`, matches other configs with single option > - `\(elided\)` should be escaped > - `useCompressedOops` should be handled > - 11u version still has `UseBarriersForVolatlie` block, so I had to add it for Shenandoah > - `TestVolatilesShenandoah.java` should use itself in `@driver` statements > > Additional testing: > - [x] Affected test now passes on AArch64 11u Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/267 From clanger at openjdk.java.net Mon Aug 23 22:35:31 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 23 Aug 2021 22:35:31 GMT Subject: [jdk11u-dev] RFR: 8248682: AArch64: Use ATTRIBUTE_ALIGNED helper In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 10:14:15 GMT, Reka Kovacs wrote: > Changes apply cleanly. > > This is part of the Windows/AArch64 port. Same here, please wait for backport approval before "/integrate"-ing. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/266 From github.com+25946952+rnkovacs at openjdk.java.net Mon Aug 23 22:35:31 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 23 Aug 2021 22:35:31 GMT Subject: [jdk11u-dev] Integrated: 8248682: AArch64: Use ATTRIBUTE_ALIGNED helper In-Reply-To: References: Message-ID: <6gDNvN-z1e-zlSckr7lOrLnPEGOhwXWuntOlDsJ-H1I=.5beac6f5-6c93-41ea-883f-3b068c00e5f9@github.com> On Fri, 20 Aug 2021 10:14:15 GMT, Reka Kovacs wrote: > Changes apply cleanly. > > This is part of the Windows/AArch64 port. This pull request has now been integrated. Changeset: dfb67bc3 Author: Reka Kovacs Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/dfb67bc383698aacd0a7df459d41e0743c8f88f4 Stats: 8 lines in 2 files changed: 0 ins; 0 del; 8 mod 8248682: AArch64: Use ATTRIBUTE_ALIGNED helper Co-authored-by: Bernhard Urban-Forster Backport-of: 0417fcf13f7f2159499d325f2b3ace49d2643557 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/266 From github.com+3094961+buddyliao at openjdk.java.net Tue Aug 24 01:33:25 2021 From: github.com+3094961+buddyliao at openjdk.java.net (Bin Liao) Date: Tue, 24 Aug 2021 01:33:25 GMT Subject: [jdk11u-dev] RFR: 8215624: Add parallel heap iteration for jmap =?UTF-8?B?4oCTaGlzdG8=?= In-Reply-To: References: Message-ID: On Tue, 17 Aug 2021 07:47:33 GMT, Bin Liao wrote: >> Unclean backport, since original patch does not apply cleanly to 11u, because jmap command parameter is different between each other, and the code structure has little changed. >> >> 8215624: Add parallel heap iteration for jmap -histo >> 8253763: ParallelObjectIterator should have virtual destructor > > Would anyone help me to review this backport? Thank you! > Hi, @buddyliao, we can have a look. > > First of all, I see that you have included JDK-8253763 in this commit, which seems to make sense. Can you please add the issue to this PR via the "/issue add" command? > > Furthermore, JDK-8251570 seems to be a follow up. Do you plan to backport this as well? If so, you could use a "dependent PR" to also propose a backport for this and we can test it together. Please let me know and I can guide you on how to do it. Hi RealCLanger , thank you for your kindly review and suggestions. I intent to backport JDK-8251570 after this patch. But I really don't know how to do it by using "dependent PR", since JDK-8251570 is based on this patch. Would you please guide me how to do this ? Thank you! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/127 From github.com+3094961+buddyliao at openjdk.java.net Tue Aug 24 01:54:27 2021 From: github.com+3094961+buddyliao at openjdk.java.net (Bin Liao) Date: Tue, 24 Aug 2021 01:54:27 GMT Subject: [jdk11u-dev] RFR: 8233790: Forward output from heap dumper to jcmd/jmap In-Reply-To: <3nq2lxQx57gzahXjY5KpLdoWPBm55JtCkTPUVyWIiQU=.4c9f3ab5-dbfd-48c1-8507-e89263afb83c@github.com> References: <3nq2lxQx57gzahXjY5KpLdoWPBm55JtCkTPUVyWIiQU=.4c9f3ab5-dbfd-48c1-8507-e89263afb83c@github.com> Message-ID: On Thu, 19 Aug 2021 05:53:02 GMT, Bin Liao wrote: > Backport of the heap dump enhancement: Forward output from heap dumper to jcmd/jmap > > Patch did not apply cleanly, I had to resolve/modify > src/hotspot/share/services/diagnosticCommand.cpp > src/hotspot/share/services/heapDumper.cpp > src/hotspot/share/services/heapDumper.hpp > > since patch 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea is backport before this one, so this patch can't backport cleanly Would anyone else could help me to do this review? Thank you ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/256 From hshi at openjdk.java.net Tue Aug 24 02:03:30 2021 From: hshi at openjdk.java.net (Hui Shi) Date: Tue, 24 Aug 2021 02:03:30 GMT Subject: [jdk11u-dev] RFR: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj In-Reply-To: References: Message-ID: On Mon, 23 Aug 2021 21:14:55 GMT, Christoph Langer wrote: >> @phohensee Thanks for your review. > > @huishi-hs: This PR was integrated before jdk11u approval was given in JBS. No problem in this case - I have retroactively approved it. But please take care to wait for JBS approval next time. (@phohensee: As sponsor, you should probably also check that approval was given. Sponsoring to me includes guiding non-comitters who contribute only occasionally or for the first time through the process ??) Thanks. @RealCLanger I'll check JBS jdk11u-fix-yes before integration. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/250 From dholmes at openjdk.java.net Tue Aug 24 02:33:40 2021 From: dholmes at openjdk.java.net (David Holmes) Date: Tue, 24 Aug 2021 02:33:40 GMT Subject: [jdk17u] RFR: 8272472: StackGuardPages test doesn't build with glibc 2.34 In-Reply-To: <2dqn_r2-k6oFFb8q0gMt2rvu2AGhGYuorsn0GFzjD4s=.a985d9b8-7e99-47e8-ac83-85f76409da38@github.com> References: <2dqn_r2-k6oFFb8q0gMt2rvu2AGhGYuorsn0GFzjD4s=.a985d9b8-7e99-47e8-ac83-85f76409da38@github.com> Message-ID: On Sun, 22 Aug 2021 23:07:26 GMT, David Holmes wrote: > Backport of 8272472: StackGuardPages test doesn't build with glibc 2.34 Backport has been approved. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/32 From dholmes at openjdk.java.net Tue Aug 24 02:36:38 2021 From: dholmes at openjdk.java.net (David Holmes) Date: Tue, 24 Aug 2021 02:36:38 GMT Subject: [jdk17u] Integrated: 8272472: StackGuardPages test doesn't build with glibc 2.34 In-Reply-To: <2dqn_r2-k6oFFb8q0gMt2rvu2AGhGYuorsn0GFzjD4s=.a985d9b8-7e99-47e8-ac83-85f76409da38@github.com> References: <2dqn_r2-k6oFFb8q0gMt2rvu2AGhGYuorsn0GFzjD4s=.a985d9b8-7e99-47e8-ac83-85f76409da38@github.com> Message-ID: On Sun, 22 Aug 2021 23:07:26 GMT, David Holmes wrote: > Backport of 8272472: StackGuardPages test doesn't build with glibc 2.34 This pull request has now been integrated. Changeset: bb7c412e Author: David Holmes URL: https://git.openjdk.java.net/jdk17u/commit/bb7c412e259893091210267252faf3c0a1be0969 Stats: 11 lines in 1 file changed: 9 ins; 0 del; 2 mod 8272472: StackGuardPages test doesn't build with glibc 2.34 Backport-of: f77a1a156f3da9068d012d9227c7ee0fee58f571 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/32 From github.com+3094961+buddyliao at openjdk.java.net Tue Aug 24 03:05:01 2021 From: github.com+3094961+buddyliao at openjdk.java.net (Bin Liao) Date: Tue, 24 Aug 2021 03:05:01 GMT Subject: [jdk11u-dev] RFR: 8215624: Add parallel heap iteration for jmap =?UTF-8?B?4oCTaGlzdG8=?= [v2] In-Reply-To: References: Message-ID: <_1AvUpPWKQAutI-_lS2cqLLD5EQyB_72ECPi3hNpJIQ=.4c94f43d-cb8e-4a3b-b249-5225b9c5dfd8@github.com> > Unclean backport, since original patch does not apply cleanly to 11u, because jmap command parameter is different between each other, and the code structure has little changed. > > 8215624: Add parallel heap iteration for jmap -histo > 8253763: ParallelObjectIterator should have virtual destructor Bin Liao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into parallel_heap_iter - 8266352: Add parallel heap iteration for jmap -histo 8215624: Add parallel heap iteration for jmap histo 8253763: ParallelObjectIterator should have virtual destructor ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/127/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/127/files/a2fe90d3..d220790f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=127&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=127&range=00-01 Stats: 24153 lines in 626 files changed: 13695 ins; 7193 del; 3265 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/127.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/127/head:pull/127 PR: https://git.openjdk.java.net/jdk11u-dev/pull/127 From vkempik at openjdk.java.net Tue Aug 24 05:02:28 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 24 Aug 2021 05:02:28 GMT Subject: [jdk11u-dev] Integrated: 8248414: AArch64: Remove uses of long and unsigned long ints In-Reply-To: References: Message-ID: On Mon, 9 Aug 2021 18:35:24 GMT, Vladimir Kempik wrote: > This is a backport of 8248414 to jdk11u-dev > > The backport didn't apply clean, partially due to backport of JDK-8247766 > > It's needed for mac-aarch and win-aarch64 ports > > It will be followed by 8250824 and 8251930. > > Sections of aarch64.ad file between line 10260-12560 were regenerated from aarch64_ad.m4 > > Original commit - https://github.com/openjdk/jdk/commit/c7d84850bfdbd112a495fab453a79832e3810f47 This pull request has now been integrated. Changeset: bf01efaa Author: Vladimir Kempik URL: https://git.openjdk.java.net/jdk11u-dev/commit/bf01efaa24c58bcc87d465325e8c130c35148294 Stats: 567 lines in 22 files changed: 321 ins; 9 del; 237 mod 8248414: AArch64: Remove uses of long and unsigned long ints Reviewed-by: phh Backport-of: c7d84850bfdbd112a495fab453a79832e3810f47 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/215 From vkempik at openjdk.java.net Tue Aug 24 05:19:37 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 24 Aug 2021 05:19:37 GMT Subject: [jdk11u-dev] RFR: 8250824: AArch64: follow up for JDK-8248414 Message-ID: <5rVs09-0gnWQCLgVv2YvIptGyWWYv2pRJ-MeP0VBWWs=.622f293c-1340-445e-86c1-b08efe2eaed2@github.com> Clean backport to jdk11u-dev ------------- Commit messages: - Backport d9abf606d9a3156574ca87846e7580a4092c815b Changes: https://git.openjdk.java.net/jdk11u-dev/pull/281/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=281&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8250824 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/281.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/281/head:pull/281 PR: https://git.openjdk.java.net/jdk11u-dev/pull/281 From github.com+25946952+rnkovacs at openjdk.java.net Tue Aug 24 06:17:27 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Tue, 24 Aug 2021 06:17:27 GMT Subject: [jdk11u-dev] RFR: 8250824: AArch64: follow up for JDK-8248414 In-Reply-To: <5rVs09-0gnWQCLgVv2YvIptGyWWYv2pRJ-MeP0VBWWs=.622f293c-1340-445e-86c1-b08efe2eaed2@github.com> References: <5rVs09-0gnWQCLgVv2YvIptGyWWYv2pRJ-MeP0VBWWs=.622f293c-1340-445e-86c1-b08efe2eaed2@github.com> Message-ID: On Tue, 24 Aug 2021 05:12:25 GMT, Vladimir Kempik wrote: > Clean backport to jdk11u-dev Thank you! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/281 From github.com+25946952+rnkovacs at openjdk.java.net Tue Aug 24 06:19:25 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Tue, 24 Aug 2021 06:19:25 GMT Subject: [jdk11u-dev] RFR: 8248671: AArch64: Remove unused variables In-Reply-To: References: Message-ID: On Mon, 23 Aug 2021 22:19:51 GMT, Christoph Langer wrote: >> Tiny change, applies cleanly. >> >> This is part of the Windows/AArch64 port. > > @rnkovacs You need to request push approval for jdk11u backports, even when a PR is marked as "ready". So you should have waited with /integrate until the JBS issue (https://bugs.openjdk.java.net/browse/JDK-8248671) has label jdk11u-fix-xes. > > I have approved and sponsored this now. @RealCLanger Sorry about that - I was so focused on getting the GH workflow right, I forgot that's still needed. I've requested authorship so that I can do the JBS administration myself (it's inconvenient to ask someone all the time). The two commits you've pushed for me should be enough - thank you! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/261 From shade at redhat.com Tue Aug 24 06:42:21 2021 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 24 Aug 2021 08:42:21 +0200 Subject: [17u Communication] Heads up: Final few days for 17.0.1 fixes In-Reply-To: References: Message-ID: <29a4a9c4-c294-32a2-69f7-31b63ea2d134@redhat.com> Hi Rob, On 8/23/21 5:46 PM, Robert Mckenna wrote: > Just a heads up: we expect to stop accepting fixes for 17.0.1 by the end of this week. If you need something in 17.0.1 please file a fix request ASAP. What is the process to get to 17.0.1? Current PRs against 17u seem to go to 17.0.2. -- Thanks, -Aleksey From clanger at openjdk.java.net Tue Aug 24 06:49:23 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 24 Aug 2021 06:49:23 GMT Subject: [jdk11u-dev] RFR: 8248671: AArch64: Remove unused variables In-Reply-To: References: Message-ID: On Mon, 23 Aug 2021 22:19:51 GMT, Christoph Langer wrote: >> Tiny change, applies cleanly. >> >> This is part of the Windows/AArch64 port. > > @rnkovacs You need to request push approval for jdk11u backports, even when a PR is marked as "ready". So you should have waited with /integrate until the JBS issue (https://bugs.openjdk.java.net/browse/JDK-8248671) has label jdk11u-fix-xes. > > I have approved and sponsored this now. > @RealCLanger Sorry about that - I was so focused on getting the GH workflow right, I forgot that's still needed. I've requested authorship so that I can do the JBS administration myself (it's inconvenient to ask someone all the time). The two commits you've pushed for me should be enough - thank you! Yeah, no problem. I just wanted to make you aware of that. Ideally, maintainer approvals should also be handled via GitHub - I'll continue to propose that to Skara folks. With authorship in JBS it will at least be less cumbersome. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/261 From clanger at openjdk.java.net Tue Aug 24 07:25:24 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 24 Aug 2021 07:25:24 GMT Subject: [jdk11u-dev] RFR: 8215624: Add parallel heap iteration for jmap =?UTF-8?B?4oCTaGlzdG8=?= In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 01:30:27 GMT, Bin Liao wrote: > Hi RealCLanger , thank you for your kindly review and suggestions. I intent to backport JDK-8251570 after this patch. But I really don't know how to do it by using "dependent PR", since JDK-8251570 is based on this patch. Would you please guide me how to do this ? Thank you! Sure. It is as simple as to do the backport based on this change/branch and create a PR with branch [pr/127](https://github.com/openjdk/jdk11u-dev/tree/pr/127) as target. If you have created the PR for JDK-8251570, please let me know. We can then run it together through our testing. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/127 From clanger at openjdk.java.net Tue Aug 24 07:29:43 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 24 Aug 2021 07:29:43 GMT Subject: [jdk17u] Integrated: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup In-Reply-To: <0BZ7XGy8ivmfaXNG471uHdvajmX56XsEeQ3YD1VL4GY=.e4bc32e0-92a9-4680-b18a-db632560f2fa@github.com> References: <0BZ7XGy8ivmfaXNG471uHdvajmX56XsEeQ3YD1VL4GY=.e4bc32e0-92a9-4680-b18a-db632560f2fa@github.com> Message-ID: On Mon, 23 Aug 2021 06:35:31 GMT, Christoph Langer wrote: > Hi all, > > this pull request contains a backport of JDK-8270137 from the openjdk/jdk repository. > > The commit being backported was authored by Martin Balao on 10 Aug 2021 and was reviewed by Weijun Wang. > > Thanks! This pull request has now been integrated. Changeset: 9a7046d6 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk17u/commit/9a7046d649b597e26e425f566c930a3d59ad1056 Stats: 97 lines in 3 files changed: 47 ins; 9 del; 41 mod 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup Backport-of: 67869b491ae1eaf311dfb8c61a9e94329a822ffc ------------- PR: https://git.openjdk.java.net/jdk17u/pull/33 From rob.mckenna at oracle.com Tue Aug 24 07:45:33 2021 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Tue, 24 Aug 2021 07:45:33 +0000 Subject: [External] : Re: [17u Communication] Heads up: Final few days for 17.0.1 fixes In-Reply-To: <29a4a9c4-c294-32a2-69f7-31b63ea2d134@redhat.com> References: <29a4a9c4-c294-32a2-69f7-31b63ea2d134@redhat.com> Message-ID: <32DF93F3-3BC1-4653-AB7D-E3793D098CB4@oracle.com> I pull them in automatically. -Rob > On 24 Aug 2021, at 07:42, Aleksey Shipilev wrote: > > ?Hi Rob, > >> On 8/23/21 5:46 PM, Robert Mckenna wrote: >> Just a heads up: we expect to stop accepting fixes for 17.0.1 by the end of this week. If you need something in 17.0.1 please file a fix request ASAP. > > What is the process to get to 17.0.1? > Current PRs against 17u seem to go to 17.0.2. > > -- > Thanks, > -Aleksey > From shade at openjdk.java.net Tue Aug 24 08:35:34 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 08:35:34 GMT Subject: [jdk11u-dev] RFR: 8225790: Two NestedDialogs tests fail on Ubuntu In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 12:41:21 GMT, Aleksey Shipilev wrote: > Clean backport to stabilize the tests and match `11.0.13-oracle`. > > Additional testing: > - [x] Ubuntu 20.04 passes Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/254 From shade at openjdk.java.net Tue Aug 24 08:35:32 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 08:35:32 GMT Subject: [jdk11u-dev] RFR: 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode In-Reply-To: References: Message-ID: On Thu, 19 Aug 2021 09:26:25 GMT, Aleksey Shipilev wrote: > Clean backport to stabilize the test. > > Additional testing: > - [x] Affected test still passes Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/259 From shade at openjdk.java.net Tue Aug 24 08:35:35 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 08:35:35 GMT Subject: [jdk11u-dev] Integrated: 8225790: Two NestedDialogs tests fail on Ubuntu In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 12:41:21 GMT, Aleksey Shipilev wrote: > Clean backport to stabilize the tests and match `11.0.13-oracle`. > > Additional testing: > - [x] Ubuntu 20.04 passes This pull request has now been integrated. Changeset: 2d6c9762 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/2d6c97628f54b02b04970776d3f0cc184fe76f9f Stats: 788 lines in 4 files changed: 81 ins; 610 del; 97 mod 8225790: Two NestedDialogs tests fail on Ubuntu Backport-of: 21e67e54604e60f57106be32d48ba75ebf8c1130 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/254 From shade at openjdk.java.net Tue Aug 24 08:36:33 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 08:36:33 GMT Subject: [jdk11u-dev] RFR: 8213007: Update the link in test/jdk/sun/security/provider/SecureRandom/DrbgCavp.java In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 12:32:23 GMT, Aleksey Shipilev wrote: > Clean backport to match 11.0.13-oracle. Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/253 From shade at openjdk.java.net Tue Aug 24 08:36:34 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 08:36:34 GMT Subject: [jdk11u-dev] RFR: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient In-Reply-To: References: Message-ID: On Thu, 19 Aug 2021 09:19:42 GMT, Aleksey Shipilev wrote: > Clean backport to improve test stability. > > Additional testing: > - [x] Affected tests still pass Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/258 From shade at openjdk.java.net Tue Aug 24 08:36:35 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 08:36:35 GMT Subject: [jdk11u-dev] Integrated: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient In-Reply-To: References: Message-ID: On Thu, 19 Aug 2021 09:19:42 GMT, Aleksey Shipilev wrote: > Clean backport to improve test stability. > > Additional testing: > - [x] Affected tests still pass This pull request has now been integrated. Changeset: 519894a4 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/519894a414dee7835d657123b5aa290eed4528d4 Stats: 97 lines in 2 files changed: 68 ins; 18 del; 11 mod 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient Backport-of: 23d2996fee54afcc386a505a65d3236aab874e9e ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/258 From shade at openjdk.java.net Tue Aug 24 08:36:34 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 08:36:34 GMT Subject: [jdk11u-dev] Integrated: 8213007: Update the link in test/jdk/sun/security/provider/SecureRandom/DrbgCavp.java In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 12:32:23 GMT, Aleksey Shipilev wrote: > Clean backport to match 11.0.13-oracle. This pull request has now been integrated. Changeset: 7b72611b Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/7b72611b7c307d831370731b93de59b8b3fb7e41 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod 8213007: Update the link in test/jdk/sun/security/provider/SecureRandom/DrbgCavp.java Backport-of: ae77ef7d7a4633474f7d1a45b9246f13c0711d23 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/253 From shade at openjdk.java.net Tue Aug 24 08:38:31 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 08:38:31 GMT Subject: [jdk11u-dev] RFR: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1 In-Reply-To: <-rREx2zK_B5taJxeu2p9CLmOCVCfzAUVmaUd2wQJMUU=.6706b7e9-b2f4-4bc1-8c71-8f0961d68055@github.com> References: <-rREx2zK_B5taJxeu2p9CLmOCVCfzAUVmaUd2wQJMUU=.6706b7e9-b2f4-4bc1-8c71-8f0961d68055@github.com> Message-ID: On Thu, 19 Aug 2021 12:23:02 GMT, Aleksey Shipilev wrote: > Unclean backport, because the context is a bit different (StoreVal -> IU renaming already happened). > > Additional testing: > - [x] Affected test still passes on AArch64, x86_64 > - [x] `hotspot_gc_shenandoah` passes on AArch64 Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/260 From shade at openjdk.java.net Tue Aug 24 08:38:32 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 08:38:32 GMT Subject: [jdk11u-dev] Integrated: 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode In-Reply-To: References: Message-ID: On Thu, 19 Aug 2021 09:26:25 GMT, Aleksey Shipilev wrote: > Clean backport to stabilize the test. > > Additional testing: > - [x] Affected test still passes This pull request has now been integrated. Changeset: a27ee498 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/a27ee498ad05ccc5e85bd59839edb0c62d16b54b Stats: 17 lines in 1 file changed: 7 ins; 0 del; 10 mod 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode Backport-of: 4f322a9b6c9cfdf080df23326daa45733f1b9aad ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/259 From shade at openjdk.java.net Tue Aug 24 08:38:32 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 08:38:32 GMT Subject: [jdk11u-dev] Integrated: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1 In-Reply-To: <-rREx2zK_B5taJxeu2p9CLmOCVCfzAUVmaUd2wQJMUU=.6706b7e9-b2f4-4bc1-8c71-8f0961d68055@github.com> References: <-rREx2zK_B5taJxeu2p9CLmOCVCfzAUVmaUd2wQJMUU=.6706b7e9-b2f4-4bc1-8c71-8f0961d68055@github.com> Message-ID: On Thu, 19 Aug 2021 12:23:02 GMT, Aleksey Shipilev wrote: > Unclean backport, because the context is a bit different (StoreVal -> IU renaming already happened). > > Additional testing: > - [x] Affected test still passes on AArch64, x86_64 > - [x] `hotspot_gc_shenandoah` passes on AArch64 This pull request has now been integrated. Changeset: 4a2cd36a Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/4a2cd36a28577d27f2e96842f865a685f3152c85 Stats: 16 lines in 2 files changed: 6 ins; 7 del; 3 mod 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1 Reviewed-by: zgu, rkennke Backport-of: 4fb1980fd0539230fdc310aad63bbda8cb1725e6 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/260 From shade at openjdk.java.net Tue Aug 24 08:39:24 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 08:39:24 GMT Subject: [jdk11u-dev] RFR: 8272472: StackGuardPages test doesn't build with glibc 2.34 In-Reply-To: References: Message-ID: On Mon, 23 Aug 2021 08:20:38 GMT, Aleksey Shipilev wrote: > Clean backport to get newer glibc working for this test. > > Additional testing: > - [x] Test still works on older glibc Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/275 From shade at openjdk.java.net Tue Aug 24 08:39:25 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 08:39:25 GMT Subject: [jdk11u-dev] Integrated: 8272472: StackGuardPages test doesn't build with glibc 2.34 In-Reply-To: References: Message-ID: On Mon, 23 Aug 2021 08:20:38 GMT, Aleksey Shipilev wrote: > Clean backport to get newer glibc working for this test. > > Additional testing: > - [x] Test still works on older glibc This pull request has now been integrated. Changeset: 417b3885 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/417b3885505ce61ed8dbc1ee55fa6401886b9330 Stats: 11 lines in 1 file changed: 9 ins; 0 del; 2 mod 8272472: StackGuardPages test doesn't build with glibc 2.34 Backport-of: f77a1a156f3da9068d012d9227c7ee0fee58f571 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/275 From jiefu at openjdk.java.net Tue Aug 24 08:48:01 2021 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 24 Aug 2021 08:48:01 GMT Subject: [jdk17u] RFR: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 Message-ID: Backport of [macos] Build failure with Xcode 13.0 after JDK-8264848 ------------- Commit messages: - Backport of JDK-8272700 Changes: https://git.openjdk.java.net/jdk17u/pull/36/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=36&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272700 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u/pull/36.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/36/head:pull/36 PR: https://git.openjdk.java.net/jdk17u/pull/36 From jiefu at openjdk.java.net Tue Aug 24 09:07:41 2021 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 24 Aug 2021 09:07:41 GMT Subject: [jdk17u] RFR: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 08:39:58 GMT, Jie Fu wrote: > Backport of [macos] Build failure with Xcode 13.0 after JDK-8264848 Backport has been approved. So integrate it. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/36 From jiefu at openjdk.java.net Tue Aug 24 09:07:42 2021 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 24 Aug 2021 09:07:42 GMT Subject: [jdk17u] Integrated: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 08:39:58 GMT, Jie Fu wrote: > Backport of [macos] Build failure with Xcode 13.0 after JDK-8264848 This pull request has now been integrated. Changeset: 648f3f6a Author: Jie Fu URL: https://git.openjdk.java.net/jdk17u/commit/648f3f6a8fe9ea2e00b60710afa44208cfbc2c49 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 Backport-of: d007be0952abdc8beb7b68ebf7529a939162307b ------------- PR: https://git.openjdk.java.net/jdk17u/pull/36 From clanger at openjdk.java.net Tue Aug 24 09:12:24 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 24 Aug 2021 09:12:24 GMT Subject: [jdk11u-dev] RFR: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux In-Reply-To: References: Message-ID: On Mon, 23 Aug 2021 10:26:56 GMT, Severin Gehwolf wrote: > > At eyeballing this looks good to me. If you can wait, I'd like to run it through SAP's testing tonight and let you know the results tomorrow. > > Sure, I'll wait. Thanks for the extra tests. Our testing did not reveal issues, so good to go from my end. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/241 From shade at redhat.com Tue Aug 24 09:15:41 2021 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 24 Aug 2021 11:15:41 +0200 Subject: [External] : Re: [17u Communication] Heads up: Final few days for 17.0.1 fixes In-Reply-To: <32DF93F3-3BC1-4653-AB7D-E3793D098CB4@oracle.com> References: <29a4a9c4-c294-32a2-69f7-31b63ea2d134@redhat.com> <32DF93F3-3BC1-4653-AB7D-E3793D098CB4@oracle.com> Message-ID: <4571ebdb-2e2e-d582-58fc-0b6dcbe597dc@redhat.com> On 8/24/21 9:45 AM, Robert Mckenna wrote: > I pull them in automatically. All right, thank you. I'll propose 17.0.1 patches then, and propose/push patches destined to 17.0.2 after the cutoff. -- -Aleksey From shade at openjdk.java.net Tue Aug 24 09:27:24 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 09:27:24 GMT Subject: [jdk11u-dev] RFR: 8272772: Shenandoah: compiler/c2/aarch64/TestVolatilesShenandoah.java fails in 11u In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 11:46:12 GMT, Aleksey Shipilev wrote: > Shenandoah-specific, 11u-specific test bug. See more details in bug report. > > Attention @rkennke, @adinn. > > Changes: > - `argcount` is incorrect, should be `9`, matches other configs with single option > - `\(elided\)` should be escaped > - `useCompressedOops` should be handled > - 11u version still has `UseBarriersForVolatlie` block, so I had to add it for Shenandoah > - `TestVolatilesShenandoah.java` should use itself in `@driver` statements > > Additional testing: > - [x] Affected test now passes on AArch64 11u Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/267 From shade at openjdk.java.net Tue Aug 24 09:27:24 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 09:27:24 GMT Subject: [jdk11u-dev] Integrated: 8272772: Shenandoah: compiler/c2/aarch64/TestVolatilesShenandoah.java fails in 11u In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 11:46:12 GMT, Aleksey Shipilev wrote: > Shenandoah-specific, 11u-specific test bug. See more details in bug report. > > Attention @rkennke, @adinn. > > Changes: > - `argcount` is incorrect, should be `9`, matches other configs with single option > - `\(elided\)` should be escaped > - `useCompressedOops` should be handled > - 11u version still has `UseBarriersForVolatlie` block, so I had to add it for Shenandoah > - `TestVolatilesShenandoah.java` should use itself in `@driver` statements > > Additional testing: > - [x] Affected test now passes on AArch64 11u This pull request has now been integrated. Changeset: 83d916eb Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/83d916eb0c827c3b46912f8fe5a9444e1e53b43c Stats: 30 lines in 2 files changed: 11 ins; 0 del; 19 mod 8272772: Shenandoah: compiler/c2/aarch64/TestVolatilesShenandoah.java fails in 11u Reviewed-by: rkennke, clanger ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/267 From jiefu at openjdk.java.net Tue Aug 24 09:42:35 2021 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 24 Aug 2021 09:42:35 GMT Subject: [jdk11u-dev] RFR: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 Message-ID: Backport of 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 ------------- Commit messages: - Backport d007be0952abdc8beb7b68ebf7529a939162307b Changes: https://git.openjdk.java.net/jdk11u-dev/pull/282/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=282&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272700 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/282.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/282/head:pull/282 PR: https://git.openjdk.java.net/jdk11u-dev/pull/282 From sgehwolf at openjdk.java.net Tue Aug 24 09:45:27 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 24 Aug 2021 09:45:27 GMT Subject: [jdk11u-dev] Integrated: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux In-Reply-To: References: Message-ID: On Thu, 12 Aug 2021 15:24:24 GMT, Severin Gehwolf wrote: > Please review this backport of JDK-8255790 which fixes a crash of simple FileDialog-using apps on some systems (for example F34 when not using system harfbuzz). See JDK-8272149. In a nutshell, this patch is a not quite complete revert of JDK-8249821. I.e. the OpenJDK 11u version of it. It does not revert the source code re-structuring, though. The JDK 17 patch doesn't apply clean. I've mostly hand-picked changes from the original patch. Note that JDK-8272332 is included in this backport. The differences mostly stem from differences in DISABLED_WARNINGS_ settings when BUILD_FONTMANAGER is being called. > > Testing: Build on an affected system with/without --with-harfbuzz=system. Reproducer from JDK-8272149 (crashes before, passes after) This pull request has now been integrated. Changeset: 6a6e00e5 Author: Severin Gehwolf URL: https://git.openjdk.java.net/jdk11u-dev/commit/6a6e00e56b57006fc80e7b3560c860a0f0967111 Stats: 98 lines in 1 file changed: 5 ins; 64 del; 29 mod 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux 8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790 Reviewed-by: clanger Backport-of: 05fe06a6bafc089c6466ccbdea335e5dbfdaf335 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/241 From goetz.lindenmaier at sap.com Tue Aug 24 09:46:32 2021 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Tue, 24 Aug 2021 09:46:32 +0000 Subject: [11u reminder]: jdk 11.0.13 rampdown starts Tuesday, August 31, 18:00 CET. Message-ID: Hi, I would like to remind everybody who is working on jdk 11 updates that Rampdown of 11.0.13 starts next Tuesday, August 31, at 18:00 CET. At that point in time the last merge from jdk11u-dev to jdk11u will take place. Please push all changes you want to get to 11.0.13 before that date. After that, changes for 11.0.13 must be requested with jdk11u-critical-request tags, and they need to be pushed directly to jdk11u. Best regards, Goetz See also https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u From shade at openjdk.java.net Tue Aug 24 10:06:40 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 10:06:40 GMT Subject: [jdk17u] RFR: 8269897: Shenandoah: Resolve UNKNOWN access strength, where possible Message-ID: Clean backport to fix a serious Shenandoah bug. Additional testing: - [x] `jcstress` now passes - [x] `hotspot_gc_shenandoah` passes - [x] `tier1` with `-XX:+UseShenandoahGC` passes - [x] `tier2` with `-XX:+UseShenandoahGC` passes ------------- Commit messages: - Backport 7ac08161a8b2080ed054bc00a30d6f694ece4df3 Changes: https://git.openjdk.java.net/jdk17u/pull/37/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=37&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269897 Stats: 116 lines in 3 files changed: 49 ins; 33 del; 34 mod Patch: https://git.openjdk.java.net/jdk17u/pull/37.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/37/head:pull/37 PR: https://git.openjdk.java.net/jdk17u/pull/37 From vkempik at openjdk.java.net Tue Aug 24 10:13:26 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 24 Aug 2021 10:13:26 GMT Subject: [jdk11u-dev] Integrated: 8250824: AArch64: follow up for JDK-8248414 In-Reply-To: <5rVs09-0gnWQCLgVv2YvIptGyWWYv2pRJ-MeP0VBWWs=.622f293c-1340-445e-86c1-b08efe2eaed2@github.com> References: <5rVs09-0gnWQCLgVv2YvIptGyWWYv2pRJ-MeP0VBWWs=.622f293c-1340-445e-86c1-b08efe2eaed2@github.com> Message-ID: On Tue, 24 Aug 2021 05:12:25 GMT, Vladimir Kempik wrote: > Clean backport to jdk11u-dev This pull request has now been integrated. Changeset: 8afb159c Author: Vladimir Kempik URL: https://git.openjdk.java.net/jdk11u-dev/commit/8afb159c24c0f676544d7792a1222da554c962fa Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8250824: AArch64: follow up for JDK-8248414 The original change missed to update an assert. Backport-of: d9abf606d9a3156574ca87846e7580a4092c815b ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/281 From shade at openjdk.java.net Tue Aug 24 10:30:25 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 10:30:25 GMT Subject: [jdk11u-dev] RFR: 8263776: [JVMCI] add helper to perform Java upcalls [v2] In-Reply-To: <_JqBNe6NoFMdBl9ZKb9Nori81Jvfi2Gx4WKqC4Zpxm4=.bcb9af18-9ffe-448d-b361-b468149061d3@github.com> References: <7wco05J7hRzI4xOvDgpIDF655fi6ZH-L0W2WwVOz3TY=.f9ee248f-f6c0-4445-a9f1-79d998fe6d43@github.com> <_JqBNe6NoFMdBl9ZKb9Nori81Jvfi2Gx4WKqC4Zpxm4=.bcb9af18-9ffe-448d-b361-b468149061d3@github.com> Message-ID: <1s0olVpFTVGITmtFxvbJegYjW3iWHNJoZaDVAYwGaek=.1c33c188-de2b-4f2d-a2fb-e59f9c7919a9@github.com> On Mon, 23 Aug 2021 16:28:07 GMT, Severin Gehwolf wrote: >> src/hotspot/share/jvmci/jvmciRuntime.cpp line 513: >> >>> 511: return value->f; >>> 512: case T_DOUBLE: >>> 513: return value->d; >> >> The original commit uses `value->i` and `value->j` here. Of course, `value->f` and `value->d` look more correct, but do you understand why this difference? > > The original change handles `T_INT` and `T_FLOAT` (same bit width) with a single case statement. Same for `T_DOUBLE` and `T_LONG`. Therefore returning the more generic union types `value->i` and `value->j` respectively. I'm not sure this actually makes any difference. This seems the cleaner way to handle it. Yeah, I don't see the difference, but I think this is how we do conversions: put the `jdouble` to `value->d`, read `jlong` from `value->j`. Since this method returns `jlong`, I would expect `value->j` here. See e.g. `next_double()` in this patch. Note that if we do `->f`, `->d` for `T_FLOAT` and `T_DOUBLE`, then it is reasonable to expect `T_BOOLEAN` and friends also replaced by their own type-specific union fields. I would personally like to match mainline here, and then maybe clean up mainline, then backport the cleanup as the follow-up. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/279 From shade at redhat.com Tue Aug 24 11:57:16 2021 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 24 Aug 2021 13:57:16 +0200 Subject: Enable GHA "Checks" for 17u Message-ID: <8cb99aa7-27af-8a99-ad2c-72bbff4bdc29@redhat.com> Hi, JDK 17u workspace has GHA workflows enabled, so it can be tested. For example, this is the run for recent backport: https://github.com/shipilev/jdk17u/actions/runs/1158027935 However, the "Checks" tab in PR does not show it: https://github.com/openjdk/jdk17u/pull/35 I believe it requires a bit of configuration nudge (in 17u Skara bots?). Christoph, do you remember what you did in 11u for this? Rob, can you see what can be done here? -- Thanks, -Aleksey From clanger at openjdk.java.net Tue Aug 24 11:56:24 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 24 Aug 2021 11:56:24 GMT Subject: [jdk11u-dev] RFR: 8248666: AArch64: Use THREAD_LOCAL instead of __thread In-Reply-To: References: Message-ID: <75DaD7QVnh02dSNKfBBkJBwsjV1IBS3mp4d_GCNd1Pw=.a786193c-cfda-4c54-a98a-6f9a340283fd@github.com> On Fri, 20 Aug 2021 06:28:24 GMT, Reka Kovacs wrote: > Not a clean backport. Original patch used a macro called THREAD_LOCAL, this backport uses THREAD_LOCAL_DECL. THREAD_LOCAL_DECL was renamed to THREAD_LOCAL by [JDK-8230877](https://bugs.openjdk.java.net/browse/JDK-8230877) in JDK 14. Testing: tier1. > > This is part of the Windows/AArch64 port. I can sponsor this one but it needs rebasing first. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/262 From clanger at openjdk.java.net Tue Aug 24 11:59:24 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 24 Aug 2021 11:59:24 GMT Subject: [jdk11u-dev] RFR: 8248668: AArch64: Avoid MIN/MAX macros when using MSVC In-Reply-To: References: Message-ID: On Mon, 23 Aug 2021 19:52:16 GMT, Reka Kovacs wrote: > I'm not sure what's up with the Windows x64 hotspot test failure (it says `STATUS:Passed.`, times out, and produces a seemingly empty `newfailures.txt` at the same time), but this patch only touches AArch64-related files. You can try to merge master into this PR. With that GHA will run again and we can check if it occurs again. Please do so and I'll sponsor the change if the issue is not reproduced. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/263 From sgehwolf at openjdk.java.net Tue Aug 24 12:00:26 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 24 Aug 2021 12:00:26 GMT Subject: [jdk11u-dev] RFR: 8263776: [JVMCI] add helper to perform Java upcalls [v2] In-Reply-To: <1s0olVpFTVGITmtFxvbJegYjW3iWHNJoZaDVAYwGaek=.1c33c188-de2b-4f2d-a2fb-e59f9c7919a9@github.com> References: <7wco05J7hRzI4xOvDgpIDF655fi6ZH-L0W2WwVOz3TY=.f9ee248f-f6c0-4445-a9f1-79d998fe6d43@github.com> <_JqBNe6NoFMdBl9ZKb9Nori81Jvfi2Gx4WKqC4Zpxm4=.bcb9af18-9ffe-448d-b361-b468149061d3@github.com> <1s0olVpFTVGITmtFxvbJegYjW3iWHNJoZaDVAYwGaek=.1c33c188-de2b-4f2d-a2fb-e59f9c7919a9@github.com> Message-ID: On Tue, 24 Aug 2021 10:28:08 GMT, Aleksey Shipilev wrote: >> The original change handles `T_INT` and `T_FLOAT` (same bit width) with a single case statement. Same for `T_DOUBLE` and `T_LONG`. Therefore returning the more generic union types `value->i` and `value->j` respectively. I'm not sure this actually makes any difference. This seems the cleaner way to handle it. > > Yeah, I don't see the difference, but I think this is how we do conversions: put the `jdouble` to `value->d`, read `jlong` from `value->j`. Since this method returns `jlong`, I would expect `value->j` here. See e.g. `next_double()` in this patch. > > Note that if we do `->f`, `->d` for `T_FLOAT` and `T_DOUBLE`, then it is reasonable to expect `T_BOOLEAN` and friends also replaced by their own type-specific union fields. > > I would personally like to match mainline here, and then maybe clean up mainline, then backport the cleanup as the follow-up. Sure. I've also noticed that there are minor differences to the JDK 17 version (local `return_type` variable over `jap.get_ret_type()`). Will fix. Thanks! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/279 From sgehwolf at redhat.com Tue Aug 24 12:01:46 2021 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Tue, 24 Aug 2021 14:01:46 +0200 Subject: Enable GHA "Checks" for 17u In-Reply-To: <8cb99aa7-27af-8a99-ad2c-72bbff4bdc29@redhat.com> References: <8cb99aa7-27af-8a99-ad2c-72bbff4bdc29@redhat.com> Message-ID: <2e4f114345b43e06f6975cf60880299275d8b59c.camel@redhat.com> Hi, On Tue, 2021-08-24 at 13:57 +0200, Aleksey Shipilev wrote: > Hi, > > JDK 17u workspace has GHA workflows enabled, so it can be tested. > > For example, this is the run for recent backport: > ?? https://github.com/shipilev/jdk17u/actions/runs/1158027935 > > However, the "Checks" tab in PR does not show it: > ?? https://github.com/openjdk/jdk17u/pull/35 > > I believe it requires a bit of configuration nudge (in 17u Skara bots?). > Christoph, do you remember what you did in 11u for this? Not Christoph, but the Skara issue for this work was: https://bugs.openjdk.java.net/browse/SKARA-1124 I'd expect for 17u to require similar config. Thanks, Severin From christoph.langer at sap.com Tue Aug 24 12:03:17 2021 From: christoph.langer at sap.com (Langer, Christoph) Date: Tue, 24 Aug 2021 12:03:17 +0000 Subject: Enable GHA "Checks" for 17u In-Reply-To: <2e4f114345b43e06f6975cf60880299275d8b59c.camel@redhat.com> References: <8cb99aa7-27af-8a99-ad2c-72bbff4bdc29@redhat.com> <2e4f114345b43e06f6975cf60880299275d8b59c.camel@redhat.com> Message-ID: Hi, yes, I've sent and email to ops at openjdk.java.net. They were quite responsive, opened this JBS item: https://bugs.openjdk.java.net/browse/SKARA-1124 and resolved it within one day. I think, Rob, you will need to do the same (although you surely know the Oracle processes better than me ??) Cheers Christoph > -----Original Message----- > From: Severin Gehwolf > Sent: Dienstag, 24. August 2021 14:02 > To: Aleksey Shipilev ; Langer, Christoph > ; Rob McKenna > Cc: jdk-updates-dev at openjdk.java.net > Subject: Re: Enable GHA "Checks" for 17u > > Hi, > > On Tue, 2021-08-24 at 13:57 +0200, Aleksey Shipilev wrote: > > Hi, > > > > JDK 17u workspace has GHA workflows enabled, so it can be tested. > > > > For example, this is the run for recent backport: > > ?? https://github.com/shipilev/jdk17u/actions/runs/1158027935 > > > > However, the "Checks" tab in PR does not show it: > > ?? https://github.com/openjdk/jdk17u/pull/35 > > > > I believe it requires a bit of configuration nudge (in 17u Skara bots?). > > Christoph, do you remember what you did in 11u for this? > > Not Christoph, but the Skara issue for this work was: > https://bugs.openjdk.java.net/browse/SKARA-1124 > > I'd expect for 17u to require similar config. > > Thanks, > Severin From github.com+25946952+rnkovacs at openjdk.java.net Tue Aug 24 12:04:26 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Tue, 24 Aug 2021 12:04:26 GMT Subject: [jdk11u-dev] Integrated: 8248657: Windows: strengthening in ThreadCritical regarding memory model In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 08:07:35 GMT, Reka Kovacs wrote: > Removed line [L59](https://github.com/openjdk/jdk11u-dev/pull/265/files#diff-7eb55bd4224b99f2ae0f2df4c3e65e586af8998933eeeba6ea4615ce558a36fbL59) in src/hotspot/os/windows/threadCritical_windows.cpp has changed between 11 and tip ([JDK-8234740](https://bugs.openjdk.java.net/browse/JDK-8234740)), otherwise the backport is clean. Testing: tier1. > > This is part of the Windows/AArch64 port. This pull request has now been integrated. Changeset: 4a3afd77 Author: Reka Kovacs Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/4a3afd77e35baa486be50d1541a751e79407cfe0 Stats: 37 lines in 1 file changed: 8 ins; 20 del; 9 mod 8248657: Windows: strengthening in ThreadCritical regarding memory model Co-authored-by: Bernhard Urban-Forster Reviewed-by: phh Backport-of: 6af643e5a1f9f22ecd29a652ebfb9b6d0bf210a4 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/265 From kevin.rushforth at oracle.com Tue Aug 24 12:16:24 2021 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 24 Aug 2021 05:16:24 -0700 Subject: Enable GHA "Checks" for 17u In-Reply-To: References: <8cb99aa7-27af-8a99-ad2c-72bbff4bdc29@redhat.com> <2e4f114345b43e06f6975cf60880299275d8b59c.camel@redhat.com> Message-ID: Yes, this is all that's needed. It's a simple change. -- Kevin On 8/24/2021 5:03 AM, Langer, Christoph wrote: > Hi, > > yes, I've sent and email to ops at openjdk.java.net. They were quite responsive, opened this JBS item: https://bugs.openjdk.java.net/browse/SKARA-1124 and resolved it within one day. I think, Rob, you will need to do the same (although you surely know the Oracle processes better than me ??) > > Cheers > Christoph > >> -----Original Message----- >> From: Severin Gehwolf >> Sent: Dienstag, 24. August 2021 14:02 >> To: Aleksey Shipilev ; Langer, Christoph >> ; Rob McKenna >> Cc: jdk-updates-dev at openjdk.java.net >> Subject: Re: Enable GHA "Checks" for 17u >> >> Hi, >> >> On Tue, 2021-08-24 at 13:57 +0200, Aleksey Shipilev wrote: >>> Hi, >>> >>> JDK 17u workspace has GHA workflows enabled, so it can be tested. >>> >>> For example, this is the run for recent backport: >>> ?? https://github.com/shipilev/jdk17u/actions/runs/1158027935 >>> >>> However, the "Checks" tab in PR does not show it: >>> ?? https://github.com/openjdk/jdk17u/pull/35 >>> >>> I believe it requires a bit of configuration nudge (in 17u Skara bots?). >>> Christoph, do you remember what you did in 11u for this? >> Not Christoph, but the Skara issue for this work was: >> https://bugs.openjdk.java.net/browse/SKARA-1124 >> >> I'd expect for 17u to require similar config. >> >> Thanks, >> Severin From shade at redhat.com Tue Aug 24 12:20:50 2021 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 24 Aug 2021 14:20:50 +0200 Subject: Enable GHA "Checks" for 17u In-Reply-To: References: <8cb99aa7-27af-8a99-ad2c-72bbff4bdc29@redhat.com> <2e4f114345b43e06f6975cf60880299275d8b59c.camel@redhat.com> Message-ID: On 8/24/21 2:16 PM, Kevin Rushforth wrote: > Yes, this is all that's needed. It's a simple change. Thanks! I took the liberty of submitting the similar RFE: https://bugs.openjdk.java.net/browse/SKARA-1132 Rob, please ack there if you agree. -- Thanks, -Aleksey From rob.mckenna at oracle.com Tue Aug 24 12:25:39 2021 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Tue, 24 Aug 2021 12:25:39 +0000 Subject: [External] : Re: Enable GHA "Checks" for 17u In-Reply-To: References: <8cb99aa7-27af-8a99-ad2c-72bbff4bdc29@redhat.com> <2e4f114345b43e06f6975cf60880299275d8b59c.camel@redhat.com> Message-ID: Sorry, just getting to this thread now. Thanks for filing the bug. I've commented there. -Rob ________________________________________ From: Aleksey Shipilev Sent: Tuesday 24 August 2021 13:20 To: Kevin Rushforth; Langer, Christoph; sgehwolf; Robert Mckenna Cc: jdk-updates-dev at openjdk.java.net Subject: [External] : Re: Enable GHA "Checks" for 17u On 8/24/21 2:16 PM, Kevin Rushforth wrote: > Yes, this is all that's needed. It's a simple change. Thanks! I took the liberty of submitting the similar RFE: https://bugs.openjdk.java.net/browse/SKARA-1132 Rob, please ack there if you agree. -- Thanks, -Aleksey From clanger at openjdk.java.net Tue Aug 24 12:30:28 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 24 Aug 2021 12:30:28 GMT Subject: [jdk11u-dev] RFR: 8248816: C1: Fix signature conflict in LIRGenerator::strength_reduce_multiply In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 22:48:53 GMT, Reka Kovacs wrote: > Changes apply cleanly. > > This is part of the Windows/AArch64 port. Again the test failure in Windows hs tests - but I'm quite conviced it cannot have to do with this one. So, ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/269 From github.com+25946952+rnkovacs at openjdk.java.net Tue Aug 24 12:30:28 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Tue, 24 Aug 2021 12:30:28 GMT Subject: [jdk11u-dev] Integrated: 8248816: C1: Fix signature conflict in LIRGenerator::strength_reduce_multiply In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 22:48:53 GMT, Reka Kovacs wrote: > Changes apply cleanly. > > This is part of the Windows/AArch64 port. This pull request has now been integrated. Changeset: 46994677 Author: Reka Kovacs Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/4699467721b31c532453c88e96f8d7cdeff18713 Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod 8248816: C1: Fix signature conflict in LIRGenerator::strength_reduce_multiply Co-authored-by: Bernhard Urban-Forster Backport-of: d3776c7d30f23489c04518d20d441c2ec2f06705 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/269 From sgehwolf at openjdk.java.net Tue Aug 24 12:30:56 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 24 Aug 2021 12:30:56 GMT Subject: [jdk11u-dev] RFR: 8263776: [JVMCI] add helper to perform Java upcalls [v3] In-Reply-To: References: Message-ID: > Here is a backport for JDK-8263776. The patch doesn't apply cleanly since it uses features only introduced with JDK-8230199 (JDK 15+, not in OpenJDK 11u). This patch is the same labsopenjdk 11 uses. This patch is also needed for using graal js with plain OpenJDK. > > Testing: test/hotspot/jtreg/compiler/jvmci and manual upstream Graal unit test. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Use a closer version of the JDK 17 patch - Merge branch 'master' into jdk-8263776-no-arg-jvmci-change - Cleanup whitespace - Backport 6b4c654186e49528eeae7249fdcd0f2d1a98b3ad ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/279/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/279/files/7b7e3407..bec2238b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=279&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=279&range=01-02 Stats: 276 lines in 5 files changed: 126 ins; 77 del; 73 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/279.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/279/head:pull/279 PR: https://git.openjdk.java.net/jdk11u-dev/pull/279 From zgu at openjdk.java.net Tue Aug 24 12:31:39 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 24 Aug 2021 12:31:39 GMT Subject: [jdk11u-dev] RFR: 8213718: [TEST] Wrong classname in vmTestbase/nsk/stress/except/except002 and except003 Message-ID: <42fnD14Xv5dOG0bAswoahRt9R3-1twReZNh44-eFs_s=.0522b26d-66c9-404e-a0f4-bf0954c6ea5c@github.com> A clean backport for parity with Oracle 11.0.14. The two affected tests passed. ------------- Commit messages: - Backport 90cf7a7d12729e1f0afc404c49e620796abf539b Changes: https://git.openjdk.java.net/jdk11u-dev/pull/283/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=283&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8213718 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/283.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/283/head:pull/283 PR: https://git.openjdk.java.net/jdk11u-dev/pull/283 From sgehwolf at openjdk.java.net Tue Aug 24 12:34:24 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 24 Aug 2021 12:34:24 GMT Subject: [jdk11u-dev] RFR: 8263776: [JVMCI] add helper to perform Java upcalls In-Reply-To: <0O0pr4A8dzBYKm6HayVIRLcBKazJzESyqVBPfaTQa20=.66b9c6f7-93d7-4f91-ac72-90da32555ea7@github.com> References: <0O0pr4A8dzBYKm6HayVIRLcBKazJzESyqVBPfaTQa20=.66b9c6f7-93d7-4f91-ac72-90da32555ea7@github.com> Message-ID: <0fXPitDg8uXXY2er68U1dktMrSPx3lRJh9jdrcrnon0=.0799dfae-bdc9-49eb-babd-35586c309478@github.com> On Mon, 23 Aug 2021 14:31:33 GMT, Aleksey Shipilev wrote: >> I'm pretty sure the GHA tier1 failure of `gc/stress/gcold/TestGCOldWithCMS.java` on Linux x86 is unrelated as this is an JVMCI only change. > >> I'm pretty sure the GHA tier1 failure of `gc/stress/gcold/TestGCOldWithCMS.java` on Linux x86 is unrelated as this is an JVMCI only change. > > Yes, it looks like another instance of [JDK-8272195](https://bugs.openjdk.java.net/browse/JDK-8272195). @shipilev I've updated the patch to be similar to the mainline version now. Changes include: - Get rid of unused `is_static` boolean in `ArgumentPusher` - Get rid of unused `expectedType` in `nextArg()` - Use local variable `return_type` over calling `jap.get_ret_type()` repeatedly. - Use the same fall-through case for `T_DOUBLE/T_LONG` (`value->j`) and `T_INT/T_FLOAT` (`value->i`), which matches mainline. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/279 From rkennke at openjdk.java.net Tue Aug 24 12:41:26 2021 From: rkennke at openjdk.java.net (Roman Kennke) Date: Tue, 24 Aug 2021 12:41:26 GMT Subject: [jdk11u-dev] RFR: 8232782: Shenandoah: streamline post-LRB CAS barrier (aarch64) In-Reply-To: References: Message-ID: <-uZ_cbLSKwzw4ZML6yFna-D0_Zp1MwJ2wVxXfWUUoSQ=.a9f442c5-7dbd-4678-bf83-7efe743b914f@github.com> On Fri, 20 Aug 2021 15:24:23 GMT, Aleksey Shipilev wrote: > Unclean backport to improve Shenandoah AArch64 performance and provide grounds for subsequent backports. > > There were conflicts in `shenandoah_aarch64.ad`, as there is `weakCompareAndSwapPAcq_shenandoah` and `weakCompareAndSwapNAcq_shenandoah` are missing in 11u. > > Additional testing: > - [x] Linux AArch64 `hotspot_gc_shenandoah` > - [x] Linux AArch64 `tier1` with `-XX:+UseShenandoahGC` > - [x] Linux AArch64 `tier2` with `-XX:+UseShenandoahGC` > - [x] Linux AArch64 jcstress `-m quick` with `-XX:+UseShenandoahGC` Looks good to me, thanks!! ------------- Marked as reviewed by rkennke (Committer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/268 From github.com+25946952+rnkovacs at openjdk.java.net Tue Aug 24 12:42:28 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Tue, 24 Aug 2021 12:42:28 GMT Subject: [jdk11u-dev] Integrated: 8261072: AArch64: Fix MacroAssembler::get_thread convention In-Reply-To: <2RcCV4w6COz7Wmj0xH6MhGDFlqhSLgdAOOlL-Xc1_rQ=.ae7482e0-6edc-46fb-bd7d-683d73246d86@github.com> References: <2RcCV4w6COz7Wmj0xH6MhGDFlqhSLgdAOOlL-Xc1_rQ=.ae7482e0-6edc-46fb-bd7d-683d73246d86@github.com> Message-ID: On Sun, 22 Aug 2021 16:57:48 GMT, Reka Kovacs wrote: > Clean backport. The non-Linux path will only be exercised once [JEP 388](https://github.com/openjdk/jdk11u-dev/pull/222) is in. > > This is part of the Windows/AArch64 port. This pull request has now been integrated. Changeset: 13ddf0ee Author: Reka Kovacs Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/13ddf0eeaaf0f843c48f9b0e79cdf2dea5bb2a24 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod 8261072: AArch64: Fix MacroAssembler::get_thread convention Co-authored-by: Monica Beckwith Backport-of: b670efd896a2905b6842b8199261aa2f3d7c12b9 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/271 From github.com+25946952+rnkovacs at openjdk.java.net Tue Aug 24 12:45:30 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Tue, 24 Aug 2021 12:45:30 GMT Subject: [jdk11u-dev] Integrated: 8263136: C4530 was reported from VS 2019 at access bridge In-Reply-To: References: Message-ID: On Sun, 22 Aug 2021 14:08:19 GMT, Reka Kovacs wrote: > Changes apply cleanly. > > This is part of the Windows/AArch64 port. This pull request has now been integrated. Changeset: f334c2e7 Author: Reka Kovacs Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/f334c2e70731ee0ab902e8d8f1afd1ab2dfcdfdc Stats: 9 lines in 1 file changed: 2 ins; 1 del; 6 mod 8263136: C4530 was reported from VS 2019 at access bridge Co-authored-by: Monica Beckwith Backport-of: d339320e0b648e28bcc0c07801ae9376a33fc975 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/270 From github.com+25946952+rnkovacs at openjdk.java.net Tue Aug 24 12:47:30 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Tue, 24 Aug 2021 12:47:30 GMT Subject: [jdk11u-dev] Integrated: 8265756: AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter In-Reply-To: References: Message-ID: On Sun, 22 Aug 2021 17:11:28 GMT, Reka Kovacs wrote: > Changes apply cleanly. > > This is part of the Windows/AArch64 port. This pull request has now been integrated. Changeset: da90fbb8 Author: Reka Kovacs Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/da90fbb8c78320f54deed55322b2ebb1db1d3a83 Stats: 123 lines in 3 files changed: 116 ins; 5 del; 2 mod 8265756: AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter Co-authored-by: Monica Beckwith Backport-of: f6e26f6f33cd06ec4d8e911972a193aea9fab557 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/272 From github.com+3094961+buddyliao at openjdk.java.net Tue Aug 24 12:48:40 2021 From: github.com+3094961+buddyliao at openjdk.java.net (Bin Liao) Date: Tue, 24 Aug 2021 12:48:40 GMT Subject: [jdk11u-dev] RFR: 8251570: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id Message-ID: This patch is backport based on https://github.com/openjdk/jdk11u-dev/pull/127 ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/127 Commit messages: - Backport 2631422bc55c8a411e170c5bf737a1882a61d2f5 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/284/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=284&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8251570 Stats: 76 lines in 12 files changed: 33 ins; 36 del; 7 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/284.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/284/head:pull/284 PR: https://git.openjdk.java.net/jdk11u-dev/pull/284 From clanger at openjdk.java.net Tue Aug 24 12:49:32 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 24 Aug 2021 12:49:32 GMT Subject: [jdk11u-dev] RFR: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 09:33:47 GMT, Jie Fu wrote: > Backport of 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 @DamonFool, can you please run GHA on this commit (e.g. enable it on your fork and rebase this PR to current master branch)? Thanks ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/282 From dholmes at openjdk.java.net Tue Aug 24 13:02:40 2021 From: dholmes at openjdk.java.net (David Holmes) Date: Tue, 24 Aug 2021 13:02:40 GMT Subject: [jdk17u] RFR: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status Message-ID: Hi all, This pull request contains a backport of commit 7e518f42 from the openjdk/jdk repository. The commit being backported was authored by David Holmes on 4 Aug 2021 and was reviewed by Thomas Stuefe, Daniel D. Daugherty and Serguei Spitsyn. Thanks! David ------------- Commit messages: - Backport 7e518f42c9346abdf0c8059b45d3dfef95ed69bb Changes: https://git.openjdk.java.net/jdk17u/pull/38/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=38&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269934 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u/pull/38.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/38/head:pull/38 PR: https://git.openjdk.java.net/jdk17u/pull/38 From jiefu at openjdk.java.net Tue Aug 24 13:03:52 2021 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 24 Aug 2021 13:03:52 GMT Subject: [jdk11u-dev] RFR: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 [v2] In-Reply-To: References: Message-ID: > Backport of 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 Jie Fu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into Backport-of-JDK-8272700 - Backport d007be0952abdc8beb7b68ebf7529a939162307b ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/282/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/282/files/475a240b..e905967f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=282&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=282&range=00-01 Stats: 278 lines in 11 files changed: 135 ins; 90 del; 53 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/282.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/282/head:pull/282 PR: https://git.openjdk.java.net/jdk11u-dev/pull/282 From jiefu at openjdk.java.net Tue Aug 24 13:06:26 2021 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 24 Aug 2021 13:06:26 GMT Subject: [jdk11u-dev] RFR: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 12:46:27 GMT, Christoph Langer wrote: > @DamonFool, can you please run GHA on this commit (e.g. enable it on your fork and rebase this PR to current master branch)? Thanks Testing is now in progress. Thanks. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/282 From zgu at openjdk.java.net Tue Aug 24 13:08:34 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 24 Aug 2021 13:08:34 GMT Subject: [jdk11u-dev] Integrated: 8249548: backward focus traversal gets stuck in button group In-Reply-To: References: Message-ID: On Thu, 5 Aug 2021 19:48:27 GMT, Zhengyu Gu wrote: > A clean backport for parity with Oracle 11.0.14. This pull request has now been integrated. Changeset: 5a539dbc Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk11u-dev/commit/5a539dbc161494c6e4d4a206cea82d1457ac1751 Stats: 1157 lines in 5 files changed: 538 ins; 618 del; 1 mod 8249548: backward focus traversal gets stuck in button group Backport-of: 22bb597d0d2d901c5c8227ea700ab27c670dd545 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/199 From vkempik at openjdk.java.net Tue Aug 24 13:09:57 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 24 Aug 2021 13:09:57 GMT Subject: [jdk13u-dev] RFR: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status Message-ID: Clean backport from 15u ( reviewed by Paul Hohensee ). Not clean backport from jdk/jdk ------------- Commit messages: - Backport 7e518f42c9346abdf0c8059b45d3dfef95ed69bb Changes: https://git.openjdk.java.net/jdk13u-dev/pull/254/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=254&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269934 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/254.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/254/head:pull/254 PR: https://git.openjdk.java.net/jdk13u-dev/pull/254 From vkempik at openjdk.java.net Tue Aug 24 13:15:43 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 24 Aug 2021 13:15:43 GMT Subject: [jdk11u-dev] RFR: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status Message-ID: <4W_AwFKxIu3NrluAJZlLguz42x4tm8fVWAt2qhRiAFQ=.583cc713-9f00-48ab-be33-3b8ffca4f51b@github.com> Clean backport from 15u ( reviewed by Paul Hohensee ). Not clean backport from jdk/jdk ------------- Commit messages: - Backport 7e518f42c9346abdf0c8059b45d3dfef95ed69bb Changes: https://git.openjdk.java.net/jdk11u-dev/pull/285/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=285&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269934 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/285.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/285/head:pull/285 PR: https://git.openjdk.java.net/jdk11u-dev/pull/285 From clanger at openjdk.java.net Tue Aug 24 13:32:46 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 24 Aug 2021 13:32:46 GMT Subject: [jdk11u-dev] RFR: 8169246: java/net/DatagramSocket/ReportSocketClosed.java fails intermittently with BindException Message-ID: Hi all, this pull request contains a backport of JDK-8169246 from the openjdk/jdk repository. The commit being backported was authored by Chris Yin on 21 Sep 2018 and was reviewed by Chris Hegarty. Thanks! ------------- Commit messages: - Merge branch 'openjdk:master' into RealCLanger-backport-33c9c89b - Backport 33c9c89bf0166c21600b9aa8beb84c019ff1e03d Changes: https://git.openjdk.java.net/jdk11u-dev/pull/287/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=287&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8169246 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/287.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/287/head:pull/287 PR: https://git.openjdk.java.net/jdk11u-dev/pull/287 From clanger at openjdk.java.net Tue Aug 24 13:32:42 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 24 Aug 2021 13:32:42 GMT Subject: [jdk11u-dev] RFR: 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received" Message-ID: Hi all, this pull request contains a backport of JDK-8199931 from the openjdk/jdk repository. The commit being backported was authored by Chris Yin on 21 Sep 2018 and was reviewed by Chris Hegarty. Thanks! ------------- Commit messages: - Backport f367eb89657e69989c15463fd4195d6869c132f5 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/286/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=286&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8199931 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/286.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/286/head:pull/286 PR: https://git.openjdk.java.net/jdk11u-dev/pull/286 From phh at openjdk.java.net Tue Aug 24 14:15:25 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 24 Aug 2021 14:15:25 GMT Subject: [jdk11u-dev] RFR: 8248666: AArch64: Use THREAD_LOCAL instead of __thread In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 06:28:24 GMT, Reka Kovacs wrote: > Not a clean backport. Original patch used a macro called THREAD_LOCAL, this backport uses THREAD_LOCAL_DECL. THREAD_LOCAL_DECL was renamed to THREAD_LOCAL by [JDK-8230877](https://bugs.openjdk.java.net/browse/JDK-8230877) in JDK 14. Testing: tier1. > > This is part of the Windows/AArch64 port. There's an auto-generated comment above that says that rebasing wil be done automatically. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/262 From clanger at openjdk.java.net Tue Aug 24 14:19:24 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 24 Aug 2021 14:19:24 GMT Subject: [jdk11u-dev] RFR: 8248666: AArch64: Use THREAD_LOCAL instead of __thread In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 14:12:38 GMT, Paul Hohensee wrote: > There's an auto-generated comment above that says that rebasing wil be done automatically. Well, we can try... I'm not sure if this will work here as here seems to be a real conflict. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/262 From yan at openjdk.java.net Tue Aug 24 14:24:43 2021 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Tue, 24 Aug 2021 14:24:43 GMT Subject: [jdk13u-dev] RFR: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 13:03:48 GMT, Vladimir Kempik wrote: > Clean backport from 15u ( reviewed by Paul Hohensee ). Not clean backport from jdk/jdk Marked as reviewed by yan (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/254 From shade at openjdk.java.net Tue Aug 24 14:32:26 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 14:32:26 GMT Subject: [jdk11u-dev] Integrated: 8232782: Shenandoah: streamline post-LRB CAS barrier (aarch64) In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 15:24:23 GMT, Aleksey Shipilev wrote: > Unclean backport to improve Shenandoah AArch64 performance and provide grounds for subsequent backports. > > There were conflicts in `shenandoah_aarch64.ad`, as there is `weakCompareAndSwapPAcq_shenandoah` and `weakCompareAndSwapNAcq_shenandoah` are missing in 11u. > > Additional testing: > - [x] Linux AArch64 `hotspot_gc_shenandoah` > - [x] Linux AArch64 `tier1` with `-XX:+UseShenandoahGC` > - [x] Linux AArch64 `tier2` with `-XX:+UseShenandoahGC` > - [x] Linux AArch64 jcstress `-m quick` with `-XX:+UseShenandoahGC` This pull request has now been integrated. Changeset: fb886e93 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/fb886e9381f40972fccc9f08cff67ee0d4ea9eac Stats: 184 lines in 4 files changed: 139 ins; 6 del; 39 mod 8232782: Shenandoah: streamline post-LRB CAS barrier (aarch64) Reviewed-by: phh, rkennke Backport-of: c5bb02358472a993fbefe816302411483273656c ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/268 From shade at openjdk.java.net Tue Aug 24 14:32:25 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 14:32:25 GMT Subject: [jdk11u-dev] RFR: 8232782: Shenandoah: streamline post-LRB CAS barrier (aarch64) In-Reply-To: References: Message-ID: <5YtvmtEhyYfpE3kF_6f2KCHBfzqO0MOA3MfTCPFVpsg=.2a096d08-354d-42a3-a797-96a0ce94272b@github.com> On Fri, 20 Aug 2021 15:24:23 GMT, Aleksey Shipilev wrote: > Unclean backport to improve Shenandoah AArch64 performance and provide grounds for subsequent backports. > > There were conflicts in `shenandoah_aarch64.ad`, as there is `weakCompareAndSwapPAcq_shenandoah` and `weakCompareAndSwapNAcq_shenandoah` are missing in 11u. > > Additional testing: > - [x] Linux AArch64 `hotspot_gc_shenandoah` > - [x] Linux AArch64 `tier1` with `-XX:+UseShenandoahGC` > - [x] Linux AArch64 `tier2` with `-XX:+UseShenandoahGC` > - [x] Linux AArch64 jcstress `-m quick` with `-XX:+UseShenandoahGC` Got the push approvals and reviews. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/268 From shade at openjdk.java.net Tue Aug 24 14:51:26 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 14:51:26 GMT Subject: [jdk11u-dev] RFR: 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException In-Reply-To: References: Message-ID: On Wed, 18 Aug 2021 12:49:48 GMT, Aleksey Shipilev wrote: > Backport to stabilize the test and match `11.0.13-oracle`. > It contains two bugfixes that are clean backports on their own. > > Additional testing: > - [x] Affected test still passes Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/255 From shade at openjdk.java.net Tue Aug 24 14:51:28 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 14:51:28 GMT Subject: [jdk11u-dev] Integrated: 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException In-Reply-To: References: Message-ID: <8Aomrl0g21n7Zwg2mOGmRfLqeJYf7g1pTHpIE5_XQpM=.a5e9908f-3819-4d11-b4e8-fd0a07fdeecb@github.com> On Wed, 18 Aug 2021 12:49:48 GMT, Aleksey Shipilev wrote: > Backport to stabilize the test and match `11.0.13-oracle`. > It contains two bugfixes that are clean backports on their own. > > Additional testing: > - [x] Affected test still passes This pull request has now been integrated. Changeset: b3c293cf Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/b3c293cf4f6539f3d42035585ca48955cda0ba5d Stats: 32 lines in 1 file changed: 23 ins; 0 del; 9 mod 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException 8226683: Remove review suggestion from fix to 8219804 Reviewed-by: clanger Backport-of: eccfec498d4062b582282f3b73bba84206a36046 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/255 From coffeys at openjdk.java.net Tue Aug 24 14:54:02 2021 From: coffeys at openjdk.java.net (Sean Coffey) Date: Tue, 24 Aug 2021 14:54:02 GMT Subject: [jdk17u] RFR: 8270344: Session resumption errors Message-ID: Clean backport to JDK 17 Updates ------------- Commit messages: - 8270344: Session resumption errors Changes: https://git.openjdk.java.net/jdk17u/pull/39/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=39&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270344 Stats: 185 lines in 4 files changed: 162 ins; 21 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u/pull/39.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/39/head:pull/39 PR: https://git.openjdk.java.net/jdk17u/pull/39 From shade at openjdk.java.net Tue Aug 24 15:02:26 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 15:02:26 GMT Subject: [jdk11u-dev] RFR: 8263776: [JVMCI] add helper to perform Java upcalls [v3] In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 12:30:56 GMT, Severin Gehwolf wrote: >> Here is a backport for JDK-8263776. The patch doesn't apply cleanly since it uses features only introduced with JDK-8230199 (JDK 15+, not in OpenJDK 11u). This patch is the same labsopenjdk 11 uses. This patch is also needed for using graal js with plain OpenJDK. >> >> Testing: test/hotspot/jtreg/compiler/jvmci and manual upstream Graal unit test. > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Use a closer version of the JDK 17 patch > - Merge branch 'master' into jdk-8263776-no-arg-jvmci-change > - Cleanup whitespace > - Backport 6b4c654186e49528eeae7249fdcd0f2d1a98b3ad All right, this looks good to me. ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/279 From sgehwolf at openjdk.java.net Tue Aug 24 15:02:28 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 24 Aug 2021 15:02:28 GMT Subject: [jdk11u-dev] RFR: 8263776: [JVMCI] add helper to perform Java upcalls [v3] In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 12:30:56 GMT, Severin Gehwolf wrote: >> Here is a backport for JDK-8263776. The patch doesn't apply cleanly since it uses features only introduced with JDK-8230199 (JDK 15+, not in OpenJDK 11u). This patch is the same labsopenjdk 11 uses. This patch is also needed for using graal js with plain OpenJDK. >> >> Testing: test/hotspot/jtreg/compiler/jvmci and manual upstream Graal unit test. > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Use a closer version of the JDK 17 patch > - Merge branch 'master' into jdk-8263776-no-arg-jvmci-change > - Cleanup whitespace > - Backport 6b4c654186e49528eeae7249fdcd0f2d1a98b3ad Thanks for the review! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/279 From sgehwolf at openjdk.java.net Tue Aug 24 15:06:45 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 24 Aug 2021 15:06:45 GMT Subject: [jdk11u-dev] RFR: 8261846: [JVMCI] c2v_iterateFrames can get out of sync with the StackFrameStream Message-ID: This is a JVMCI related backport for OpenJDK 11. It fixes an issue of a fastdebug JVM asserting when running an upstream graal unit test. Applies clean. ------------- Commit messages: - Backport 97e1657ba2424f253cd9a9b51cc7749c72f9b268 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/288/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=288&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261846 Stats: 14 lines in 3 files changed: 9 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/288.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/288/head:pull/288 PR: https://git.openjdk.java.net/jdk11u-dev/pull/288 From vkempik at openjdk.java.net Tue Aug 24 15:47:33 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 24 Aug 2021 15:47:33 GMT Subject: [jdk13u-dev] Integrated: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 13:03:48 GMT, Vladimir Kempik wrote: > Clean backport from 15u ( reviewed by Paul Hohensee ). Not clean backport from jdk/jdk This pull request has now been integrated. Changeset: 75ccf0a1 Author: Vladimir Kempik URL: https://git.openjdk.java.net/jdk13u-dev/commit/75ccf0a1722ac9ffbb3e35d0dee5d964f4a77269 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status Reviewed-by: yan Backport-of: 7e518f42c9346abdf0c8059b45d3dfef95ed69bb ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/254 From zgu at openjdk.java.net Tue Aug 24 15:57:26 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 24 Aug 2021 15:57:26 GMT Subject: [jdk11u-dev] Integrated: 8213718: [TEST] Wrong classname in vmTestbase/nsk/stress/except/except002 and except003 In-Reply-To: <42fnD14Xv5dOG0bAswoahRt9R3-1twReZNh44-eFs_s=.0522b26d-66c9-404e-a0f4-bf0954c6ea5c@github.com> References: <42fnD14Xv5dOG0bAswoahRt9R3-1twReZNh44-eFs_s=.0522b26d-66c9-404e-a0f4-bf0954c6ea5c@github.com> Message-ID: On Tue, 24 Aug 2021 12:23:57 GMT, Zhengyu Gu wrote: > A clean backport for parity with Oracle 11.0.14. > > The two affected tests passed. This pull request has now been integrated. Changeset: c55b1e5c Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk11u-dev/commit/c55b1e5c064f9929e9bc1c2610a6b1431cd437c5 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8213718: [TEST] Wrong classname in vmTestbase/nsk/stress/except/except002 and except003 Backport-of: 90cf7a7d12729e1f0afc404c49e620796abf539b ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/283 From vkempik at openjdk.java.net Tue Aug 24 16:21:42 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 24 Aug 2021 16:21:42 GMT Subject: [jdk11u-dev] RFR: 8251930: AArch64: Native types mismatch in hotspot Message-ID: <_n92Z1xrvoWGVQA-H6zNJir7VCAKd65trEQS62xNUvg=.bc7169a5-e4d6-4c94-9a51-a253abdf423d@github.com> Applies almost clean, one context code difference and one whitespace issue ------------- Commit messages: - Backport f1e07806686a837f744e279b6b11394be88c0818 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/290/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=290&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8251930 Stats: 66 lines in 5 files changed: 8 ins; 13 del; 45 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/290.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/290/head:pull/290 PR: https://git.openjdk.java.net/jdk11u-dev/pull/290 From clanger at openjdk.java.net Tue Aug 24 17:07:37 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 24 Aug 2021 17:07:37 GMT Subject: [jdk11u-dev] RFR: 8212718: Refactor some annotation processor tests to better use collections Message-ID: Hi all, this pull request contains a backport of JDK-8212718 from the openjdk/jdk repository. The commit being backported was authored by Joe Darcy on 23 Oct 2018 and was reviewed by Jim Laskey and Vicente Romero. Thanks! ------------- Commit messages: - Backport 34397c4914925b990a5d74a238b01bb05d5b7c44 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/291/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=291&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8212718 Stats: 24 lines in 2 files changed: 2 ins; 11 del; 11 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/291.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/291/head:pull/291 PR: https://git.openjdk.java.net/jdk11u-dev/pull/291 From sgehwolf at openjdk.java.net Tue Aug 24 17:42:35 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 24 Aug 2021 17:42:35 GMT Subject: [jdk11u-dev] RFR: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon Message-ID: Please review this defensive backport of JDK-8272124. OpenJDK 11u is affected too, but it manifests in a different way. Basically Java metrics report wrong results on affected system where the cgroup path contains a colon. The JDK 18 patch doesn't apply cleanly since JDK-8230305 (cgroups v2 support) isn't in 11u. Test support in 11 isn't ass good as well, thus dropped the test changes. Also, I've kept the token number filter to keep using `>= 3` since that's the more defensive approach. It's not clear if systems with `/proc/self/cgroup` files exist in the wild with less than 3 tokens. Thoughts? ------------- Commit messages: - Backport 4d6593ce0243457e7431a5990957a8f880e0a3fb Changes: https://git.openjdk.java.net/jdk11u-dev/pull/292/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=292&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272124 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/292.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/292/head:pull/292 PR: https://git.openjdk.java.net/jdk11u-dev/pull/292 From shade at openjdk.java.net Tue Aug 24 17:49:05 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 17:49:05 GMT Subject: [jdk11u-dev] RFR: 8252857: AArch64: Shenandoah C1 CAS is not sequentially consistent Message-ID: Unclean backport to fix Shenandoah AArch64 bug. The patch does not apply cleanly, because there is a trivial conflict in a copyright line. Then it fails to build, because the check in `LIR_OpShenandoahCompareAndSwap::emit_code` should match the 11u version. In JDK mainline: void LIRGenerator::volatile_field_load(LIR_Address* address, LIR_Opr result, * info) { .... if (!CompilerConfig::is_c1_only_no_jvmci()) { __ membar(); } __ volatile_load_mem_reg(address, result, info); } ... void LIR_OpShenandoahCompareAndSwap::emit_code(LIR_Assembler* masm) { ... if (CompilerConfig::is_c1_only_no_jvmci()) { ... __ membar(__ AnyAny); } } In JDK 11u (this PR): void LIRGenerator::volatile_field_load(LIR_Address* address, LIR_Opr result, CodeEmitInfo* info) { ... if (! UseBarriersForVolatile) { __ membar(); } __ volatile_load_mem_reg(address, result, info); } void LIR_OpShenandoahCompareAndSwap::emit_code(LIR_Assembler* masm) { ... if (UseBarriersForVolatile) { ... __ membar(__ AnyAny); } } Additional testing: - [x] Linux AArch64 hotspot_gc_shenandoah - [x] Linux AArch64 tier1 with -XX:+UseShenandoahGC - [x] Linux AArch64 tier2 with -XX:+UseShenandoahGC - [ ] Linux AArch64 jcstress -m quick with -XX:+UseShenandoahGC ------------- Commit messages: - Fix the 11u build failure: use UseBarriersForVolatile instead - Backport 8e87d46f41e663f5d0506554054417e3049175e7 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/289/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=289&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8252857 Stats: 52 lines in 2 files changed: 10 ins; 30 del; 12 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/289.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/289/head:pull/289 PR: https://git.openjdk.java.net/jdk11u-dev/pull/289 From rkennke at openjdk.java.net Tue Aug 24 17:55:29 2021 From: rkennke at openjdk.java.net (Roman Kennke) Date: Tue, 24 Aug 2021 17:55:29 GMT Subject: [jdk11u-dev] RFR: 8252857: AArch64: Shenandoah C1 CAS is not sequentially consistent In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 15:51:28 GMT, Aleksey Shipilev wrote: > Unclean backport to fix Shenandoah AArch64 bug. The patch does not apply cleanly, because there is a trivial conflict in a copyright line. Then it fails to build, because the check in `LIR_OpShenandoahCompareAndSwap::emit_code` should match the 11u version. > > In JDK mainline: > > > void LIRGenerator::volatile_field_load(LIR_Address* address, LIR_Opr result, * info) { > .... > if (!CompilerConfig::is_c1_only_no_jvmci()) { > __ membar(); > } > __ volatile_load_mem_reg(address, result, info); > } > ... > void LIR_OpShenandoahCompareAndSwap::emit_code(LIR_Assembler* masm) { > ... > if (CompilerConfig::is_c1_only_no_jvmci()) { > ... > __ membar(__ AnyAny); > } > } > > > In JDK 11u (this PR): > > > void LIRGenerator::volatile_field_load(LIR_Address* address, LIR_Opr result, > CodeEmitInfo* info) { > ... > if (! UseBarriersForVolatile) { > __ membar(); > } > __ volatile_load_mem_reg(address, result, info); > } > > void LIR_OpShenandoahCompareAndSwap::emit_code(LIR_Assembler* masm) { > ... > if (UseBarriersForVolatile) { > ... > __ membar(__ AnyAny); > } > } > > > Additional testing: > - [x] Linux AArch64 hotspot_gc_shenandoah > - [x] Linux AArch64 tier1 with -XX:+UseShenandoahGC > - [x] Linux AArch64 tier2 with -XX:+UseShenandoahGC > - [ ] Linux AArch64 jcstress -m quick with -XX:+UseShenandoahGC Looks good! Thanks! ------------- Marked as reviewed by rkennke (Committer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/289 From clanger at openjdk.java.net Tue Aug 24 18:53:03 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 24 Aug 2021 18:53:03 GMT Subject: [jdk11u-dev] RFR: 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received" [v2] In-Reply-To: References: Message-ID: <8Y5tvJI9-aIlJS1s4qoKjgOwyPD_d8OVEL--D1W1HlE=.6cf6c074-ac0a-411c-82f4-7d8baf49b33d@github.com> > Hi all, > > this pull request contains a backport of JDK-8199931 from the openjdk/jdk repository. > > The commit being backported was authored by Chris Yin on 21 Sep 2018 and was reviewed by Chris Hegarty. > > Thanks! Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into RealCLanger-backport-f367eb89 - Backport f367eb89657e69989c15463fd4195d6869c132f5 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/286/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/286/files/bfe24b65..42de2c22 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=286&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=286&range=00-01 Stats: 37533 lines in 731 files changed: 25209 ins; 8618 del; 3706 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/286.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/286/head:pull/286 PR: https://git.openjdk.java.net/jdk11u-dev/pull/286 From clanger at openjdk.java.net Tue Aug 24 18:54:51 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 24 Aug 2021 18:54:51 GMT Subject: [jdk11u-dev] RFR: 8212718: Refactor some annotation processor tests to better use collections [v2] In-Reply-To: References: Message-ID: > Hi all, > > this pull request contains a backport of JDK-8212718 from the openjdk/jdk repository. > > The commit being backported was authored by Joe Darcy on 23 Oct 2018 and was reviewed by Jim Laskey and Vicente Romero. > > Thanks! Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into RealCLanger-backport-34397c49 - Backport 34397c4914925b990a5d74a238b01bb05d5b7c44 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/291/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/291/files/b1cdc839..6312769c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=291&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=291&range=00-01 Stats: 40672 lines in 814 files changed: 28003 ins; 8678 del; 3991 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/291.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/291/head:pull/291 PR: https://git.openjdk.java.net/jdk11u-dev/pull/291 From clanger at openjdk.java.net Tue Aug 24 20:20:43 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 24 Aug 2021 20:20:43 GMT Subject: [jdk11u-dev] RFR: 8212695: Add explicit timeout to several HTTP Client tests Message-ID: Backport of JDK-8212695. I had to make adjustments because JDK-8222527 was already backported. ------------- Commit messages: - Backport cea4eef60aadf7dceb1fa857722faa8b17c810ae Changes: https://git.openjdk.java.net/jdk11u-dev/pull/294/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=294&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8212695 Stats: 27 lines in 2 files changed: 12 ins; 0 del; 15 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/294.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/294/head:pull/294 PR: https://git.openjdk.java.net/jdk11u-dev/pull/294 From clanger at openjdk.java.net Tue Aug 24 20:21:46 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 24 Aug 2021 20:21:46 GMT Subject: [jdk11u-dev] RFR: 8211325: test/jdk/java/net/Socket/LingerTest.java fails with cleaning up Message-ID: <6gVT4UWVf3Lc7PKPT2aeaP9aGV5TsFBbry6ztRE_AiM=.cf8c1f8a-0b3d-4bfb-b41a-8d1e484dac6b@github.com> Clean backport of 8211325. The change to the problem list doesn't apply though, because the removed exclusion didn't exist in 11. ------------- Commit messages: - Backport 0cb267ad1c099d90267f764ade91b16f139a0aa7 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/293/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=293&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8211325 Stats: 22 lines in 1 file changed: 7 ins; 0 del; 15 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/293.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/293/head:pull/293 PR: https://git.openjdk.java.net/jdk11u-dev/pull/293 From shade at openjdk.java.net Tue Aug 24 21:13:48 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 21:13:48 GMT Subject: [jdk17u] RFR: 8269897: Shenandoah: Resolve UNKNOWN access strength, where possible In-Reply-To: References: Message-ID: <8Yp9cZdUeq4hjkgTEzuZ2M8OLDm8lvsxdH_8CmOry_s=.a3369d2f-2699-4770-91c5-0abd53339e88@github.com> On Tue, 24 Aug 2021 09:59:01 GMT, Aleksey Shipilev wrote: > Clean backport to fix a serious Shenandoah bug. > > Additional testing: > - [x] `jcstress` now passes > - [x] `hotspot_gc_shenandoah` passes > - [x] `tier1` with `-XX:+UseShenandoahGC` passes > - [x] `tier2` with `-XX:+UseShenandoahGC` passes Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/37 From shade at openjdk.java.net Tue Aug 24 21:13:48 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 24 Aug 2021 21:13:48 GMT Subject: [jdk17u] Integrated: 8269897: Shenandoah: Resolve UNKNOWN access strength, where possible In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 09:59:01 GMT, Aleksey Shipilev wrote: > Clean backport to fix a serious Shenandoah bug. > > Additional testing: > - [x] `jcstress` now passes > - [x] `hotspot_gc_shenandoah` passes > - [x] `tier1` with `-XX:+UseShenandoahGC` passes > - [x] `tier2` with `-XX:+UseShenandoahGC` passes This pull request has now been integrated. Changeset: 37de147b Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk17u/commit/37de147bea6f06d2751a80c7a25bd61c522e11e8 Stats: 116 lines in 3 files changed: 49 ins; 33 del; 34 mod 8269897: Shenandoah: Resolve UNKNOWN access strength, where possible Backport-of: 7ac08161a8b2080ed054bc00a30d6f694ece4df3 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/37 From jiefu at openjdk.java.net Tue Aug 24 23:28:28 2021 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 24 Aug 2021 23:28:28 GMT Subject: [jdk11u-dev] RFR: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 [v2] In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 13:03:52 GMT, Jie Fu wrote: >> Backport of 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 > > Jie Fu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into Backport-of-JDK-8272700 > - Backport d007be0952abdc8beb7b68ebf7529a939162307b Backport has been approved. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/282 From github.com+3094961+buddyliao at openjdk.java.net Wed Aug 25 01:14:22 2021 From: github.com+3094961+buddyliao at openjdk.java.net (Bin Liao) Date: Wed, 25 Aug 2021 01:14:22 GMT Subject: [jdk11u-dev] RFR: 8215624: Add parallel heap iteration for jmap =?UTF-8?B?4oCTaGlzdG8=?= In-Reply-To: References: Message-ID: <3i_2Rl1SEhj7_k01_h5wVS5dWzyVM53WpVjiM_MHtas=.7a7557e4-bb34-47ee-94ef-576cf13f986a@github.com> On Tue, 24 Aug 2021 07:22:02 GMT, Christoph Langer wrote: > > Hi RealCLanger , thank you for your kindly review and suggestions. I intent to backport JDK-8251570 after this patch. But I really don't know how to do it by using "dependent PR", since JDK-8251570 is based on this patch. Would you please guide me how to do this ? Thank you! > > Sure. It is as simple as to do the backport based on this change/branch and create a PR with branch [pr/127](https://github.com/openjdk/jdk11u-dev/tree/pr/127) as target. If you have created the PR for JDK-8251570, please let me know. We can then run it together through our testing. Hi @RealCLanger, JDK-8251570 has been backported in https://github.com/openjdk/jdk11u-dev/pull/284, would you please help me to review them together, thank you very much. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/127 From akolarkunnu at openjdk.java.net Wed Aug 25 02:44:55 2021 From: akolarkunnu at openjdk.java.net (Abdul Kolarkunnu) Date: Wed, 25 Aug 2021 02:44:55 GMT Subject: [jdk17u] RFR: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java Message-ID: Test Result - ------------- Commit messages: - Backport ed57cf1cf3f2d107e085ecdae38a63e66ab2fa30 Changes: https://git.openjdk.java.net/jdk17u/pull/40/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=40&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266182 Stats: 1184 lines in 3 files changed: 731 ins; 453 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u/pull/40.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/40/head:pull/40 PR: https://git.openjdk.java.net/jdk17u/pull/40 From tnakamura at openjdk.java.net Wed Aug 25 02:53:37 2021 From: tnakamura at openjdk.java.net (Toshio Nakamura) Date: Wed, 25 Aug 2021 02:53:37 GMT Subject: [jdk11u-dev] RFR: 8263490: [macos] Crash occurs on JPasswordField with activated InputMethod Message-ID: Hi, Original patch almost applies cleanly to 11u. Only copyright year was adjusted. This crash issue with Input Method of GUI was observed with 11.0.12, and I'd like to backport it. Original bug: https://bugs.openjdk.java.net/browse/JDK-8263490 Testing: tier1, java/awt and javax/swing on macOS ------------- Commit messages: - Backport 32c7fcc67010e44411918cc73681422fd8b7a67a Changes: https://git.openjdk.java.net/jdk11u-dev/pull/295/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=295&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263490 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/295.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/295/head:pull/295 PR: https://git.openjdk.java.net/jdk11u-dev/pull/295 From akolarkunnu at openjdk.java.net Wed Aug 25 03:15:49 2021 From: akolarkunnu at openjdk.java.net (Abdul Kolarkunnu) Date: Wed, 25 Aug 2021 03:15:49 GMT Subject: [jdk17u] RFR: 8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182 Message-ID: Test Result - ------------- Commit messages: - a199ebc0175f9882f051551cff9ce08016f204a4 - Backport ed57cf1cf3f2d107e085ecdae38a63e66ab2fa30 Changes: https://git.openjdk.java.net/jdk17u/pull/41/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=41&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272581 Stats: 1184 lines in 3 files changed: 731 ins; 453 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u/pull/41.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/41/head:pull/41 PR: https://git.openjdk.java.net/jdk17u/pull/41 From jiefu at openjdk.java.net Wed Aug 25 05:37:24 2021 From: jiefu at openjdk.java.net (Jie Fu) Date: Wed, 25 Aug 2021 05:37:24 GMT Subject: [jdk11u-dev] Integrated: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 09:33:47 GMT, Jie Fu wrote: > Backport of 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 This pull request has now been integrated. Changeset: 7539e758 Author: Jie Fu Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/7539e75845902bbd3bc61066e6c8f21abb6d6631 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 Backport-of: d007be0952abdc8beb7b68ebf7529a939162307b ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/282 From jiefu at openjdk.java.net Wed Aug 25 06:04:26 2021 From: jiefu at openjdk.java.net (Jie Fu) Date: Wed, 25 Aug 2021 06:04:26 GMT Subject: [jdk11u-dev] RFR: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 [v2] In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 13:03:52 GMT, Jie Fu wrote: >> Backport of 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 > > Jie Fu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into Backport-of-JDK-8272700 > - Backport d007be0952abdc8beb7b68ebf7529a939162307b > /sponsor Thanks @RealCLanger for your sponsor. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/282 From shade at redhat.com Wed Aug 25 08:44:50 2021 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 25 Aug 2021 10:44:50 +0200 Subject: CFV: New JDK Updates Reviewer: Roman Kennke Message-ID: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> I hereby nominate Roman Kennke (rkennke) to JDK Updates Project Reviewer. Roman is the long-time Reviewer in the JDK project. In addition to heavy involvement in mainline development work, Roman contributed a significant number of backports to 11u [1], including the very significant backport of Shenandoah GC [2]. These references and his engagement in the JDK Updates project justify the call to make him a JDK Updates Reviewer as well. Votes are due by Sep 9, 2021, 18:00 CET. Only current JDK Updates Reviewers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [4]. -- Thanks, -Aleksey [1] https://github.com/openjdk/jdk11u-dev/commits?author=rkennke [2] https://github.com/openjdk/jdk11u-dev/commit/20a0625da8558b0b15bbe9328983abe3341d75b0 [3] http://openjdk.java.net/census#jdk-updates [4] http://openjdk.java.net/projects/#reviewer-vote From clanger at openjdk.java.net Wed Aug 25 08:47:33 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 25 Aug 2021 08:47:33 GMT Subject: [jdk11u-dev] RFR: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration Message-ID: <-E9H960xOzBqy_rtO0S06MI9ex8yRVjcO1Ich1V36dI=.e2a38079-ccf9-4309-9c99-74ce2c6dd341@github.com> Backport of JDK-8241336 ------------- Commit messages: - Backport 5ddbcb7a515e29d805df17ca2977eeb720adef29 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/296/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=296&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8241336 Stats: 103 lines in 3 files changed: 65 ins; 6 del; 32 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/296.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/296/head:pull/296 PR: https://git.openjdk.java.net/jdk11u-dev/pull/296 From sgehwolf at redhat.com Wed Aug 25 08:53:56 2021 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Wed, 25 Aug 2021 10:53:56 +0200 Subject: CFV: New JDK Updates Reviewer: Roman Kennke In-Reply-To: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> References: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> Message-ID: Vote: yes. On Wed, 2021-08-25 at 10:44 +0200, Aleksey Shipilev wrote: > I hereby nominate Roman Kennke (rkennke) to JDK Updates Project Reviewer. > > Roman is the long-time Reviewer in the JDK project. In addition to heavy involvement in mainline > development work, Roman contributed a significant number of backports to 11u [1], including the very > significant backport of Shenandoah GC [2]. > > These references and his engagement in the JDK Updates project justify the call to make him a JDK > Updates Reviewer as well. > > Votes are due by Sep 9, 2021, 18:00 CET. > > Only current JDK Updates Reviewers [3] are eligible to vote on this nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > From neugens at redhat.com Wed Aug 25 08:54:22 2021 From: neugens at redhat.com (Mario Torre) Date: Wed, 25 Aug 2021 10:54:22 +0200 Subject: CFV: New JDK Updates Reviewer: Roman Kennke In-Reply-To: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> References: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> Message-ID: Vote: Yes, Cheers, Mario On Wed, Aug 25, 2021 at 10:45 AM Aleksey Shipilev wrote: > > I hereby nominate Roman Kennke (rkennke) to JDK Updates Project Reviewer. > > Roman is the long-time Reviewer in the JDK project. In addition to heavy involvement in mainline > development work, Roman contributed a significant number of backports to 11u [1], including the very > significant backport of Shenandoah GC [2]. > > These references and his engagement in the JDK Updates project justify the call to make him a JDK > Updates Reviewer as well. > > Votes are due by Sep 9, 2021, 18:00 CET. > > Only current JDK Updates Reviewers [3] are eligible to vote on this nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > -- > Thanks, > -Aleksey > > [1] https://github.com/openjdk/jdk11u-dev/commits?author=rkennke > [2] https://github.com/openjdk/jdk11u-dev/commit/20a0625da8558b0b15bbe9328983abe3341d75b0 > [3] http://openjdk.java.net/census#jdk-updates > [4] http://openjdk.java.net/projects/#reviewer-vote > -- Mario Torre Manager, Software Engineering, core OpenJDK Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From yan at azul.com Wed Aug 25 09:01:56 2021 From: yan at azul.com (Yuri Nesterenko) Date: Wed, 25 Aug 2021 12:01:56 +0300 Subject: CFV: New JDK Updates Reviewer: Roman Kennke In-Reply-To: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> References: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> Message-ID: <8c782fa0-db4c-7a0a-afee-90da6e77c2b7@azul.com> Vote: yes On 25.08.2021 11:44, Aleksey Shipilev wrote: > I hereby nominate Roman Kennke (rkennke) to JDK Updates Project Reviewer. > > Roman is the long-time Reviewer in the JDK project. In addition to heavy > involvement in mainline development work, Roman contributed a > significant number of backports to 11u [1], including the very > significant backport of Shenandoah GC [2]. > > These references and his engagement in the JDK Updates project justify > the call to make him a JDK > Updates Reviewer as well. > > Votes are due by Sep 9, 2021, 18:00 CET. > > Only current JDK Updates Reviewers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [4]. > From goetz.lindenmaier at sap.com Wed Aug 25 09:04:47 2021 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Wed, 25 Aug 2021 09:04:47 +0000 Subject: CFV: New JDK Updates Reviewer: Roman Kennke In-Reply-To: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> References: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> Message-ID: Vote: yes Best, Goetz -----Original Message----- From: jdk-updates-dev On Behalf Of Aleksey Shipilev Sent: Mittwoch, 25. August 2021 09:45 To: jdk-updates-dev at openjdk.java.net Subject: CFV: New JDK Updates Reviewer: Roman Kennke I hereby nominate Roman Kennke (rkennke) to JDK Updates Project Reviewer. Roman is the long-time Reviewer in the JDK project. In addition to heavy involvement in mainline development work, Roman contributed a significant number of backports to 11u [1], including the very significant backport of Shenandoah GC [2]. These references and his engagement in the JDK Updates project justify the call to make him a JDK Updates Reviewer as well. Votes are due by Sep 9, 2021, 18:00 CET. Only current JDK Updates Reviewers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [4]. -- Thanks, -Aleksey [1] https://github.com/openjdk/jdk11u-dev/commits?author=rkennke [2] https://github.com/openjdk/jdk11u-dev/commit/20a0625da8558b0b15bbe9328983abe3341d75b0 [3] http://openjdk.java.net/census#jdk-updates [4] http://openjdk.java.net/projects/#reviewer-vote From goetz at openjdk.java.net Wed Aug 25 09:18:44 2021 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 25 Aug 2021 09:18:44 GMT Subject: [jdk11u] RFR: Merge jdk11u-dev:master Message-ID: Bring changes for build tag 4 to jdk11u ------------- Commit messages: - 8213718: [TEST] Wrong classname in vmTestbase/nsk/stress/except/except002 and except003 - 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException - 8232782: Shenandoah: streamline post-LRB CAS barrier (aarch64) - 8249548: backward focus traversal gets stuck in button group - 8265756: AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter - 8263136: C4530 was reported from VS 2019 at access bridge - 8261072: AArch64: Fix MacroAssembler::get_thread convention - 8248816: C1: Fix signature conflict in LIRGenerator::strength_reduce_multiply - 8248657: Windows: strengthening in ThreadCritical regarding memory model - 8250824: AArch64: follow up for JDK-8248414 - ... and 18 more: https://git.openjdk.java.net/jdk11u/compare/3a32efcd...c55b1e5c The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.java.net/jdk11u/pull/9/files Stats: 13670 lines in 121 files changed: 11678 ins; 1434 del; 558 mod Patch: https://git.openjdk.java.net/jdk11u/pull/9.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/9/head:pull/9 PR: https://git.openjdk.java.net/jdk11u/pull/9 From sgehwolf at openjdk.java.net Wed Aug 25 09:20:31 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Wed, 25 Aug 2021 09:20:31 GMT Subject: [jdk11u-dev] Integrated: 8263776: [JVMCI] add helper to perform Java upcalls In-Reply-To: References: Message-ID: <4v1F6XYEiafePkPD-hsajN8XS2qkRhppnWNXd4Iqvmg=.4be8bf8a-4a90-42b2-85e1-6ed80fac0292@github.com> On Mon, 23 Aug 2021 14:00:49 GMT, Severin Gehwolf wrote: > Here is a backport for JDK-8263776. The patch doesn't apply cleanly since it uses features only introduced with JDK-8230199 (JDK 15+, not in OpenJDK 11u). This patch is the same labsopenjdk 11 uses. This patch is also needed for using graal js with plain OpenJDK. > > Testing: test/hotspot/jtreg/compiler/jvmci and manual upstream Graal unit test. This pull request has now been integrated. Changeset: 3bc22755 Author: Severin Gehwolf URL: https://git.openjdk.java.net/jdk11u-dev/commit/3bc227552071ac96563a46b0afe15bf7467fa441 Stats: 115 lines in 3 files changed: 115 ins; 0 del; 0 mod 8263776: [JVMCI] add helper to perform Java upcalls Co-authored-by: Tom Rodriguez Reviewed-by: shade Backport-of: 6b4c654186e49528eeae7249fdcd0f2d1a98b3ad ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/279 From sgehwolf at openjdk.java.net Wed Aug 25 09:20:30 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Wed, 25 Aug 2021 09:20:30 GMT Subject: [jdk11u-dev] Integrated: 8264016: [JVMCI] add some thread local fields for use by JVMCI In-Reply-To: References: Message-ID: On Mon, 23 Aug 2021 13:12:27 GMT, Severin Gehwolf wrote: > Please review this JVMCI-related backport for OpenJDK 11u. It adds some thread-local fields and is useful so as to be able to run graal js on stock OpenJDK. The JDK 17 patch didn't apply clean due to context differences, which got fairly trivially resolved. > > Testing: test/hotspot/jtreg/compiler/jvmci and manual test using upstream Graal unit test. > > Thoughts? This pull request has now been integrated. Changeset: 1f6eb0fc Author: Severin Gehwolf URL: https://git.openjdk.java.net/jdk11u-dev/commit/1f6eb0fc9c041a3fb277db0b39b5a369401510a6 Stats: 14 lines in 3 files changed: 14 ins; 0 del; 0 mod 8264016: [JVMCI] add some thread local fields for use by JVMCI Reviewed-by: shade Backport-of: 182b11c31aa1d697ed254042c3350330ca3ac6e4 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/278 From adinn at redhat.com Wed Aug 25 09:25:04 2021 From: adinn at redhat.com (Andrew Dinn) Date: Wed, 25 Aug 2021 10:25:04 +0100 Subject: CFV: New JDK Updates Reviewer: Roman Kennke In-Reply-To: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> References: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> Message-ID: <518cbdec-d4cd-c848-ca65-ad70f8aab08d@redhat.com> Vote: yes On 25/08/2021 09:44, Aleksey Shipilev wrote: > I hereby nominate Roman Kennke (rkennke) to JDK Updates Project Reviewer. > > Roman is the long-time Reviewer in the JDK project. In addition to heavy > involvement in mainline development work, Roman contributed a > significant number of backports to 11u [1], including the very > significant backport of Shenandoah GC [2]. > > These references and his engagement in the JDK Updates project justify > the call to make him a JDK > Updates Reviewer as well. > > Votes are due by Sep 9, 2021, 18:00 CET. > > Only current JDK Updates Reviewers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [4]. > -- regards, Andrew Dinn ----------- Red Hat Distinguished Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill From sgehwolf at openjdk.java.net Wed Aug 25 09:24:28 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Wed, 25 Aug 2021 09:24:28 GMT Subject: [jdk11u-dev] Integrated: 8261846: [JVMCI] c2v_iterateFrames can get out of sync with the StackFrameStream In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 14:57:08 GMT, Severin Gehwolf wrote: > This is a JVMCI related backport for OpenJDK 11. It fixes an issue of a fastdebug JVM asserting when running an upstream graal unit test. Applies clean. This pull request has now been integrated. Changeset: 09f37074 Author: Severin Gehwolf URL: https://git.openjdk.java.net/jdk11u-dev/commit/09f370740b85f090b1488fb7813e831bbf16a59f Stats: 14 lines in 3 files changed: 9 ins; 0 del; 5 mod 8261846: [JVMCI] c2v_iterateFrames can get out of sync with the StackFrameStream Backport-of: 97e1657ba2424f253cd9a9b51cc7749c72f9b268 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/288 From andy.herrick at oracle.com Wed Aug 25 11:02:16 2021 From: andy.herrick at oracle.com (Andy Herrick) Date: Wed, 25 Aug 2021 07:02:16 -0400 Subject: CFV: New JDK Updates Reviewer: Roman Kennke In-Reply-To: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> References: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> Message-ID: vote: yes /Andy On 8/25/2021 4:44 AM, Aleksey Shipilev wrote: > I hereby nominate Roman Kennke (rkennke) to JDK Updates Project Reviewer. > > Roman is the long-time Reviewer in the JDK project. In addition to > heavy involvement in mainline development work, Roman contributed a > significant number of backports to 11u [1], including the very > significant backport of Shenandoah GC [2]. > > These references and his engagement in the JDK Updates project justify > the call to make him a JDK > Updates Reviewer as well. > > Votes are due by Sep 9, 2021, 18:00 CET. > > Only current JDK Updates Reviewers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [4]. > From coffeys at openjdk.java.net Wed Aug 25 11:37:48 2021 From: coffeys at openjdk.java.net (Sean Coffey) Date: Wed, 25 Aug 2021 11:37:48 GMT Subject: [jdk17u] Integrated: 8270344: Session resumption errors In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 14:45:11 GMT, Sean Coffey wrote: > Clean backport to JDK 17 Updates This pull request has now been integrated. Changeset: 20d00eba Author: Sean Coffey URL: https://git.openjdk.java.net/jdk17u/commit/20d00ebaf789935c05ebf9605fd139a4ed1f4417 Stats: 185 lines in 4 files changed: 162 ins; 21 del; 2 mod 8270344: Session resumption errors Backport-of: 04a806ec86a388b8de31d42f904c4321beb69e14 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/39 From zgu at redhat.com Wed Aug 25 11:54:45 2021 From: zgu at redhat.com (Zhengyu Gu) Date: Wed, 25 Aug 2021 07:54:45 -0400 Subject: CFV: New JDK Updates Reviewer: Roman Kennke In-Reply-To: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> References: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> Message-ID: Vote: yes -Zhengyu On 8/25/21 4:44 AM, Aleksey Shipilev wrote: > I hereby nominate Roman Kennke (rkennke) to JDK Updates Project Reviewer. > > Roman is the long-time Reviewer in the JDK project. In addition to heavy > involvement in mainline development work, Roman contributed a > significant number of backports to 11u [1], including the very > significant backport of Shenandoah GC [2]. > > These references and his engagement in the JDK Updates project justify > the call to make him a JDK > Updates Reviewer as well. > > Votes are due by Sep 9, 2021, 18:00 CET. > > Only current JDK Updates Reviewers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [4]. > From goetz at openjdk.java.net Wed Aug 25 12:41:05 2021 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 25 Aug 2021 12:41:05 GMT Subject: [jdk11u] RFR: Merge jdk11u-dev:master [v2] In-Reply-To: References: Message-ID: > Bring changes for build tag 4 to jdk11u Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u/pull/9/files - new: https://git.openjdk.java.net/jdk11u/pull/9/files/c55b1e5c..c55b1e5c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=9&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=9&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u/pull/9.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/9/head:pull/9 PR: https://git.openjdk.java.net/jdk11u/pull/9 From goetz at openjdk.java.net Wed Aug 25 12:41:08 2021 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 25 Aug 2021 12:41:08 GMT Subject: [jdk11u] Integrated: Merge jdk11u-dev:master In-Reply-To: References: Message-ID: On Wed, 25 Aug 2021 09:13:40 GMT, Goetz Lindenmaier wrote: > Bring changes for build tag 4 to jdk11u This pull request has now been integrated. Changeset: e261bf74 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u/commit/e261bf74fea070a78a41151f724828240de62655 Stats: 13670 lines in 121 files changed: 11678 ins; 1434 del; 558 mod Merge ------------- PR: https://git.openjdk.java.net/jdk11u/pull/9 From mbalao at redhat.com Wed Aug 25 13:04:13 2021 From: mbalao at redhat.com (Martin Balao) Date: Wed, 25 Aug 2021 09:04:13 -0400 Subject: CFV: New JDK Updates Reviewer: Roman Kennke In-Reply-To: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> References: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> Message-ID: Vote: Yes From christoph.langer at sap.com Wed Aug 25 14:08:04 2021 From: christoph.langer at sap.com (Langer, Christoph) Date: Wed, 25 Aug 2021 14:08:04 +0000 Subject: CFV: New JDK Updates Reviewer: Roman Kennke In-Reply-To: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> References: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> Message-ID: Vote:yes (about time!) Cheers Christoph > -----Original Message----- > From: jdk-updates-dev On > Behalf Of Aleksey Shipilev > Sent: Mittwoch, 25. August 2021 10:45 > To: jdk-updates-dev at openjdk.java.net > Subject: CFV: New JDK Updates Reviewer: Roman Kennke > > I hereby nominate Roman Kennke (rkennke) to JDK Updates Project > Reviewer. > > Roman is the long-time Reviewer in the JDK project. In addition to heavy > involvement in mainline > development work, Roman contributed a significant number of backports to > 11u [1], including the very > significant backport of Shenandoah GC [2]. > > These references and his engagement in the JDK Updates project justify the > call to make him a JDK > Updates Reviewer as well. > > Votes are due by Sep 9, 2021, 18:00 CET. > > Only current JDK Updates Reviewers [3] are eligible to vote on this > nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > -- > Thanks, > -Aleksey > > [1] https://github.com/openjdk/jdk11u-dev/commits?author=rkennke > [2] https://github.com/openjdk/jdk11u- > dev/commit/20a0625da8558b0b15bbe9328983abe3341d75b0 > [3] http://openjdk.java.net/census#jdk-updates > [4] http://openjdk.java.net/projects/#reviewer-vote From volker.simonis at gmail.com Wed Aug 25 14:13:24 2021 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 25 Aug 2021 16:13:24 +0200 Subject: CFV: New JDK Updates Reviewer: Roman Kennke In-Reply-To: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> References: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> Message-ID: Vote: yes On Wed, Aug 25, 2021 at 10:45 AM Aleksey Shipilev wrote: > > I hereby nominate Roman Kennke (rkennke) to JDK Updates Project Reviewer. > > Roman is the long-time Reviewer in the JDK project. In addition to heavy involvement in mainline > development work, Roman contributed a significant number of backports to 11u [1], including the very > significant backport of Shenandoah GC [2]. > > These references and his engagement in the JDK Updates project justify the call to make him a JDK > Updates Reviewer as well. > > Votes are due by Sep 9, 2021, 18:00 CET. > > Only current JDK Updates Reviewers [3] are eligible to vote on this nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > -- > Thanks, > -Aleksey > > [1] https://github.com/openjdk/jdk11u-dev/commits?author=rkennke > [2] https://github.com/openjdk/jdk11u-dev/commit/20a0625da8558b0b15bbe9328983abe3341d75b0 > [3] http://openjdk.java.net/census#jdk-updates > [4] http://openjdk.java.net/projects/#reviewer-vote > From clanger at openjdk.java.net Wed Aug 25 14:29:23 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 25 Aug 2021 14:29:23 GMT Subject: [jdk11u-dev] RFR: 8252857: AArch64: Shenandoah C1 CAS is not sequentially consistent In-Reply-To: References: Message-ID: <0OTxk_PLAfKsZXMkjUEHyI-dDKju5kRv62R5bcWcSlk=.cd19d84b-c041-4fd1-b64e-b84bcdcdc00c@github.com> On Tue, 24 Aug 2021 15:51:28 GMT, Aleksey Shipilev wrote: > Unclean backport to fix Shenandoah AArch64 bug. The patch does not apply cleanly, because there is a trivial conflict in a copyright line. Then it fails to build, because the check in `LIR_OpShenandoahCompareAndSwap::emit_code` should match the 11u version. > > In JDK mainline: > > > void LIRGenerator::volatile_field_load(LIR_Address* address, LIR_Opr result, * info) { > .... > if (!CompilerConfig::is_c1_only_no_jvmci()) { > __ membar(); > } > __ volatile_load_mem_reg(address, result, info); > } > ... > void LIR_OpShenandoahCompareAndSwap::emit_code(LIR_Assembler* masm) { > ... > if (CompilerConfig::is_c1_only_no_jvmci()) { > ... > __ membar(__ AnyAny); > } > } > > > In JDK 11u (this PR): > > > void LIRGenerator::volatile_field_load(LIR_Address* address, LIR_Opr result, > CodeEmitInfo* info) { > ... > if (! UseBarriersForVolatile) { > __ membar(); > } > __ volatile_load_mem_reg(address, result, info); > } > > void LIR_OpShenandoahCompareAndSwap::emit_code(LIR_Assembler* masm) { > ... > if (UseBarriersForVolatile) { > ... > __ membar(__ AnyAny); > } > } > > > Additional testing: > - [x] Linux AArch64 hotspot_gc_shenandoah > - [x] Linux AArch64 tier1 with -XX:+UseShenandoahGC > - [x] Linux AArch64 tier2 with -XX:+UseShenandoahGC > - [x] Linux AArch64 jcstress -m quick with -XX:+UseShenandoahGC Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/289 From shade at openjdk.java.net Wed Aug 25 15:14:24 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 25 Aug 2021 15:14:24 GMT Subject: [jdk11u-dev] RFR: 8252857: AArch64: Shenandoah C1 CAS is not sequentially consistent In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 15:51:28 GMT, Aleksey Shipilev wrote: > Unclean backport to fix Shenandoah AArch64 bug. The patch does not apply cleanly, because there is a trivial conflict in a copyright line. Then it fails to build, because the check in `LIR_OpShenandoahCompareAndSwap::emit_code` should match the 11u version. > > In JDK mainline: > > > void LIRGenerator::volatile_field_load(LIR_Address* address, LIR_Opr result, * info) { > .... > if (!CompilerConfig::is_c1_only_no_jvmci()) { > __ membar(); > } > __ volatile_load_mem_reg(address, result, info); > } > ... > void LIR_OpShenandoahCompareAndSwap::emit_code(LIR_Assembler* masm) { > ... > if (CompilerConfig::is_c1_only_no_jvmci()) { > ... > __ membar(__ AnyAny); > } > } > > > In JDK 11u (this PR): > > > void LIRGenerator::volatile_field_load(LIR_Address* address, LIR_Opr result, > CodeEmitInfo* info) { > ... > if (! UseBarriersForVolatile) { > __ membar(); > } > __ volatile_load_mem_reg(address, result, info); > } > > void LIR_OpShenandoahCompareAndSwap::emit_code(LIR_Assembler* masm) { > ... > if (UseBarriersForVolatile) { > ... > __ membar(__ AnyAny); > } > } > > > Additional testing: > - [x] Linux AArch64 hotspot_gc_shenandoah > - [x] Linux AArch64 tier1 with -XX:+UseShenandoahGC > - [x] Linux AArch64 tier2 with -XX:+UseShenandoahGC > - [x] Linux AArch64 jcstress -m quick with -XX:+UseShenandoahGC Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/289 From shade at openjdk.java.net Wed Aug 25 15:14:25 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 25 Aug 2021 15:14:25 GMT Subject: [jdk11u-dev] Integrated: 8252857: AArch64: Shenandoah C1 CAS is not sequentially consistent In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 15:51:28 GMT, Aleksey Shipilev wrote: > Unclean backport to fix Shenandoah AArch64 bug. The patch does not apply cleanly, because there is a trivial conflict in a copyright line. Then it fails to build, because the check in `LIR_OpShenandoahCompareAndSwap::emit_code` should match the 11u version. > > In JDK mainline: > > > void LIRGenerator::volatile_field_load(LIR_Address* address, LIR_Opr result, * info) { > .... > if (!CompilerConfig::is_c1_only_no_jvmci()) { > __ membar(); > } > __ volatile_load_mem_reg(address, result, info); > } > ... > void LIR_OpShenandoahCompareAndSwap::emit_code(LIR_Assembler* masm) { > ... > if (CompilerConfig::is_c1_only_no_jvmci()) { > ... > __ membar(__ AnyAny); > } > } > > > In JDK 11u (this PR): > > > void LIRGenerator::volatile_field_load(LIR_Address* address, LIR_Opr result, > CodeEmitInfo* info) { > ... > if (! UseBarriersForVolatile) { > __ membar(); > } > __ volatile_load_mem_reg(address, result, info); > } > > void LIR_OpShenandoahCompareAndSwap::emit_code(LIR_Assembler* masm) { > ... > if (UseBarriersForVolatile) { > ... > __ membar(__ AnyAny); > } > } > > > Additional testing: > - [x] Linux AArch64 hotspot_gc_shenandoah > - [x] Linux AArch64 tier1 with -XX:+UseShenandoahGC > - [x] Linux AArch64 tier2 with -XX:+UseShenandoahGC > - [x] Linux AArch64 jcstress -m quick with -XX:+UseShenandoahGC This pull request has now been integrated. Changeset: 7cafcf4c Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/7cafcf4c34bef00fceb295f17877f88ff8c7e0bb Stats: 52 lines in 2 files changed: 10 ins; 30 del; 12 mod 8252857: AArch64: Shenandoah C1 CAS is not sequentially consistent Reviewed-by: rkennke, clanger Backport-of: 8e87d46f41e663f5d0506554054417e3049175e7 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/289 From shade at redhat.com Wed Aug 25 15:55:22 2021 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 25 Aug 2021 17:55:22 +0200 Subject: CFV: New JDK Updates Reviewer: Roman Kennke In-Reply-To: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> References: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> Message-ID: <140c26d6-9202-bd27-e86c-531f07a2a33d@redhat.com> Vote: yes On 8/25/21 10:44 AM, Aleksey Shipilev wrote: > I hereby nominate Roman Kennke (rkennke) to JDK Updates Project Reviewer. From github.com+25946952+rnkovacs at openjdk.java.net Wed Aug 25 16:02:20 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Wed, 25 Aug 2021 16:02:20 GMT Subject: [jdk11u-dev] RFR: 8248668: AArch64: Avoid MIN/MAX macros when using MSVC [v2] In-Reply-To: References: Message-ID: > Changes apply cleanly. Testing: tier1. > > This is part of the Windows/AArch64 port. Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport 26680f0c1a998d41f87170b2d5a6487932ed33bb ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/263/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/263/files/7c70d350..cda127b3 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=263&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=263&range=00-01 Stats: 3577 lines in 69 files changed: 1581 ins; 1434 del; 562 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/263.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/263/head:pull/263 PR: https://git.openjdk.java.net/jdk11u-dev/pull/263 From github.com+25946952+rnkovacs at openjdk.java.net Wed Aug 25 16:03:48 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Wed, 25 Aug 2021 16:03:48 GMT Subject: [jdk11u-dev] RFR: 8248666: AArch64: Use THREAD_LOCAL instead of __thread [v2] In-Reply-To: References: Message-ID: > Not a clean backport. Original patch used a macro called THREAD_LOCAL, this backport uses THREAD_LOCAL_DECL. THREAD_LOCAL_DECL was renamed to THREAD_LOCAL by [JDK-8230877](https://bugs.openjdk.java.net/browse/JDK-8230877) in JDK 14. Testing: tier1. > > This is part of the Windows/AArch64 port. Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 2f8653fbf0f4ed2ab0e40b2bb541ef2eff913469 ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/262/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=262&range=01 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/262.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/262/head:pull/262 PR: https://git.openjdk.java.net/jdk11u-dev/pull/262 From github.com+25946952+rnkovacs at openjdk.java.net Wed Aug 25 16:03:48 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Wed, 25 Aug 2021 16:03:48 GMT Subject: [jdk11u-dev] RFR: 8248666: AArch64: Use THREAD_LOCAL instead of __thread In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 06:28:24 GMT, Reka Kovacs wrote: > Not a clean backport. Original patch used a macro called THREAD_LOCAL, this backport uses THREAD_LOCAL_DECL. THREAD_LOCAL_DECL was renamed to THREAD_LOCAL by [JDK-8230877](https://bugs.openjdk.java.net/browse/JDK-8230877) in JDK 14. Testing: tier1. > > This is part of the Windows/AArch64 port. I believe I solved the merge conflict. Thanks so much for pushing all the ready PRs in, I really appreciate it! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/262 From clanger at openjdk.java.net Wed Aug 25 16:09:26 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 25 Aug 2021 16:09:26 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master Message-ID: Transport latest merge commit from jdk11u->jdk11u-dev. ------------- Commit messages: The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.java.net/jdk11u-dev/pull/297/files Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/297.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/297/head:pull/297 PR: https://git.openjdk.java.net/jdk11u-dev/pull/297 From clanger at openjdk.java.net Wed Aug 25 16:09:27 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 25 Aug 2021 16:09:27 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: References: Message-ID: On Wed, 25 Aug 2021 16:02:19 GMT, Christoph Langer wrote: > Transport latest merge commit from jdk11u->jdk11u-dev. This pull request has now been integrated. Changeset: 9012b4a1 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/9012b4a14e28b698bcd2f36270a8be10e94975c4 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Merge ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/297 From clanger at openjdk.java.net Wed Aug 25 16:20:31 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 25 Aug 2021 16:20:31 GMT Subject: [jdk11u-dev] RFR: 8233790: Forward output from heap dumper to jcmd/jmap In-Reply-To: <3nq2lxQx57gzahXjY5KpLdoWPBm55JtCkTPUVyWIiQU=.4c9f3ab5-dbfd-48c1-8507-e89263afb83c@github.com> References: <3nq2lxQx57gzahXjY5KpLdoWPBm55JtCkTPUVyWIiQU=.4c9f3ab5-dbfd-48c1-8507-e89263afb83c@github.com> Message-ID: On Thu, 19 Aug 2021 05:53:02 GMT, Bin Liao wrote: > Backport of the heap dump enhancement: Forward output from heap dumper to jcmd/jmap > > Patch did not apply cleanly, I had to resolve/modify > src/hotspot/share/services/diagnosticCommand.cpp > src/hotspot/share/services/heapDumper.cpp > src/hotspot/share/services/heapDumper.hpp > > since patch 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea is backport before this one, so this patch can't backport cleanly As Paul didn't react so far, I can sponsor this. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/256 From github.com+3094961+buddyliao at openjdk.java.net Wed Aug 25 16:20:34 2021 From: github.com+3094961+buddyliao at openjdk.java.net (Bin Liao) Date: Wed, 25 Aug 2021 16:20:34 GMT Subject: [jdk11u-dev] Integrated: 8233790: Forward output from heap dumper to jcmd/jmap In-Reply-To: <3nq2lxQx57gzahXjY5KpLdoWPBm55JtCkTPUVyWIiQU=.4c9f3ab5-dbfd-48c1-8507-e89263afb83c@github.com> References: <3nq2lxQx57gzahXjY5KpLdoWPBm55JtCkTPUVyWIiQU=.4c9f3ab5-dbfd-48c1-8507-e89263afb83c@github.com> Message-ID: On Thu, 19 Aug 2021 05:53:02 GMT, Bin Liao wrote: > Backport of the heap dump enhancement: Forward output from heap dumper to jcmd/jmap > > Patch did not apply cleanly, I had to resolve/modify > src/hotspot/share/services/diagnosticCommand.cpp > src/hotspot/share/services/heapDumper.cpp > src/hotspot/share/services/heapDumper.hpp > > since patch 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea is backport before this one, so this patch can't backport cleanly This pull request has now been integrated. Changeset: 5d1b9bbe Author: Bin Liao Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/5d1b9bbe8328305d41d7756a55a639c48af857c7 Stats: 47 lines in 4 files changed: 3 ins; 29 del; 15 mod 8233790: Forward output from heap dumper to jcmd/jmap Reviewed-by: phh Backport-of: b2a967382980bbaca2c2f7d08eab565024ede40e ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/256 From clanger at openjdk.java.net Wed Aug 25 16:26:27 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 25 Aug 2021 16:26:27 GMT Subject: [jdk11u-dev] RFR: 8236177: assert(status == 0) failed: error ETIMEDOUT(60), cond_wait In-Reply-To: <1rBksZr1JQiKmh3h8T4SNMgk4ZTrh5M_gbwF17u_fag=.13725ecf-5af4-4b32-bc6a-f425493a1f5f@github.com> References: <1rBksZr1JQiKmh3h8T4SNMgk4ZTrh5M_gbwF17u_fag=.13725ecf-5af4-4b32-bc6a-f425493a1f5f@github.com> Message-ID: On Thu, 19 Aug 2021 07:03:14 GMT, Aleksey Shipilev wrote: > Unclean backport: some of `pthread_cond_wait` uses are not present in 11u (added later by JDK-8210832), I ignored them. LGTM ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/257 From phh at openjdk.java.net Wed Aug 25 17:46:28 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 25 Aug 2021 17:46:28 GMT Subject: [jdk11u-dev] RFR: 8233790: Forward output from heap dumper to jcmd/jmap In-Reply-To: <3nq2lxQx57gzahXjY5KpLdoWPBm55JtCkTPUVyWIiQU=.4c9f3ab5-dbfd-48c1-8507-e89263afb83c@github.com> References: <3nq2lxQx57gzahXjY5KpLdoWPBm55JtCkTPUVyWIiQU=.4c9f3ab5-dbfd-48c1-8507-e89263afb83c@github.com> Message-ID: On Thu, 19 Aug 2021 05:53:02 GMT, Bin Liao wrote: > Backport of the heap dump enhancement: Forward output from heap dumper to jcmd/jmap > > Patch did not apply cleanly, I had to resolve/modify > src/hotspot/share/services/diagnosticCommand.cpp > src/hotspot/share/services/heapDumper.cpp > src/hotspot/share/services/heapDumper.hpp > > since patch 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea is backport before this one, so this patch can't backport cleanly Thanks, Christoph. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/256 From prr at openjdk.java.net Wed Aug 25 23:14:45 2021 From: prr at openjdk.java.net (Phil Race) Date: Wed, 25 Aug 2021 23:14:45 GMT Subject: [jdk17u] RFR: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed Message-ID: Backport 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed ------------- Commit messages: - Backport f681d6544ac2506cb72e45c1f9ed8dfbbde099f2 Changes: https://git.openjdk.java.net/jdk17u/pull/42/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=42&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272806 Stats: 4 lines in 2 files changed: 1 ins; 2 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u/pull/42.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/42/head:pull/42 PR: https://git.openjdk.java.net/jdk17u/pull/42 From prr at openjdk.java.net Wed Aug 25 23:25:41 2021 From: prr at openjdk.java.net (Phil Race) Date: Wed, 25 Aug 2021 23:25:41 GMT Subject: [jdk17u] Integrated: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed In-Reply-To: References: Message-ID: On Wed, 25 Aug 2021 23:05:51 GMT, Phil Race wrote: > Backport 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed This pull request has now been integrated. Changeset: 71a6aae3 Author: Phil Race URL: https://git.openjdk.java.net/jdk17u/commit/71a6aae38d7e7e0aa24264c98b0138808ffd0e8f Stats: 4 lines in 2 files changed: 1 ins; 2 del; 1 mod 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed Backport-of: f681d6544ac2506cb72e45c1f9ed8dfbbde099f2 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/42 From dholmes at openjdk.java.net Thu Aug 26 01:49:28 2021 From: dholmes at openjdk.java.net (David Holmes) Date: Thu, 26 Aug 2021 01:49:28 GMT Subject: [jdk17u] RFR: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 12:52:50 GMT, David Holmes wrote: > Hi all, > > This pull request contains a backport of commit 7e518f42 from the openjdk/jdk repository. > > The commit being backported was authored by David Holmes on 4 Aug 2021 and was reviewed by Thomas Stuefe, Daniel D. Daugherty and Serguei Spitsyn. > > Thanks! > David Backport has been approved. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/38 From dholmes at openjdk.java.net Thu Aug 26 01:49:29 2021 From: dholmes at openjdk.java.net (David Holmes) Date: Thu, 26 Aug 2021 01:49:29 GMT Subject: [jdk17u] Integrated: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 12:52:50 GMT, David Holmes wrote: > Hi all, > > This pull request contains a backport of commit 7e518f42 from the openjdk/jdk repository. > > The commit being backported was authored by David Holmes on 4 Aug 2021 and was reviewed by Thomas Stuefe, Daniel D. Daugherty and Serguei Spitsyn. > > Thanks! > David This pull request has now been integrated. Changeset: 671dab61 Author: David Holmes URL: https://git.openjdk.java.net/jdk17u/commit/671dab6154a73b80f5f3f863f688fea93fd8fcde Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status Backport-of: 7e518f42c9346abdf0c8059b45d3dfef95ed69bb ------------- PR: https://git.openjdk.java.net/jdk17u/pull/38 From github.com+3094961+buddyliao at openjdk.java.net Thu Aug 26 02:55:36 2021 From: github.com+3094961+buddyliao at openjdk.java.net (Bin Liao) Date: Thu, 26 Aug 2021 02:55:36 GMT Subject: [jdk11u-dev] RFR: 8237354: Add option to jcmd to write a gzipped heap dump [v3] In-Reply-To: References: Message-ID: > Backport of the heap dump enhancement: Add option to jcmd to write a gzipped heap dump > > Patch did not apply cleanly, I had to resolve/modify > > 1) src/hotspot/share/services/heapDumper.cpp > function "int dump(const char* path, bool overwrite = false)" has some different from the jdk-master, since patch 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea is backport before this one, so this patch can't backport clearly > > 2) src/hotspot/share/services/heapDumperCompression.cpp > MonitorLockerEx is named MonitorLocker in jdk-master, MonitorLockerEx.wait should have parameters, the constructor of MonitorLockerEx and MutexUnlockerEx also different from jdk-master > > 3) src/hotspot/share/services/heapDumperCompression.hpp > FileWriter is different from jdk-master since backport of 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea before this patch. > > I have built it on linux x86_64 and run test-tier1 Bin Liao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge branch 'backport-19be49714356f2f598924c9fefa6358679ab6dbe' of github.com:buddyliao/jdk11u-dev into backport-19be49714356f2f598924c9fefa6358679ab6dbe - Merge branch 'master' of https://git.openjdk.java.net/jdk11u-dev into backport-19be49714356f2f598924c9fefa6358679ab6dbe - Merge master - Backport 19be49714356f2f598924c9fefa6358679ab6dbe ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/209/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=209&range=02 Stats: 1758 lines in 13 files changed: 1637 ins; 52 del; 69 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/209.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/209/head:pull/209 PR: https://git.openjdk.java.net/jdk11u-dev/pull/209 From akolarkunnu at openjdk.java.net Thu Aug 26 03:51:33 2021 From: akolarkunnu at openjdk.java.net (Abdul Kolarkunnu) Date: Thu, 26 Aug 2021 03:51:33 GMT Subject: [jdk17u] Integrated: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java In-Reply-To: References: Message-ID: On Wed, 25 Aug 2021 02:38:48 GMT, Abdul Kolarkunnu wrote: > Test Result - https://mach5.us.oracle.com/mdash/jobs/akolarku-jdk17u-cpu-20210825-0713-24028774 This pull request has now been integrated. Changeset: 9248bd08 Author: Abdul Kolarkunnu URL: https://git.openjdk.java.net/jdk17u/commit/9248bd08cf6d16aca27ea1b00506736fc0544070 Stats: 1184 lines in 3 files changed: 731 ins; 453 del; 0 mod 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java Backport-of: ed57cf1cf3f2d107e085ecdae38a63e66ab2fa30 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/40 From github.com+3094961+buddyliao at openjdk.java.net Thu Aug 26 03:52:27 2021 From: github.com+3094961+buddyliao at openjdk.java.net (Bin Liao) Date: Thu, 26 Aug 2021 03:52:27 GMT Subject: [jdk11u-dev] RFR: 8237354: Add option to jcmd to write a gzipped heap dump [v2] In-Reply-To: References: Message-ID: On Thu, 19 Aug 2021 05:54:53 GMT, Bin Liao wrote: > I strongly recommend backporting JDK-8233790 first. The general update release rule is to backport dependencies first, then the dependent issue. It's easier to review that way. Also, I doubt the maintainers will approve a backport such as this one that breaks a test, even if the test is broken for only a short time. At a minimum, automated test systems will notice the failure and provoke work on the part of their owners. Hi @phohensee , JDK-8233790 has been backported and merged, I have rebased this patch and test tier1. Would you please continue reviewing this backport? Thank you. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/209 From akolarkunnu at openjdk.java.net Thu Aug 26 04:05:00 2021 From: akolarkunnu at openjdk.java.net (Abdul Kolarkunnu) Date: Thu, 26 Aug 2021 04:05:00 GMT Subject: [jdk17u] RFR: 8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182 Message-ID: Test Result - https://mach5.us.oracle.com/mdash/jobs/akolarku-jdk17u-cpu-20210825-0713-24028774 ------------- Commit messages: - Backport a199ebc0175f9882f051551cff9ce08016f204a4 Changes: https://git.openjdk.java.net/jdk17u/pull/43/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=43&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272581 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u/pull/43.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/43/head:pull/43 PR: https://git.openjdk.java.net/jdk17u/pull/43 From akolarkunnu at openjdk.java.net Thu Aug 26 04:08:50 2021 From: akolarkunnu at openjdk.java.net (Abdul Kolarkunnu) Date: Thu, 26 Aug 2021 04:08:50 GMT Subject: [jdk17u] Integrated: 8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182 In-Reply-To: References: Message-ID: On Thu, 26 Aug 2021 03:57:50 GMT, Abdul Kolarkunnu wrote: > Test Result - https://mach5.us.oracle.com/mdash/jobs/akolarku-jdk17u-cpu-20210825-0713-24028774 This pull request has now been integrated. Changeset: ff6a9382 Author: Abdul Kolarkunnu URL: https://git.openjdk.java.net/jdk17u/commit/ff6a9382f5ed16bfad7440433bb4fe0a21db8a6c Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182 Backport-of: a199ebc0175f9882f051551cff9ce08016f204a4 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/43 From clanger at openjdk.java.net Thu Aug 26 07:10:23 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 26 Aug 2021 07:10:23 GMT Subject: [jdk11u-dev] RFR: 8248666: AArch64: Use THREAD_LOCAL instead of __thread [v2] In-Reply-To: References: Message-ID: On Wed, 25 Aug 2021 16:03:48 GMT, Reka Kovacs wrote: >> Not a clean backport. Original patch used a macro called THREAD_LOCAL, this backport uses THREAD_LOCAL_DECL. THREAD_LOCAL_DECL was renamed to THREAD_LOCAL by [JDK-8230877](https://bugs.openjdk.java.net/browse/JDK-8230877) in JDK 14. Testing: tier1. >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 2f8653fbf0f4ed2ab0e40b2bb541ef2eff913469 Looks good. I think you can integrate it now. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/262 From shade at openjdk.java.net Thu Aug 26 07:22:23 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 26 Aug 2021 07:22:23 GMT Subject: [jdk11u-dev] RFR: 8212695: Add explicit timeout to several HTTP Client tests In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 20:15:26 GMT, Christoph Langer wrote: > Backport of JDK-8212695. I had to make adjustments because JDK-8222527 was already backported. It is a bit weird to see the double execution of the same config in `DigestEchoClientSSL.java`, but it is that way upstream. So, looks good! ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/294 From shade at openjdk.java.net Thu Aug 26 07:26:26 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 26 Aug 2021 07:26:26 GMT Subject: [jdk11u-dev] RFR: 8211325: test/jdk/java/net/Socket/LingerTest.java fails with cleaning up In-Reply-To: <6gVT4UWVf3Lc7PKPT2aeaP9aGV5TsFBbry6ztRE_AiM=.cf8c1f8a-0b3d-4bfb-b41a-8d1e484dac6b@github.com> References: <6gVT4UWVf3Lc7PKPT2aeaP9aGV5TsFBbry6ztRE_AiM=.cf8c1f8a-0b3d-4bfb-b41a-8d1e484dac6b@github.com> Message-ID: On Tue, 24 Aug 2021 20:07:20 GMT, Christoph Langer wrote: > Clean backport of 8211325. The change to the problem list doesn't apply though, because the removed exclusion didn't exist in 11. Looks fine. ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/293 From clanger at openjdk.java.net Thu Aug 26 07:27:22 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 26 Aug 2021 07:27:22 GMT Subject: [jdk11u-dev] RFR: 8212695: Add explicit timeout to several HTTP Client tests In-Reply-To: References: Message-ID: <-mgixgtiu_5dCR0JP6gRxC3MhjA_21_IYgtP9_Me1cc=.d29d6a79-1901-4823-9745-91fceae077e5@github.com> On Thu, 26 Aug 2021 07:19:19 GMT, Aleksey Shipilev wrote: > It is a bit weird to see the double execution of the same config in `DigestEchoClientSSL.java`, but it is that way upstream. So, looks good! You're right. Probably worth a fix upstream. Thanks for the review. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/294 From shade at openjdk.java.net Thu Aug 26 07:30:26 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 26 Aug 2021 07:30:26 GMT Subject: [jdk11u-dev] RFR: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration In-Reply-To: <-E9H960xOzBqy_rtO0S06MI9ex8yRVjcO1Ich1V36dI=.e2a38079-ccf9-4309-9c99-74ce2c6dd341@github.com> References: <-E9H960xOzBqy_rtO0S06MI9ex8yRVjcO1Ich1V36dI=.e2a38079-ccf9-4309-9c99-74ce2c6dd341@github.com> Message-ID: <8sg3GrocyEw_bq-M8zSOrfVyr4K8F5FOpsWwuAClZKI=.c89bb7ac-d1ac-49ff-8016-f2f42cda358c@github.com> On Wed, 25 Aug 2021 08:39:03 GMT, Christoph Langer wrote: > Backport of JDK-8241336 > > - This is WIP, not ready for review yet - The patch looks fine. Do you see this failing in 11u? (I just wonder why Oracle had not backported this yet). ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/296 From shade at openjdk.java.net Thu Aug 26 07:42:25 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 26 Aug 2021 07:42:25 GMT Subject: [jdk11u-dev] RFR: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 17:34:28 GMT, Severin Gehwolf wrote: > Please review this defensive backport of JDK-8272124. OpenJDK 11u is affected too, but it manifests in a different way. Basically Java metrics report wrong results on affected system where the cgroup path contains a colon. The JDK 18 patch doesn't apply cleanly since JDK-8230305 (cgroups v2 support) isn't in 11u. Test support in 11 isn't as good as well (files don't exist), thus dropped the test changes. > > Also, I've kept the token number filter to keep using `>= 3` since that's the more defensive approach. It's not clear if systems with `/proc/self/cgroup` files exist in the wild with less than 3 tokens. > > Testing: Manual reproduce before/after patch. See explicit backport bug for details. > > Thoughts? Looks fine as a limited fix. ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/292 From shade at openjdk.java.net Thu Aug 26 07:44:23 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 26 Aug 2021 07:44:23 GMT Subject: [jdk11u-dev] RFR: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status In-Reply-To: <4W_AwFKxIu3NrluAJZlLguz42x4tm8fVWAt2qhRiAFQ=.583cc713-9f00-48ab-be33-3b8ffca4f51b@github.com> References: <4W_AwFKxIu3NrluAJZlLguz42x4tm8fVWAt2qhRiAFQ=.583cc713-9f00-48ab-be33-3b8ffca4f51b@github.com> Message-ID: On Tue, 24 Aug 2021 13:08:53 GMT, Vladimir Kempik wrote: > Clean backport from 15u ( reviewed by Paul Hohensee ). Not clean backport from jdk/jdk Looks fine. ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/285 From shade at openjdk.java.net Thu Aug 26 07:47:26 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 26 Aug 2021 07:47:26 GMT Subject: [jdk11u-dev] RFR: 8263490: [macos] Crash occurs on JPasswordField with activated InputMethod In-Reply-To: References: Message-ID: On Wed, 25 Aug 2021 02:44:05 GMT, Toshio Nakamura wrote: > Hi, > > Original patch almost applies cleanly to 11u. Only copyright year was adjusted. > This crash issue with Input Method of GUI was observed with 11.0.12, and I'd like to backport it. > > Original bug: https://bugs.openjdk.java.net/browse/JDK-8263490 > > Testing: tier1, java/awt and javax/swing on macOS The patch looks fine. ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/295 From clanger at openjdk.java.net Thu Aug 26 08:06:51 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 26 Aug 2021 08:06:51 GMT Subject: [jdk11u-dev] RFR: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration [v2] In-Reply-To: <-E9H960xOzBqy_rtO0S06MI9ex8yRVjcO1Ich1V36dI=.e2a38079-ccf9-4309-9c99-74ce2c6dd341@github.com> References: <-E9H960xOzBqy_rtO0S06MI9ex8yRVjcO1Ich1V36dI=.e2a38079-ccf9-4309-9c99-74ce2c6dd341@github.com> Message-ID: <7a_C8lDUhtmzGhsXeCfcqn-eue4Wdv6DMCxTiJWVhHA=.6e1bbf95-1e89-4cbd-8a2e-392d39888983@github.com> > Backport of JDK-8241336 > > - This is WIP, not ready for review yet - Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: Add missing @library /test/lib annotation to Promiscuous.java. It was part of JDK-8220673 which is not backported. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/296/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/296/files/31c28dd8..8f9ea912 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=296&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=296&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/296.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/296/head:pull/296 PR: https://git.openjdk.java.net/jdk11u-dev/pull/296 From clanger at openjdk.java.net Thu Aug 26 08:27:27 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 26 Aug 2021 08:27:27 GMT Subject: [jdk11u-dev] RFR: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration [v2] In-Reply-To: <8sg3GrocyEw_bq-M8zSOrfVyr4K8F5FOpsWwuAClZKI=.c89bb7ac-d1ac-49ff-8016-f2f42cda358c@github.com> References: <-E9H960xOzBqy_rtO0S06MI9ex8yRVjcO1Ich1V36dI=.e2a38079-ccf9-4309-9c99-74ce2c6dd341@github.com> <8sg3GrocyEw_bq-M8zSOrfVyr4K8F5FOpsWwuAClZKI=.c89bb7ac-d1ac-49ff-8016-f2f42cda358c@github.com> Message-ID: On Thu, 26 Aug 2021 07:27:34 GMT, Aleksey Shipilev wrote: > The patch looks fine. Do you see this failing in 11u? (I just wonder why Oracle had not backported this yet). I added another small commit to add a test library annotation for Promiscious.java. Now it should work. And, yes, we see these kind of errors in 11 now, too. Probably we have a special configuration in our 11 test landscape now that Oracle hasn't. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/296 From sgehwolf at openjdk.java.net Thu Aug 26 09:43:22 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Thu, 26 Aug 2021 09:43:22 GMT Subject: [jdk11u-dev] RFR: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 17:34:28 GMT, Severin Gehwolf wrote: > Please review this defensive backport of JDK-8272124. OpenJDK 11u is affected too, but it manifests in a different way. Basically Java metrics report wrong results on affected system where the cgroup path contains a colon. The JDK 18 patch doesn't apply cleanly since JDK-8230305 (cgroups v2 support) isn't in 11u. Test support in 11 isn't as good as well (files don't exist), thus dropped the test changes. > > Also, I've kept the token number filter to keep using `>= 3` since that's the more defensive approach. It's not clear if systems with `/proc/self/cgroup` files exist in the wild with less than 3 tokens. > > Testing: Manual reproduce before/after patch. See explicit backport bug for details. > > Thoughts? Thanks for the review! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/292 From vkempik at openjdk.java.net Thu Aug 26 16:01:24 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Thu, 26 Aug 2021 16:01:24 GMT Subject: [jdk11u-dev] Integrated: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status In-Reply-To: <4W_AwFKxIu3NrluAJZlLguz42x4tm8fVWAt2qhRiAFQ=.583cc713-9f00-48ab-be33-3b8ffca4f51b@github.com> References: <4W_AwFKxIu3NrluAJZlLguz42x4tm8fVWAt2qhRiAFQ=.583cc713-9f00-48ab-be33-3b8ffca4f51b@github.com> Message-ID: On Tue, 24 Aug 2021 13:08:53 GMT, Vladimir Kempik wrote: > Clean backport from 15u ( reviewed by Paul Hohensee ). Not clean backport from jdk/jdk This pull request has now been integrated. Changeset: cb0775ff Author: Vladimir Kempik URL: https://git.openjdk.java.net/jdk11u-dev/commit/cb0775ffc75db9825424ce8d4aa792636843d72e Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status Reviewed-by: shade Backport-of: 7e518f42c9346abdf0c8059b45d3dfef95ed69bb ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/285 From vkempik at openjdk.java.net Thu Aug 26 16:14:52 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Thu, 26 Aug 2021 16:14:52 GMT Subject: [jdk15u-dev] RFR: 8264848: [macos] libjvm.dylib linker warning due to macOS version mismatch Message-ID: Clean backport to jdk15u ------------- Commit messages: - Backport 04fa1ed4d0d409bf9bd741297ca95c7f1b7a3e9f Changes: https://git.openjdk.java.net/jdk15u-dev/pull/92/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=92&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8264848 Stats: 11 lines in 1 file changed: 10 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/92.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/92/head:pull/92 PR: https://git.openjdk.java.net/jdk15u-dev/pull/92 From sgehwolf at openjdk.java.net Thu Aug 26 17:47:25 2021 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Thu, 26 Aug 2021 17:47:25 GMT Subject: [jdk11u-dev] Integrated: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon In-Reply-To: References: Message-ID: <0rejlXG4gVDu0rTVqyl_CPYoO5E4E07CFsZh1yxZKug=.434a727f-c456-4ef7-8bb0-6aab65c726d8@github.com> On Tue, 24 Aug 2021 17:34:28 GMT, Severin Gehwolf wrote: > Please review this defensive backport of JDK-8272124. OpenJDK 11u is affected too, but it manifests in a different way. Basically Java metrics report wrong results on affected system where the cgroup path contains a colon. The JDK 18 patch doesn't apply cleanly since JDK-8230305 (cgroups v2 support) isn't in 11u. Test support in 11 isn't as good as well (files don't exist), thus dropped the test changes. > > Also, I've kept the token number filter to keep using `>= 3` since that's the more defensive approach. It's not clear if systems with `/proc/self/cgroup` files exist in the wild with less than 3 tokens. > > Testing: Manual reproduce before/after patch. See explicit backport bug for details. > > Thoughts? This pull request has now been integrated. Changeset: 7c872ed3 Author: Severin Gehwolf URL: https://git.openjdk.java.net/jdk11u-dev/commit/7c872ed381953786e8159d03dd8e7ad58804454c Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon Reviewed-by: shade Backport-of: 4d6593ce0243457e7431a5990957a8f880e0a3fb ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/292 From phh at openjdk.java.net Thu Aug 26 21:05:28 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Thu, 26 Aug 2021 21:05:28 GMT Subject: [jdk11u-dev] RFR: 8248666: AArch64: Use THREAD_LOCAL instead of __thread [v2] In-Reply-To: References: Message-ID: On Wed, 25 Aug 2021 16:03:48 GMT, Reka Kovacs wrote: >> Not a clean backport. Original patch used a macro called THREAD_LOCAL, this backport uses THREAD_LOCAL_DECL. THREAD_LOCAL_DECL was renamed to THREAD_LOCAL by [JDK-8230877](https://bugs.openjdk.java.net/browse/JDK-8230877) in JDK 14. Testing: tier1. >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 2f8653fbf0f4ed2ab0e40b2bb541ef2eff913469 Reka, please add a /integrate comment. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/262 From hohensee at amazon.com Thu Aug 26 22:38:08 2021 From: hohensee at amazon.com (Hohensee, Paul) Date: Thu, 26 Aug 2021 22:38:08 +0000 Subject: CFV: New JDK Updates Reviewer: Roman Kennke Message-ID: <5B03B57F-898F-49C0-B488-0CF2A864E511@amazon.com> Vote: yes ?-----Original Message----- From: jdk-updates-dev on behalf of Aleksey Shipilev Date: Wednesday, August 25, 2021 at 1:45 AM To: "jdk-updates-dev at openjdk.java.net" Subject: CFV: New JDK Updates Reviewer: Roman Kennke I hereby nominate Roman Kennke (rkennke) to JDK Updates Project Reviewer. Roman is the long-time Reviewer in the JDK project. In addition to heavy involvement in mainline development work, Roman contributed a significant number of backports to 11u [1], including the very significant backport of Shenandoah GC [2]. These references and his engagement in the JDK Updates project justify the call to make him a JDK Updates Reviewer as well. Votes are due by Sep 9, 2021, 18:00 CET. Only current JDK Updates Reviewers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [4]. -- Thanks, -Aleksey [1] https://github.com/openjdk/jdk11u-dev/commits?author=rkennke [2] https://github.com/openjdk/jdk11u-dev/commit/20a0625da8558b0b15bbe9328983abe3341d75b0 [3] http://openjdk.java.net/census#jdk-updates [4] http://openjdk.java.net/projects/#reviewer-vote From phh at openjdk.java.net Thu Aug 26 22:40:27 2021 From: phh at openjdk.java.net (Paul Hohensee) Date: Thu, 26 Aug 2021 22:40:27 GMT Subject: [jdk11u-dev] RFR: 8248668: AArch64: Avoid MIN/MAX macros when using MSVC [v2] In-Reply-To: References: Message-ID: On Wed, 25 Aug 2021 16:02:20 GMT, Reka Kovacs wrote: >> Changes apply cleanly. Testing: tier1. >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 26680f0c1a998d41f87170b2d5a6487932ed33bb Reka, you need to add another /integrate comment in order for /sponsor to work. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/263 From tnakamura at openjdk.java.net Fri Aug 27 00:25:25 2021 From: tnakamura at openjdk.java.net (Toshio Nakamura) Date: Fri, 27 Aug 2021 00:25:25 GMT Subject: [jdk11u-dev] RFR: 8263490: [macos] Crash occurs on JPasswordField with activated InputMethod In-Reply-To: References: Message-ID: On Thu, 26 Aug 2021 07:45:04 GMT, Aleksey Shipilev wrote: >> Hi, >> >> Original patch almost applies cleanly to 11u. Only copyright year was adjusted. >> This crash issue with Input Method of GUI was observed with 11.0.12, and I'd like to backport it. >> >> Original bug: https://bugs.openjdk.java.net/browse/JDK-8263490 >> >> Testing: tier1, java/awt and javax/swing on macOS > > The patch looks fine. Thank you for the review, @shipilev Got the approval label. Can anyone sponsor this? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/295 From tnakamura at openjdk.java.net Fri Aug 27 06:20:24 2021 From: tnakamura at openjdk.java.net (Toshio Nakamura) Date: Fri, 27 Aug 2021 06:20:24 GMT Subject: [jdk11u-dev] Integrated: 8263490: [macos] Crash occurs on JPasswordField with activated InputMethod In-Reply-To: References: Message-ID: On Wed, 25 Aug 2021 02:44:05 GMT, Toshio Nakamura wrote: > Hi, > > Original patch almost applies cleanly to 11u. Only copyright year was adjusted. > This crash issue with Input Method of GUI was observed with 11.0.12, and I'd like to backport it. > > Original bug: https://bugs.openjdk.java.net/browse/JDK-8263490 > > Testing: tier1, java/awt and javax/swing on macOS This pull request has now been integrated. Changeset: 45ed9e80 Author: Toshio Nakamura Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/45ed9e8052d3ad5bddc947f5556acee31cb6b533 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8263490: [macos] Crash occurs on JPasswordField with activated InputMethod Reviewed-by: shade Backport-of: 32c7fcc67010e44411918cc73681422fd8b7a67a ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/295 From clanger at openjdk.java.net Fri Aug 27 06:24:25 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 27 Aug 2021 06:24:25 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build In-Reply-To: References: Message-ID: On Mon, 23 Aug 2021 15:43:20 GMT, Reka Kovacs wrote: > Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: > > - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. > - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. > - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). > - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. > - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) > > This is part of the Windows/AArch64 port. @rnkovacs can you update this PR as well to resolve the merge conflicts? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From clanger at openjdk.java.net Fri Aug 27 10:30:30 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 27 Aug 2021 10:30:30 GMT Subject: [jdk11u-dev] Integrated: 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received" In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 13:21:42 GMT, Christoph Langer wrote: > Hi all, > > this pull request contains a backport of JDK-8199931 from the openjdk/jdk repository. > > The commit being backported was authored by Chris Yin on 21 Sep 2018 and was reviewed by Chris Hegarty. > > Thanks! This pull request has now been integrated. Changeset: 069b4cc0 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/069b4cc08c327a5e977a2700e133f0d05261dd24 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received" Backport-of: f367eb89657e69989c15463fd4195d6869c132f5 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/286 From clanger at openjdk.java.net Fri Aug 27 10:31:24 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 27 Aug 2021 10:31:24 GMT Subject: [jdk11u-dev] Integrated: 8169246: java/net/DatagramSocket/ReportSocketClosed.java fails intermittently with BindException In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 13:22:11 GMT, Christoph Langer wrote: > Hi all, > > this pull request contains a backport of JDK-8169246 from the openjdk/jdk repository. > > The commit being backported was authored by Chris Yin on 21 Sep 2018 and was reviewed by Chris Hegarty. > > Thanks! This pull request has now been integrated. Changeset: 7100a652 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/7100a6529c1735a3fd618af29a6c5cd0ff573bf9 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8169246: java/net/DatagramSocket/ReportSocketClosed.java fails intermittently with BindException Backport-of: 33c9c89bf0166c21600b9aa8beb84c019ff1e03d ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/287 From clanger at openjdk.java.net Fri Aug 27 10:32:26 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 27 Aug 2021 10:32:26 GMT Subject: [jdk11u-dev] RFR: 8211325: test/jdk/java/net/Socket/LingerTest.java fails with cleaning up In-Reply-To: <6gVT4UWVf3Lc7PKPT2aeaP9aGV5TsFBbry6ztRE_AiM=.cf8c1f8a-0b3d-4bfb-b41a-8d1e484dac6b@github.com> References: <6gVT4UWVf3Lc7PKPT2aeaP9aGV5TsFBbry6ztRE_AiM=.cf8c1f8a-0b3d-4bfb-b41a-8d1e484dac6b@github.com> Message-ID: <_5LhPE5jkiFhwaigJ4jlZGKIy60_dA8nkKnV29q0Fek=.e2ac4616-867f-4dfb-80e7-1c8e04923223@github.com> On Tue, 24 Aug 2021 20:07:20 GMT, Christoph Langer wrote: > Clean backport of 8211325. The change to the problem list doesn't apply though, because the removed exclusion didn't exist in 11. Thanks for the review. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/293 From clanger at openjdk.java.net Fri Aug 27 10:32:26 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 27 Aug 2021 10:32:26 GMT Subject: [jdk11u-dev] Integrated: 8211325: test/jdk/java/net/Socket/LingerTest.java fails with cleaning up In-Reply-To: <6gVT4UWVf3Lc7PKPT2aeaP9aGV5TsFBbry6ztRE_AiM=.cf8c1f8a-0b3d-4bfb-b41a-8d1e484dac6b@github.com> References: <6gVT4UWVf3Lc7PKPT2aeaP9aGV5TsFBbry6ztRE_AiM=.cf8c1f8a-0b3d-4bfb-b41a-8d1e484dac6b@github.com> Message-ID: On Tue, 24 Aug 2021 20:07:20 GMT, Christoph Langer wrote: > Clean backport of 8211325. The change to the problem list doesn't apply though, because the removed exclusion didn't exist in 11. This pull request has now been integrated. Changeset: e5ec6797 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/e5ec6797e9a9d16fbc789b383c729b0747c58967 Stats: 22 lines in 1 file changed: 7 ins; 0 del; 15 mod 8211325: test/jdk/java/net/Socket/LingerTest.java fails with cleaning up Reviewed-by: shade Backport-of: 0cb267ad1c099d90267f764ade91b16f139a0aa7 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/293 From clanger at openjdk.java.net Fri Aug 27 11:05:28 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 27 Aug 2021 11:05:28 GMT Subject: [jdk11u-dev] Integrated: 8212695: Add explicit timeout to several HTTP Client tests In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 20:15:26 GMT, Christoph Langer wrote: > Backport of JDK-8212695. I had to make adjustments because JDK-8222527 was already backported. This pull request has now been integrated. Changeset: 5792854d Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/5792854d7d1aceff66108bbd6777b5eb6efec3c0 Stats: 27 lines in 2 files changed: 12 ins; 0 del; 15 mod 8212695: Add explicit timeout to several HTTP Client tests Reviewed-by: shade Backport-of: cea4eef60aadf7dceb1fa857722faa8b17c810ae ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/294 From clanger at openjdk.java.net Fri Aug 27 12:18:25 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 27 Aug 2021 12:18:25 GMT Subject: [jdk11u-dev] Integrated: 8212718: Refactor some annotation processor tests to better use collections In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 16:56:56 GMT, Christoph Langer wrote: > Hi all, > > this pull request contains a backport of JDK-8212718 from the openjdk/jdk repository. > > The commit being backported was authored by Joe Darcy on 23 Oct 2018 and was reviewed by Jim Laskey and Vicente Romero. > > Thanks! This pull request has now been integrated. Changeset: 910e24b2 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/910e24b23205b680c6367785528bfd7d79311ac8 Stats: 24 lines in 2 files changed: 2 ins; 11 del; 11 mod 8212718: Refactor some annotation processor tests to better use collections Backport-of: 34397c4914925b990a5d74a238b01bb05d5b7c44 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/291 From clanger at openjdk.java.net Fri Aug 27 12:24:54 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 27 Aug 2021 12:24:54 GMT Subject: [jdk17u] RFR: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags Message-ID: <7KpWXz4o6h8UcuO3yKYeKvNDSvHlIkUk0t7DcnkyeSE=.6c26bffa-1688-413a-b823-0620646cdcfe@github.com> Hi all, this pull request contains a backport of JDK-8269993 from the openjdk/jdk repository. The commit being backported was authored by Thejasvi Voniadka on 8 Jul 2021 and was reviewed by Daniel Fuchs and Vyom Tewari. Thanks! ------------- Commit messages: - Backport 4e18ec26ddfa0b44e8780ebd556a5e8aa2e90dc0 Changes: https://git.openjdk.java.net/jdk17u/pull/44/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=44&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269993 Stats: 6 lines in 1 file changed: 0 ins; 6 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u/pull/44.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/44/head:pull/44 PR: https://git.openjdk.java.net/jdk17u/pull/44 From clanger at openjdk.java.net Fri Aug 27 12:27:26 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 27 Aug 2021 12:27:26 GMT Subject: [jdk11u-dev] Integrated: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration In-Reply-To: <-E9H960xOzBqy_rtO0S06MI9ex8yRVjcO1Ich1V36dI=.e2a38079-ccf9-4309-9c99-74ce2c6dd341@github.com> References: <-E9H960xOzBqy_rtO0S06MI9ex8yRVjcO1Ich1V36dI=.e2a38079-ccf9-4309-9c99-74ce2c6dd341@github.com> Message-ID: On Wed, 25 Aug 2021 08:39:03 GMT, Christoph Langer wrote: > Unclean backport of JDK-8241336. We seem to have a new Mac configuration in our test landscape that exhibits these failures in JDK11, too. > > Changes to problem list do not apply. > Promiscious.java needs an "@library /test/lib" annotation because JDK-8220673 was not backported. > AdaptorMulticasting.java does not exist in 11 This pull request has now been integrated. Changeset: c816276e Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/c816276ee6834332bece428e77583b6e1d80b20b Stats: 104 lines in 3 files changed: 66 ins; 6 del; 32 mod 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration NetworkConfiguration updated to skip interfaces that have only IPv6 link local addresses. Reviewed-by: shade Backport-of: 5ddbcb7a515e29d805df17ca2977eeb720adef29 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/296 From clanger at openjdk.java.net Fri Aug 27 12:31:37 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 27 Aug 2021 12:31:37 GMT Subject: [jdk11u-dev] RFR: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags Message-ID: Clean backport of JDK-8269993. ------------- Commit messages: - Backport 4e18ec26ddfa0b44e8780ebd556a5e8aa2e90dc0 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/298/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=298&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269993 Stats: 6 lines in 1 file changed: 0 ins; 6 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/298.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/298/head:pull/298 PR: https://git.openjdk.java.net/jdk11u-dev/pull/298 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 27 16:20:29 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 27 Aug 2021 16:20:29 GMT Subject: [jdk11u-dev] RFR: 8248666: AArch64: Use THREAD_LOCAL instead of __thread [v2] In-Reply-To: References: Message-ID: <8f6KOBdaqtXMyxNkJ3RqITJqb0BTfDHfjpJiEN53kDo=.1762229a-80a6-4da8-bd23-33ea2226bfba@github.com> On Wed, 25 Aug 2021 16:03:48 GMT, Reka Kovacs wrote: >> Not a clean backport. Original patch used a macro called THREAD_LOCAL, this backport uses THREAD_LOCAL_DECL. THREAD_LOCAL_DECL was renamed to THREAD_LOCAL by [JDK-8230877](https://bugs.openjdk.java.net/browse/JDK-8230877) in JDK 14. Testing: tier1. >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 2f8653fbf0f4ed2ab0e40b2bb541ef2eff913469 Sorry for the delay - thank you! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/262 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 27 16:21:28 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 27 Aug 2021 16:21:28 GMT Subject: [jdk11u-dev] RFR: 8248668: AArch64: Avoid MIN/MAX macros when using MSVC [v2] In-Reply-To: References: Message-ID: On Wed, 25 Aug 2021 16:02:20 GMT, Reka Kovacs wrote: >> Changes apply cleanly. Testing: tier1. >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 26680f0c1a998d41f87170b2d5a6487932ed33bb Thank you, Paul. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/263 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 27 16:50:41 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 27 Aug 2021 16:50:41 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v2] In-Reply-To: References: Message-ID: > Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: > > - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. > - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. > - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). > - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. > - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) > > This is part of the Windows/AArch64 port. Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport d2812f780e87511736f2d41bc57a69c2a898b583 ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/280/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=280&range=01 Stats: 29 lines in 10 files changed: 4 ins; 5 del; 20 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/280.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/280/head:pull/280 PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 27 16:50:41 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 27 Aug 2021 16:50:41 GMT Subject: [jdk11u-dev] RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build In-Reply-To: References: Message-ID: On Mon, 23 Aug 2021 15:43:20 GMT, Reka Kovacs wrote: > Despite its title, this patch only touches common code that's present before adding Windows/AArch64 support. Not a clean backport. Differences to the original commit: > > - This is the first time we disable an MSVC warning for hotspot in 11, so in `make/hotspot/lib/CompileJvm.gmk` this introduces a new `DISABLED_WARNINGS_microsoft` line. > - We disable the same warning in `make/hotspot/lib/CompileGtest.gmk`. > - A tiny useless switch is removed from `src/hotspot/cpu/aarch64/aarch64.ad` that's no longer present on tip (probably not worth a separate PR). > - Changes to `src/hotspot/cpu/aarch64/frame_aarch64.cpp` don't yet include the changes from #215. > - The assert on line 1477 in `src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp` needed some adjustment to compile. (I'm not sure how it compiles on tip, as I don't see `-Wsign-compare` turned off there either, but the types seem to be the same.) > > This is part of the Windows/AArch64 port. I did, thanks. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/280 From vladimir.kozlov at oracle.com Fri Aug 27 17:40:51 2021 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Fri, 27 Aug 2021 10:40:51 -0700 Subject: CFV: New JDK Updates Reviewer: Roman Kennke In-Reply-To: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> References: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> Message-ID: Vote: yes Thanks, Vladimir K On 8/25/21 1:44 AM, Aleksey Shipilev wrote: > I hereby nominate Roman Kennke (rkennke) to JDK Updates Project Reviewer. > > Roman is the long-time Reviewer in the JDK project. In addition to heavy involvement in mainline development work, Roman > contributed a significant number of backports to 11u [1], including the very significant backport of Shenandoah GC [2]. > > These references and his engagement in the JDK Updates project justify the call to make him a JDK > Updates Reviewer as well. > > Votes are due by Sep 9, 2021, 18:00 CET. > > Only current JDK Updates Reviewers [3] are eligible to vote on this nomination. Votes must be cast in the open by > replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 27 18:24:34 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 27 Aug 2021 18:24:34 GMT Subject: [jdk11u-dev] Integrated: 8248666: AArch64: Use THREAD_LOCAL instead of __thread In-Reply-To: References: Message-ID: On Fri, 20 Aug 2021 06:28:24 GMT, Reka Kovacs wrote: > Not a clean backport. Original patch used a macro called THREAD_LOCAL, this backport uses THREAD_LOCAL_DECL. THREAD_LOCAL_DECL was renamed to THREAD_LOCAL by [JDK-8230877](https://bugs.openjdk.java.net/browse/JDK-8230877) in JDK 14. Testing: tier1. > > This is part of the Windows/AArch64 port. This pull request has now been integrated. Changeset: 97192705 Author: Reka Kovacs Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/97192705f2aa49e04e5bc1cf64936fb005466e30 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8248666: AArch64: Use THREAD_LOCAL instead of __thread __thread is gcc-ism, instead rely on compiler independent macro. Co-authored-by: Bernhard Urban-Forster Reviewed-by: phh, clanger Backport-of: 2f8653fbf0f4ed2ab0e40b2bb541ef2eff913469 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/262 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 27 18:30:29 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 27 Aug 2021 18:30:29 GMT Subject: [jdk11u-dev] Integrated: 8248668: AArch64: Avoid MIN/MAX macros when using MSVC In-Reply-To: References: Message-ID: <2taqLpFaj4Q3qAozAc-rIqYbzqMGssbaaVX_4T8d8-8=.1825916b-54f4-4b88-a8b4-d091982e7611@github.com> On Fri, 20 Aug 2021 06:52:08 GMT, Reka Kovacs wrote: > Changes apply cleanly. Testing: tier1. > > This is part of the Windows/AArch64 port. This pull request has now been integrated. Changeset: 63fc945c Author: Reka Kovacs Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/63fc945c1d4cdc893d89796804acfe0ce9341860 Stats: 5 lines in 3 files changed: 0 ins; 0 del; 5 mod 8248668: AArch64: Avoid MIN/MAX macros when using MSVC MSVC employs min/max as macros Co-authored-by: Monica Beckwith Co-authored-by: Ludovic Henry Co-authored-by: Bernhard Urban-Forster Backport-of: 26680f0c1a998d41f87170b2d5a6487932ed33bb ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/263 From github.com+25946952+rnkovacs at openjdk.java.net Fri Aug 27 20:50:39 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Fri, 27 Aug 2021 20:50:39 GMT Subject: [jdk11u-dev] RFR: 8253015: Aarch64: Move linux code out from generic CPU feature detection Message-ID: Not a clean backport. Differences to the original commit: - Changes to files under `src/hotspot/cpu/aarch64/` and `src/hotspot/os_cpu/linux_aarch64/` are adjusted to cover hardware features supported in JDK 11. - As JDK 11 is built using an older C++ standard than tip, `static_assert`s need to be replaced with `STATIC_ASSERT` macros in `vm_version_linux_aarch64.cpp`. - The GraalVM related changes in `vmStructs_jvmci.cpp`, `AArch64HotSpotLIRGenerator.java` and `GraalHotSpotVMConfig.java` are skipped as they seem to be modifying code added in JDK 14 ([JDK-8226222](https://bugs.openjdk.java.net/browse/JDK-8226222) and [JDK-8231973](https://bugs.openjdk.java.net/browse/JDK-8229201)). This is part of the Windows/AArch64 port. ------------- Commit messages: - Backport ec9bee68660acd6abf0b4dd4023ae69514542256 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/299/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=299&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253015 Stats: 255 lines in 3 files changed: 99 ins; 124 del; 32 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/299.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/299/head:pull/299 PR: https://git.openjdk.java.net/jdk11u-dev/pull/299 From clanger at openjdk.java.net Fri Aug 27 20:56:25 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 27 Aug 2021 20:56:25 GMT Subject: [jdk11u-dev] RFR: 8215624: Add parallel heap iteration for jmap =?UTF-8?B?4oCTaGlzdG8=?= [v2] In-Reply-To: <_1AvUpPWKQAutI-_lS2cqLLD5EQyB_72ECPi3hNpJIQ=.4c94f43d-cb8e-4a3b-b249-5225b9c5dfd8@github.com> References: <_1AvUpPWKQAutI-_lS2cqLLD5EQyB_72ECPi3hNpJIQ=.4c94f43d-cb8e-4a3b-b249-5225b9c5dfd8@github.com> Message-ID: On Tue, 24 Aug 2021 03:05:01 GMT, Bin Liao wrote: >> Unclean backport, since original patch does not apply cleanly to 11u, because jmap command parameter is different between each other, and the code structure has little changed. >> >> 8215624: Add parallel heap iteration for jmap -histo >> 8253763: ParallelObjectIterator should have virtual destructor > > Bin Liao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into parallel_heap_iter > - 8266352: Add parallel heap iteration for jmap -histo > > 8215624: Add parallel heap iteration for jmap histo > 8253763: ParallelObjectIterator should have virtual destructor I've added both backports to our regression test queue now. Will try to review the changes some time next week. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/127 From clanger at openjdk.java.net Fri Aug 27 21:25:27 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 27 Aug 2021 21:25:27 GMT Subject: [jdk11u-dev] RFR: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead [v3] In-Reply-To: References: Message-ID: On Thu, 5 Aug 2021 19:32:03 GMT, Martin Doerr wrote: >> Backport of JDK-7179006. CPrinterJob.m parts don't apply cleanly because JNF removal is already backported. Included tests have passed on M1 with Rosetta (x86_64 build). >> >> Note that the manual test from JDK-8211055 "TestSaveFileWithoutPrinter.java" does no longer pass with this change. Let's break it for parity with 11.0.13-oracle :-) >> (That one seems to be unsupported even with JDK17.) > > Martin Doerr has updated the pull request incrementally with one additional commit since the last revision: > > Add JNFJavaToNSString replacement and CHECK_EXCEPTION. Changes look good to me. The issue with TestSaveFileWithoutPrinter seems to have been reported with JDK-8272469 and there's no fix yet for it, even in head. So I think this one is good to go. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/197 From thomas.stuefe at gmail.com Sat Aug 28 06:47:46 2021 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Sat, 28 Aug 2021 08:47:46 +0200 Subject: CFV: New JDK Updates Reviewer: Roman Kennke In-Reply-To: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> References: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> Message-ID: Vote: yes On Wed, Aug 25, 2021 at 10:45 AM Aleksey Shipilev wrote: > I hereby nominate Roman Kennke (rkennke) to JDK Updates Project Reviewer. > > Roman is the long-time Reviewer in the JDK project. In addition to heavy > involvement in mainline > development work, Roman contributed a significant number of backports to > 11u [1], including the very > significant backport of Shenandoah GC [2]. > > These references and his engagement in the JDK Updates project justify the > call to make him a JDK > Updates Reviewer as well. > > Votes are due by Sep 9, 2021, 18:00 CET. > > Only current JDK Updates Reviewers [3] are eligible to vote on this > nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > -- > Thanks, > -Aleksey > > [1] https://github.com/openjdk/jdk11u-dev/commits?author=rkennke > [2] > https://github.com/openjdk/jdk11u-dev/commit/20a0625da8558b0b15bbe9328983abe3341d75b0 > [3] http://openjdk.java.net/census#jdk-updates > [4] http://openjdk.java.net/projects/#reviewer-vote > > From clanger at openjdk.java.net Sun Aug 29 07:30:16 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Sun, 29 Aug 2021 07:30:16 GMT Subject: [jdk17u] Integrated: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags In-Reply-To: <7KpWXz4o6h8UcuO3yKYeKvNDSvHlIkUk0t7DcnkyeSE=.6c26bffa-1688-413a-b823-0620646cdcfe@github.com> References: <7KpWXz4o6h8UcuO3yKYeKvNDSvHlIkUk0t7DcnkyeSE=.6c26bffa-1688-413a-b823-0620646cdcfe@github.com> Message-ID: <_yvAqYx0F22JeXMGSu5S7Zgv27tK0F18SPUxS1WJQp8=.0059dd96-2b5f-4451-bff9-3027a58f4924@github.com> On Fri, 27 Aug 2021 12:17:55 GMT, Christoph Langer wrote: > Hi all, > > this pull request contains a backport of JDK-8269993 from the openjdk/jdk repository. > > The commit being backported was authored by Thejasvi Voniadka on 8 Jul 2021 and was reviewed by Daniel Fuchs and Vyom Tewari. > > Thanks! This pull request has now been integrated. Changeset: 5e04e452 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk17u/commit/5e04e452714742ee5cbc6e922695db9d7d56da92 Stats: 6 lines in 1 file changed: 0 ins; 6 del; 0 mod 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags Backport-of: 4e18ec26ddfa0b44e8780ebd556a5e8aa2e90dc0 ------------- PR: https://git.openjdk.java.net/jdk17u/pull/44 From alexander.zvegintsev at oracle.com Sun Aug 29 10:59:22 2021 From: alexander.zvegintsev at oracle.com (alexander.zvegintsev at oracle.com) Date: Sun, 29 Aug 2021 12:59:22 +0200 Subject: CFV: New JDK Updates Reviewer: Roman Kennke In-Reply-To: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> References: <2c306d86-b0ad-fb77-5d88-d49d7427236f@redhat.com> Message-ID: <90d51113-6315-674d-2929-14c5b54ea677@oracle.com> Vote: yes Thanks, Alexander. On 25/08/2021 10:44, Aleksey Shipilev wrote: > I hereby nominate Roman Kennke (rkennke) to JDK Updates Project Reviewer. > > Roman is the long-time Reviewer in the JDK project. In addition to > heavy involvement in mainline development work, Roman contributed a > significant number of backports to 11u [1], including the very > significant backport of Shenandoah GC [2]. > > These references and his engagement in the JDK Updates project justify > the call to make him a JDK > Updates Reviewer as well. > > Votes are due by Sep 9, 2021, 18:00 CET. > > Only current JDK Updates Reviewers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [4]. > From github.com+25946952+rnkovacs at openjdk.java.net Sun Aug 29 19:14:57 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Sun, 29 Aug 2021 19:14:57 GMT Subject: [jdk11u-dev] RFR: 8248817: Windows: Improving common cross-platform code Message-ID: Not a clean backport. Differences to the original commit: - The removed lines in `stubGenerator_x86_32.cpp` and `stubGenerator_x86_64.cpp` are slightly different on tip (comments - [JDK-8234563](https://bugs.openjdk.java.net/browse/JDK-8234563), MP checks - [JDK-8188764](https://bugs.openjdk.java.net/browse/JDK-8188764)), but fundamentally the same. - Changes to `add`, `xchg` and `cmpxchg` definitions in `atomic_windows_x86.hpp` needed to be adjusted to keep the original parameter orders (changed in JDK 14 by [JDK-8234563](https://bugs.openjdk.java.net/browse/JDK-8234563)). Changes to `os_windows_x86.cpp` and `os_windows_x86.hpp` could be applied cleanly. This is part of the Windows/AArch64 port. ------------- Commit messages: - Backport 257809d7440e87ac595d03b6c9a98d8f457f314c Changes: https://git.openjdk.java.net/jdk11u-dev/pull/300/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=300&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8248817 Stats: 512 lines in 5 files changed: 5 ins; 450 del; 57 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/300.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/300/head:pull/300 PR: https://git.openjdk.java.net/jdk11u-dev/pull/300 From github.com+25946952+rnkovacs at openjdk.java.net Sun Aug 29 20:39:39 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Sun, 29 Aug 2021 20:39:39 GMT Subject: [jdk11u-dev] RFR: 8250810: Push missing parts of JDK-8248817 [v2] In-Reply-To: <5rQ17hdgRiagcdC76vWlrx6oEEFuTtr94tvxWPPBdfs=.e750270f-2a2d-4906-a3e2-a8151d29fcca@github.com> References: <5rQ17hdgRiagcdC76vWlrx6oEEFuTtr94tvxWPPBdfs=.e750270f-2a2d-4906-a3e2-a8151d29fcca@github.com> Message-ID: <4WuMpKaoPK_pWoPLv_22lHsdbYaTeHPBV1kT8qw_2Rc=.e0caebca-2821-43b9-998e-b30b6723a3f0@github.com> > This is a refactoring patch with no functional change. It didn't apply cleanly. Differences to the original commit: > > In `thread_windows_x86.cpp`: > - Some removed lines were simpler on tip because of [JDK-8248240](https://github.com/openjdk/jdk/commit/a6e794b3e85d28537bf740d9d7e68339707d38e1#diff-d4111d540c34b1e0f4acac1e92877ce458b29d70126ccb113b439261a503ed95). > > In `os_windows.cpp`: > - The block around L2461 is no longer present on tip, that and a bit of the next block can be simplified. > - The conditions on L2539 ([JDK-8234372](https://github.com/openjdk/jdk/commit/4e4d1f2b4dad61b4c4590f1d3a956b9ad86ff74c#diff-84938e7dfe64805a850b8a729495117a972a474622fff12bb97ee45cbc2184f2)) and L2549 ([JDK-8213199](https://github.com/openjdk/jdk/commit/7c3f2b06f13e3d28b74193d8acac4478e8c12bdb#diff-84938e7dfe64805a850b8a729495117a972a474622fff12bb97ee45cbc2184f2)) (original line numbers) are different on tip. We actually didn't touch those, they only show up colored in the diff because of the whitespace changes. > - The surrounding code is different around L2586 because of [JDK-8191278](https://github.com/openjdk/jdk/commit/aedbb7580334cb9131f547845f9b7aa3916ddf4b#diff-84938e7dfe64805a850b8a729495117a972a474622fff12bb97ee45cbc2184f2), but the changes are the same. Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport a4eaf9536c272862b5ec856bf263679be09bddc9 ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/274/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=274&range=01 Stats: 76 lines in 2 files changed: 6 ins; 33 del; 37 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/274.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/274/head:pull/274 PR: https://git.openjdk.java.net/jdk11u-dev/pull/274 From github.com+25946952+rnkovacs at openjdk.java.net Mon Aug 30 05:49:38 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 30 Aug 2021 05:49:38 GMT Subject: [jdk11u-dev] RFR: 8253015: Aarch64: Move linux code out from generic CPU feature detection [v2] In-Reply-To: References: Message-ID: > Not a clean backport. Differences to the original commit: > > - Changes to files under `src/hotspot/cpu/aarch64/` and `src/hotspot/os_cpu/linux_aarch64/` are adjusted to cover hardware features supported in JDK 11. > - As JDK 11 is built using an older C++ standard than tip, `static_assert`s need to be replaced with `STATIC_ASSERT` macros in `vm_version_linux_aarch64.cpp`. > - The GraalVM related changes in `vmStructs_jvmci.cpp`, `AArch64HotSpotLIRGenerator.java` and `GraalHotSpotVMConfig.java` are skipped as they seem to be modifying code added in JDK 14 ([JDK-8226222](https://bugs.openjdk.java.net/browse/JDK-8226222) and [JDK-8231973](https://bugs.openjdk.java.net/browse/JDK-8229201)). > > This is part of the Windows/AArch64 port. Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Backport ec9bee68660acd6abf0b4dd4023ae69514542256 - Backport a4eaf9536c272862b5ec856bf263679be09bddc9 ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/299/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=299&range=01 Stats: 331 lines in 5 files changed: 105 ins; 157 del; 69 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/299.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/299/head:pull/299 PR: https://git.openjdk.java.net/jdk11u-dev/pull/299 From yan at openjdk.java.net Mon Aug 30 08:02:50 2021 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Mon, 30 Aug 2021 08:02:50 GMT Subject: [jdk15u-dev] RFR: 8264848: [macos] libjvm.dylib linker warning due to macOS version mismatch In-Reply-To: References: Message-ID: On Thu, 26 Aug 2021 16:00:18 GMT, Vladimir Kempik wrote: > Clean backport to jdk15u How about JDK-8272700 here? ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/92 From github.com+25946952+rnkovacs at openjdk.java.net Mon Aug 30 08:36:03 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 30 Aug 2021 08:36:03 GMT Subject: [jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support Message-ID: Main commit of the Windows/AArch64 port. Depends on #274 and #299. ------------- Commit messages: - Backport 9604ee82690f89320614b37bfef4178abc869777 - Backport ec9bee68660acd6abf0b4dd4023ae69514542256 - Backport a4eaf9536c272862b5ec856bf263679be09bddc9 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/301/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=301&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8248238 Stats: 4025 lines in 64 files changed: 2371 ins; 276 del; 1378 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/301.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/301/head:pull/301 PR: https://git.openjdk.java.net/jdk11u-dev/pull/301 From clanger at openjdk.java.net Mon Aug 30 09:02:25 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 30 Aug 2021 09:02:25 GMT Subject: [jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: References: Message-ID: On Mon, 30 Aug 2021 08:06:36 GMT, Reka Kovacs wrote: > Main commit of the Windows/AArch64 port. > > Also fixes [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) by adding [`src/hotspot/os_cpu/windows_aarch64/pauth_windows_aarch64.inline.hpp`](https://github.com/openjdk/jdk11u-dev/pull/301/files#diff-235302dc4618158c4f75771ebbb6f0e4beeee5daf0a537b03ee4253a711268c6), which is needed for a successful Windows-AArch64 build. > > Depends on #274 and #299. Hi @rnkovacs, can you split these into separate, dependent Pull requests? E.g. #274 as first in the row. Then, open another PR in favor of #299 that has branch pr/274 as target. And then the 3 commits included in this one also as separate PRs, targeting the appropriate predecessor PR? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/301 From github.com+25946952+rnkovacs at openjdk.java.net Mon Aug 30 09:07:27 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 30 Aug 2021 09:07:27 GMT Subject: [jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: References: Message-ID: <9joHLIEKqCHjE9wNmigNEBr7HojKrRUNvFKxuCYKlrc=.5cda0ea4-b8c2-49cc-896d-fc806550215e@github.com> On Mon, 30 Aug 2021 09:00:08 GMT, Christoph Langer wrote: >> Main commit of the Windows/AArch64 port. >> >> Also fixes [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) by adding [`src/hotspot/os_cpu/windows_aarch64/pauth_windows_aarch64.inline.hpp`](https://github.com/openjdk/jdk11u-dev/pull/301/files#diff-235302dc4618158c4f75771ebbb6f0e4beeee5daf0a537b03ee4253a711268c6), which is needed for a successful Windows-AArch64 build. >> >> Depends on #274 and #299. > > Hi @rnkovacs, can you split these into separate, dependent Pull requests? > E.g. #274 as first in the row. Then, open another PR in favor of #299 that has branch pr/274 as target. And then the 3 commits included in this one also as separate PRs, targeting the appropriate predecessor PR? Hi @RealCLanger, I attempted to do that but apparently failed - I forgot to change the target branch. Do I need to close #299 and this one and open completely new PRs? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/301 From github.com+25946952+rnkovacs at openjdk.java.net Mon Aug 30 09:17:10 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 30 Aug 2021 09:17:10 GMT Subject: [jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v2] In-Reply-To: References: Message-ID: <1wlbThUtxZ5it15217NicVN5ALV4KexxYwY6Ciq2nbM=.2ea2e1b7-0d3c-4112-a9d7-20cdcebc8c27@github.com> > Main commit of the Windows/AArch64 port. > > Also fixes [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) by adding [`src/hotspot/os_cpu/windows_aarch64/pauth_windows_aarch64.inline.hpp`](https://github.com/openjdk/jdk11u-dev/pull/301/files#diff-235302dc4618158c4f75771ebbb6f0e4beeee5daf0a537b03ee4253a711268c6), which is needed for a successful Windows-AArch64 build. > > Depends on #274 and #299. Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/301/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/301/files/4f530dd9..4f530dd9 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=301&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=301&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/301.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/301/head:pull/301 PR: https://git.openjdk.java.net/jdk11u-dev/pull/301 From github.com+25946952+rnkovacs at openjdk.java.net Mon Aug 30 09:17:10 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 30 Aug 2021 09:17:10 GMT Subject: [jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: References: Message-ID: On Mon, 30 Aug 2021 08:06:36 GMT, Reka Kovacs wrote: > Main commit of the Windows/AArch64 port. > > Also fixes [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) by adding [`src/hotspot/os_cpu/windows_aarch64/pauth_windows_aarch64.inline.hpp`](https://github.com/openjdk/jdk11u-dev/pull/301/files#diff-235302dc4618158c4f75771ebbb6f0e4beeee5daf0a537b03ee4253a711268c6), which is needed for a successful Windows-AArch64 build. > > Depends on #274 and #299. Seems like I could do the change on the GUI. Could you please check if it's correct now? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/301 From clanger at openjdk.java.net Mon Aug 30 09:27:30 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 30 Aug 2021 09:27:30 GMT Subject: [jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: References: Message-ID: On Mon, 30 Aug 2021 09:11:49 GMT, Reka Kovacs wrote: > Seems like I could do the change on the GUI. Could you please check if it's correct now? Yes, I think this looks good now, thanks. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/301 From github.com+25946952+rnkovacs at openjdk.java.net Mon Aug 30 09:27:29 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 30 Aug 2021 09:27:29 GMT Subject: [jdk11u-dev] RFR: JDK-8253947: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: <5muM-4NZ2lDqig_Ad-ZP5nooARMvps_MhKBkR0j39mU=.9565dbd4-e2a7-4b5d-99ef-3f070c3f7705@github.com> References: <5muM-4NZ2lDqig_Ad-ZP5nooARMvps_MhKBkR0j39mU=.9565dbd4-e2a7-4b5d-99ef-3f070c3f7705@github.com> Message-ID: On Mon, 23 Aug 2021 22:28:06 GMT, Christoph Langer wrote: >> This is a more recent version of https://github.com/openjdk/jdk11u/pull/2. >> >> Changes since then: >> - [JDK-8254634](https://bugs.openjdk.java.net/browse/JDK-8254634) (backport of [Build failure with VS 2019 (16.5.0) due to C2039 and C2873](https://bugs.openjdk.java.net/browse/JDK-8241087)) was removed, as it had been committed separately. >> - [JDK-8269391](https://bugs.openjdk.java.net/browse/JDK-8269391) (backport of [AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter](https://bugs.openjdk.java.net/browse/JDK-8265756)) was added. >> - [JDK-8271095](https://bugs.openjdk.java.net/browse/JDK-8271095) (backport of [C4530 was reported from VS 2019 at access bridge](https://bugs.openjdk.java.net/browse/JDK-8263136)) was added. >> - [JDK-8271002](https://bugs.openjdk.java.net/browse/JDK-8271002) (backport of [AArch64: Fix MacroAssembler::get_thread convention](https://bugs.openjdk.java.net/browse/JDK-8261072)) was added. >> - [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) was added, containing the Windows/AArch64 related part of [JDK-8271571](https://bugs.openjdk.java.net/browse/JDK-8271571) (backport of [AArch64: Backtracing broken on PAC enabled systems](https://bugs.openjdk.java.net/browse/JDK-8266749)), necessary for a correct build. >> - Various small merge conflict resolutions. >> >> Similarly to how it was done on tip, we have incorporated parts of [JDK-8253015: Aarch64: Move linux code out from generic CPU feature detection](https://bugs.openjdk.java.net/browse/JDK-8253015) by @AntonKozlov into the [JDK-8253947: Implementation: JEP 388: Windows AArch64 Support](https://bugs.openjdk.java.net/browse/JDK-8253947) commit. >> >> Please let me know how I can make the review process easier / faster. > > Hi, > I have a suggestion: For this series of backports you can use dependent PRs. That is, you create a standard PR for the first change. Then, create the next backport to the branch "pr/#" which will appear in the repo after the first PR is opened. This way, the whole chain is based upon each other and can be reviewed in parallel. > > You have to integrate the PRs in order then. Once a PR is merged, its successor will automatically be updated to target the master branch. @RealCLanger thanks for the suggestion. I'm opening a chain of PRs for the last few commits in the following order: #274 - #299 - #301 - 8254827 - 8252114. I liked the simplicity of most of the PRs going in independently, but now in the end chaining makes a lot of sense. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/222 From akozlov at openjdk.java.net Mon Aug 30 11:03:26 2021 From: akozlov at openjdk.java.net (Anton Kozlov) Date: Mon, 30 Aug 2021 11:03:26 GMT Subject: [jdk11u-dev] RFR: 8253015: Aarch64: Move linux code out from generic CPU feature detection [v2] In-Reply-To: References: Message-ID: On Mon, 30 Aug 2021 05:49:38 GMT, Reka Kovacs wrote: >> Not a clean backport. Differences to the original commit: >> >> - Changes to files under `src/hotspot/cpu/aarch64/` and `src/hotspot/os_cpu/linux_aarch64/` are adjusted to cover hardware features supported in JDK 11. >> - As JDK 11 is built using an older C++ standard than tip, `static_assert`s need to be replaced with `STATIC_ASSERT` macros in `vm_version_linux_aarch64.cpp`. >> - The GraalVM related changes in `vmStructs_jvmci.cpp`, `AArch64HotSpotLIRGenerator.java` and `GraalHotSpotVMConfig.java` are skipped as they seem to be modifying code added in JDK 14 ([JDK-8226222](https://bugs.openjdk.java.net/browse/JDK-8226222) and [JDK-8231973](https://bugs.openjdk.java.net/browse/JDK-8229201)). >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Backport ec9bee68660acd6abf0b4dd4023ae69514542256 > - Backport a4eaf9536c272862b5ec856bf263679be09bddc9 Thanks for taking care of this. Original change introduced two regressions which were fixed in: * JDK-8255975: Fix AArch64 OpenJDK build failure with gcc-5 -- but it is not a problem for this change, since `STATIC_ASSERT` is used * JDK-8255716: AArch64: Regression: JVM crashes if manually offline a core -- this is still a problem for this backport I'm not sure is it better to backport JDK-8255716 separately or, considering that the follow-up change is small, to add that into this change (like adding another commit in the PR and do `/issue add` manually as described in https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/issue) src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp line 119: > 117: fclose(f); > 118: } > 119: guarantee(cpu_lines == os::processor_count(), "core count should be consistent"); This line was later removed in https://bugs.openjdk.java.net/browse/JDK-8255716 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/299 From github.com+25946952+rnkovacs at openjdk.java.net Mon Aug 30 11:43:00 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 30 Aug 2021 11:43:00 GMT Subject: [jdk11u-dev] RFR: 8253015: Aarch64: Move linux code out from generic CPU feature detection [v3] In-Reply-To: References: Message-ID: > Not a clean backport. Differences to the original commit: > > - Changes to files under `src/hotspot/cpu/aarch64/` and `src/hotspot/os_cpu/linux_aarch64/` are adjusted to cover hardware features supported in JDK 11. > - As JDK 11 is built using an older C++ standard than tip, `static_assert`s need to be replaced with `STATIC_ASSERT` macros in `vm_version_linux_aarch64.cpp`. > - The GraalVM related changes in `vmStructs_jvmci.cpp`, `AArch64HotSpotLIRGenerator.java` and `GraalHotSpotVMConfig.java` are skipped as they seem to be modifying code added in JDK 14 ([JDK-8226222](https://bugs.openjdk.java.net/browse/JDK-8226222) and [JDK-8231973](https://bugs.openjdk.java.net/browse/JDK-8229201)). > > This is part of the Windows/AArch64 port. Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport 36998b006d6a9ee8145004778534d1f35a55e068 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/299/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/299/files/4884ef8f..1b4247f5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=299&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=299&range=01-02 Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/299.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/299/head:pull/299 PR: https://git.openjdk.java.net/jdk11u-dev/pull/299 From github.com+25946952+rnkovacs at openjdk.java.net Mon Aug 30 11:43:04 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 30 Aug 2021 11:43:04 GMT Subject: [jdk11u-dev] RFR: 8253015: Aarch64: Move linux code out from generic CPU feature detection [v2] In-Reply-To: References: Message-ID: On Mon, 30 Aug 2021 10:39:40 GMT, Anton Kozlov wrote: >> Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: >> >> - Backport ec9bee68660acd6abf0b4dd4023ae69514542256 >> - Backport a4eaf9536c272862b5ec856bf263679be09bddc9 > > src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp line 119: > >> 117: fclose(f); >> 118: } >> 119: guarantee(cpu_lines == os::processor_count(), "core count should be consistent"); > > This line was later removed in https://bugs.openjdk.java.net/browse/JDK-8255716 Thanks for bringing this to my attention. I added that commit / issue here. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/299 From akozlov at openjdk.java.net Mon Aug 30 11:58:29 2021 From: akozlov at openjdk.java.net (Anton Kozlov) Date: Mon, 30 Aug 2021 11:58:29 GMT Subject: [jdk11u-dev] RFR: 8253015: Aarch64: Move linux code out from generic CPU feature detection [v3] In-Reply-To: References: Message-ID: On Mon, 30 Aug 2021 11:43:00 GMT, Reka Kovacs wrote: >> Not a clean backport. Differences to the original commit: >> >> - Changes to files under `src/hotspot/cpu/aarch64/` and `src/hotspot/os_cpu/linux_aarch64/` are adjusted to cover hardware features supported in JDK 11. >> - As JDK 11 is built using an older C++ standard than tip, `static_assert`s need to be replaced with `STATIC_ASSERT` macros in `vm_version_linux_aarch64.cpp`. >> - The GraalVM related changes in `vmStructs_jvmci.cpp`, `AArch64HotSpotLIRGenerator.java` and `GraalHotSpotVMConfig.java` are skipped as they seem to be modifying code added in JDK 14 ([JDK-8226222](https://bugs.openjdk.java.net/browse/JDK-8226222) and [JDK-8231973](https://bugs.openjdk.java.net/browse/JDK-8229201)). >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 36998b006d6a9ee8145004778534d1f35a55e068 Marked as reviewed by akozlov (no project role). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/299 From aph-open at littlepinkcloud.com Mon Aug 30 12:59:35 2021 From: aph-open at littlepinkcloud.com (Andrew Haley) Date: Mon, 30 Aug 2021 13:59:35 +0100 Subject: [jdk11u-dev] RFR: JDK-8253947: Implementation: JEP 388: Windows AArch64 Support In-Reply-To: References: Message-ID: On 8/14/21 12:07 AM, Reka Kovacs wrote: > Thank you @phohensee. I understand that reviewing such a huge patch is a pain, and the chance of overlooking something goes up with size. I'll proceed to open PRs for the rest of the issues. Thanks. In particular, the integer types patch is pretty much standalone, and it touches many files. It's good for that one to be reviewed and committed entirely independently, because while it is a requirement for Windows support it is in no way Windows specific. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From github.com+25946952+rnkovacs at openjdk.java.net Mon Aug 30 14:20:30 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 30 Aug 2021 14:20:30 GMT Subject: [jdk11u-dev] RFR: 8253015: Aarch64: Move linux code out from generic CPU feature detection [v3] In-Reply-To: References: Message-ID: On Mon, 30 Aug 2021 11:55:42 GMT, Anton Kozlov wrote: >> Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: >> >> Backport 36998b006d6a9ee8145004778534d1f35a55e068 > > Marked as reviewed by akozlov (no project role). @AntonKozlov Thank you. Could you please tag these two JBS issues for me? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/299 From akozlov at openjdk.java.net Mon Aug 30 15:40:29 2021 From: akozlov at openjdk.java.net (Anton Kozlov) Date: Mon, 30 Aug 2021 15:40:29 GMT Subject: [jdk11u-dev] RFR: 8253015: Aarch64: Move linux code out from generic CPU feature detection [v3] In-Reply-To: References: Message-ID: On Mon, 30 Aug 2021 14:17:21 GMT, Reka Kovacs wrote: > Could you please tag these two JBS issues for me? I would like to, but my review does not count -- I'm not a formal reviewer in the JDK Updates project. I think this should be possible after a formal review (per step 4 of https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/299 From github.com+25946952+rnkovacs at openjdk.java.net Mon Aug 30 16:18:25 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Mon, 30 Aug 2021 16:18:25 GMT Subject: [jdk11u-dev] RFR: 8253015: Aarch64: Move linux code out from generic CPU feature detection [v3] In-Reply-To: References: Message-ID: On Mon, 30 Aug 2021 15:36:23 GMT, Anton Kozlov wrote: > > Could you please tag these two JBS issues for me? > > I would like to, but my review does not count -- I'm not a formal reviewer in the JDK Updates project. > I think this should be possible after a formal review (per step 4 of https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix). Right, I'll check out the formal Reviewers list. Thanks. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/299 From vkempik at openjdk.java.net Mon Aug 30 18:39:46 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Mon, 30 Aug 2021 18:39:46 GMT Subject: [jdk11u-dev] RFR: 8270216: [macOS] Update named used for Java run loop mode Message-ID: <8v7zVIna3DNuLmTTrP--EI8vUIHX8InpKkNa5ttTmYc=.2e745b85-e992-4e3c-97c4-a4937a8b0a36@github.com> Simple fix, clean backport ------------- Commit messages: - Backport 254600658acbc5c40ae8f0de0d01c9906c67c46c Changes: https://git.openjdk.java.net/jdk11u-dev/pull/302/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=302&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270216 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/302.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/302/head:pull/302 PR: https://git.openjdk.java.net/jdk11u-dev/pull/302 From vkempik at openjdk.java.net Mon Aug 30 18:40:06 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Mon, 30 Aug 2021 18:40:06 GMT Subject: [jdk15u-dev] RFR: 8270216: [macOS] Update named used for Java run loop mode Message-ID: Simple fix, clean backport ------------- Commit messages: - Backport 254600658acbc5c40ae8f0de0d01c9906c67c46c Changes: https://git.openjdk.java.net/jdk15u-dev/pull/93/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=93&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270216 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/93.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/93/head:pull/93 PR: https://git.openjdk.java.net/jdk15u-dev/pull/93 From vkempik at openjdk.java.net Mon Aug 30 18:40:20 2021 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Mon, 30 Aug 2021 18:40:20 GMT Subject: [jdk13u-dev] RFR: 8270216: [macOS] Update named used for Java run loop mode Message-ID: Simple fix, clean backport ------------- Commit messages: - Backport 254600658acbc5c40ae8f0de0d01c9906c67c46c Changes: https://git.openjdk.java.net/jdk13u-dev/pull/255/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=255&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270216 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/255.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/255/head:pull/255 PR: https://git.openjdk.java.net/jdk13u-dev/pull/255 From rhalade at openjdk.java.net Mon Aug 30 21:38:21 2021 From: rhalade at openjdk.java.net (Rajan Halade) Date: Mon, 30 Aug 2021 21:38:21 GMT Subject: [jdk17u] RFR: 8273150: Revert "8225083: Remove Google certificate that is expiring in December 2021" Message-ID: The removal of Google's GlobalSign root was pulled into 17.0.1 which is to be released in Oct 2021. But this root doesn't expire until Dec 2021 so the fix should be backed out from 17.0.1 This reverts commit 551354e0d3c7fba5c304c20fc38db38e3c49b01d. ------------- Commit messages: - Revert "8225083: Remove Google certificate that is expiring in December 2021" Changes: https://git.openjdk.java.net/jdk17u/pull/45/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=45&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273150 Stats: 34 lines in 2 files changed: 31 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u/pull/45.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/45/head:pull/45 PR: https://git.openjdk.java.net/jdk17u/pull/45 From mbaesken at openjdk.java.net Tue Aug 31 08:13:42 2021 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 31 Aug 2021 08:13:42 GMT Subject: [jdk11u-dev] RFR: 8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify Message-ID: <7cM8dCkR8aGUPfftgn8IM-Q2RVDSROBZq-voS3iFinQ=.bfc8bb94-11c9-4879-8a5f-a34d2a26dd8e@github.com> 8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify ------------- Commit messages: - Backport ea30bd6684fa3003889062a129a5aee1bc9b0024 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/303/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=303&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263362 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/303.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/303/head:pull/303 PR: https://git.openjdk.java.net/jdk11u-dev/pull/303 From mbaesken at openjdk.java.net Tue Aug 31 08:20:30 2021 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 31 Aug 2021 08:20:30 GMT Subject: [jdk11u-dev] RFR: 8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify In-Reply-To: <7cM8dCkR8aGUPfftgn8IM-Q2RVDSROBZq-voS3iFinQ=.bfc8bb94-11c9-4879-8a5f-a34d2a26dd8e@github.com> References: <7cM8dCkR8aGUPfftgn8IM-Q2RVDSROBZq-voS3iFinQ=.bfc8bb94-11c9-4879-8a5f-a34d2a26dd8e@github.com> Message-ID: On Tue, 31 Aug 2021 08:05:47 GMT, Matthias Baesken wrote: > 8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify Hi all, this pull request contains a backport of commit ea30bd66 from the openjdk/jdk repository. The commit being backported was authored by Matthias Baesken on 6 May 2021 and was reviewed by Prasanta Sadhukhan. Thanks! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/303 From mbaesken at openjdk.java.net Tue Aug 31 10:58:51 2021 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 31 Aug 2021 10:58:51 GMT Subject: [jdk17u] RFR: 8269031: linux x86_64 check for binutils 2.25 or higher after 8265783 Message-ID: <0xBTn9Bjc-DGpl0sLCDGSDbC5mM7bXw-PX7Q8hkxaL8=.7516a491-ed52-4080-8e6a-548b4224c103@github.com> Hi all, this pull request contains a backport of commit 18a1dd26 from the openjdk/jdk repository. The commit being backported was authored by Matthias Baesken on 22 Jun 2021 and was reviewed by Magnus Ihse Bursie and Erik Joelsson. Thanks! ------------- Commit messages: - Backport 18a1dd261cec6fa1c5820dce2df47d488417afff Changes: https://git.openjdk.java.net/jdk17u/pull/46/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=46&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269031 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u/pull/46.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/46/head:pull/46 PR: https://git.openjdk.java.net/jdk17u/pull/46 From github.com+75672469+larry-n at openjdk.java.net Tue Aug 31 11:46:51 2021 From: github.com+75672469+larry-n at openjdk.java.net (Larry-N) Date: Tue, 31 Aug 2021 11:46:51 GMT Subject: [jdk17u] RFR: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit Message-ID: Tested with tier1 ------------- Commit messages: - Backport 1ea437a4b87381b558cf8157ac52fc03e37ac507 Changes: https://git.openjdk.java.net/jdk17u/pull/47/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=47&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272720 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u/pull/47.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/47/head:pull/47 PR: https://git.openjdk.java.net/jdk17u/pull/47 From github.com+75672469+larry-n at openjdk.java.net Tue Aug 31 11:56:47 2021 From: github.com+75672469+larry-n at openjdk.java.net (Larry-N) Date: Tue, 31 Aug 2021 11:56:47 GMT Subject: [jdk17u] RFR: 8272391: Undeleted debug information Message-ID: Tested with tier1 ------------- Commit messages: - Backport e4766ee0aa96ab80aeaca36afac5fcaa516620ef Changes: https://git.openjdk.java.net/jdk17u/pull/48/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=48&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272391 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u/pull/48.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/48/head:pull/48 PR: https://git.openjdk.java.net/jdk17u/pull/48 From github.com+75672469+larry-n at openjdk.java.net Tue Aug 31 12:04:40 2021 From: github.com+75672469+larry-n at openjdk.java.net (Larry-N) Date: Tue, 31 Aug 2021 12:04:40 GMT Subject: [jdk17u] RFR: 8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes Message-ID: Tested with tier1 ------------- Commit messages: - Backport 75a06421e596b0e0006120a13836ec65a3ab9d46 Changes: https://git.openjdk.java.net/jdk17u/pull/49/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=49&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272335 Stats: 8 lines in 1 file changed: 5 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u/pull/49.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/49/head:pull/49 PR: https://git.openjdk.java.net/jdk17u/pull/49 From jiefu at openjdk.java.net Tue Aug 31 12:23:33 2021 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 31 Aug 2021 12:23:33 GMT Subject: [jdk17u] RFR: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit In-Reply-To: References: Message-ID: On Tue, 31 Aug 2021 11:40:48 GMT, Larry-N wrote: > Tested with tier1 Thanks for doing this backport. Did you follow this guide to prepare a backport PR? https://wiki.openjdk.java.net/display/SKARA/Backports ------------- PR: https://git.openjdk.java.net/jdk17u/pull/47 From github.com+75672469+larry-n at openjdk.java.net Tue Aug 31 13:08:37 2021 From: github.com+75672469+larry-n at openjdk.java.net (Larry-N) Date: Tue, 31 Aug 2021 13:08:37 GMT Subject: [jdk17u] RFR: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit In-Reply-To: References: Message-ID: On Tue, 31 Aug 2021 12:20:47 GMT, Jie Fu wrote: > Thanks for doing this backport. > > Did you follow this guide to prepare a backport PR? > https://wiki.openjdk.java.net/display/SKARA/Backports Yes, I referred to the wiki, and create the commit manually as described in the 'CLI' paragraph. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/47 From github.com+25946952+rnkovacs at openjdk.java.net Tue Aug 31 13:18:50 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Tue, 31 Aug 2021 13:18:50 GMT Subject: [jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v3] In-Reply-To: References: Message-ID: <171STLfw7W3ZaLnjKLxXEg6rL7n8G4HOo-Garl--nT4=.8607d574-ce24-4341-82e9-4eea30c7e92c@github.com> > Main commit of the Windows/AArch64 port. > > Also fixes [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) by adding [`src/hotspot/os_cpu/windows_aarch64/pauth_windows_aarch64.inline.hpp`](https://github.com/openjdk/jdk11u-dev/pull/301/files#diff-235302dc4618158c4f75771ebbb6f0e4beeee5daf0a537b03ee4253a711268c6), which is needed for a successful Windows-AArch64 build. > > Depends on #274 and #299. Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport 9604ee82690f89320614b37bfef4178abc869777 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/301/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/301/files/4f530dd9..f7f50ab7 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=301&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=301&range=01-02 Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/301.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/301/head:pull/301 PR: https://git.openjdk.java.net/jdk11u-dev/pull/301 From github.com+25946952+rnkovacs at openjdk.java.net Tue Aug 31 13:42:40 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Tue, 31 Aug 2021 13:42:40 GMT Subject: [jdk11u-dev] RFR: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC Message-ID: The original commit and the backport don't have a lot to do with each other quite honestly, but they both fit under the JBS issue. The original commit enabled ZGC for Windows/AArch64 (Shenandoah was already enabled on all AArch64 platforms), while this one enables Shenandoah. This is part of the Windows/AArch64 port. ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/301 Commit messages: - Backport 96f722cf63ae0e115612d816aa339d38074d3ade Changes: https://git.openjdk.java.net/jdk11u-dev/pull/304/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=304&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8252114 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/304.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/304/head:pull/304 PR: https://git.openjdk.java.net/jdk11u-dev/pull/304 From jiefu at openjdk.java.net Tue Aug 31 13:46:27 2021 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 31 Aug 2021 13:46:27 GMT Subject: [jdk17u] RFR: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit In-Reply-To: References: Message-ID: On Tue, 31 Aug 2021 13:05:17 GMT, Larry-N wrote: > > Thanks for doing this backport. > > Did you follow this guide to prepare a backport PR? > > https://wiki.openjdk.java.net/display/SKARA/Backports > > Yes, I referred to the wiki, and create the commit manually as described in the 'CLI' paragraph. Please set the PR's title as `Backport 1ea437a4b87381b558cf8157ac52fc03e37ac507` . Then the robot can recognize it as a backport. Thanks. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/47 From shade at openjdk.java.net Tue Aug 31 14:09:37 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 31 Aug 2021 14:09:37 GMT Subject: [jdk11u-dev] RFR: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC In-Reply-To: References: Message-ID: On Tue, 31 Aug 2021 13:31:23 GMT, Reka Kovacs wrote: > The original commit and the backport don't have a lot to do with each other quite honestly, but they both fit under the JBS issue. The original commit enabled ZGC for Windows/AArch64 (Shenandoah was already enabled on all AArch64 platforms), while this one enables Shenandoah. > > This is part of the Windows/AArch64 port. I have a question. [Upstream version checks](https://github.com/openjdk/jdk/blob/master/make/autoconf/jvm-features.m4#L309-L310) `OPENJDK_TARGET_CPU` directly. Why not to do the same here? The only reason off the top of my head is to avoid accidentally enabling macos-aarch64, but that port is not yet in 11u, and Shenandoah is supposed to work there anyway. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/304 From github.com+25946952+rnkovacs at openjdk.java.net Tue Aug 31 14:23:49 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Tue, 31 Aug 2021 14:23:49 GMT Subject: [jdk11u-dev] RFR: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC [v2] In-Reply-To: References: Message-ID: <_5JHIPAfzeITXNsvRowGXYxQ9MbUHPfnnLbta2efYBE=.90c1827e-31d0-427a-b96b-f02240220cae@github.com> > The original commit and the backport don't have a lot to do with each other quite honestly, but they both fit under the JBS issue. The original commit enabled ZGC for Windows/AArch64 (Shenandoah was already enabled on all AArch64 platforms), while this one enables Shenandoah. > > This is part of the Windows/AArch64 port. Reka Kovacs has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 96f722cf63ae0e115612d816aa339d38074d3ade ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/304/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/304/files/e70c0d80..2836aff9 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=304&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=304&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/304.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/304/head:pull/304 PR: https://git.openjdk.java.net/jdk11u-dev/pull/304 From github.com+25946952+rnkovacs at openjdk.java.net Tue Aug 31 14:23:49 2021 From: github.com+25946952+rnkovacs at openjdk.java.net (Reka Kovacs) Date: Tue, 31 Aug 2021 14:23:49 GMT Subject: [jdk11u-dev] RFR: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC [v2] In-Reply-To: References: Message-ID: On Tue, 31 Aug 2021 14:05:11 GMT, Aleksey Shipilev wrote: > I have a question. [Upstream version checks](https://github.com/openjdk/jdk/blob/master/make/autoconf/jvm-features.m4#L309-L310) `OPENJDK_TARGET_CPU` directly. Why not to do the same here? The only reason off the top of my head is to avoid accidentally enabling macos-aarch64, but that port is not yet in 11u, and Shenandoah is supposed to work there anyway. I thought about it, but wasn't sure if there are any risks I'm not aware of. Thanks - updated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/304 From jiefu at openjdk.java.net Tue Aug 31 14:32:30 2021 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 31 Aug 2021 14:32:30 GMT Subject: [jdk17u] RFR: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit In-Reply-To: References: Message-ID: On Tue, 31 Aug 2021 11:40:48 GMT, Larry-N wrote: > Tested with tier1 Now it should be OK to integrate it since it has been approved. Thanks. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/47 From rhalade at openjdk.java.net Tue Aug 31 14:48:32 2021 From: rhalade at openjdk.java.net (Rajan Halade) Date: Tue, 31 Aug 2021 14:48:32 GMT Subject: [jdk17u] RFR: 8273150: Revert "8225083: Remove Google certificate that is expiring in December 2021" In-Reply-To: References: Message-ID: <8Bt7uXmev9-MnzXnZWojj5lOpcTCK74z0scDiEABnBU=.545a1d17-85c8-4064-8adb-5f45b6a10168@github.com> On Mon, 30 Aug 2021 21:27:49 GMT, Rajan Halade wrote: > The removal of Google's GlobalSign root was pulled into 17.0.1 which is to be released in Oct 2021. But this root doesn't expire until Dec 2021 so the fix should be backed out from 17.0.1 > > This reverts commit 551354e0d3c7fba5c304c20fc38db38e3c49b01d. @seanjmullan can you please review this? ------------- PR: https://git.openjdk.java.net/jdk17u/pull/45 From github.com+75672469+larry-n at openjdk.java.net Tue Aug 31 15:20:43 2021 From: github.com+75672469+larry-n at openjdk.java.net (Larry-N) Date: Tue, 31 Aug 2021 15:20:43 GMT Subject: [jdk17u] RFR: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit In-Reply-To: References: Message-ID: On Tue, 31 Aug 2021 11:40:48 GMT, Larry-N wrote: > Tested with tier1 Thank you for help. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/47 From shade at openjdk.java.net Tue Aug 31 15:36:25 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 31 Aug 2021 15:36:25 GMT Subject: [jdk11u-dev] RFR: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC [v2] In-Reply-To: <_5JHIPAfzeITXNsvRowGXYxQ9MbUHPfnnLbta2efYBE=.90c1827e-31d0-427a-b96b-f02240220cae@github.com> References: <_5JHIPAfzeITXNsvRowGXYxQ9MbUHPfnnLbta2efYBE=.90c1827e-31d0-427a-b96b-f02240220cae@github.com> Message-ID: On Tue, 31 Aug 2021 14:23:49 GMT, Reka Kovacs wrote: >> The original commit and the backport don't have a lot to do with each other quite honestly, but they both fit under the JBS issue. The original commit enabled ZGC for Windows/AArch64 (Shenandoah was already enabled on all AArch64 platforms), while this one enables Shenandoah. >> >> This is part of the Windows/AArch64 port. > > Reka Kovacs has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. Thanks! Looks good. ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/304 From mullan at openjdk.java.net Tue Aug 31 15:40:31 2021 From: mullan at openjdk.java.net (Sean Mullan) Date: Tue, 31 Aug 2021 15:40:31 GMT Subject: [jdk17u] RFR: 8273150: Revert "8225083: Remove Google certificate that is expiring in December 2021" In-Reply-To: References: Message-ID: <-pYVtopcB_8ECiGLvl27r_iky4Fo4QB88fSYaMboHV4=.7c593206-ca18-49ab-9e53-d1121e1792ec@github.com> On Mon, 30 Aug 2021 21:27:49 GMT, Rajan Halade wrote: > The removal of Google's GlobalSign root was pulled into 17.0.1 which is to be released in Oct 2021. But this root doesn't expire until Dec 2021 so the fix should be backed out from 17.0.1 > > This reverts commit 551354e0d3c7fba5c304c20fc38db38e3c49b01d. Marked as reviewed by mullan (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk17u/pull/45 From github.com+75672469+larry-n at openjdk.java.net Tue Aug 31 16:24:45 2021 From: github.com+75672469+larry-n at openjdk.java.net (Larry-N) Date: Tue, 31 Aug 2021 16:24:45 GMT Subject: [jdk17u] RFR: 8272305: several hotspot runtime/modules don't check exit codes Message-ID: Tested with tier1 ------------- Commit messages: - Backport b2c272d4e21eb4aeb6c8e1c0be0d08943dc36db8 Changes: https://git.openjdk.java.net/jdk17u/pull/50/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=50&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272305 Stats: 24 lines in 5 files changed: 15 ins; 1 del; 8 mod Patch: https://git.openjdk.java.net/jdk17u/pull/50.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/50/head:pull/50 PR: https://git.openjdk.java.net/jdk17u/pull/50 From github.com+75672469+larry-n at openjdk.java.net Tue Aug 31 16:27:46 2021 From: github.com+75672469+larry-n at openjdk.java.net (Larry-N) Date: Tue, 31 Aug 2021 16:27:46 GMT Subject: [jdk17u] RFR: 8271215: Fix data races in G1PeriodicGCTask Message-ID: Tested with tier1 ------------- Commit messages: - Backport f2c359a8826e51a92f6a7c6917f2c3d223c24488 Changes: https://git.openjdk.java.net/jdk17u/pull/51/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=51&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271215 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u/pull/51.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/51/head:pull/51 PR: https://git.openjdk.java.net/jdk17u/pull/51 From goetz at openjdk.java.net Tue Aug 31 16:57:42 2021 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 31 Aug 2021 16:57:42 GMT Subject: [jdk11u-dev] RFR: 8272902: Bump update version for OpenJDK: jdk-11.0.14 Message-ID: Release is planned for 18th of January 2022 ------------- Commit messages: - 8272902: Bump update version for OpenJDK: jdk-11.0.14 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/305/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=305&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272902 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/305.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/305/head:pull/305 PR: https://git.openjdk.java.net/jdk11u-dev/pull/305 From snazarki at openjdk.java.net Tue Aug 31 19:39:02 2021 From: snazarki at openjdk.java.net (Sergey Nazarkin) Date: Tue, 31 Aug 2021 19:39:02 GMT Subject: [jdk15u-dev] RFR: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled Message-ID: <1qK2F8oXSac67tq139EDSV1dLgvMKdmiFRnNemYVAVw=.b0df51f2-721f-4457-a624-d47a23f63fc5@github.com> I'd like to backport this fix for SA that reflex changes was made by JDK-8231586 in OopMapValue. The patch applies cleanly. Tested with hotspot/tier1 and by the instruction from bug description. ------------- Commit messages: - Backport 752b6df34c92c02ac0992566e3efa7bc22b96aa1 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/94/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=94&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261236 Stats: 58 lines in 3 files changed: 12 ins; 28 del; 18 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/94.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/94/head:pull/94 PR: https://git.openjdk.java.net/jdk15u-dev/pull/94 From zgu at openjdk.java.net Tue Aug 31 19:53:46 2021 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 31 Aug 2021 19:53:46 GMT Subject: [jdk11u-dev] RFR: 8169959: javax/swing/JTable/6263446/bug6263446.java: Table should be editing Message-ID: Backport for parity with Oracle 11.0.14. The original patch does not apply cleanly. The conflict is in ProblemList.txt, resolved manually. Test: - [x] The test failed without patch, passed after patch. ------------- Commit messages: - Backport 8812113984177bb14d2a7b51b9391097853585b8 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/306/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=306&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8169959 Stats: 156 lines in 2 files changed: 30 ins; 47 del; 79 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/306.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/306/head:pull/306 PR: https://git.openjdk.java.net/jdk11u-dev/pull/306 From clanger at openjdk.java.net Tue Aug 31 20:04:50 2021 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 31 Aug 2021 20:04:50 GMT Subject: [jdk11u-dev] RFR: 8272902: Bump update version for OpenJDK: jdk-11.0.14 In-Reply-To: References: Message-ID: On Tue, 31 Aug 2021 16:51:28 GMT, Goetz Lindenmaier wrote: > Release is planned for 18th of January 2022 Marked as reviewed by clanger (Reviewer). LGTM ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/305 From goetz at openjdk.java.net Tue Aug 31 20:36:50 2021 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 31 Aug 2021 20:36:50 GMT Subject: [jdk11u-dev] Integrated: 8272902: Bump update version for OpenJDK: jdk-11.0.14 In-Reply-To: References: Message-ID: On Tue, 31 Aug 2021 16:51:28 GMT, Goetz Lindenmaier wrote: > Release is planned for 18th of January 2022 This pull request has now been integrated. Changeset: 0ea1e0fe Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/0ea1e0fe7ab4449fa137a25c39d38e6694b599bc Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8272902: Bump update version for OpenJDK: jdk-11.0.14 Reviewed-by: clanger ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/305