[jdk11u-dev] RFR: 8266761: AssertionError in sun.net.httpserver.ServerImpl.responseCompleted

[Paul Hohensee]

On Wed, 28 Jul 2021 13:13:44 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> Backport of JDK-8266761. Applies cleanly except the following hunk:
> 
> --- src/jdk.httpserver/share/classes/sun/net/httpserver/ExchangeImpl.java
> +++ src/jdk.httpserver/share/classes/sun/net/httpserver/ExchangeImpl.java
> @@ -270,7 +269,6 @@ public void sendResponseHeaders (int rCode, long contentLen)
>                      Optional.ofNullable(rspHdrs.get("Connection"))
>                      .map(List::stream).orElse(Stream.empty());
>              if (conheader.anyMatch("close"::equalsIgnoreCase)) {
> -                Logger logger = server.getLogger();
>                  logger.log (Level.DEBUG, "Connection: close requested by handler");
>                  close = true;
>              }
> 
> That code belongs to the enhancement JDK-8218554 which is not in 11u.

Lgtm, except please put a comment about JDK-8218554 in ExchangeImpl.java at the point where JDK-8218554 applies. If JDK-8218554 is backported in the future, it's unlikely the engineer doing the backport will notice that this patch was done. No need for another review.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.java.net/jdk11u-dev/pull/169