[jdk11u-dev] RFR: 8220445: Support for side by side MSVC Toolset versions

[Thomas Stuefe]

On Tue, 3 Aug 2021 05:07:21 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> This is a backport of JDK-8220445 Support for side by side MSVC Toolset versions. It is needed to support the GitHub Actions workflow for Windows because it is using the hereby introduced configure option --with-msvc-toolset-version.
> 
> The backport did not apply cleanly because JDK-8215445: Enable building for Windows in WSL is missing. I adapted the change to make it fit.
> 
> I moved the line
> `        $ECHO "$WINPATH_BASH -c 'echo VCToolsRedistDir="'"$VCToolsRedistDir " >> set-vs-env.sh' \
>             >> $EXTRACT_VC_ENV_BAT_FILE`
> to the fitting place and dropped the hunk
> `        $ECHO 'echo VCToolsRedistDir="%VCToolsRedistDir% " >> set-vs-env.sh' \
>             >> $EXTRACT_VC_ENV_BAT_FILE`

Not an expert, but looks okay to me. You did test it, right?

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk11u-dev/pull/180