[jdk11u-dev] RFR: 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully

Evgeny Astigeevich github.com+42899633+eastig at openjdk.java.net
Tue Aug 3 17:06:30 UTC 2021


On Thu, 29 Jul 2021 12:22:06 GMT, Sergey Nazarkin <snazarki at openjdk.org> wrote:

> Hi!
> I'd like to backport this changes to fix crash happens on memory mapped file operations.  The patch applies almost cleanly except stubGenerator_arm.cpp due to miss of JEP 340 (One AArch64 Port, Not Two), and some copyright year conflicts. 
> Need to note that a series of follow up is required to fix some platforms build. Particularly arm32/aarch64 is not buildable without 8226871. I'll create necessary PR soon. 
> Tested with tier1/tier2 and new InternalErrorTest.

LGTM

Confirm changes to files except stubGenerator_arm.cpp are identical to the original patch. Changes to stubGenerator_arm.cpp look good to me.

> Particularly arm32/aarch64 is not buildable without 8226871. I'll create necessary PR soon.

BTW, 8226871 looks trivial. Maybe it is worth to push it first.

-------------

Marked as reviewed by eastig at github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/jdk11u-dev/pull/173


More information about the jdk-updates-dev mailing list