[jdk11u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v2]
Aleksey Shipilev
shade at openjdk.java.net
Thu Aug 5 07:35:36 UTC 2021
On Wed, 4 Aug 2021 21:51:15 GMT, Christoph Langer <clanger at openjdk.org> wrote:
>> This is the backport of the GitHub Actions workflow to JDK11 Updates
>>
>> It is close to the current state of the workflow in head openjdk/jdk, except for the following modifications:
>>
>> - No Windows Aarch64
>> - No MacOs Aarch64
>> - Used jtreg5.1-b01 vs. jtreg-6+1 (which means a slight modification for the steps that build it). This can/should probably be updated later
>> - Use Adopt OpenJDK 11.0.11 as boot JDK (I don't know whether Adoptium 11.0.12 is ready. I guess this can be changed later on as well)
>> - Computation of JDK_VERSION used in bundle names: It is different because 11u is an update release (e.g. we have to account for 11.0.13 vs. only 11)
>> - Added a step "Fix jtreg permissions" because configure on Linux/Mac would bail out otherwise. I don't know why this is not needed in head. Maybe configure was improved?
>> - Use gcc 9 vs. gcc 10 on Linux. I chose to take what we use in SAP's nightly tests for the moment. We could probably spend some effort later to update the code to be able to compile on gcc 10.
>> - No gtest support
>> - Make target for test runs is "run-test-prebuilt" vs. "test-prebuilt". There was some refactoring between 11 and 18.
>> - MacOS bundle names contain 'osx' (vs 'macos' in head)
>>
>> To make the pipeline work and results look greenish, I proposed 6 other backports to be done before merging this: #180, #181, #182, #185, #186 and #187.
>>
>> There are probably a few more testfixes needed to further reduce testing noise.
>
> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
>
> Use Temurin JDK 11.0.12 for Bootstrap
This looks fine to me. I think these fixes are included too, but not linked to this PR:
8255305: Add Linux x86_32 tier1 to submit workflow
8255352: Archive important test outputs in submit workflow
-------------
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk11u-dev/pull/189
More information about the jdk-updates-dev
mailing list