[jdk11u-dev] RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v3]

Christoph Langer clanger at openjdk.java.net
Thu Aug 5 16:51:04 UTC 2021


> This is the backport of the GitHub Actions workflow to JDK11 Updates
> 
> It is close to the current state of the workflow in head openjdk/jdk, except for the following modifications:
> 
> - No Windows Aarch64
> - No MacOs Aarch64
> - Used jtreg5.1-b01 vs. jtreg-6+1 (which means a slight modification for the steps that build it). This can/should probably be updated later
> - Use Adopt OpenJDK 11.0.11 as boot JDK (I don't know whether Adoptium 11.0.12 is ready. I guess this can be changed later on as well)
> - Computation of JDK_VERSION used in bundle names: It is different because 11u is an update release (e.g. we have to account for 11.0.13 vs. only 11)
> - Added a step "Fix jtreg permissions" because configure on Linux/Mac would bail out otherwise. I don't know why this is not needed in head. Maybe configure was improved?
> - Use gcc 9 vs. gcc 10 on Linux. I chose to take what we use in SAP's nightly tests for the moment. We could probably spend some effort later to update the code to be able to compile on gcc 10.
> - No gtest support
> - Make target for test runs is "run-test-prebuilt" vs. "test-prebuilt". There was some refactoring between 11 and 18.
> - MacOS bundle names contain 'osx' (vs 'macos' in head)
> 
> To make the pipeline work and results look greenish, I proposed 6 other backports to be done before merging this: #180, #181, #182, #185, #186 and #187.
> 
> There are probably a few more testfixes needed to further reduce testing noise.

Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:

 - Merge branch 'master' into gha
 - Use Temurin JDK 11.0.12 for Bootstrap
 - GitHub Actions for JDK11 Updates
 - 8249095: tools/javac/launcher/SourceLauncherTest.java fails on Windows
   
   Reviewed-by: jjg
 - 8209380: ARM: cleanup maybe-uninitialized and reorder compiler warnings
   
   Reviewed-by: dholmes, drwhite, tschatzl
 - 8257913: Add more known library locations to simplify Linux cross-compilation
   
   Reviewed-by: erikj
 - 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c
   
   Reviewed-by: redestad, cjplummer, dholmes, stuefe
 - 8221988: add possibility to build with Visual Studio 2019
   
   Reviewed-by: erikj, ysuenaga
 - 8220445: Support for side by side MSVC Toolset versions
   
   Co-authored-by: Ali Ince <ali.ince at gmail.com>
   Reviewed-by: tbell

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk11u-dev/pull/189/files
  - new: https://git.openjdk.java.net/jdk11u-dev/pull/189/files/73229c2d..440e04a5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=189&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=189&range=01-02

  Stats: 1262 lines in 27 files changed: 1032 ins; 197 del; 33 mod
  Patch: https://git.openjdk.java.net/jdk11u-dev/pull/189.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/189/head:pull/189

PR: https://git.openjdk.java.net/jdk11u-dev/pull/189


More information about the jdk-updates-dev mailing list