[jdk11u-dev] RFR: 8230841: Remove oopDesc::equals()

[Roman Kennke]

On Fri, 6 Aug 2021 09:53:57 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> This is the second patch in the series to cleanup/revert the GC BarrierSets to most current state. See the dependent ("this issue blocks" links) issues to see what is next.
> 
> The equals APIs were added for Shenandoah GC, in the incarnation that exposed both from- and to-copies to the runtime system (see JDK-8199781). Since then, Shenandoah greatly simplified this by switching to a strong to-space invariant, which obviates the need for this API. Therefore, it was removed in JDK 14. This patch reverts JDK 11 parts to that shape as well, which should simplify 11u maintenance.

LGTM. One small comment, I leave this up to you. Thanks!

src/hotspot/share/classfile/systemDictionary.cpp line 521:

> 519:       = ObjectSynchronizer::current_thread_holds_lock((JavaThread*)THREAD, lockObject);
> 520:   assert(calledholdinglock,"must hold lock for notify");
> 521:   assert((lockObject() != _system_loader_lock_obj && !is_parallelCapable(lockObject)), "unexpected double_lock_wait");

I know it's pre-existing, but there is one ( and ) too many.

-------------

Marked as reviewed by rkennke (Committer).

PR: https://git.openjdk.java.net/jdk11u-dev/pull/204