[jdk11u-dev] RFR: 8210908: Refactor java/util/prefs/PrefsSpi.sh to plain java test

[Paul Hohensee]

On Wed, 11 Aug 2021 08:05:02 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Backporting for `11.0.13-oracle` parity.
> 
> This is an unclean backport, because `JarUtils.createJarFile` does not have the overload that accepts only `(Path, Path)`. I fixed it as follows:
> 
> 
> diff --git a/test/jdk/java/util/prefs/PrefsSpiTest.java b/test/jdk/java/util/prefs/PrefsSpiTest.java
> index 0369c60cae2..7e5b59ff754 100644
> --- a/test/jdk/java/util/prefs/PrefsSpiTest.java
> +++ b/test/jdk/java/util/prefs/PrefsSpiTest.java
> @@ -34,6 +34,7 @@
>  import java.io.File;
>  import java.nio.file.Files;
>  import java.nio.file.Path;
> +import java.nio.file.Paths;
>  import java.util.ArrayList;
>  import java.util.List;
>  
> @@ -74,7 +75,7 @@ public class PrefsSpiTest {
>              Files.copy(source, target, REPLACE_EXISTING);
>          }
>  
> -        JarUtils.createJarFile(SPIJAR, xdir);
> +        JarUtils.createJarFile(SPIJAR, xdir, Paths.get("."));
>      }
>  
>      @DataProvider
> 
> 
> Additional testing:
>  - [x] New test passes
>  - [x] `java/util/prefs` tests pass
>  - [x] Eyeballing new test output

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.java.net/jdk11u-dev/pull/231