[jdk11u-dev] RFR: 8242882: opening jar file with large manifest might throw NegativeArraySizeException

Paul Hohensee phh at openjdk.java.net
Wed Aug 11 20:26:23 UTC 2021


On Wed, 11 Aug 2021 07:29:13 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Unclean backport to match `11.0.13-oracle`. The uncleanliness is due to ambuity in `JarUtils.createJarFile` that does not have the overload with just `(Path, Path)`, as it was added in later JDKs. I added the `Paths.get(".")` to do the same thing.
> 
> 
>         JarUtils.createJarFile(jarFilePath.toAbsolutePath(), jarSourceRoot, Paths.get("."));
> 
> 
> Additional testing:
>  - [x] New test fails without the patch
>  - [x] New test passes with the patch

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.java.net/jdk11u-dev/pull/225


More information about the jdk-updates-dev mailing list