[jdk11u-dev] RFR: JDK-8253947: Implementation: JEP 388: Windows AArch64 Support

[Vladimir Kempik]

On Fri, 13 Aug 2021 12:07:37 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> This is a more recent version of https://github.com/openjdk/jdk11u/pull/2.
>> 
>> Changes since then:
>> - [JDK-8254634](https://bugs.openjdk.java.net/browse/JDK-8254634) (backport of [Build failure with VS 2019 (16.5.0) due to C2039 and C2873](https://bugs.openjdk.java.net/browse/JDK-8241087)) was removed, as it had been committed separately.
>> - [JDK-8269391](https://bugs.openjdk.java.net/browse/JDK-8269391) (backport of [AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter](https://bugs.openjdk.java.net/browse/JDK-8265756)) was added.
>> - [JDK-8271095](https://bugs.openjdk.java.net/browse/JDK-8271095) (backport of [C4530 was reported from VS 2019 at access bridge](https://bugs.openjdk.java.net/browse/JDK-8263136)) was added.
>> - [JDK-8271002](https://bugs.openjdk.java.net/browse/JDK-8271002) (backport of [AArch64: Fix MacroAssembler::get_thread convention](https://bugs.openjdk.java.net/browse/JDK-8261072)) was added.
>> - [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) was added, containing the Windows/AArch64 related part of [JDK-8271571](https://bugs.openjdk.java.net/browse/JDK-8271571) (backport of [AArch64: Backtracing broken on PAC enabled systems](https://bugs.openjdk.java.net/browse/JDK-8266749)), necessary for a correct build.
>> - Various small merge conflict resolutions.
>> 
>> Similarly to how it was done on tip, we have incorporated parts of [JDK-8253015: Aarch64: Move linux code out from generic CPU feature detection](https://bugs.openjdk.java.net/browse/JDK-8253015) by @AntonKozlov into the [JDK-8253947: Implementation: JEP 388: Windows AArch64 Support](https://bugs.openjdk.java.net/browse/JDK-8253947) commit.
>> 
>> Please let me know how I can make the review process easier / faster.
>
> Also, could you please be more specific, which parts of https://github.com/openjdk/jdk/commit/ec9bee68 were taken and which wasn't ?
> it's not trivial to find them in this PR. 
> Thanks

> @VladimirKempik, changes to
> 
> * src/hotspot/cpu/aarch64/vm_version_aarch64.cpp,
> * src/hotspot/cpu/aarch64/vm_version_aarch64.hpp, and
> * src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp
> 
> were taken over from [openjdk/jdk at ec9bee6](https://github.com/openjdk/jdk/commit/ec9bee68). However, now that we're breaking up the PR into its elements, it might make sense to backport this whole commit separately too. WDYT?

Ok, I will do the JDK-8248414 ( it's already reviewed) and its follow-ups: JDK-8250824 and JDK-JDK-8251930.
And Anton's fix for vm_version

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/222