[jdk11u-dev] RFR: 8237354: Add option to jcmd to write a gzipped heap dump [v2]

[Paul Hohensee]

On Wed, 18 Aug 2021 02:44:41 GMT, BuddyLiao <github.com+3094961+buddyliao at openjdk.org> wrote:

>> Backport of the heap dump enhancement: Add option to jcmd to write a gzipped heap dump
>> 
>> Patch did not apply cleanly, I had to resolve/modify
>> 
>> 1) src/hotspot/share/services/heapDumper.cpp
>> function "int dump(const char* path, bool overwrite = false)" has some different from the jdk-master, since patch 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea is backport before this one, so this patch can't backport clearly
>> 
>> 2) src/hotspot/share/services/heapDumperCompression.cpp
>> MonitorLockerEx is named MonitorLocker in jdk-master, MonitorLockerEx.wait should have parameters, the constructor of  MonitorLockerEx and MutexUnlockerEx also different from jdk-master
>> 
>> 3) src/hotspot/share/services/heapDumperCompression.hpp
>> FileWriter is different from jdk-master since backport of 7cbb67a3f8adc83a5b51c092a66480d7b22a6bea before this patch.
>> 
>> I have built it on linux x86_64 and run test-tier1
>
> BuddyLiao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' of https://git.openjdk.java.net/jdk11u-dev into backport-19be49714356f2f598924c9fefa6358679ab6dbe
>  - Backport 19be49714356f2f598924c9fefa6358679ab6dbe

I strongly recommend backporting JDK-8233790 first. The general update release rule is to backport dependencies first, then the dependent issue. It's easier to review that way. Also, I doubt the maintainers will approve a backport such as this one that breaks a test, even if the test is broken for only a short time. At a minimum, automated test systems will notice the failure and provoke work on the part of their owners.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/209