[jdk11u-dev] RFR: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux

[Christoph Langer]

On Thu, 12 Aug 2021 15:24:24 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this backport of JDK-8255790 which fixes a crash of simple FileDialog-using apps on some systems (for example F34 when not using system harfbuzz). See JDK-8272149. In a nutshell, this patch is a not quite complete revert of JDK-8249821. I.e. the OpenJDK 11u version of it. It does not revert the source code re-structuring, though. The JDK 17 patch doesn't apply clean. I've mostly hand-picked changes from the original patch. Note that JDK-8272332 is included in this backport. The differences mostly stem from differences in DISABLED_WARNINGS_ settings when BUILD_FONTMANAGER is being called.
> 
> Testing: Build on an affected system with/without --with-harfbuzz=system. Reproducer from JDK-8272149 (crashes before, passes after)

At eyeballing this looks good to me. If you can wait, I'd like to run it through SAP's testing tonight and let you know the results tomorrow.

-------------

Marked as reviewed by clanger (Reviewer).

PR: https://git.openjdk.java.net/jdk11u-dev/pull/241