[jdk11u-dev] RFR: 8248671: AArch64: Remove unused variables

Christoph Langer clanger at openjdk.java.net
Tue Aug 24 06:49:23 UTC 2021


On Mon, 23 Aug 2021 22:19:51 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Tiny change, applies cleanly.
>> 
>> This is part of the Windows/AArch64 port.
>
> @rnkovacs You need to request push approval for jdk11u backports, even when a PR is marked as "ready". So you should have waited with /integrate until the JBS issue (https://bugs.openjdk.java.net/browse/JDK-8248671) has label jdk11u-fix-xes.
> 
> I have approved and sponsored this now.

> @RealCLanger Sorry about that - I was so focused on getting the GH workflow right, I forgot that's still needed. I've requested authorship so that I can do the JBS administration myself (it's inconvenient to ask someone all the time). The two commits you've pushed for me should be enough - thank you!

Yeah, no problem. I just wanted to make you aware of that. Ideally, maintainer approvals should also be handled via GitHub - I'll continue to propose that to Skara folks. With authorship in JBS it will at least be less cumbersome.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/261


More information about the jdk-updates-dev mailing list