[jdk11u-dev] Integrated: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
Severin Gehwolf
sgehwolf at openjdk.java.net
Thu Aug 26 17:47:25 UTC 2021
On Tue, 24 Aug 2021 17:34:28 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
> Please review this defensive backport of JDK-8272124. OpenJDK 11u is affected too, but it manifests in a different way. Basically Java metrics report wrong results on affected system where the cgroup path contains a colon. The JDK 18 patch doesn't apply cleanly since JDK-8230305 (cgroups v2 support) isn't in 11u. Test support in 11 isn't as good as well (files don't exist), thus dropped the test changes.
>
> Also, I've kept the token number filter to keep using `>= 3` since that's the more defensive approach. It's not clear if systems with `/proc/self/cgroup` files exist in the wild with less than 3 tokens.
>
> Testing: Manual reproduce before/after patch. See explicit backport bug for details.
>
> Thoughts?
This pull request has now been integrated.
Changeset: 7c872ed3
Author: Severin Gehwolf <sgehwolf at openjdk.org>
URL: https://git.openjdk.java.net/jdk11u-dev/commit/7c872ed381953786e8159d03dd8e7ad58804454c
Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod
8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
Reviewed-by: shade
Backport-of: 4d6593ce0243457e7431a5990957a8f880e0a3fb
-------------
PR: https://git.openjdk.java.net/jdk11u-dev/pull/292
More information about the jdk-updates-dev
mailing list