[jdk11u-dev] RFR: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead [v3]

[Christoph Langer]

On Thu, 5 Aug 2021 19:32:03 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Backport of JDK-7179006. CPrinterJob.m parts don't apply cleanly because JNF removal is already backported. Included tests have passed on M1 with Rosetta (x86_64 build).
>> 
>> Note that the manual test from JDK-8211055 "TestSaveFileWithoutPrinter.java" does no longer pass with this change. Let's break it for parity with 11.0.13-oracle :-)
>> (That one seems to be unsupported even with JDK17.)
>
> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add JNFJavaToNSString replacement and CHECK_EXCEPTION.

Changes look good to me. The issue with TestSaveFileWithoutPrinter seems to have been reported with JDK-8272469 and there's no fix yet for it, even in head. So I think this one is good to go.

-------------

Marked as reviewed by clanger (Reviewer).

PR: https://git.openjdk.java.net/jdk11u-dev/pull/197