[jdk11u-dev] RFR: 8234930: Use MAP_JIT when allocating pages for code cache on macOS [v7]

[Thomas Stuefe]

On Sat, 11 Dec 2021 15:47:20 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

> > @VladimirKempik, SAP nightlies ran through with your patch on Windows x64, all Linux platforms and Mac intel; no problems attributable that I could see. Note that the tests did not include MacOS aarch64, since we don't have the machines yet. But I expect you tested that. We also don't test 32-bit, Solaris, or AIX. AIX is supposedly tested by IBM now since SAP stepped away from it.
> 
> Not exactly, none can test mac-arm on openjdk11 as it's not present there yet. I have made a sanity check on zulu11, applying this patch to it. C2/C1 still works which means this patch doesn't break memory management for codecache on mac-arm. Solaris is another issue, as we can't build solaris from openjdk11 repo here, only from zulu11 repo. ( due to harfbuzz issues on jdk11u-dev). Since this patch equals to "nothing" on platforms other than macos, it should be safe for them.

I agree. It is fine from my side. Thank you for testing, and for preparing a minimal patch.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/710