[jdk11u] RFR: 8210205 build fails on AIX in hotspot cpp tests (for example getstacktr001.cpp)

Tyler duke at openjdk.java.net
Wed Dec 22 19:47:13 UTC 2021


On Wed, 22 Dec 2021 19:08:17 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> I am creating this PR in response to a build issue brought to my attention by a member of the Adoptium Group. The issue is blocking their build as noted [here](https://github.com/adoptium/temurin-build/issues/2807).
>> 
>> This PR renames instances of `NUMBER_OF_FRAMES` and `MAXIMUM_NUMBER_OF_FRAMES` to `NUMBER_OF_STACK_FRAMES` and `MAXIMUM_NUMBER_OF_STACK_FRAMES` respectively in several files in the directory `jdk11u/test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetStackTrace`. This change fixes the name collision preventing build.
>> 
>> This fix has been tested on my AIX development machine.
>
> From https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u:
> 
> "During the later stages of a release cycle, the release enters rampdown. The master jdk11u repository contains the latest version of that release, while the jdk11u-dev repository is used to start work on the next release. If a change needs to be pushed to a release in rampdown, push approval can still be requested using the jdk11u-critical-request label. As the name of this tag suggests, this process is intended for fixes such as major regressions that must make the release. More minor bugs and new features should go in the next release being developed in jdk11u-dev. The maintainers may approve with jdk11u-critical-yes, defer to jdk11u-dev or reject altogether. Outstanding approvals for critical fixes can be monitored here. If, and only if, the fix gets approved with jdk11u-critical-yes, it may be pushed to the jdk11u repository. Approved critical fixes show up in this JBS filter (login required)."
> 
> If you consider this to be a critical fix, then a pull request against jdk11u seems to be the correct thing to do.

Sounds like this falls under the description of critical request (Thanks for the pointer @phohensee).

-------------

PR: https://git.openjdk.java.net/jdk11u/pull/24


More information about the jdk-updates-dev mailing list