[jdk11u] RFR: 8210205 build fails on AIX in hotspot cpp tests (for example getstacktr001.cpp)
Thomas Stuefe
stuefe at openjdk.java.net
Thu Dec 23 09:23:22 UTC 2021
On Tue, 21 Dec 2021 23:19:15 GMT, Tyler Steele <duke at openjdk.java.net> wrote:
> I am creating this PR in response to a build issue brought to my attention by a member of the Adoptium Group. The issue is blocking their build as noted [here](https://github.com/adoptium/temurin-build/issues/2807).
>
> This PR renames instances of `NUMBER_OF_FRAMES` and `MAXIMUM_NUMBER_OF_FRAMES` to `NUMBER_OF_STACK_FRAMES` and `MAXIMUM_NUMBER_OF_STACK_FRAMES` respectively in several files in the directory `jdk11u/test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetStackTrace`. This change fixes the name collision preventing build.
>
> This fix has been tested on my AIX development machine.
Hi Tyler,
please, in the future, follow the backport process. It simplifies our work and is actually the fastest way to get things rolling because it streamlines information for us. In particular, it is important to know:
- whether a patch is a clean backport or whether changes had to be made.
- whether and what you tested. This is typically left at the discretion of the authors, but any test gaps would have to be picked by the maintainers. In your case, it would have been interesting to know which AIX versions you tested the build on.
The formalized "Fix Request" comment in JBS allows us to see all that information at a glance.
Thank you,
Thomas
-------------
PR: https://git.openjdk.java.net/jdk11u/pull/24
More information about the jdk-updates-dev
mailing list