[jdk16u] Are we ignoring jdk16u-fix-* protocol?

[Yuri Nesterenko]

Hi Aleksey,

Skara as of now does not read these labels, and as all the discussions are mostly in PRs,
it's all too easy for everybody to ignore it.

--yan

On 15.02.2021 14:30, Aleksey Shipilev wrote:
> On 2/15/21 12:20 PM, Aleksey Shipilev wrote:
>> I have a process question about 16u (and maybe Skara).
>>
>> Look here:
>>     JDK 17:     https://bugs.openjdk.java.net/browse/JDK-8198540
>>     JDK 16.0.1: https://bugs.openjdk.java.net/browse/JDK-8261691
>>
>> This is backport PR:
>>     https://github.com/openjdk/jdk16u/pull/26
>>
>> I see no mention of any of jdk16u-fix-* tags on the original issue. Is this is process bug, i.e.
>> Skara allowing integration without maintainer approval? Or have I missed some announcement that
>> maintainer's approval is not required for 16u anymore?
> 
> I went through all closed JDK 16u PRs, and it looks like only 3 issues have slipped without the
> explicit 16u maintainer approval. I think this is a process bug then, and Skara bots should not really
> allow to integrate without the maintainer approval.
> 
> *) Have no jdk16u-fix-* tags at all:
>   8260380: Upgrade to LittleCMS 2.12
>   8198540: Dynalink leaks memory when generating type converters
> 
> *) Have jdk16u-fix-request, but NOT jdk16u-fix-yes:
>   8259628: jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java fails intermittently
> 
> *) Have both jdk16u-fix-request AND jdk16u-fix-yes:
>   8249867: xml declaration is not followed by a newline
>   8260356: (tz) Upgrade time-zone data to tzdata2021a
>   8260864: ProblemList two security/krb5 tests on Linux
>   8256421: Add 2 HARICA roots to cacerts truststore
>   8259706: C2 compilation fails with assert(vtable_index == Method::invalid_vtable_index) failed
>   8259049: Uninitialized variable after JDK-8257513
>   8257513: C2: assert((constant_addr - _masm.code()->consts()->start()) == con.offset())
>   8260338: Some fields in HaltNode is not cloned
>   8259777: Incorrect predication condition generated by ADLC
>   8259773: Incorrect encoding of AVX-512 kmovq instruction
>   8259619: C1: 3-arg StubAssembler::call_RT stack-use condition is incorrect
>   8259576: Misplaced curly brace in Matcher::find_shared_post_visit
>   8260010: UTF8ZipCoder not thread-safe since JDK-8243469
>   8258243: C2: assert failed ("Bad derived pointer") with -XX:+VerifyRegisterAllocator
>   8258946: Fix optimization-unstable code involving signed integer overflow
>   8260009: InstanceKlass::has_as_permitted_subclass() fails if subclass was redefined
>   7146776: deadlock between URLStreamHandler.getHostAddress and file.Handler.openconnection
>   8258909: update jdk16u jcheck conf
>   8253368: TLS connection always receives close_notify exception
>   8258471: "search codecache" clhsdb command does not work
>   8226810: Failed to launch JVM because of NullPointerException occured on System.props
>   8259048: (tz) Upgrade time-zone data to tzdata2020f
> 
>