[11u] Make use of DEFAULT_PROMOTED_VERSION_PRE

[Langer, Christoph]

Hi,

it looks like "DEFAULT_PROMOTED_VERSION_PRE=ea" is used in head openjdk/jdk and in the beginning when a release is branched into a separate repository. At the point when the branch is marked as release candidate, it's set to an empty value. For update releases it always empty as well (compare with jdk15u, jdk16u...). So no flipping upon ga tags.

To match this pattern in 11u, we should have "DEFAULT_PROMOTED_VERSION_PRE=". OTOH, I don't think this change will have a lot of effect to downstream consumers as they would set the version_pre value via configure anyway. But I'd welcome if we would align this. Would you mind to do this, Andrew?

Cheers
Christoph

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
> Behalf Of Severin Gehwolf
> Sent: Freitag, 19. Februar 2021 10:43
> To: Andrew Hughes <gnu.andrew at redhat.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: Re: [11u] Make use of DEFAULT_PROMOTED_VERSION_PRE
> 
> Hi,
> 
> On Fri, 2021-02-19 at 05:18 +0000, Andrew Hughes wrote:
> > It seems that the addition of DEFAULT_PROMOTED_VERSION_PRE
> > was backported to 11u for 11.0.7:
> >
> > https://bugs.openjdk.java.net/browse/JDK-8223464
> > https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-
> December/002302.html
> >
> > However, the value does not seem to have been updated since.
> >
> > Should this not be set to the empty string when the jdk11
> > tree is tagged with a *-ga release?
> 
> Yeah it could. But is it worth doing? Even if it was done it would have
> no effect on the build downstream consumers do, unless they
> specifically take that value and pass it to configure.
> 
> So I'm somewhat on the fence about this as it would be yet annother
> change which would needed to be done as part of the CPU patching (and
> reverted once the next dev-cycle starts). A lot of churn for little
> gain.
> 
> It feels like it's not really worth doing. YMMV.
> 
> Thanks,
> Severin
> 
> > This is what was done recently for the RC of OpenJDK 16:
> >
> > https://bugs.openjdk.java.net/browse/JDK-8259794
> >
> > Thanks,