[11u] RFR (XS): 8259312: VerifyCACerts.java fails as soneraclass2ca cert will expire in 90 days

Langer, Christoph christoph.langer at sap.com
Thu Jan 7 15:03:43 UTC 2021


Hi,

> > please help reviewing a fix for test VerifyCACerts.java due to a soon
> > expiring certificate.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8259312
> > Original Change: https://github.com/openjdk/jdk/commit/3be6e069
> > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8259312.11u/
> 
> This looks fine.

Thanks for the review, Severin. I've tagged it for approval.

> > I had to resolve the @bug section because JDK-8243559 is already
> > resolved in head but only targeted for backport to 11.0.12.
> >
> > I would also suggest to add this backport to the 11.0.10 CPU release.
> > If you don’t object, at Severin Gehwolf, at Andrew Hughes, I would add it
> > to the 11.0.10 bundle once reviewed and pushed in jdk11u-dev.
> 
> I'm not sure about that. It's a test-fix only and, thus, not really
> critical. On the other hand, it's fairly safe to include.
> 
> My vote goes to including it with 11.0.11.

I'm not completely sure either.

The test fix feels very safe and will remove the obvious noise in testing. I would assume that the final test runs for the CPU bundle have not been conducted by most folks, so it could still be included at this time, two weeks away from release. It would hopefully be beneficial to testing.

@Andrew Hughes, I would defer the final decision to you �� What do you think?

Cheers
Christoph



More information about the jdk-updates-dev mailing list