[11u] RFR: 8222518: Remove unnecessary caching of Parker object in java.lang.Thread

[Volker Simonis]

I think this downport looks good.
Moreover we already have it in Corretto since 11.0.9 and haven't
encountered any issues yet.

Reviewed from my side.

Best regards,
Volker


On Wed, Dec 23, 2020 at 5:13 PM Hohensee, Paul <hohensee at amazon.com> wrote:
>
> Thanks, Christoph. I'll do that.
>
> Paul
>
> -----Original Message-----
> From: "Langer, Christoph" <christoph.langer at sap.com>
> Date: Wednesday, December 23, 2020 at 3:03 AM
> To: "Hohensee, Paul" <hohensee at amazon.com>, "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
> Cc: "Reingruber, Richard" <richard.reingruber at sap.com>
> Subject: RE: [11u] RFR: 8222518: Remove unnecessary caching of Parker object in java.lang.Thread
>
> Hi Paul,
>
> this is no review, rather a maintainer's statement.
>
> I've little knowledge or experience in the area of hotspot thread synchronization. With that disclaimer, the patch looks benign to me but I would want to hear another expert's assessment before being able to approve this with a good conscience.
>
> I could ask Richard from our team (on cc) to have a look when he's back from vacation. Or feel free to find somebody else to review and assess this backport from a technical pov.
>
> Best regards
> Christoph
>
> > -----Original Message-----
> > From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
> > Behalf Of Hohensee, Paul
> > Sent: Montag, 21. Dezember 2020 16:34
> > To: jdk-updates-dev at openjdk.java.net
> > Subject: Re: [11u] RFR: 8222518: Remove unnecessary caching of Parker
> > object in java.lang.Thread
> >
> > Passes tier1 as well as before the patch. We do, however, have 3 tier1
> > langtools failures independent of this patch.
> >
> > jdk/javadoc/doclet/testGeneratedBy/TestGeneratedBy.java: Verify that
> > files use a common Generated By string
> > jdk/javadoc/doclet/testVersionOption/TestVersionOption.java: javadoc
> > should support --version and --full-version flags
> > tools/javac/VersionOpt.java: tools/javac/versionOpt.sh fails on OpenJDK
> > builds Test checks the version strings displayed by javac, using strings that
> > come out of the Java runtime.
> >
> > Thanks,
> > Paul
> >
> > -----Original Message-----
> > From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> on
> > behalf of "Hohensee, Paul" <hohensee at amazon.com>
> > Date: Sunday, December 20, 2020 at 10:18 AM
> > To: "jdk-updates-dev at openjdk.java.net" <jdk-updates-
> > dev at openjdk.java.net>
> > Subject: [11u] RFR: 8222518: Remove unnecessary caching of Parker object in
> > java.lang.Thread
> >
> > Please review this small code deletion and footprint reduction backport.
> >
> > JBS: https://bugs.openjdk.java.net/browse/JDK-8222518
> > Original patch: http://hg.openjdk.java.net/jdk/jdk/rev/9ebb614d293d
> > Webrev: http://cr.openjdk.java.net/~phh/8222518/webrev.11u.00/
> >
> > The backport is not clean because (1) javaClasses.cpp needed a copyright
> > date update to 2019 and the original 3rd hunk that deletes park_event() and
> > set_park_event() contained slightly different code that does not check for
> > non-existent Thread fields, and (2) unsafe.cpp needed a copyright update to
> > 2019.
> >
> > Thanks,
> > Paul
> >
>
>