[jdk11u-dev] RFR: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*) [v2]

[Denghui Dong]

On Tue, 6 Jul 2021 09:56:08 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update according to the comment
>
> Changes requested by mgronlun (Reviewer).

@mgronlun 
Thank you, please help review the latest version.

> src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSet.cpp line 306:
> 
>> 304:   if (array_klass == NULL) {
>> 305:     // The first klass id is reserved for the void.class.
>> 306:     return MaxJfrEventId + 100;
> 
> 101?

fixed.

> src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSet.cpp line 992:
> 
>> 990:     ClearKlassAndMethods clear(_writer);
>> 991:     _artifacts->iterate_klasses(clear);
>> 992:     JfrTypeSet::clear();
> 
> JfrTypeSet::clear() sets _clear_artifacts to true already. Maybe remove that call or remove the adjoining _clear_artifacts = true.

fixed.

> src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.cpp line 203:
> 
>> 201:   if (tak == NULL) {
>> 202:     // The first klass id is reserved for the void.class
>> 203:     id = MaxJfrEventId + 100;
> 
> 101? Because traceid class_id_counter = MaxJfrEventId + 101, letting the first dynamically assigned id start at 102.

fixed.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/47