[jdk11u-dev] RFR: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*) [v2]

[Christoph Langer]

On Tue, 6 Jul 2021 11:05:25 GMT, Denghui Dong <ddong at openjdk.org> wrote:

>> Could I have a review of this backport that fixes a crash problem?
>> 
>> Although there are many conflicts, I think it's necessary to backport it to 11u since the problem is very easy to reproduce.
>> 
>> And I hope JFR's folks could review it.
>> 
>> In addition to the different context of modified files, I think the following items we should review carefully:
>> 
>> 1. use MaxJfrEventId + 101 instead of LAST_TYPE_ID + 1 as the klass id of void.class
>> 2. jdk 11 doesn't support jfr streaming, so I removed the call `JfrTraceIdEpoch::set_changed_tag_state()` in `load_primitive`
>> 3. the Class in jdk 11 doesn't have the field 'hidden', so I removed `writer->write<bool>(false);` in `write_primitive`
>> 4. there are many differences in the API of JfrTraceId between 11u and tip
>> 
>> Thanks,
>> Denghui
>
> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update according to the comment

> 
> 
> /integrate

@D-D-H you (still) need to flag the JBS item with jdk11u-fix-request and add a comment.

I wil run the updated version through our testing once more and then I'm ready to approve & sponsor after JBS bug was flagged. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/47