[jdk11u-dev] RFR: 8269661: JNI_GetStringCritical does not lock char array [v2]
Zhengyu Gu
zgu at openjdk.java.net
Thu Jul 8 19:13:19 UTC 2021
> I would like to backport this patch to openjdk11u.
>
> This patch mainly impacts Shenandoah GC, which is the only GC that supports object pinning and string deduplication.
>
> The original patch does not apply cleanly, because it uses new string deduplication API introduced in jdk17. openjdk11u cannot prevent a string from being deduplicated, so it risks the possibility that string deduplication modifies string value while string critical session is in progress.
>
> I purpose to take an alternative approach in openjdk11u: return a copy of string value when object pinning + string deduplication is enabled.
>
> Test:
> - [x] tier1 with UseShenandoahGC + UseStringDeduplication on Linux x86_64.
Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
Aleksey's comment
-------------
Changes:
- all: https://git.openjdk.java.net/jdk11u-dev/pull/109/files
- new: https://git.openjdk.java.net/jdk11u-dev/pull/109/files/cc1cd1e6..ac6da026
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=109&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=109&range=00-01
Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod
Patch: https://git.openjdk.java.net/jdk11u-dev/pull/109.diff
Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/109/head:pull/109
PR: https://git.openjdk.java.net/jdk11u-dev/pull/109
More information about the jdk-updates-dev
mailing list