[jdk11u-dev] RFR: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows

Christoph Langer clanger at openjdk.java.net
Tue Jul 27 05:32:31 UTC 2021


On Thu, 1 Jul 2021 19:27:20 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:

> This is the request to backport the fix to jdk11u.
> 
> The original patch https://github.com/openjdk/jdk/commit/02287349.patch
> has only one conflict with copyright year (2018 vs 2015) in `src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java` file comparing with jdk11u-dev repository.
> 
> WPrinterJob.java in [JDK-8262470](https://github.com/openjdk/jdk/commit/02287349) patch: [WPrinterJob.java#L2](https://github.com/openjdk/jdk/commit/02287349#diff-15469ef255a67c118d758bec4ddd0d8868875ce2ed8c2277975d68e823464b1bL2)
> 
> WPrinterJob.java in jdk11u-dev repo:
> https://github.com/openjdk/jdk11u-dev/blob/master/src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java#L2
> 
> The java/awt/print and java/awt/PrintJob automated and manual tests were run with the fix.
> 
> The automated tests pass.
> The following manual tests fail with and without the fix:
> 
> Parse Exception: Arguments to manual option not supported: yesno:
> java/awt/print/Dialog/DialogOrient.java Error. Parse Exception: Arguments to `manual' option not supported: yesno
> java/awt/print/Dialog/DialogType.java Error. Parse Exception: Arguments to `manual' option not supported: yesno
> java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java Error. Parse Exception: Arguments to `manual' option not supported: yesno
> java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java Error. Parse Exception: Arguments to `manual' option not supported: yesno
> java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java Error. Parse Exception: Arguments to `manual' option not supported: yesno
> java/awt/print/PrinterJob/PageDialogTest.java Error. Parse Exception: Arguments to `manual' option not supported: yesno
> java/awt/print/PrinterJob/PageRanges.java Error. Parse Exception: Arguments to `manual' option not supported: yesno
> java/awt/print/PrinterJob/PageRangesDlgTest.java Error. Parse Exception: Arguments to `manual' option not supported: yesno
> java/awt/print/PrinterJob/PrintGlyphVectorTest.java Error. Parse Exception: Arguments to `manual' option not supported: yesno
> java/awt/print/PrinterJob/PrintLatinCJKTest.java Error. Parse Exception: Arguments to `manual' option not supported: yesno
> java/awt/print/PrinterJob/PrintTextTest.java Error. Parse Exception: Arguments to `manual' option not supported: yesno
> java/awt/print/PrinterJob/SwingUIText.java Error. Parse Exception: Arguments to `manual' option not supported: yesno
> java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java Error. Parse Exception: Arguments to `manual' option not supported: yesno
> java/awt/PrintJob/PageSetupDlgBlockingTest/PageSetupDlgBlockingTest.java Error. Parse Exception: Arguments to `manual' option not supported: yesno
> java/awt/PrintJob/SaveDialogTitleTest.java Error. Parse Exception: Arguments to `manual' option not supported: yesno
> 
> Cannot access a member of class:
> java/awt/print/Dialog/PrintDlgApp.java Error. java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainThread cannot access a member of class PrintDlgApp with modifiers "public static"
> java/awt/print/Dialog/PrintDlgPageable.java Error. java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainThread cannot access a member of class PrintDlgPageable with modifiers "public static"
> 
> Can't find HTML file:
> java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java Error. Can't find HTML file: C:\Development\github\alexsch\jdk11u-dev-print\test\jdk\java\awt\PrintJob\PrintCheckboxTest\PrintCheckboxManualTest.html
> 
> Does not have buttons on test dialog (pass, fail, ...)
> java/awt/print/PrinterJob/SecurityDialogTest.java

LGTM

-------------

Marked as reviewed by clanger (Reviewer).

PR: https://git.openjdk.java.net/jdk11u-dev/pull/91


More information about the jdk-updates-dev mailing list