[11u] RFR 8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821

[Zhengyu Gu]

Thanks, Paul.

-Zhengyu

On 6/1/21 12:59 PM, Hohensee, Paul wrote:
> Looks fine. Even if it's minor refactoring, it's in Oracle 8u. :)
> 
> Thanks,
> Paul
> 
> -----Original Message-----
> From: Zhengyu Gu <zgu at redhat.com>
> Date: Tuesday, June 1, 2021 at 7:08 AM
> To: "Hohensee, Paul" <hohensee at amazon.com>, Sergey Nazarkin <snazarkin at azul.com>
> Cc: "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
> Subject: RE: [11u] RFR 8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821
> 
> Hi Sergey and Paul,
> 
> Thanks for pointing out.
> 
> Updated: http://cr.openjdk.java.net/~zgu/JDK-8265231-11u/webrev.01/
> 
> 
> -Zhengyu
> 
> On 5/28/21 12:11 PM, Hohensee, Paul wrote:
>> Hi, Sergey,
>>
>> Thanks for pointing this out. Looking at it again, you're correct. Only the change to DirectoIOTest.java should be retained: do you agree? If so, Zhengyu, would you please revise the patch?
>>
>> On the topic of Solaris support, I surveyed Adopt, Alibaba Dragonwell, Amazon Corretto, Azul Zulu, and Oracle. Only Oracle makes Solaris JDK 11 binaries available (only Solaris-Sparc64, at that). Illumos distros are available, and they may run JDK 11, but if I were an Illumos user I wouldn't be using Java, given that Solaris support has been gone since JDK 15. Given all that, it's an open question to me whether OpenJDK 11 should continue to support Solaris and/or Sparc.
>>
>> Paul
>>
>> -----Original Message-----
>> From: Sergey Nazarkin <snazarkin at azul.com>
>> Date: Friday, May 28, 2021 at 2:10 AM
>> To: "Hohensee, Paul" <hohensee at amazon.com>
>> Cc: Zhengyu Gu <zgu at redhat.com>, "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
>> Subject: RE: [11u] RFR 8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821
>>
>> Hi Paul,
>>
>> Pardon me for the intrusion and I’m definitely not a reviewer,  but according to original bug isDirectIOSupportedByFS is required for tests running on Solaris.  As I’m author of the 8264821 jdk11u backport, I’d like to clarify, for my further activity, should I care about Solaris platform when patches is taken from jdk17?
>>
>> Sergey
>>
>>
>>
>>
>>> On May 28, 2021, at 03:27, Hohensee, Paul <hohensee at amazon.com> wrote:
>>>
>>> Lgtm.
>>>
>>> Thanks,
>>> Paul
>>>
>>> -----Original Message-----
>>> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> on behalf of Zhengyu Gu <zgu at redhat.com>
>>> Date: Monday, May 24, 2021 at 6:57 AM
>>> To: "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
>>> Subject: [11u] RFR 8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821
>>>
>>> I would like to backport this patch to 11u for parity with Oracle 11.0.13.
>>>
>>> The original bug: https://bugs.openjdk.java.net/browse/JDK-8265231
>>> The original patch: https://github.com/openjdk/jdk/commit/d1b28e7a
>>>
>>> The original patch does not apply cleanly, due to JDK-8262465 11u
>>> backport diverged from original patch, and preserved
>>> isDirectIOSupportedByFS check.
>>>
>>> 11u webrev: http://cr.openjdk.java.net/~zgu/JDK-8265231-11u/webrev.00/
>>>
>>>
>>> Test:
>>>     DirectIOTest.java passed on Linux x86_64
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>>
>>>
>>
>>
> 
>