[11u] [REDO] RFR: 8265099: Revert backport to 11u of 8236859: WebSocket over authenticating proxy fails with NPE

[Ilarion Nakonechnyy]

Dear Sirs, good day.
I've corrected the wrong library path in broken testcase, and prepared new webrev for backport the fix again.
Shall I open a redo-issue in JBS and use the new bugid number in webrev, as described in ' Backing Out a Change', chapter 2 here: https://openjdk.java.net/guide/ ? 
Thanks ! 


On 13.04.2021, 01:32, "Hohensee, Paul" <hohensee at amazon.com> wrote:

    Thanks, Christoph. Pushed.

    -----Original Message-----
    From: "Langer, Christoph" <christoph.langer at sap.com>
    Date: Monday, April 12, 2021 at 3:16 PM
    To: "Hohensee, Paul" <hohensee at amazon.com>, "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>, Ilarion Nakonechnyy <ilarion at azul.com>
    Cc: "Doerr, Martin" <martin.doerr at sap.com>
    Subject: RE: [11u] RFR: 8265099: Revert backport to 11u of 8236859: WebSocket over authenticating proxy fails with NPE

    OK, I agree. The reversion looks correct to me. I've also approved the issue in JBS.

    Cheers
    Christoph

    > -----Original Message-----
    > From: Hohensee, Paul <hohensee at amazon.com>
    > Sent: Dienstag, 13. April 2021 00:08
    > To: Langer, Christoph <christoph.langer at sap.com>; jdk-updates-
    > dev at openjdk.java.net; Ilarion Nakonechnyy <ilarion at azul.com>
    > Cc: Doerr, Martin <martin.doerr at sap.com>
    > Subject: Re: [11u] RFR: 8265099: Revert backport to 11u of 8236859:
    > WebSocket over authenticating proxy fails with NPE
    >
    > Also, reversion and redo is the tip dev process, which, having been subject to
    > it :), imo is the right way to handle it for update releases.
    >
    > -----Original Message-----
    > From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> on
    > behalf of "Hohensee, Paul" <hohensee at amazon.com>
    > Date: Monday, April 12, 2021 at 3:04 PM
    > To: "Langer, Christoph" <christoph.langer at sap.com>, "jdk-updates-
    > dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>, Ilarion
    > Nakonechnyy <ilarion at azul.com>
    > Cc: "Doerr, Martin" <martin.doerr at sap.com>
    > Subject: Re: [11u] RFR: 8265099: Revert backport to 11u of 8236859:
    > WebSocket over authenticating proxy fails with NPE
    >
    > I'd rather revert it now and file a redo issue. We don't know who might be
    > doing 11u nightlies that are currently broken, and fixing the infrastructure
    > may need another backport (or several). If the fix is just referencing a library
    > that's in a different place, then the redo patch can include it.
    >
    > Thanks,
    > Paul
    >
    > -----Original Message-----
    > From: "Langer, Christoph" <christoph.langer at sap.com>
    > Date: Monday, April 12, 2021 at 2:57 PM
    > To: "Hohensee, Paul" <hohensee at amazon.com>, "jdk-updates-
    > dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>, Ilarion
    > Nakonechnyy <ilarion at azul.com>
    > Cc: "Doerr, Martin" <martin.doerr at sap.com>
    > Subject: RE: [11u] RFR: 8265099: Revert backport to 11u of 8236859:
    > WebSocket over authenticating proxy fails with NPE
    >
    > Hi Paul,
    >
    > I think reverting is fine. However, I don't know whether Ilarion will be able to
    > provide a fix on short call.  The error "can't find
    > jdk.test.lib.net.SimpleSSLContext in test directory or libraries" sounds a bit
    > like an infrastructure thing which maybe isn't too hard to repair? Maybe we
    > want to give him a day or two and then just push a fix? What do you think
    > (also @Ilarion...)?
    >
    > Best regards
    > Christoph
    >
    > > -----Original Message-----
    > > From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
    > > Behalf Of Hohensee, Paul
    > > Sent: Montag, 12. April 2021 23:31
    > > To: jdk-updates-dev at openjdk.java.net
    > > Subject: [DMARC FAILURE] [11u] RFR: 8265099: Revert backport to 11u of
    > > 8236859: WebSocket over authenticating proxy fails with NPE
    > >
    > > The recent backport of 8236859 to 11.0.12 causes tier2 failures in
    > > java/net/httpclient. I’d like to revert the backport for now.
    > >
    > > Original issue: https://bugs.openjdk.java.net/browse/JDK-8236859
    > > Original patch: https://hg.openjdk.java.net/jdk/jdk/rev/ed8e7bf32188
    > >
    > > 11.0.12 backport issue: https://bugs.openjdk.java.net/browse/JDK-
    > 8264988
    > > 11.0.12 patch: https://hg.openjdk.java.net/jdk-updates/jdk11u-
    > > dev/rev/57e3fa3574ec
    > >
    > > Reversion issue: https://bugs.openjdk.java.net/browse/JDK-8265099
    > > Reversion webrev:
    > > https://cr.openjdk.java.net/~phh/8265099/webrev.11u.00/
    > >
    > > Thanks,
    > > Paul
    >
    >