[jdk11u-dev] RFR: 8213137: Remove static initialization of monitor/mutex instances

Xin Liu xliu at openjdk.java.net
Mon Jun 14 21:47:54 UTC 2021


On Wed, 9 Jun 2021 19:48:52 GMT, Evgeny Astigeevich <github.com+42899633+eastig at openjdk.org> wrote:

> We are backporting JDK-8210832: Remove sneaky locking in class Monitor. It has a few dependencies. JDK-8213137: Remove static initialization of monitor/mutex instances is one of them.
> 
> The original patch from JDK-8213137 causes conflicts. The conflicts are because a patched file does not exist in jdk11u and git struggled to position changes. The original changes are not changed after resolution of the conflicts.
> 
> Testing: Amazon Linux 2, aarch64, tier1 and tier2. Amazon Linux 2, x86_64, tier1 and tier2.

Why does your patch drop change of CodeCacheUnloadingTask::_lock? 
Yes, it's weird, jdk11u has this file in shenandoah-specific directory.
https://github.com/openjdk/jdk11u-dev/blob/master/src/hotspot/share/gc/shenandoah/parallelCleaning.hpp#L62

Other parts look good to me. I am not reviewer.  Still need other reviewers approval.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/21


More information about the jdk-updates-dev mailing list