[jdk11u-dev] RFR: 8251945: SIGSEGV in PackageEntry::purge_qualified_exports() [v6]

[Zhengyu Gu]

On Fri, 18 Jun 2021 14:26:42 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed trailing whitespaces
>
> src/hotspot/share/classfile/javaClasses.cpp line 4023:
> 
>> 4021: int  java_lang_ClassLoader::unnamedModule_offset = -1;
>> 4022: 
>> 4023: ClassLoaderData* java_lang_ClassLoader::loader_data(oop loader) {
> 
> I understand the desire to minimize changes to related files (specifically the JFR files that currently include calls to java_lang_ClassLoader::loader_data() and java_lang_ClassLoader::set_loader_data(). However, I think it risks misleading future maintainers to leave these methods with their existing names when they are actually being modified to employ acquire/release semantics.
> 
> I think it would be much better to rename them consistently with the upstream patch so they are called java_lang_ClassLoader::loader_data_acquire() and java_lang_ClassLoader::release_set_loader_data() and then work those name changes through to all client calls. That not only retains consistency with upstream it also clarifies the local use.

@adinn Thanks for reviewing. 

Make sense, updated accordingly.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/22