[jdk11u-dev] RFR: 8223050: JVMCI: findUniqueConcreteMethod() should not use Dependencies::find_unique_concrete_method() for non-virtual methods
Andrew Dinn
adinn at redhat.com
Mon Jun 21 15:24:45 UTC 2021
On 21/06/2021 15:19, Severin Gehwolf wrote:
> Please review this backport of JDK-8223050 related to JVMCI. The JDK
> 13 patch doesn't apply cleanly. The change in assert in
> check_unique_method() has been left out since JDK 11u doesn't have
> [JDK-8223171](https://bugs.openjdk.java.net/browse/JDK-8223171) which
> introduced this method. It doesn't seem needed to bring that in too.
> JVMCI_THROW_MSG_NULL doesn't exist in JDK 11u. I've used THROW_MSG_0
> instead. Finally, test `TestResolvedJavaMethod.java` needed to account
> for this change as it would fail otherwise. Note that the test is
> `@ignored` in HEAD so hasn't been fixed there.
Yes, that all looks good to me. I have marked the PR as reviewed.
regards,
Andrew Dinn
-----------
Red Hat Distinguished Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill
More information about the jdk-updates-dev
mailing list