[jdk11u-dev] RFR: 8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M
Hui Shi
hshi at openjdk.java.net
Wed Jun 23 14:38:26 UTC 2021
On Wed, 23 Jun 2021 07:46:15 GMT, Christoph Langer <clanger at openjdk.org> wrote:
> > In my understanding, you prefer two separate PRs for JDK-8264752 and JDK-8266206 backport. The second one must base on the first one and two must be integrated at same time.
> > Is there any instructions for backporting in this way?
>
> Your understanding is correct. Unfortunately it is not possible with GitHub/Skara to merge two commits in one PR. Those would automatically be squashed.
> So, I suggest to use two separate PRs and create/merge the second PR right after the first one. Maybe the build fix would apply clean and can immediately be merged without reviewer? If not, I can review it in github quickly, just @ me. In any case I'll approve both at once in JBS.
@RealCLanger Thanks for your detail description!
After removing JDK-8266206 change, it fails build on jdk11u-dev. However it doesn't fail when removing JDK-8266206 change and build on jdk17. Build on same machine with same gcc verison 7.5.0.
This PR is updated to backport of JDK-8264752 only and I have tested JDK-8266206's change can apply cleanly.
https://bugs.openjdk.java.net/browse/JDK-8266206 jdk11u-fix-request label is added.
-------------
PR: https://git.openjdk.java.net/jdk11u-dev/pull/52
More information about the jdk-updates-dev
mailing list