[11u] RFR: 8261752: Multiple GC test are missing memory requirements
Hohensee, Paul
hohensee at amazon.com
Thu Mar 11 16:32:46 UTC 2021
No problem. I added your name to the changeset as a contributor. Pushed.
Paul
-----Original Message-----
From: Christoph Göttschkes <christoph.goettschkes at microdoc.com>
Date: Wednesday, March 10, 2021 at 3:28 AM
To: "Hohensee, Paul" <hohensee at amazon.com>, "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
Subject: RE: [11u] RFR: 8261752: Multiple GC test are missing memory requirements
Hi Paul,
the backport got already approved. I updated the webrev and added you as
a reviewer:
https://cr.openjdk.java.net/~cgo/8261752/backport-11u.01/
https://bugs.openjdk.java.net/browse/JDK-8261752
Would you mind sponsoring this changset? I already added a comment to
8211123.
Thanks,
Christoph
On 3/9/21 6:31 PM, Hohensee, Paul wrote:
> Lgtm.
>
> To help keep track of tests that haven't been backported, please include in your fix request comment that TestMetaSpaceLog.java is missing from the backport, link 8261752 to 8211123 (the issue that introduced it), and add a comment to 8211123 that the test was excluded from the 8261752 backport. There are 12 patches that affect that missing test, so it's a difficult backport candidate, but someone may want to tackle it sometime.
>
> Thanks,
> Paul
>
> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> on behalf of Christoph Göttschkes <christoph.goettschkes at microdoc.com>
> Date: Tuesday, March 9, 2021 at 3:59 AM
> To: "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
> Subject: [11u] RFR: 8261752: Multiple GC test are missing memory requirements
>
> Hello,
>
> please review the following backport to 11u.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8261752
> Original commit: https://git.openjdk.java.net/jdk/commit/2e18b52a
> Webrev: https://cr.openjdk.java.net/~cgo/8261752/backport-11u.00/
>
> The patch doesn't apply cleanly, because 8249000 [1] and 8244614 [2]
> have not been backported yet and changed a lot of test cases. Applying
> the changes manually was trivial, since it only changes @requires tags
> of some tests.
> One of the test cases (TestMetaSpaceLog.java) doesn't exist in 11u.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8249000
> [2] https://bugs.openjdk.java.net/browse/JDK-8244614
>
>
More information about the jdk-updates-dev
mailing list