[11u] RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll

Severin Gehwolf sgehwolf at redhat.com
Tue Mar 23 12:56:15 UTC 2021


On Mon, 2021-03-22 at 20:02 +0000, Jonathan Dowland wrote:
> Hi,
> 
> Please consider and review this backport for 11u. It does not apply
> clean from main, but the only hunk that doesn't is the Test metadata
> tagging. The patch substantially reduces the JNI local reference
> count when using NetworkInterface::getAll, which otherwise breaches
> the limit set by -Xcheck:jni very quickly.
> 
> head patch:
> https://github.com/openjdk/jdk/commit/ba504fcee8ba9ca3e6c223effc46754444a9c49f
> Bug: https://bugs.openjdk.java.net/browse/JDK-8187450
> Webrev:
> https://cr.openjdk.java.net/~jdowland/webrevs/JDK-8187450/webrev.00/
> 
> Testing: Linux x86_64 tier1 and test/jdk/java/net/NetworkInterface/Test.java,
> and by hand (see next paragraph)

This looks good to me.

Aside: For some reason the patch metadata looks different when doing a
git hg-export from jdk/jdk. Both variants are fine, though.

Thanks,
Severin



More information about the jdk-updates-dev mailing list