[11u] RFR: JDK-8236859 backport: WebSocket over authenticating proxy fails with NPE

[Hohensee, Paul]

Lgtm, except in HttpResponseImpl.java, the new closeRawChannel method looks like it needs its indentation fixed.

In AuthenticationFilter.java, "return null" is in the scope of "PROXY_AUTHORIZED" rather than the scope of "UNAUTHORIZED". That's what I'd expect from looking at the existing 11u code, but the original patch does more checking later on. There may be more backports that should be done to incorporate that checking.

Thanks,
Paul

-----Original Message-----
From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> on behalf of Ilarion Nakonechnyy <ilarion at azul.com>
Date: Friday, March 26, 2021 at 1:26 PM
To: "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
Subject: FW: [11u] RFR: JDK-8236859 backport: WebSocket over authenticating proxy fails with NPE

Dear Sirs, kindly reminder about following review request.

From: Ilarion Nakonechnyy <ilarion at azul.com>
Date: Friday, 19 February 2021, 21:18
To: "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
Subject: [11u] RFR: JDK-8236859 backport: WebSocket over authenticating proxy fails with NPE


Dear sirs, I’d like to backport JDK-8236859 to JDK11.

The bug causes jtreg test java/net/httpclient/websocket/WebSocketProxyTest.java to fail with timeout.
Was caught on x86_64 platform, but seems that it’s platform independent.

Patch applied unclear, manually merged files src/java.net.http/share/classes/jdk/internal/net/http/AuthenticationFilter.java and src/java.net.http/share/classes/jdk/internal/net/http/HttpResponseImpl.java
Jdk was built on Ubuntu x86_64 and tested with tier1

Could you please review my changes?

Bug:  https://bugs.openjdk.java.net/browse/JDK-8236859
Webrev:  http://cr.openjdk.java.net/~yan/8236859/webrev.11.0/

Original change: https://hg.openjdk.java.net/jdk/jdk/rev/ed8e7bf32188