[11u] RFR (S): 8264786: [macos] All Swing/AWT apps cause Allow Notifications prompt to appear when app is launched

Hohensee, Paul hohensee at amazon.com
Tue May 4 14:48:57 UTC 2021


Lgtm.

Thanks,
Paul

-----Original Message-----
From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> on behalf of Vladimir Kempik <vkempik at azul.com>
Date: Tuesday, May 4, 2021 at 4:33 AM
To: jdk-updates-dev <jdk-updates-dev at openjdk.java.net>
Cc: "Sergey.Bylokhov at oracle.com" <Sergey.Bylokhov at oracle.com>
Subject: RE: [11u] RFR (S): 8264786: [macos] All Swing/AWT apps cause Allow Notifications prompt to appear when app is launched

Hello

Updating webrev, I don’t think that additional line has to be moved to CTrayIcon.m

http://cr.openjdk.java.net/~vkempik/8264786/webrev.02/ <http://cr.openjdk.java.net/~vkempik/8264786/webrev.02/>

Vladimir.

> 4 мая 2021 г., в 14:21, Vladimir Kempik <vkempik at azul.com> написал(а):
>
> Please review this backport to fix the issue with notification center pop-ups on jdk10+
>
> the fix didn’t apply cleanly because one more line of code had to be moved to NSApplicationAWT.m to CTrayIcon.m:
> [[NSNotificationCenter defaultCenter] postNotificationName:JNFRunLoopDidStartNotification object:self];
>
>
> The bug - https://bugs.openjdk.java.net/browse/JDK-8264786
> The webrev - http://cr.openjdk.java.net/~vkempik/8264786/webrev.01/
> The original commit - https://git.openjdk.java.net/jdk/commit/020236cb9825bf4fa91a495a179623e3fcdc0149
>
> Will wait for positive tests run before doing jdk11u-fix-request in the bug.
>
> Regards, Vladimir




More information about the jdk-updates-dev mailing list